corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
890,588 Commits 1 Branch 0 Tags
34caedb5e06d01b718ee88c54aaa73e65e5596d9
Commit Graph

1664 Commits

Author SHA1 Message Date
Mike Conley
1d3fdc07d8 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao 
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
 2023-07-07 15:19:49 +00:00
scottdowne
8789495725 Bug 1840681 - Pocket newtab fallback to publisher if we don't have a source prop. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D182388
 2023-06-29 16:20:24 +00:00
negin
87e6259495 Bug 1834368 - Update styles for links in about:welcome/spotlight r=omc-reviewers,desktop-theme-reviewers,aminomancer,hanna_a 
Differential Revision: https://phabricator.services.mozilla.com/D179241
 2023-06-28 19:55:43 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180713
 2023-06-23 19:23:51 +00:00
Mike Conley
e8864ee16f Bug 1838926 - Add ASRouter targeting for whether or not the user has ever used the migration wizard to import passwords from a CSV file. r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D181287
 2023-06-23 14:14:26 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Emily McMinn
b7ca5d8e41 Bug 1838904 - Update split template to handle appstore buttons & qr code r=omc-reviewers,aminomancer,pdahiya 
Updating the template to allow for these two treatments for the 116 experiment:
https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-H1-2023?type=design&node-id=2337-52398&t=Y1N9vfuftoee2MJ3-4

Differential Revision: https://phabricator.services.mozilla.com/D181303
 2023-06-19 16:49:25 +00:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Iulian Moraru
7725c61610 Backed out changeset 11d0cb525f1d (bug 1835212) for causing bc failures on browser_feature_callout.js. CLOSED TREE 2023-06-13 00:34:23 +03:00
hanna alemu
6890b0f07f Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D179839
 2023-06-12 20:24:08 +00:00
negin
2640a6b2b8 Bug 1836083 - Fixes Embedded Migration Wizard import and Done button should render correct on shorter responsive layout r=desktop-theme-reviewers,dao,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D180336
 2023-06-12 16:41:53 +00:00
Cristina Horotan
00b07ba633 Backed out changeset a79a0225de72 (bug 1835212) for causing bc failures at browser_feature_callout.js on a CLOSED TREE 2023-06-09 01:31:13 +03:00
hanna alemu
bdfd7be5bc Bug 1835212 - Create method to set custom time limits for feature-callout to close after N seconds r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D179839
 2023-06-08 19:33:29 +00:00
Shane Hughes
075092d296 Bug 1832715 - Allow multistage spotlight OPEN_URL actions to include UTM params. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D177848
 2023-06-08 19:20:07 +00:00
Shane Hughes
99653f2ab9 Bug 1835028 - Change newtab stylelint problem severity from warning to error. r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D179906
 2023-06-05 12:58:01 +00:00
Katherine Patenio
a408bb9d46 Bug 1834115 - migrate newtab/lib JSMs that do not import modules to ESMs r=Standard8,fxview-reviewers,omc-reviewers,aminomancer,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D178568
 2023-05-30 22:44:42 +00:00
Nan Jiang
9ad8b6e8e1 Bug 1834795 - Implement Share-of-Voice for sponsored tiles r=thecount,ttran 
Differential Revision: https://phabricator.services.mozilla.com/D179149
 2023-05-29 20:44:25 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
negin
5a8e8520ab Bug 1832855 - Fix up hover styles for text links throughout onboarding & spotlights r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D178237
 2023-05-19 21:22:49 +00:00
Shane Hughes
bac2c296d0 Bug 1833986 - Adjust aboutwelcome multi select transition styles. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D178493
 2023-05-19 16:52:02 +00:00
Shane Hughes
d779f112c6 Bug 1818249 - Add a message property to allow CFRs in Private Browsing. r=omc-reviewers,pdahiya 
Also, because the data collection policy now allows Category 1 and 2
data collection in Private Browsing Mode, these CFRs will record
telemetry in PBM according to the existing CFR policy, which allows
Cat1-3 data for pre-release builds and experiments, and Cat1-2 data for
release builds. PBM windows will be treated in the same way that release
builds treat normal windows. When not enrolled in a CFR experiment, the
PBM window will only collect Cat1-2 data. When enrolled in a CFR
experiment, the PBM window may collect Cat3 data. This patch also adds a
new option to PopupNotifications that allows its usual interaction
probes to be recorded in PBM. That means, outside of an experiment,
pings from a PBM window will look just like pings from a release build
non-PBM window. And inside an experiment, pings from a PBM window will
look just like pings from a non-PBM window in any build. This ensures
that the PBM pings do not intrinsically confer any identifying
information, since their privateness cannot be known with certainty.

Differential Revision: https://phabricator.services.mozilla.com/D174200
 2023-05-18 16:26:49 +00:00
scottdowne
f53be495f8 Bug 1832789 - Pocket newtab card context menu buttons don't show if card is focused. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178350
 2023-05-17 17:42:23 +00:00
scottdowne
823afcbb67 Bug 1833125 - Pocket newtab onboarding experience dialog small fixes for high contrast modes. r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D178094
 2023-05-15 18:36:19 +00:00
scottdowne
272067742c Bug 1832507 - Pocket newtab fixng new markets onboarding dialog telemetry from firing in offscreen preloaded tabs r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177935
 2023-05-15 13:46:01 +00:00
Barret Rennie
935952aa19 Bug 1832827 - Improve Experimenter error messages for FxMS schemas r=aminomancer 
Previously, when a `TemplatedMessage` was missing a required field, the error
on Experimenter would be that the message's template field was expected to be
`multi`. This happens because the `oneOf` doesn't match `TemplatedMessage` due
to required fields missing, so it infers it must be a `MultiMessage`.

Now instead of using a `oneOf` to match against either a `MultiMessage` or a
`TemplatedMessage`, we use an `if`/`then`/`else`, predicated by the `template`
key so that if `template != "multi"`, the errors will come form the
`TemplatedMessage` definition.

Differential Revision: https://phabricator.services.mozilla.com/D177914
 2023-05-12 15:20:47 +00:00
scottdowne
4b6221125c Bug 1832178 - Pocket newtab international onboarding experience alignment issue r=gvn 
Differential Revision: https://phabricator.services.mozilla.com/D177641
 2023-05-10 18:33:07 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Mark Banner
0fadbc1ec4 Bug 1829618 - Enable Prettier on json files (automatic fixes). r=perftest-reviewers,webcompat-reviewers,extension-reviewers,andi,desktop-theme-reviewers,pip-reviewers,devtools-reviewers,sync-reviewers,mossop,denschub,dao,sparky,robwu,geckoview-reviewers,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D176336
 2023-05-09 16:14:51 +00:00
Shane Hughes
da6cbc353b Bug 1619842 - Remove longhand rule from newtab stylelint config. r=CosminS 
CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D177522
 2023-05-09 16:39:07 +00:00
Shane Hughes
268b8b6c64 Bug 1619842 - Migrate from sass-lint to stylelint. r=omc-reviewers,thecount,emcminn 
Fix a bug where VS Code's eslint integration does not work for the
newtab project because of a conflict caused by sass-lint's eslint
dependency. Switching over to stylelint eliminates that dependency and
generally modernizes our SCSS linting. stylelint doesn't have a 1 to 1
replacement for every sass-lint rule, so a few rules have been changed.

Differential Revision: https://phabricator.services.mozilla.com/D173605
 2023-05-09 15:37:15 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Shane Hughes
2c1e31da7b Bug 1829043 - Add actions for AboutWelcome embedded migration wizard. r=pdahiya,mconley 
Add some properties to the migration wizard screen JSON to specify what
action to perform when CTAs inside the embedded migration wizard are
clicked. This lets us advance screens when the cancel or finish button
is clicked, and send telemetry when the start button is clicked. In
theory we could perform any special message actions too, but for now we
only need telemetry and screen navigation.

Differential Revision: https://phabricator.services.mozilla.com/D176358
 2023-05-08 18:23:47 +00:00
Katherine Patenio
f2226c4d20 Bug 1828433 - restore underlines for links in new tab page. r=amy 
This patch restores link underlines in the new tab page, particularly the settings page and discovery stream (top sites, pocket tiles, and recent activity). Only links that had underlines on hover were updated. `text-decoration: none` is added for cards to maintain original styling.

Differential Revision: https://phabricator.services.mozilla.com/D176819
 2023-05-08 16:28:50 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-03 13:46:47 +00:00
hanna alemu
2ac6135d00 Bug 1816511 - Allow messaging about:welcome users by screen usage r=omc-reviewers,pdahiya,jprickett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D172836
 2023-05-02 13:53:07 +00:00
Punam Dahiya
daa96c9a8e Bug 1823779 - Evaluate screen targeting and update screen state on index change r=Mardak,omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D174044
 2023-04-29 20:10:42 +00:00
Mike Conley
4d8e83d0c3 Bug 1830178 - Rename FXA_SIGNIN_TAB_FLOW message to FXA_SIGNIN_FLOW and allow for signing in via a new window. r=aminomancer,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D176684
 2023-04-28 15:38:24 +00:00
Mike Conley
143026f39c Bug 1829426 - Add a 'welcome back' screen to onboarding for users going through the device migration flow. r=Mardak,fluent-reviewers,flod 
Significant portions of this were written by Shane Hughes <shughes@mozilla.com> -
specifically the parts that move the Firefox Account sign-in flow for tabs into
a SpecialMessageAction, and making AboutWelcomeUtils.handleUserAction return
a Promise.

Differential Revision: https://phabricator.services.mozilla.com/D176453
 2023-04-28 15:38:24 +00:00