Commit Graph

1664 Commits

Author SHA1 Message Date
Maxx Crawford
575446179c Bug 1910689 - Add additional topic selection data to click/save/impression events r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D218141
2024-07-31 16:41:45 +00:00
scottdowne
dc1f13e376 Bug 1910525 - Newtab topic selection button shows up in highlights/recent activity r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D218088
2024-07-30 17:45:53 +00:00
Nathan Barrett
a80ed35bb1 Bug 1907446 - update topic selection for onboarding r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D217769
2024-07-30 13:44:08 +00:00
Amy Churchwell
fd6564e4c3 Bug 1909760 - Add strings for topic labels. r=home-newtab-reviewers,fluent-reviewers,nbarrett,thecount,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D217646
2024-07-29 21:30:32 +00:00
scottdowne
7135685cf3 Bug 1906989 - Home and newtab do not include stories spocs for startup cache r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D216122
2024-07-29 19:54:52 +00:00
Maxx Crawford
86bebe1530 Bug 1909900 - Add region controls to thumbs up and down buttons r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D217761
2024-07-28 20:30:57 +00:00
Maxx Crawford
abe4527277 Bug 1907152 - Add telemetry for topic selection r=nbarrett,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D216483
2024-07-26 18:26:30 +00:00
Maxx Crawford
23fcbc8287 Bug 1902063 - Fix issue where wallpaper attribution was mispositioned if only one section/element was active on HNT page r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216623
2024-07-26 15:23:58 +00:00
scottdowne
4a5776b9ae Bug 1908163 - Home and newtab updating recommendation card loading state and animation. r=home-newtab-reviewers,nbarrett,maxx
Differential Revision: https://phabricator.services.mozilla.com/D217061
2024-07-24 18:45:09 +00:00
Noemi Erli
270b530bf2 Backed out changeset 55511000ae6e (bug 1908163) for causing failures in browser_basic_endtoend.js CLOSED TREE 2024-07-24 03:50:16 +03:00
scottdowne
b5c0e4d573 Bug 1908163 - Home and newtab updating recommendation card loading state and animation. r=home-newtab-reviewers,nbarrett,maxx
Differential Revision: https://phabricator.services.mozilla.com/D217061
2024-07-23 15:20:13 +00:00
Norisz Fay
84d1b9f527 Backed out changeset f4841fd42927 (bug 1908163) for causing bc failures on browser_basic_endtoend.js 2024-07-23 08:15:14 +03:00
scottdowne
e4b7e2934c Bug 1908163 - Home and newtab updating recommendation card loading state and animation. r=home-newtab-reviewers,nbarrett,maxx
Differential Revision: https://phabricator.services.mozilla.com/D217061
2024-07-22 22:03:08 +00:00
Dão Gottwald
a9a33b7b49 Bug 1909245 - Fix pin icon color on hover. r=home-newtab-reviewers,thecount,amy
Differential Revision: https://phabricator.services.mozilla.com/D217285
2024-07-22 19:50:59 +00:00
Nathan Barrett
db10fa1c0b Bug 1904633 - Add context menu to weather error message r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D215229
2024-07-18 17:52:45 +00:00
Amy Churchwell
880328f9a1 Bug 1904657 - Add topic labels to Pocket cards. r=home-newtab-reviewers,nbarrett,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216429
2024-07-16 20:28:23 +00:00
Norisz Fay
6a89206409 Backed out changeset f6085a9f4c95 (bug 1904657) for causing newtab failures 2024-07-16 00:54:15 +03:00
Amy Churchwell
251953d0da Bug 1904657 - Add topic labels to Pocket cards. r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D216429
2024-07-15 20:48:38 +00:00
Maxx Crawford
55169a87ea Bug 1907419 - Adjust top sites hover padding spacing for thumbs up/down compact view r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D216343
2024-07-15 19:38:04 +00:00
Nathan Barrett
cb1f62c3b5 Bug 1904656 - Create modal for topic selection r=home-newtab-reviewers,frontend-codestyle-reviewers,amy
Differential Revision: https://phabricator.services.mozilla.com/D215700
2024-07-15 13:42:05 +00:00
Maxx Crawford
95152e8414 Bug 1900832, Bug 1896862, Bug 1901156 - CSS adjustments for HNT weather widget r=home-newtab-reviewers,amy,nbarrett
This patch addresses three seperate issues:
- (Bug 1900832) Adjust the Weather widget to push down the page content on HNT page when the search section is disabled
- (Bug 1896862) Move the Weather widget component in the Base component so that it reflects the expected focus: tab order when navigating by keyboard
- (Bug 1901156) Adjust the Weather widget to hide current conditions symbol and detailed weather information text on medium size screens to not overlap the search logo

Differential Revision: https://phabricator.services.mozilla.com/D216057
2024-07-12 15:49:53 +00:00
Maxx Crawford
a73bec65fc Bug 1905258 - Add tests for Notifications and Thumbs up/down UI r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D215432
2024-07-09 15:43:06 +00:00
Maxx Crawford
c5283f51cc Bug 1905319 - Adjust new tab page elements spacing to be more consistent r=home-newtab-reviewers,thecount
This patch changes the spacing/padding/margins of the major sections if the thumbs up/down UI is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D215551
2024-07-03 21:24:49 +00:00
Maxx Crawford
c675d51427 Bug 1905259 - Add updated thumbs up and down icons, add CSS animation to active state r=home-newtab-reviewers,desktop-theme-reviewers,thecount,dao
Differential Revision: https://phabricator.services.mozilla.com/D215650
2024-07-03 19:29:27 +00:00
scottdowne
d0b2071285 Bug 1904594 - Home and newtab switch Pocket recs to Merino r=home-newtab-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D214829
2024-06-28 21:37:03 +00:00
Maxx Crawford
5b142ed5e6 Bug 1902099 - Add thumbs up/down buttons to Recommended Story cards r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount
Differential Revision: https://phabricator.services.mozilla.com/D213650
2024-06-28 01:41:21 +00:00
Nathan Barrett
b5cd40009b Bug 1903354 - Change weather error text color to grey r=desktop-theme-reviewers,home-newtab-reviewers,dao,thecount
Differential Revision: https://phabricator.services.mozilla.com/D214890
2024-06-27 18:41:40 +00:00
Nathan Barrett
1473c40461 Bug 1904910 - fix typo for abstract label in wallpapers r=thecount,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D214998
2024-06-26 17:27:20 +00:00
Nathan Barrett
9981fc66a2 Bug 1900418 - update thumbnails for wallpapers, use selectedWallpaper if availible r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D214435
2024-06-21 14:28:02 +00:00
scottdowne
5977993543 Bug 1902109 - Home and newtab wallpapers v2 fixing lint rule for fluent dom r=home-newtab-reviewers,frontend-codestyle-reviewers,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D214290
2024-06-20 14:50:54 +00:00
Shane Hughes
93a3b7524c Bug 1899030 - Part 4: Remove unused ASRouterButton import in newtab. r=omc-reviewers,home-newtab-reviewers,nbarrett,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D211672
2024-06-19 19:45:02 +00:00
scottdowne
2e8663d04d Bug 1901134 - Home and newtab wallpaper solid color selector r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212890
2024-06-18 00:25:23 +00:00
Daniel Holbert
a616266708 Bug 1901904: Improve centering for the newtab 3-dot-menu icon within its button. r=home-newtab-reviewers,maxx
Previously we had a background-position of 55%, which is sorta close to center,
but far enough away from center that it placed the image a full pixel away from
the perfect center position at certain zoom or HiDPI levels, which looked
awkward (e.g. with 9px of space to the left of the image, and 7px of space to
the right of it, when perfect-centering would have 8px on either side).

I suspect the reason we were using 55% (rather than 'center') was to be a
"tiebreaker" in favor of a slight rightwards bias when there's an odd number of
extra pixels to use for spacing -- in that case, biasing to the right makes
sense (N+1px on the left, Npx on the right).  The new background-position value
of 50.1% should still give us that behavior, without having the unwanted side
effect of nudging us off of the perfectly-centered position in cases where we
could put the same number of pixels on either side.

Differential Revision: https://phabricator.services.mozilla.com/D213444
2024-06-17 20:52:59 +00:00
Maxx Crawford
324ac7474d Bug 1902154 - Fix contrast issue with Weather error message when wallpaper is selected r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D213689
2024-06-17 19:40:32 +00:00
scottdowne
41900ed75c Bug 1902948 - Home and newtab fixing RTL issues in weather and wallpapers r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D213907
2024-06-17 15:52:05 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
2024-06-17 14:53:04 +00:00
Amy Churchwell
06609d7eb8 Bug 1900423 - Refine nested wallpapers styles. r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212611
2024-06-14 17:13:58 +00:00
Maxx Crawford
f79515b485 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212952
2024-06-07 20:44:50 +00:00
scottdowne
5227f8003a Bug 1899788 - Home and newtab adding some Nimbus values to wallpaper feature highlight. r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212746
2024-06-06 23:59:22 +00:00
scottdowne
043fca7a10 Bug 1900931 - Home and newtab fixing topsite pinned icon contrast with wallpaper r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212760
2024-06-06 16:50:41 +00:00
Maxx Crawford
b2b64dd23a Bug 1900861 - Remove fluent comments and duplicate SVG icons from Weather feature highlight r=home-newtab-reviewers,fluent-reviewers,flod,thecount
Differential Revision: https://phabricator.services.mozilla.com/D212737
2024-06-06 14:48:01 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 23:02:05 +00:00
scottdowne
28cd14bfc0 Bug 1900651 - Home and newtab create solid colour wallpaper pref r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212584
2024-06-05 22:24:56 +00:00
Norisz Fay
b51870e35d Backed out changeset 6b724772e8ba (bug 1900651) for causing newtab failures CLOSED TREE 2024-06-05 23:58:39 +03:00
scottdowne
ecefc3de9a Bug 1900651 - Home and newtab create solid colour wallpaper pref r=home-newtab-reviewers,maxx
Differential Revision: https://phabricator.services.mozilla.com/D212584
2024-06-05 19:30:53 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D211895
2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D212157
2024-06-04 00:54:00 +00:00