Commit Graph

327 Commits

Author SHA1 Message Date
Kris Maglione
39c12beb57 Bug 1445551: Part 5 - Remove add-on path service. r=aswan,mccr8
The path service was created to allow us to track resources that were part of
legacy add-ons, and to map URIs ponting to those resources to add-on IDs, so
that we could apply special behavior to them.

We have better ways to track resources belonging to WebExtensions, so this
code does not benefit them in any significant way.

The only remaining legacy extensions are system add-ons, which we control, and
do not need the path service in order to track.

MozReview-Commit-ID: BKXkcaM7jJx
2018-03-13 20:21:22 -07:00
Andrew Swan
523021e1d8 Bug 1441271 Show permissions notifications for distribution addons r=kmag
As described in the bug, this is intended as a temporary solution to
enable some experiments.  If this becomes a real feature, UX will
put some thought into a better startup experience.

MozReview-Commit-ID: 4DGMHj29M3e
2018-02-28 18:36:36 -08:00
Kirk Steuber
c8f226864a Bug 1436851 - Implement mechanism to disable system addon updates via enterprise policy r=aswan,Felipe,rhelmer
This patch additionally removes the check where if AddonManagerPrivate.backgroundUpdateTimerHandler does not call AddonManagerInternal.backgroundUpdateCheck if updates to all addons are disabled. The check is redundant as AddonManagerInternal.backgroundUpdateCheck makes those same checks.

MozReview-Commit-ID: FxS8127JYkn
2018-02-12 10:44:43 -08:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Jared Wein
db0a992247 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8
MozReview-Commit-ID: 66sXxnOWDgw
2018-02-08 12:57:31 -05:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Andrew Swan
129e3eb681 Bug 1356331 Remove hotfix code from addons manager and related tests r=rhelmer
MozReview-Commit-ID: EjCOOgmXvVH
2017-12-13 12:33:52 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Kris Maglione
6ec5334def Bug 1420775: Mark detected add-ons initially disabled. r=rhelmer
When we detect a new add-on during a directory scan, we initially add a
skeleton XPIStates entry for it, and rely on the database reconciliation to
fill in the details later in startup. In the case of extensions with invalid
install.rdf files, though, this doesn't happen, and the entry remains as we
initially created it. Since those entries are currently marked enabled by
default, and the XPIStates entries determine what non-bootstrapped chrome
manifests we load at startup, that leads to us mistakenly loading resources
that we shouldn't.

This change marks newly-detected entries disabled by default, and leaves it to
later startup stages to enable them if necessary. We still leave the XPIStates
entry in place, since removing it would cause us to rebuild the database on
every subsequent startup, when we re-detect it.

MozReview-Commit-ID: AvBmj79Ro2W
2018-01-17 11:58:22 -08:00
Robert Helmer
1ff7479a3e Bug 1395425 - actually return early on uninstall/setenable for AddonManager webAPI r=kmag,mythmon
MozReview-Commit-ID: EmHoHvDYPJS
2017-08-30 19:03:39 -07:00
Mark Banner
8f44f461ba Bug 1417944 - Enable ESLint rule mozilla/use-services for toolkit/mozapps/extensions. r=aswan
MozReview-Commit-ID: 6nK45TknN9x
2017-11-22 13:35:52 +00:00
Chris H-C
783b975832 bug 1381633 - Communicate whether getActiveAddons is serving full data r=Dexter,rhelmer
getActiveAddons can either return partial or full data for use by the Telemetry
Environment. This is just a spike that communicates that difference out of
XPIProvider and into the Environment so we know whether the DB has been loaded.

MozReview-Commit-ID: 4Y5mq5aM6uu
2017-11-21 14:00:07 -05:00
Robert Helmer
84d15ac50d Bug 1389341 - start generating jsdoc for AddonManager API r=kmag
MozReview-Commit-ID: IpREaXBIMbq
2017-09-14 13:18:11 -07:00
Dave Townsend
15e00a365e Bug 1414406: Remove the inline options feature for add-ons. r=aswan
MozReview-Commit-ID: 4ycTaMzqWgx
2017-11-13 15:09:00 -08:00
Csoregi Natalia
929e581b31 Backed out 2 changesets (bug 1414406)for ESLINT failures /toolkit/mozapps/extensions/content/extensions.js:1193 r=backout on a CLOSED TREE
Backed out changeset f501182ed44b (bug 1414406)
Backed out changeset f438ce3fc88e (bug 1414406)
2017-11-14 00:02:18 +02:00
Dave Townsend
4a1dc1050c Bug 1414406: Remove the inline options feature for add-ons. r=aswan
MozReview-Commit-ID: 4ycTaMzqWgx
2017-11-06 10:26:40 -08:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Andrew Swan
80ae253355 Bug 1401584 Properly cancel local installs of incompatible extensions r=rhelmer
MozReview-Commit-ID: EmRZQZeh0jQ
2017-09-22 14:27:20 -07:00
Andy McKay
c24336b6d3 Bug 1395720 fix Error calls to have just one argument r=mossop
MozReview-Commit-ID: i603CDTrmO
2017-09-14 15:48:22 -07:00
Andrew Swan
e0a7b20e21 Bug 1396578 Remove startup notification for non-mpc extensions r=rhelmer
MozReview-Commit-ID: 6oSi63pGCqK
2017-09-05 07:35:59 -07:00
Andy McKay
dbad30454c bug 1355788 rename Appearance to Themes r=aswan
MozReview-Commit-ID: mUhecHDOUD
2017-08-24 11:16:37 -07:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Robert Helmer
25762ff47d Bug 553869 - move error codes constants from UpdateChecker to AddonManager r=rhelmer p=lenikmutungi@gmail.com
MozReview-Commit-ID: 98XGu4M6RV1
2017-07-27 09:00:32 -07:00
Kris Maglione
65f0669a7d Bug 1385880: Part 1 - Remove WebExtensionBootstrap.js. r=aswan
MozReview-Commit-ID: X4JoEC61TF
2017-08-04 23:12:24 -07:00
Marco Castelluccio
315c360d82 Bug 1357517 - Remove Preferences.jsm usage from some toolkit/mozapps/* files. r=rhelmer 2017-07-29 01:57:14 +02:00
Andrew Swan
d6d6c58a7f Bug 1358907 Part 1a Use callProvider() properly in AddonManager.getActiveAddons r=me
MozReview-Commit-ID: 1Ocmxm3fLBg
2017-06-29 17:41:53 -07:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
tiago
ddb943f217 Bug 1354186 - Change managerListeners, installListeners, addonListeners and typeListeners from Array to Set. r=aswan
MozReview-Commit-ID: CZ5HlhWihHO
2017-05-19 01:56:05 -03:00
Kris Maglione
c04c15bd76 Bug 1368102: Part 5 - Move static content script matching into C++. r=mixedpuppy,zombie
MozReview-Commit-ID: Co04MoscqMx
2017-06-04 15:38:11 -07:00
Andrew Swan
0655dcbf28 Bug 1358907 Part 1 Addon Manager hooks for startup telemetry r=kmag
Add AddonManager.getActiveAddons() which can be called during
startup to get a limited amount of information about active addons
without forcing an unwated read of the extensions database.

MozReview-Commit-ID: Fj6z5eYgYYC
2017-05-18 13:07:14 -07:00
Luca Greco
f8dc561686 Bug 1302702 - Remove from ext-backgroundPage any code that uses the AddonManager object. r=kmag
The background page do not need to use the AddonManager to set its preferred debugging global
anymore (and it would not be able to use it from the extension child process).

MozReview-Commit-ID: 2IAxvCjDKvl
2017-03-21 16:28:15 +01:00
Sebastian Hengst
f58038d357 Backed out changeset 9859873385bc (bug 1302702) 2017-05-17 20:01:26 +02:00
Luca Greco
8ba55350c9 Bug 1302702 - Remove from ext-backgroundPage any code that uses the AddonManager object. r=kmag
The background page do not need to use the AddonManager to set its preferred debugging global
anymore (and it would not be able to use it from the extension child process).

MozReview-Commit-ID: 2IAxvCjDKvl
2017-03-21 16:28:15 +01:00
Kris Maglione
5ce24cde06 Bug 1356826: Wait for startup to finish before shutting down. r=me
MozReview-Commit-ID: LksftmZHI8H
2017-05-10 20:26:01 -07:00
Kris Maglione
3105a51eb6 Bug 1356826: Part 7 - Scan for extension sideloads after final UI startup. r=aswan,rhelmer
MozReview-Commit-ID: 1syn9GD2DEb
2017-05-10 12:34:17 -07:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Iris Hsiao
e76337ec39 Merge mozilla-central to mozilla-inbound 2017-04-24 12:04:12 +08:00
Sebastian Hengst
01abacfd1f Backed out changeset 9c407d9e588b (bug 1356828) for failing xpcshell's test_shutdown.js. r=backout 2017-04-23 22:57:34 +02:00
Kris Maglione
bbf13bf630 Bug 1356828: Don't call getAddonById from the Pocket bootstrap scope. r=rhelmer
MozReview-Commit-ID: DJM1dOIA7X4
2017-04-15 11:59:58 -07:00
Andrew Swan
6e58337eed Bug 1355336 Recognize privileged extension signing certs r=mossop
MozReview-Commit-ID: ES2OSQTv9k8
2017-04-19 17:02:42 -07:00
Andrew Swan
8ed2669b29 Bug 1356462 Show a notification when non-MPC extensions are disabled r=mossop
MozReview-Commit-ID: 8KUhRe91AFt
2017-04-19 11:30:24 -07:00
Kris Maglione
2a27aabf16 Bug 1356828: Don't call getAddonById from the Pocket bootstrap scope. r=rhelmer
MozReview-Commit-ID: DJM1dOIA7X4
2017-04-15 16:23:54 -07:00
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00