Commit Graph

91 Commits

Author SHA1 Message Date
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Sebastian Hengst
3c21120192 merge mozilla-inbound to mozilla-central. a=merge 2018-02-10 00:26:50 +02:00
Boris Zbarsky
4fd6e65c55 Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Gijs Kruitbosch
b34b68c23a Bug 1436559 - stop doing busy-work in setOverLink and make textToSubURI available on Services.jsm, r=florian
MozReview-Commit-ID: F63kE4GE67B
2018-02-07 22:07:08 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
26073c5b2c Backed out changeset 46c758115832 (bug 1436559) for ESlint failure on /browser/components/search/test/browser_426329.js on a CLOSED TREE 2018-02-08 20:37:13 +02:00
Gijs Kruitbosch
7b292fc484 Bug 1436559 - stop doing busy-work in setOverLink and make textToSubURI available on Services.jsm, r=florian
MozReview-Commit-ID: F63kE4GE67B
2018-02-07 22:07:08 +00:00
Mark Banner
62d89b0f75 Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
MozReview-Commit-ID: 8eEhjFZc4mT
2017-11-09 16:36:57 +00:00
Andreea Pavel
4d905c03dd Backed out 1 changesets (bug 1417940) for failing browser-chrome browser/components/contextualidentity/test/browser/browser_aboutURLs.js r=backout on a CLOSED TREE
Backed out changeset 2c2f807e23b5 (bug 1417940)
2017-11-17 18:08:45 +02:00
Mark Banner
0841e15072 Bug 1417940 - Change various instances of manually calling getService to use Services.jsm in toolkit/. r=mossop
MozReview-Commit-ID: 8eEhjFZc4mT
2017-11-09 16:36:57 +00:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Mike de Boer
fe79dbffb6 Bug 1339782 - use a WeakMap to keep track of windows with active findbar highlighters and make sure no JS error occurs when a window is closed. r=jaws
MozReview-Commit-ID: KGdvuWJZzMV
2017-02-27 16:15:12 +01:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Florian Quèze
0a4ee94a29 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Mike de Boer
f92ef6bfc5 Bug 1316514 - if we attempt to make the 'Highlight All' toggle a global setting, then we need to set the pref when toggled. r=Gijs
What you see first is the removal of the line `this._highlightAll = aHighlight;`, which is repeated in the `_setHighlightAll` method.
This line was put here initially to make the test_findbar_events.xul test pass but in fact makes it so that the pref is never set in `_setHighlightAll`!
In other words, we never actually persisted the 'Highlight All' state properly.
Reading further: the `_dispatchFindEvent` attaches some findbar state flags to the event details, including the value of `_highlightAll`.
Even though none of our consumers use it currently (haven't checked if TB does, though), you can cancel further execution of highlighting all ranges.
Since the `_setHighlightAll` doesn't do that kind of processing, but merely makes sure the internal state is up to snuff, is persisted properly and the buttons are updated, I moved it up to be invoked before dispatching the event.

MozReview-Commit-ID: 4BBy4FR1r5c
2017-01-13 17:27:18 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Mark Banner
dc46a8fba3 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
MozReview-Commit-ID: CiIsUjQzp4D
2016-11-09 22:06:32 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Mike de Boer
293fa85edc Bug 1303008 - refactor Fennec Finder.jsm integration to always show the correct match count results in the findbar. r=nalexander
MozReview-Commit-ID: KZIstsbHAyT
2016-10-10 11:53:25 +02:00
Mike de Boer
94e15875ac Bug 1279707 - when the location changes, we need to be more thorough in clearing the state variables than we are now to make sure we start fresh in new documents. r=jaws
MozReview-Commit-ID: KkeSKt7XVAc
2016-09-15 17:11:18 +02:00
Mike de Boer
7d5305d1be Bug 1283042 - add a test for highlighting XML documents; needed to fix up highlightFinished notifications. r=jaws
MozReview-Commit-ID: HKw51diGOBm
2016-09-12 18:46:18 +02:00
Mike de Boer
06dc0c6d3b Bug 1290914 - move the matches count and highlight-all request from the findbar binding to the JS module in the content process, so it's closer to the metal. r=jaws
MozReview-Commit-ID: INYobXmrVj5
2016-09-08 22:38:55 +02:00
Mike de Boer
a20c2bde64 Bug 1295759 - make sure selected ranges in iframes are cleared when the findbar is hidden as well. Adds a test to guard against regressions. r=jaws
MozReview-Commit-ID: 5rudNSNK8GK
2016-08-29 16:22:29 +02:00
Mike de Boer
7e1c629660 Bug 1294392 - consolidate the highlight and counter timers into one iterator timer. r=jaws
This introduces a new NLP (Natural Language Processing) module with only one
method: 'levenstein'. We're using it to allow the highlighter to keep running
when the it starts the iterator with a word that's one edit distance behind the
value in the findField.

MozReview-Commit-ID: K8oeiXoiLUe
2016-08-25 20:11:44 +02:00
Mike de Boer
c9a9a89a4c Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: 1j0C0BUfT8r
2016-08-19 17:18:41 +02:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Wes Kocher
f0be1004da Backed out changeset af4cc6c04573 (bug 1282070) for failures in test_bug263683.xul CLOSED TREE 2016-08-16 11:58:33 -07:00
Mike de Boer
6ce8b34ce5 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: JrTOarWMEQQ
2016-08-16 18:01:19 +02:00
Sebastian Hengst
850eb0c175 Backed out changeset bc160abe215b (bug 1282070) for docshell leakage in browser_visibleFindSelection.js. r=backout 2016-08-16 16:05:45 +02:00
Mike de Boer
831853c0e4 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: JKzUehP4pyP
2016-08-16 12:16:29 +02:00
Mike de Boer
858aad5164 Bug 1294644 - prevent drawing the rectangles all too often when modal highlighting is off and make sure to restore the outline of found links and the highlight color of the currentle highlighted occurrence. r=jaws
Many thanks to Tooru Fujisawa [:arai] for helping write this patch and testing it.

MozReview-Commit-ID: BxAd3WdqUXU
2016-08-16 11:25:56 +02:00
Mike de Boer
9e4a7c375b Bug 1280876 - don't take screenshots of pages that have the findbar open. r=jaws,mconley
MozReview-Commit-ID: Dmz0MaukNVq
2016-08-10 11:23:47 +02:00
Mike de Boer
4292ac8e62 Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use. r=jaws
MozReview-Commit-ID: K01dpqp8LSf
2016-08-02 10:40:21 +02:00
Carsten "Tomcat" Book
186ae7c42a Merge mozilla-central to fx-team 2016-07-28 17:44:58 +02:00
Mike de Boer
0145f8eec4 Bug 1281421 - Merge the find counter and highlighter iterators into a FinderIterator singleton. r=jaws
MozReview-Commit-ID: 9fhOKWIkOXN
2016-07-28 12:34:13 +02:00
Carsten "Tomcat" Book
334520276b Merge mozilla-central to fx-team 2016-07-27 16:40:43 +02:00
Mike de Boer
1269be4829 Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask. r=jaws
MozReview-Commit-ID: 2AmSwNgE1if
2016-07-27 16:37:26 +02:00
Jared Wein
05f9b81fa7 Bug 1285464 - Keep focus handling in the chrome process so focus will move back to the content out of the typeahead findbar but not change which chrome window has focus. r=mikedeboer
MozReview-Commit-ID: Ga8QFFgX0ZZ
2016-07-26 14:53:32 -04:00
Ray Lin
e02d84d80d Bug 1198279 - Clear all highlighted matches when find bar closed. r=mikedeboer
MozReview-Commit-ID: C4wiWWKAMpa
2016-07-05 15:59:25 +08:00
Mike de Boer
40aa390f52 Bug 269442 - whole word matching support for nsFind. r=ehsan,dao. ui-r=shorlander
MozReview-Commit-ID: KIDWHyjOSYL
2016-06-28 15:13:53 +02:00
Mike de Boer
f9037c003c Bug 384458 - part 4: implement modal highlighting using the AnonymousContent API and SVG masks. r=jaws 2016-06-09 13:30:49 +02:00