Commit Graph

10 Commits

Author SHA1 Message Date
Rune Lillesveen
2ecacaab69 Bug 1443185 [wpt PR 9816] - Computed min-width/height for auto depends on box., a=testonly
Automatic update from web-platform-testsComputed min-width/height for auto depends on box.

Resolved value of min-width and min-height for auto min sizing of flex
and grid items may be 'auto'. We based this on the computed style of the
shadow including parent. Instead we should rely on whether the element
will actually be a rendered flex/grid item.

Firefox Nightly passes all added tests.

The mentioned bug fixed is actually about using the shadow including
parent for finding parent computed style instead of the flat tree
parent, but that is no longer relevant as we look at the layout tree.

Bug: 682869
Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3
Reviewed-on: https://chromium-review.googlesource.com/948908
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540901}

wpt-commits: 85247f175ced7f78ab73facb07f6d2e4d6c9b7d8
wpt-pr: 9816
wpt-commits: 85247f175ced7f78ab73facb07f6d2e4d6c9b7d8
wpt-pr: 9816
2018-03-31 22:31:07 +01:00
Manuel Rego Casasnovas
a7617e3508 Bug 1437061 [wpt PR 9445] - [css-grid] Apply automatic minimum size clamping to spanning items too, a=testonly
Automatic update from web-platform-tests[css-grid] Apply automatic minimum size clamping to spanning items too

In r783213 we added the conditions from the spec to apply
the automatic minimum size clamping when required
but only to non-spanning items.
See: https://drafts.csswg.org/css-grid/#min-size-auto

This patch moves the code from GridTrackSizingAlgorithm::SizeTrackToFitNonSpanningItem()
to GridTrackSizingAlgorithmStrategy::MinSizeForChild()
that way the clamping is applied for both spanning and non-spanning items.

This somehow reverts r783213, as it was adding some duplicated code.
All the checks to know if we should use that part of the spec
were already present in GridTrackSizingAlgorithmStrategy::MinSizeForChild().

Apart from using the previous code, there's a new loop to verify
that the max track sizing function is fixed for all the tracks of the item.

BUG=809005
TEST=external/wpt/css/css-grid/grid-items/grid-minimum-size-grid-items-024.html
TEST=external/wpt/css/css-grid/grid-items/grid-minimum-size-grid-items-025.html

Change-Id: I919a83d152d8263251d3211dd5ebf175f7cf9717
Reviewed-on: https://chromium-review.googlesource.com/910049
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#535683}

wpt-commits: 3e05847a1dd584e0459d99b4441ad974560d9903
wpt-pr: 9445
wpt-commits: 3e05847a1dd584e0459d99b4441ad974560d9903
wpt-pr: 9445
2018-03-31 22:18:29 +01:00
James Graham
cbf7bce91e Bug 1435868 - Update web-platform-tests to revision 1e5122139897bc70789527960120354b8c640ef0, a=testonly
MozReview-Commit-ID: L9ZlgNF4QF1
2018-02-05 22:20:58 +00:00
James Graham
4706d37b48 Bug 1435337 - Update web-platform-tests to revision 7174d3e89f3057aae399483194dc4b608ee8c933, a=testonly
MozReview-Commit-ID: CSM0hnryiTp
2018-02-02 19:09:23 +00:00
James Graham
c261109887 Bug 1433144 - Update web-platform-tests to revision 2e19bfdaee6edb2c1069c07e14037284167284a3, a=testonly
MozReview-Commit-ID: 13sFeYHTYGC
2018-01-30 17:46:09 +00:00
James Graham
7fc66d1410 Bug 1429043 - Update web-platform-tests to revision 4de5305adf3d33badc23952672bcf28168fea37e, a=testonly
MozReview-Commit-ID: 8hFZiSUb5Qr
2018-01-09 14:45:43 +00:00
Emilio Cobos Álvarez
37e4daa0d7 Backout changeset e963388b7ee1 (Bug 1425227) because the OSX build machines don't have Ahem installed. r=backout 2017-12-16 22:45:56 +01:00
Emilio Cobos Álvarez
460474ca91 Bug 1425227: Fix grid-layout-properties.html to not depend on buggy Blink / WebKit behavior. r=heycam
See https://bugzilla.mozilla.org/show_bug.cgi?id=1425678.

MozReview-Commit-ID: D9MTTyHUz8R
2017-12-16 17:07:05 +01:00
James Graham
ca38db6d48 Bug 1421370 - Update web-platform-tests to revision 2b50389ee72d89dd0be12bc6ca54a6e95c98d163, a=testonly
MozReview-Commit-ID: 7xxqj73z5yl
2017-11-28 21:32:30 +00:00
James Graham
ce3ea2f585 Bug 1419296 - Update web-platform-tests to fa27b785c62e67cc3a12201612db188c4fdd49ad, a=testonly
MozReview-Commit-ID: 4P631tX3vv4
2017-11-21 07:39:00 +00:00