Commit Graph

8 Commits

Author SHA1 Message Date
Rune Lillesveen
2ecacaab69 Bug 1443185 [wpt PR 9816] - Computed min-width/height for auto depends on box., a=testonly
Automatic update from web-platform-testsComputed min-width/height for auto depends on box.

Resolved value of min-width and min-height for auto min sizing of flex
and grid items may be 'auto'. We based this on the computed style of the
shadow including parent. Instead we should rely on whether the element
will actually be a rendered flex/grid item.

Firefox Nightly passes all added tests.

The mentioned bug fixed is actually about using the shadow including
parent for finding parent computed style instead of the flat tree
parent, but that is no longer relevant as we look at the layout tree.

Bug: 682869
Change-Id: I6e47dc264a8cdbee7fc1983ce452baf7c0df85b3
Reviewed-on: https://chromium-review.googlesource.com/948908
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540901}

wpt-commits: 85247f175ced7f78ab73facb07f6d2e4d6c9b7d8
wpt-pr: 9816
wpt-commits: 85247f175ced7f78ab73facb07f6d2e4d6c9b7d8
wpt-pr: 9816
2018-03-31 22:31:07 +01:00
Morten Stenshorne
8fc7f529d4 Bug 1440683 [wpt PR 9646] - [LayoutNG] The padding box needs to exclude both borders and scrollbars., a=testonly
Automatic update from web-platform-tests[LayoutNG] The padding box needs to exclude both borders and scrollbars.

We forgot to subtract space taken up by scrollbars. Now that we do, we
also need NGBlockNode::GetScrollbarSizes() to add the horizontal
scrollbar on the correct side. Need to check with the layout object, not
directly with computed style. This matters e.g. if the object in
question is the LayoutView, which always places it on the right hand
side, even if document direction is RTL.

Also fix static block offset in flipped blocks writing mode. We got it
wrong, because we flipped an offset relative to the border edge around
the padding box. That's a regression from
https://chromium-review.googlesource.com/926004

Since I managed to break stuff without any tests regressing, I added a
few to wpt/css/css-flexbox/ (it doesn't really matter which layout model
to test with, as long as the containing block is in legacy layout, so
I just picked flexbox).

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I9527e8bb013b792a6b8ef58b370efe02b071c8bf
Reviewed-on: https://chromium-review.googlesource.com/931502
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538871}

wpt-commits: 0fe9f012a8ee5503b728a379705a6c5286ba1e96
wpt-pr: 9646
wpt-commits: 0fe9f012a8ee5503b728a379705a6c5286ba1e96
wpt-pr: 9646
2018-03-31 22:26:28 +01:00
Stephen McGruer
89ff605e96 Bug 1441390 [wpt PR 9518] - Add test for wrappable content that has flex:none, a=testonly
Automatic update from web-platform-testsAdd test for wrappable content that has flex:none (#9518)

Add test for wrappable content that has flex:none

See https://bugzilla.mozilla.org/show_bug.cgi?id=1374540; per spec, the
flex:none content should be allowed its full content width. This
currently works in Chrome, Edge, Safari, and Opera.

wpt-commits: a02389e2cc84576b8aa35bff9658f6db39003ed8
wpt-pr: 9518
wpt-commits: a02389e2cc84576b8aa35bff9658f6db39003ed8
wpt-pr: 9518
2018-03-31 22:21:16 +01:00
James Graham
cbf7bce91e Bug 1435868 - Update web-platform-tests to revision 1e5122139897bc70789527960120354b8c640ef0, a=testonly
MozReview-Commit-ID: L9ZlgNF4QF1
2018-02-05 22:20:58 +00:00
James Graham
4706d37b48 Bug 1435337 - Update web-platform-tests to revision 7174d3e89f3057aae399483194dc4b608ee8c933, a=testonly
MozReview-Commit-ID: CSM0hnryiTp
2018-02-02 19:09:23 +00:00
James Graham
7fc66d1410 Bug 1429043 - Update web-platform-tests to revision 4de5305adf3d33badc23952672bcf28168fea37e, a=testonly
MozReview-Commit-ID: 8hFZiSUb5Qr
2018-01-09 14:45:43 +00:00
James Graham
ca38db6d48 Bug 1421370 - Update web-platform-tests to revision 2b50389ee72d89dd0be12bc6ca54a6e95c98d163, a=testonly
MozReview-Commit-ID: 7xxqj73z5yl
2017-11-28 21:32:30 +00:00
James Graham
ce3ea2f585 Bug 1419296 - Update web-platform-tests to fa27b785c62e67cc3a12201612db188c4fdd49ad, a=testonly
MozReview-Commit-ID: 4P631tX3vv4
2017-11-21 07:39:00 +00:00