corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
532,991 Commits 1 Branch 0 Tags
337058f98e901b12e9af9fb34240f197e55a4cdc
Commit Graph

66 Commits

Author SHA1 Message Date
Eric Rahm
ae20682767 Bug 1384638 - Remove another NS_ENSURE warning from ShouldEnableTracking. r=gcp 2018-02-09 16:32:41 -08:00
Francois Marier
7cde82f87c Bug 1421803 - Send ThreatHit requests and telemetry at the right time. r=dimi 
The ThreatHit requests were never being sent because SetMatchedInfo() was
called on the channel _after_ calling SendThreatHitReport().

Additionally, the telemetry was sent in OnStartRequest() and so errors
returned in OnStopRequest() would not be caught.

This patch also includes some improvements to the logging of these
requests which can be toggled using:

    MOZ_LOG="UrlClassifierDbService:5,nsChannelClassifier:5"

MozReview-Commit-ID: 9dtRgEPVS3g
 2017-11-28 12:10:37 -08:00
Kershaw Chang
056956ef00 Bug 1404804 - Part 1: Make the behavior of tracking protection closer to tracking annotation. r=francois 
Since we check both blacklist and whitelist for tracking annotation now, it makes sense to also adopt this behavior for tracking protection. So, when TP is enabled, the channel will be canceled before calling ContinueBeginConnectWithResult().
 2017-10-11 23:54:00 -04:00
Thomas Nguyen
da894bb42f Bug 1351147 - Support ThreatHit requests in SafeBrowsing V4 r=francois 
MozReview-Commit-ID: 3ifQtdOTulE
 2017-08-24 11:13:12 +08:00
Thomas Nguyen
4c384705a8 Bug 1351147 - Use fullhash instead of prefix in OnClassifyComplete r=francois 
In order to optionally report the full hash back to Google, we need to keep it
around in the callback. While a prefix is not the same as a full hash (multiple
full hashes can map to the same prefix), in this case, the callback will only be
called when the full hash matches.

MozReview-Commit-ID: F4WSLZpYrXB
 2017-08-04 18:20:13 +08:00
Honza Bambas
a90d5297b3 Bug 1395525 - Make all changes landed as part of tracker request tailing preferrable. r=dragana 2017-08-31 06:07:00 -04:00
Honza Bambas
559460ce73 Bug 1358060 - Allow postponing of unimportant resources opening during page load, class-of-service Tail flag. r=dragana 2017-08-30 09:32:00 -04:00
Honza Bambas
f502c5ab25 Bug 1388448 - Logs for better network requests and context tracking. r=mcmanus 2017-08-17 12:16:00 -04:00
Nicholas Nethercote
b7346a7502 Bug 1390428 (part 1) - Remove many nsXPIDLCString local variables. r=erahm. 
These are all easy cases where an nsXPIDLCString local variable is set via
getter_Copies() and then is only used in ways that nsCStrings can also be used
(i.e. no null checks or implicit conversions to |char*|).

In every case the patch trivially replaces the nsXPIDLCString with an
nsCString. (Also, there are a couple of unused nsXPIDLCString variables that
the patch simply removes.)
 2017-08-16 13:58:35 +10:00
Nicholas Nethercote
09493fcbcf Bug 1384835 (part 3, attempt 2) - Remove the Preferences::Get*CString() variants that return nsAdoptingCString. r=froydnj. 2017-07-31 14:28:48 +10:00
Nicholas Nethercote
4ce1e9c11f Bug 1374580 (part 3) - Remove ns{,C}Substring typedefs. r=froydnj. 
All the instances are converted as follows.

- nsSubstring  --> nsAString
- nsCSubstring --> nsACString
 2017-06-20 19:19:52 +10:00
Kershaw Chang
e50c75231f Bug 1360580 - Add Throttleable flag to the channel marked as tracking. r=mayhemer 2017-06-21 19:55:00 -04:00
Kershaw Chang
ff19b67087 Bug 1370583 - Get URIClassifier service eariler. r=francois 
Move the initialization of nsUrlClassifierDBService to prior of calling ShouldEnableTrackingProtection(), so the nsUrlClassifierDBService will be initialized before staring HTTP connection. If not doing so, there is a 3.x% peformance regression on android platforam.
 2017-06-19 22:59:00 -04:00
Kershaw Chang
12c3073731 Bug 1360581 - Part2: Do channel annotation a bit earlier and only for third-party uri, r=francois 
This patch includes two changes:
1. The current channel annotation is happened at nsChannelClassifier::OnClassifyComplete and this is too late because this channel might be already hit the network.
This patch adds a new API CheckIsTrackerWithLocalTable in nsChannelClassifier to check if the URI is in local blacklist and whitelist before calling BeginConnectActual.
Please note that whitelist will be checked only when TP is disabled.
2. Skip channel annotation for first-party and top-level load http channels
 2017-06-13 01:16:00 +02:00
Felipe Gomes
96ea04cd32 Bug 1337043 - Don't bother classifying about: URLs. r=tnguyen,francois 
MozReview-Commit-ID: 8oxZwJRRIkv
 2017-05-23 15:59:25 -04:00
Dragana Damjanovic
5eb7ba7896 Bug 1188435 - Implement fast open necko part. r=mcmanus 2017-05-04 12:14:04 +02:00
Thomas Nguyen
87c03bcdea Bug 1353853 - Cache preferences when doing channel classify r=francois 
We will cache all preferences which will be read during classifing channel
- Store them into static variables nsUrlClassifierDBService
- Use a singleton class to manage/update preferrences in nsChannelClassifier

MozReview-Commit-ID: GvyBI3rVpYh
 2017-04-18 17:00:27 +08:00
Thomas Nguyen
72ec8b5761 Bug 1339006 - Specify event target if we run nsIURIClassifier.clasify() from content process.r=ehsan, r=gcp 
MozReview-Commit-ID: BztjVMlQngi
 2017-03-08 11:06:36 +08:00
Henry Chang
40c00b3543 Bug 1341506 - Part 1: Implement and use nsIURIClassifier.asyncClassifyLocalWithTables. r=Ehsan,francois 
MozReview-Commit-ID: 8dvYM4o2Xxw
 2017-03-01 11:27:51 +08:00
Thomas Nguyen
882486b2dc Bug 1336240 - Remove observer in PendingLookup and nsChannelClassifier r=dimi,francois 
MozReview-Commit-ID: EBQpQzESVZP
 2017-02-24 10:14:07 +08:00
Thomas Nguyen
6ca9c778d6 Bug 1288633 - Add more information when an URL matches Safe Browsing list. r=dragana,francois 
MozReview-Commit-ID: 6u0dUOB838F
 2017-02-21 09:46:36 +08:00
Shane Caraveo
2167bf8191 Bug 1308640 bypass TP when addon has explicit permission to url, r=bz,kmag,mrbkap 
MozReview-Commit-ID: BIhoUY2Ug8k
 2017-02-09 21:08:06 -08:00
Thomas Nguyen
433f1d4821 Bug 1324820 - Make sure we resume the channel if there's no classifier callback r=gcp 
MozReview-Commit-ID: 35jBJb1Q8Rz
 2017-01-12 18:07:22 +08:00
Ehsan Akhgari
337e003709 Bug 1170190 - Part 2: Add the nsIHttpChannel::IsTrackingResource() API to query the channel's tracking annotation; r=mayhemer 2016-12-23 14:40:11 -05:00
Ehsan Akhgari
8f540e3d78 Bug 1170190 - Part 1: Split out a new pref from privacy.trackingprotection.annotate_channels to explicitly control whether the channel priority is adjusted; r=mayhemer 2016-12-23 14:40:10 -05:00
Kershaw Chang
d1a656deb1 Bug 1141814 - Part 2: Lower the priority of channel loading tracking resource. r=honzab 2016-11-30 23:13:00 -05:00
Kirk Steuber
845ef3d6da Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings r=francois 
MozReview-Commit-ID: TXln2EQnZS
 2016-11-29 13:04:43 -08:00
Francois Marier
7e7fb9dc2f Bug 1308084 - Silence noisy warning in nsChannelClassifier::ShouldEnableTrackingProtection(). r=gcp 
MozReview-Commit-ID: 68n7476sVUM
 2016-11-10 21:01:00 -08:00
Nicholas Nethercote
62b6b0fce6 Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley. 
This function is an infallible alternative to nsIURI::GetSpec(). It's useful
when it's appropriate to handle a GetSpec() failure with a failure string, e.g.
for log/warning/error messages. It allows code like this:

  nsAutoCString spec;
  uri->GetSpec(spec);
  printf("uri: %s", spec.get());

to be changed to this:

  printf("uri: %s", uri->GetSpecOrDefault().get());

This introduces a slight behavioural change. Previously, if GetSpec() failed,
an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be
produced instead. In most cases this failure string will make for a clearer
log/warning/error message than the empty string.
* * *
Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley.

I will fold this into part 1 before landing.
 2016-08-26 16:02:31 +10:00
Ralph Giles
3722053e86 Bug 1275744 - Reference MOZ_LOG in netwerk comments. r=erahm 
NSPR_LOG_MODULES is deprecated.

Programs in the test directory still use PR_NewLogModule,
so NSPR_LOG_MODULES is accurate for them. Getting these
to link against libxul for LazyLogModule is still to do,
so leave those for now.

MozReview-Commit-ID: 3uMR3YPJyyi
 2016-05-25 16:13:54 -07:00
dimi
cb567753d9 Bug 1258033 - Part 3: Set DNT header based on preference and tracking protection. r=mcmanus 
MozReview-Commit-ID: JIOIomOvUhN
 2016-06-02 10:23:46 +08:00
Patrick McManus
e01f1d0309 Bug 1274376 - more mozilla::net namespaces r=dragana 2016-05-18 22:02:57 -04:00
Trevor Saunders
618b21e04f bug 1271436 - use nsIDocShellTreeItem::GetDocument() more r=smaug 2016-05-17 18:16:07 -04:00
Tanvi Vyas
84b3e082cf Bug 1105556 - We won't have a channelLoadingPrincipal for top level loads, so nsChannelClassifier::SameLoadingURI will return false. Adding a comment to indicate that the behavior is fine since Tracking Protection doesn't apply to top level loads. r=fmarier 2016-04-13 16:30:25 -07:00
Francois Marier
0c1e94785b Bug 1254310 - Add a hidden pref to temporarily disable Safe Browsing on given hostnames. r=gcp 2016-03-11 13:57:38 -08:00
Francois Marier
cf821cd8e5 Bug 1164518 - Better logging of completions. r=gcp 
MozReview-Commit-ID: JqhDC9GzB8l
 2016-03-02 14:54:59 -08:00
Kyle Huey
e95edb30a9 Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug 2016-01-30 09:05:36 -08:00
Patrick McManus
c07974e685 Bug 1238290 - fix bad necko deps on unified_sources r=valentin.gosu 
---
 netwerk/base/ARefBase.h                            |  2 ++
 netwerk/base/CaptivePortalService.cpp              |  1 +
 netwerk/base/CaptivePortalService.h                |  1 +
 netwerk/base/EventTokenBucket.cpp                  |  4 +++-
 netwerk/base/LoadContextInfo.cpp                   |  3 +++
 netwerk/base/LoadInfo.cpp                          |  3 +++
 netwerk/base/MemoryDownloader.cpp                  |  1 +
 netwerk/base/Predictor.cpp                         |  1 +
 netwerk/base/RedirectChannelRegistrar.h            |  1 +
 netwerk/base/nsBaseChannel.cpp                     |  1 +
 netwerk/base/nsChannelClassifier.cpp               |  1 +
 netwerk/base/nsDirectoryIndexStream.cpp            |  3 ++-
 netwerk/base/nsDownloader.cpp                      |  1 +
 netwerk/base/nsIOService.cpp                       |  1 +
 netwerk/base/nsIncrementalDownload.cpp             |  3 +++
 netwerk/base/nsNetUtil.cpp                         |  4 ++++
 netwerk/base/nsNetUtil.h                           |  1 +
 netwerk/base/nsProtocolProxyService.cpp            |  1 +
 netwerk/base/nsSecCheckWrapChannel.cpp             |  2 ++
 netwerk/base/nsUDPSocket.cpp                       |  4 +++-
 netwerk/cache/nsDiskCacheBinding.cpp               |  2 +-
 netwerk/cache/nsDiskCacheDeviceSQL.cpp             |  2 ++
 netwerk/cache/nsMemoryCacheDevice.cpp              |  2 +-
 netwerk/cache2/CacheFileUtils.cpp                  |  2 ++
 netwerk/cache2/CacheStorageService.h               |  1 +
 netwerk/ipc/NeckoParent.cpp                        |  1 +
 netwerk/ipc/RemoteOpenFileChild.cpp                |  1 +
 netwerk/protocol/about/nsAboutBloat.cpp            |  1 +
 netwerk/protocol/about/nsAboutCacheEntry.cpp       |  1 +
 netwerk/protocol/about/nsAboutProtocolHandler.cpp  |  1 +
 netwerk/protocol/data/DataChannelParent.cpp        |  1 +
 netwerk/protocol/file/nsFileProtocolHandler.cpp    |  1 +
 netwerk/protocol/ftp/FTPChannelParent.cpp          |  2 ++
 netwerk/protocol/ftp/FTPChannelParent.h            |  1 +
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  1 +
 netwerk/protocol/ftp/nsFtpProtocolHandler.h        |  1 +
 netwerk/protocol/http/Http2Compression.cpp         |  1 +
 netwerk/protocol/http/Http2Session.cpp             |  1 +
 netwerk/protocol/http/Http2Stream.h                |  2 ++
 netwerk/protocol/http/HttpBaseChannel.cpp          |  4 ++++
 netwerk/protocol/http/HttpBaseChannel.h            |  1 +
 netwerk/protocol/http/HttpChannelChild.cpp         | 25 ++--------------------
 netwerk/protocol/http/HttpChannelChild.h           | 24 +++++++++++++++++++++
 netwerk/protocol/http/HttpChannelParent.cpp        |  1 +
 netwerk/protocol/http/HttpChannelParent.h          |  1 +
 .../protocol/http/HttpChannelParentListener.cpp    |  1 +
 netwerk/protocol/http/HttpChannelParentListener.h  |  1 +
 netwerk/protocol/http/InterceptedChannel.cpp       |  1 +
 netwerk/protocol/http/NullHttpChannel.cpp          |  1 +
 netwerk/protocol/http/NullHttpTransaction.cpp      |  1 +
 netwerk/protocol/http/PackagedAppService.cpp       | 14 ++++++++++--
 netwerk/protocol/http/PackagedAppService.h         |  4 +++-
 netwerk/protocol/http/PackagedAppVerifier.cpp      |  1 +
 netwerk/protocol/http/nsCORSListenerProxy.cpp      |  2 +-
 netwerk/protocol/http/nsHttpBasicAuth.cpp          |  1 +
 netwerk/protocol/http/nsHttpChannel.cpp            |  2 ++
 netwerk/protocol/http/nsHttpChunkedDecoder.cpp     |  1 +
 netwerk/protocol/http/nsHttpConnectionInfo.cpp     |  2 ++
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  1 +
 netwerk/protocol/http/nsHttpDigestAuth.cpp         |  1 +
 netwerk/protocol/viewsource/nsViewSourceHandler.h  |  4 ++++
 .../protocol/websocket/BaseWebSocketChannel.cpp    |  1 +
 .../websocket/WebSocketEventListenerParent.cpp     |  1 +
 .../protocol/websocket/WebSocketEventService.cpp   |  3 +++
 netwerk/protocol/websocket/WebSocketFrame.cpp      |  2 ++
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  1 +
 .../protocol/wyciwyg/nsWyciwygProtocolHandler.cpp  |  1 +
 netwerk/streamconv/converters/mozTXTToHTMLConv.cpp |  1 +
 .../streamconv/converters/nsFTPDirListingConv.cpp  |  1 +
 .../streamconv/converters/nsHTTPCompressConv.cpp   |  2 ++
 netwerk/streamconv/converters/nsHTTPCompressConv.h |  1 +
 netwerk/streamconv/converters/nsIndexedToHTML.cpp  |  1 +
 netwerk/streamconv/converters/nsMultiMixedConv.cpp |  2 ++
 netwerk/streamconv/converters/nsTXTToHTMLConv.cpp  |  2 ++
 netwerk/streamconv/converters/nsUnknownDecoder.cpp |  2 ++
 75 files changed, 147 insertions(+), 32 deletions(-)
 2016-01-08 20:20:50 -05:00
Patrick McManus
050f902acb bug 1219466 - convert netwerk to LazyLogModule r=valentin.gosu 2015-11-02 23:35:29 -05:00
Francois Marier
1ee37b7820 Bug 1208285 - Improve TP debug logging. r=gcp 2015-09-25 20:39:49 -07:00
Francois Marier
206d0ba7fa Bug 1205138 - Cleanup tracking protection warnings and logs. r=gcp 2015-09-16 16:42:08 -07:00
Francois Marier
769b2df062 Bug 1197000 - Better debugging output for Safe Browsing list updates. r=gcp 2015-08-21 13:53:53 -07:00
Valentin Gosu
a6ef02816d Bug 1190450 - TP shield shows up incorrectly when pressing back while loading a page with tracking elements r=mcmanus 2015-08-13 11:14:36 +02:00
Francois Marier
2074ff80bf Bug 1141352 - add a pairwise allowlist to tracking protection. r=gcp 2015-08-07 13:08:22 -07:00
Panos Astithas
d31454ed51 Bug 1145503 - TP exceptions added while in Private Browsing mode persist beyond the Private Browsing session. r=ehsan 2015-07-26 13:23:12 +03:00
Dragana Damjanovic
f5e3e71a6d Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell 2015-07-06 07:55:00 +02:00
Emanuel Hoogeveen
b30abdc582 Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Juan Gomez
89035d527e Bug 1171931 - Refactor duplicated code using XRE_IsParent/ContentProcess. r=froydnj 2015-07-03 18:29:00 -07:00
Dragana Damjanovic
a02aa928e5 Bug 1170197 - If a channel is suspended in http-on-modify-request, it should not send any trafic untill resumed. r=mayhemer 2015-06-18 10:57:00 -04:00
Ryan VanderMeulen
7aba9d7002 Backed out changeset 8b4e4083639e (bug 1171931) for B2G debug emulator bustage. 2015-06-25 19:48:42 -04:00