Xidorn Quan
1ce57ccbed
Bug 1448535 part 2 - Remove arena-related code from style structs. r=emilio
...
MozReview-Commit-ID: LlmauyL3goU
2018-03-29 03:45:18 +11:00
Jonathan Watt
44d37e68d5
Bug 1449321 - Remove the IsServo and IsGecko methods from the style system code. r=emilio
2018-03-23 16:01:34 +00:00
Jonathan Watt
baf9ffb02b
Bug 1448714 - Fix up comments referring to 'style context' after the rename of nsStyleContext. r=emilio
2018-03-23 13:49:21 +00:00
Xidorn Quan
e74c1e1696
Bug 1448526 part 2 - Make nsStyleStructList.h not generated. r=emilio
...
nsStyleStructList.h was initially made generated in bug 873368 to avoid
manually maintaining boilerplate for if-dispatch, while the if-dispatch
was replaced by jump table in bug 1171842, so the boilerplate went away.
However, in bug 1122781 (before bug 1171842), boilerplate for dependency
check, so it still needs to be generated.
The dependency table is removed in the previous patch, so we no longer
have any boilerplate in the style struct list, and thus it doesn't need
to be generated anymore.
MozReview-Commit-ID: GkbJZ98ojbE
2018-03-26 20:09:17 +11:00
Emilio Cobos Álvarez
1d4859a89a
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
97286b35c8
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
1f5d8de5cc
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Emilio Cobos Álvarez
b1a35fbef7
Bug 1447358: Unifdef the old style system code. r=jwatt
...
Summary:
This has been automatically generated using:
http://dotat.at/prog/unifdef/
And:
find $OBJDIR -type f -name '*.h' |
while read FILE; do
echo "$FILE"
unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done
find $OBJDIR -type f -name '*.cpp' |
while read FILE; do
echo "$FILE"
unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done
MozReview-Commit-ID: I4NdKqbMXzJ
Reviewers: jwatt
Bug #: 1447358
Differential Revision: https://phabricator.services.mozilla.com/D779
2018-03-21 10:20:34 +01:00
Emilio Cobos Álvarez
d07e97013f
Bug 1439285: Hack around bug 1406134. r=bholley
...
MozReview-Commit-ID: Cg2HxB99cGD
2018-02-22 20:03:43 +01:00
Emilio Cobos Álvarez
e43f069814
Bug 1439285: Make the old image request arrive to FinishStyle if we come from ResolveSameStructsAs. r=bholley
...
MozReview-Commit-ID: H1N9jNql9tl
2018-02-22 19:44:44 +01:00
Chris Peterson
6758bf6a84
Bug 1436263 - Part 1: Replace final override virtual function specifiers with just final. r=froydnj
...
MozReview-Commit-ID: DE5HkIhsZ6D
2018-02-05 22:46:57 -08:00
Hiroyuki Ikezoe
4241626ea4
Bug 1237454 - Add VisibilityChange change hint. r=emilio
...
This new change hint doesn't influence layout so that it can be regarded
as nsChangeHint_Hints_CanIgnoreIfNotVisible. Note that if visibility changed
from collapse or to collapse, we set NS_STYLE_HINT_REFLOW separetely.
MozReview-Commit-ID: AirDWeBYVKG
2018-02-09 10:43:10 +09:00
Brad Werth
067521b8d7
Bug 1418930 Part 5: Update nsStyleStruct::FinishStyle and nsRuleNode::ComputeDisplayData to set CORS mode for shape-outside images. r=emilio
...
MozReview-Commit-ID: 7MXJHE2vidS
2018-01-31 16:08:01 -05:00
Narcis Beleuzu
48308c4297
Backed out 6 changesets (bug 1237454) for bc failures on /browser_toolbariconcolor_restyles.js. CLOSED TREE
...
Backed out changeset f8d771835fd2 (bug 1237454 )
Backed out changeset 2dbbfc331bdf (bug 1237454 )
Backed out changeset c481f409feaa (bug 1237454 )
Backed out changeset 0b9872865f0e (bug 1237454 )
Backed out changeset 43ca55e7c93b (bug 1237454 )
Backed out changeset 027b0c65d944 (bug 1237454 )
2018-02-06 11:19:56 +02:00
Hiroyuki Ikezoe
7934861cd6
Bug 1237454 - Add VisibilityChange change hint. r=emilio
...
This new change hint doesn't influence layout so that it can be regarded
as nsChangeHint_Hints_CanIgnoreIfNotVisible. Note that if visibility changed
from collapse or to collapse, we set NS_STYLE_HINT_REFLOW separetely.
MozReview-Commit-ID: AirDWeBYVKG
2018-02-06 08:43:52 +09:00
Noemi Erli
632740c63b
Backed out changeset c074e2c4b2ed (bug 1435658) for failing in layout/generic/test/test_bug632379.xul on a CLOSED TREE
2018-02-05 22:39:07 +02:00
Emilio Cobos Álvarez
c4c4eeffc6
Bug 1435658: Deal with appearance changes from / to none correctly. r=mats
...
MozReview-Commit-ID: Fl6VY0rAIiD
2018-02-05 14:55:31 +01:00
Andreea Pavel
d12d04aff1
Backed out 5 changesets (bug 1418930) for failing web platform tests at /service-workers/service-worker/fetch-request-css-images.https.html on a CLOSED TREE
...
Backed out changeset c0f673033e66 (bug 1418930)
Backed out changeset b39948ba905b (bug 1418930)
Backed out changeset 8008a54aba9a (bug 1418930)
Backed out changeset 105c81284dba (bug 1418930)
Backed out changeset 27eb8c7f8025 (bug 1418930)
2018-02-03 00:18:27 +02:00
Brad Werth
0467812c28
Bug 1418930 Part 4: Update nsStyleStruct::FinishStyle to set CORS mode for shape-outside images. r=emilio
...
MozReview-Commit-ID: 7MXJHE2vidS
2018-01-31 16:08:01 -05:00
Cameron McCormack
02c617875f
Bug 1430014 - Part 4: #ifdef out unnecessary code when the old style system is not built. r=xidorn
...
MozReview-Commit-ID: 1FZ9VzjcPzN
2018-02-01 15:04:04 +11:00
cku
7dc339dd52
Bug 1207734 - Part 4.a. Store the final combined transform in nsStyleDisplay::mCombinedTransform. r=birtles
...
MozReview-Commit-ID: FsuaMoclnL8
(grafted from 793e73f61ee1d0035b3d9d881df4eb784da3c4e9)
2018-01-24 16:22:46 +09:00
cku
b342da0285
Bug 1207734 - Part 1.d. Carry the computed value of individual transform in nsStyleDisplay. r=emilio
...
Add three more attributes in nsStyleDisplay
1. mSpecifiedRotate to carry computed value of 'rotate' property.
2. mSpecifiedTranslate to carry computed value of 'translate' property.
3. mSpecifiedScale to carry computed value of 'scale' property.
Since each of these tree new property can be an animation target, we have to store
them in speparate attributes, instead of putting them all in mSpecifiedTransform.
MozReview-Commit-ID: G2dBAxzyBWh
(grafted from 04fe9115ce1d189155ff9b2c89b1a656a55dd1c9)
2017-12-06 17:17:34 +08:00
cku
f8d026043d
Bug 1207734 - Part 1.b. Do not initialize mSpecifiedTransform in ctor. r=emilio
...
nsDisplayList::mSpecifiedTransform is a RefPtr, no need put it into intialize
list.
MozReview-Commit-ID: B04gytHwb2K
(grafted from f2dc6cad129e9f5c8c8c056c934d2ed3f2e30155)
2017-12-07 10:32:18 +08:00
cku
130fbdaacd
Bug 1207734 - Part 1.a. Implement ReleaseSharedListOnMainThread to reuse the code of releasing nsCSSValueSharedList objects hold by a style struct. r=emilio
...
MozReview-Commit-ID: IBfqulFXimi
(grafted from f5a560721ed0b41ca8c906cf6a394ce763d49949)
2017-12-07 10:22:49 +08:00
Emilio Cobos Álvarez
f085fb7158
Bug 1429723: Remove -moz-border-*-colors. r=xidorn
...
MozReview-Commit-ID: 3P6f7rFcDa6
2018-01-22 18:14:07 +01:00
Chris Peterson
677bf4030c
Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
...
MozReview-Commit-ID: DCPTnyBooIe
2017-11-05 19:37:28 -08:00
Xidorn Quan
6831f9fcc2
Bug 1325940 part 2 - Converted NS_STYLE_BORDER_IMAGE_REPEAT_* to an enum class. r=emilio
...
MozReview-Commit-ID: Kdzm5D8Dpv
2017-12-21 16:16:40 +11:00
Mats Palmgren
03018ea47a
Bug 1422839 part 1 - Add internal overflow-clip-box-block/-inline properties and make overflow-clip-box a shorthand. r=dholbert
...
MozReview-Commit-ID: axoDaWnOJQ
2017-12-05 21:08:41 +01:00
Ting-Yu Lin
ce7a0e0ebb
Bug 1265343 Part 1 - Add shape-image-threshold to style system. r=heycam
...
devtools/shared/css/generated/properties-db.js is generated by running
"./mach devtools-css-db"
MozReview-Commit-ID: 1U4yoQTDwxi
2017-11-27 15:01:25 +08:00
Ting-Yu Lin
48f97afc24
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
e4a120ce82
Bug 1418224 Part 1 - Change StyleShapeSource::SetURL's return type to void. r=heycam
...
No caller check the return value, and SetURL ever returns true.
MozReview-Commit-ID: 5XPFq41Ktlq
2017-10-02 17:51:20 +08:00
Emilio Cobos Álvarez
2cbb6be7a5
Bug 1420496: Bring back the optimization to avoid traversing XBL subtrees that will likely change. r=heycam
...
We need to get rid of BindingHolder to handle properly the case of an invalid
binding URL.
MozReview-Commit-ID: 3sIGtcVOt0r
2017-11-24 15:15:38 +01:00
dluca
617c4e7f6a
Backed out 4 changesets (bug 1418224) for build bustages r=backout on a CLOSED TREE
...
Backed out changeset 3ef8715cb8d7 (bug 1418224)
Backed out changeset 0d58d9fed90d (bug 1418224)
Backed out changeset faad7f275749 (bug 1418224)
Backed out changeset 1e86ff6b95ae (bug 1418224)
2017-11-27 07:42:50 +02:00
Ting-Yu Lin
0ba402e925
Bug 1418224 Part 3 - Add shape-outside: <image> support to style system. r=heycam
...
Some Gecko style system files are modified to prevent assertions and
crashing, and to keep test failures on stylo disabled builds to minimum.
MozReview-Commit-ID: GuxAeCTz0xx
2017-11-17 16:34:37 +08:00
Ting-Yu Lin
1f1bf331d5
Bug 1418224 Part 1 - Change StyleShapeSource::SetURL's return type to void. r=heycam
...
No caller check the return value, and SetURL ever returns true.
MozReview-Commit-ID: 5XPFq41Ktlq
2017-10-02 17:51:20 +08:00
Botond Ballo
efa5b22bde
Bug 951793 - Do not reconstruct the frame when overscroll-behavior has changed. r=mstange
...
A repaint is sufficient to pick up the new property value.
MozReview-Commit-ID: oKFgGfquyl
2017-11-25 01:29:21 +01:00
Botond Ballo
d2150a861f
Bug 951793 - Style support for overscroll-behavior. r=heycam
...
MozReview-Commit-ID: IDAfBZy2D5p
2017-11-25 01:28:58 +01:00
Sebastian Hengst
df2429a1ad
Backed out 15 changesets (bug 951793) because it landed before the necessary servo changes. r=backout requested by emilio on a CLOSED TREE
...
Backed out changeset ca8c86e229df (bug 951793)
Backed out changeset 6eef6403fa71 (bug 951793)
Backed out changeset a5e529f52fb1 (bug 951793)
Backed out changeset 054e837609d0 (bug 951793)
Backed out changeset 713a3c9617ce (bug 951793)
Backed out changeset 884913aa1668 (bug 951793)
Backed out changeset c3340b84e534 (bug 951793)
Backed out changeset 50fe3c6ac486 (bug 951793)
Backed out changeset be4e22e5c257 (bug 951793)
Backed out changeset 7055bd5dfc4e (bug 951793)
Backed out changeset fa6da1e723cf (bug 951793)
Backed out changeset 386f77004d89 (bug 951793)
Backed out changeset fa82cdc01408 (bug 951793)
Backed out changeset 867d8ea5355c (bug 951793)
Backed out changeset e61ac8e48971 (bug 951793)
2017-11-25 01:01:41 +02:00
Botond Ballo
b6edf40dae
Bug 951793 - Do not reconstruct the frame when overscroll-behavior has changed. r=mstange
...
A repaint is sufficient to pick up the new property value.
MozReview-Commit-ID: oKFgGfquyl
2017-11-22 19:06:43 -05:00
Botond Ballo
3bc3bacff3
Bug 951793 - Style support for overscroll-behavior. r=heycam
...
MozReview-Commit-ID: IDAfBZy2D5p
2017-11-22 19:01:11 -05:00
Cameron McCormack
3a63519a6b
Bug 1418899 - Followup speculative Windows build fix. (CLOSED TREE)
2017-11-21 17:11:40 +08:00
Cameron McCormack
382b3d4bbb
Bug 1418899 - Part 4: Move image layer filling function out of nsRuleNode. r=cjku
...
MozReview-Commit-ID: 2FXGFEkpIKE
2017-11-20 13:53:58 +08:00
Cameron McCormack
deb7a50a89
Bug 1418872 - Move ControlCharVisibilityDefault() out of nsCSSParser. r=TYLin
...
MozReview-Commit-ID: EkNq7lREGgA
2017-11-20 10:46:45 +08:00
Markus Stange
40cf204449
Bug 1414926 - Make -moz-font-smoothing-background-color changes only cause repaints, not reflows. r=emilio
...
This case is hit by hovering over menu items, so the optimization is somewhat worthwhile.
As a side-effect, not causing reflows also avoids a XUL <select> popup positioning bug.
MozReview-Commit-ID: AOrijytoHHL
2017-11-07 23:01:29 -05:00
Markus Stange
a2cbb75a70
Bug 1414147 - Move fontSmoothingBackgroundColor from nsStyleUserInterface to nsStyleFont / nsFont. r=dbaron
...
MozReview-Commit-ID: 7i0Sy50Badm
2017-11-02 17:48:44 -04:00
Hiroyuki Ikezoe
f0a38025cf
Bug 1329169 - Use atom for animation-name property. r=xidorn
...
MozReview-Commit-ID: 9yVWXVi1oXf
2017-10-10 17:00:28 +09:00
Nicholas Nethercote
7dbfdaf890
Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
...
(Path is actually r=froydnj.)
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.
MozReview-Commit-ID: 91U22X2NydP
2017-10-03 09:05:19 +11:00
Ting-Yu Lin
b445303baa
Bug 1404243 Part 4 - Change StyleShapeSource's URL value storage by using nsStyleImage. r=heycam
...
This is for implementing shape-outside: <image> later.
MozReview-Commit-ID: 93TmLecRjRx
2017-09-29 16:24:23 +08:00
Ting-Yu Lin
d35b7d33db
Bug 1404243 Part 3 - Remove refcount for StyleBasicShape, and use UniquePtr to hold it. r=heycam
...
After StyleBasicShape is set to StyleShapeSource, it's life cycle never go
beyond StyleShapeSource, so I make StyleBasicShape hold by a UniquePtr in
StyleShapeSource.
Also, replace all raw pointers to StyleBasicShape by UniquePtr in all APIs.
MozReview-Commit-ID: 1MfIFjP8TsQ
2017-09-25 18:50:24 +08:00
Ting-Yu Lin
bdeac3a666
Bug 1404243 Part 2 - Change StyleShapeSource::operator==() to use logic in DefinitelyEquals(). r=heycam
...
The original operator==() (implemented by EqualsInternal<true>) is not been
used. Therefore, I expand EqualsInternal<false> into it, and move it to
nsStyleStruct.cpp.
Also, use DefinitelyEqualURIs() in nsStyleStruct.cpp in operator==().
MozReview-Commit-ID: HccwKvzQHR
2017-09-29 14:36:35 +08:00