Commit Graph

20 Commits

Author SHA1 Message Date
Xidorn Quan
26a9861563 Bug 1449103 part 2 - Make CSSKeyframesRule inherit from Rule directly. r=emilio
The spec doesn't say CSSKeyframesRule needs to inherit CSSGroupingRule.
It inherited GroupRule because Gecko's keyframes rule implementation
relies on that to manage its children.

MozReview-Commit-ID: CnVP2tozwQU
2018-03-28 12:23:58 +11:00
Chris Peterson
6758bf6a84 Bug 1436263 - Part 1: Replace final override virtual function specifiers with just final. r=froydnj
MozReview-Commit-ID: DE5HkIhsZ6D
2018-02-05 22:46:57 -08:00
Boris Zbarsky
c57e2f672e Bug 1434390. Mostly get rid of GetCssTextImpl. r=emilio
MozReview-Commit-ID: 5fejArxQckq
2018-01-30 16:30:08 -05:00
Chris Peterson
677bf4030c Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
MozReview-Commit-ID: DCPTnyBooIe
2017-11-05 19:37:28 -08:00
Cameron McCormack
65f9559a03 Bug 1427512 - Part 10: Remove nsIDOMCSSKeyframesRule. r=xidorn
MozReview-Commit-ID: 1U6Jd0Y6AlR
2018-01-11 16:17:55 +08:00
Emilio Cobos Álvarez
ae4565f9fe Bug 1420762: Make StyleSheets notify directly to their StyleSets. r=heycam
This also makes the rule map not process all the stylesheets for the document,
which would be a mess with shadow DOM.

Far from the final, ideal state, but hey, progress.

MozReview-Commit-ID: 7TrifME9VZ
2017-12-01 08:46:39 +01:00
Brindusan Cristian
267e0964fa Backed out 2 changesets (bug 1420762) for merge conflicts r=merge a=merge
Backed out changeset ba350c82d823 (bug 1420762)
Backed out changeset 00287b88254b (bug 1420762)
2017-12-01 00:20:10 +02:00
Emilio Cobos Álvarez
25703a1dfa Bug 1420762: Make StyleSheets notify directly to their StyleSets. r=heycam
This also makes the rule map not process all the stylesheets for the document,
which would be a mess with shadow DOM.

Far from the final, ideal state, but hey, progress.

MozReview-Commit-ID: 7TrifME9VZ
2017-11-30 15:42:45 +01:00
Xidorn Quan
bf834867de Bug 1412145 - Drop more backpointers of CSSOM objects in dtor and unlink. r=bz
MozReview-Commit-ID: Ftg3WMBBNlO
2017-11-28 17:06:51 -06:00
Tiberius Oros
662da4c6c2 Backed out changeset 5043401c5447 (bug 1412145)for failing layout/style/test/test_any_dynamic.html r=backout on a CLOSED TREE 2017-11-28 21:50:29 +02:00
Xidorn Quan
5d76b68ffd Bug 1412145 - Drop more backpointers of CSSOM objects in dtor and unlink. r=bz
MozReview-Commit-ID: Ftg3WMBBNlO
2017-10-24 12:20:50 +11:00
Nicholas Nethercote
7dbfdaf890 Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP
2017-10-03 09:05:19 +11:00
Nicholas Nethercote
9fda5528d2 Bug 1400459 (part 2) - Devirtualize nsIAtom. r=heycam.
This patch merges nsAtom into nsIAtom. For the moment, both names can be used
interchangeably due to a typedef. The patch also devirtualizes nsIAtom, by
making it not inherit from nsISupports, removing NS_DECL_NSIATOM, and dropping
the use of NS_IMETHOD_. It also removes nsIAtom's IIDs.

These changes trigger knock-on changes throughout the codebase, changing the
types of lots of things as follows.

- nsCOMPtr<nsIAtom> --> RefPtr<nsIAtom>

- nsCOMArray<nsIAtom> --> nsTArray<RefPtr<nsIAtom>>
  - Count() --> Length()
  - ObjectAt() --> ElementAt()
  - AppendObject() --> AppendElement()
  - RemoveObjectAt() --> RemoveElementAt()

- ns*Hashtable<nsISupportsHashKey, ...> -->
  ns*Hashtable<nsRefPtrHashKey<nsIAtom>, ...>

- nsInterfaceHashtable<T, nsIAtom> --> nsRefPtrHashtable<T, nsIAtom>
  - This requires adding a Get() method to nsRefPtrHashtable that it lacks but
    nsInterfaceHashtable has.

- nsCOMPtr<nsIMutableArray> --> nsTArray<RefPtr<nsIAtom>>
  - nsArrayBase::Create() --> nsTArray()
  - GetLength() --> Length()
  - do_QueryElementAt() --> operator[]

The patch also has some changes to Rust code that manipulates nsIAtom.

MozReview-Commit-ID: DykOl8aEnUJ
2017-09-26 08:33:21 +10:00
Jeremy Chen
d256262acb Bug 1394994 - stylo: get line and column for ServoKeyframeRule. r=xidorn
The Servo_KeyframesRule_GetKeyframe binding function has been empowerd and
renamed to Servo_KeyframesRule_GetKeyframeAt in the servo side patch. In this
patch, we use Servo_KeyframesRule_GetKeyframeAt to get line and column
information for ServoKeyframeRule, so that the inspector can present Keyframe
rules on the devtool panel properly.

MozReview-Commit-ID: BGd9FFsC3Nz
2017-09-04 13:38:23 +08:00
Andrew McCreight
84ee98de3c Bug 1391005 - Eliminate NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION_INHERITED. r=peterv
Replace it with NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION, because it
has been the same for a while.

MozReview-Commit-ID: 5agRGFyUry1
2017-08-29 16:02:48 -07:00
Emilio Cobos Álvarez
6941d33a8e Bug 1372041: Refactor a bunch of stuff so link rel="media" is honored. r=heycam
This still leaves one annoying refactoring of @import so we also fix it for
them.

MozReview-Commit-ID: 4s0WExDEH75
2017-07-02 17:19:07 +02:00
Xidorn Quan
18ed7473e4 Bug 1366657 - Set stylesheet and parent rules properly for keyframe rules. r=heycam
MozReview-Commit-ID: CdIm4IypeN0
2017-05-22 16:05:14 +10:00
Phil Ringnalda
e4ab0c4347 Backed out changeset dd3a293cf053 (bug 1366247) for making Stylo build, but not run
MozReview-Commit-ID: JcbwZSt05cN
2017-05-21 12:55:08 -07:00
Xidorn Quan
84e1b2734a Bug 1366247 - Add sugar for already_AddRefed and use it for conversion between Atom and nsIAtom pointer. r=manishearth
MozReview-Commit-ID: HeV5UsqGcWs
2017-05-19 23:24:31 +10:00
Xidorn Quan
27f1a7dbf9 Bug 1345697 part 3 - Implement CSSKeyframesRule and CSSKeyframeRule for stylo. r=heycam
MozReview-Commit-ID: AeU0BWaBfYe
2017-05-19 16:12:34 +10:00