Commit Graph

131 Commits

Author SHA1 Message Date
Mark Banner
29e56bce9b Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk
2018-03-06 12:01:59 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Florian Quèze
1838aa9e08 Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Chris H-C
d910cfb973 bug 1406391 - Remove toolkit.telemetry.enabled manipulation from tests r=Dexter
Minor note:
reftests should've turned off uploadEnabled in the first place.
reftests should have unified telemetry on. It's the future.

MozReview-Commit-ID: 9spzuUAXwwP
2017-10-30 10:47:39 -04:00
Phil Ringnalda
5d3df7d6dd Backed out 4 changesets (bug 1408433, bug 1406391, bug 1408512) for crashing tests by touching the network contacting incoming.telemetry.mozilla.org on nightly builds
Backed out changeset 9bfd4b0927dc (bug 1408433)
Backed out changeset 555850d5107e (bug 1408512)
Backed out changeset 15d959b9123e (bug 1406391)
Backed out changeset e1f34ba9cecc (bug 1406391)

MozReview-Commit-ID: BVoGRsD73Hf
2017-10-27 21:08:27 -07:00
Chris H-C
dbea8807d3 bug 1406391 - Remove toolkit.telemetry.enabled manipulation from tests r=Dexter
Minor note:
reftests should've turned off uploadEnabled in the first place.

MozReview-Commit-ID: 9spzuUAXwwP
2017-10-27 10:59:43 -04:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Georg Fritzsche
bfb020d6d7 Bug 1402609 - Part 2: Make Experiments.jsm recover from unloadable manifest cache. r=Dexter 2017-10-06 05:05:00 -04:00
Mark Banner
44963145a5 Bug 1392098 - Enable the new ESLint no-useless-run-test rule across the tree. r=mossop
MozReview-Commit-ID: 35MaseieNUk
2017-08-20 18:52:05 +01:00
Masatoshi Kimura
0af76969af Bug 1375125 - Stop using nsILocalFile in the tree. r=froydnj
This mechanically replaces nsILocalFile with nsIFile in
*.js, *.jsm, *.sjs, *.html, *.xul, *.xml, and *.py.

MozReview-Commit-ID: 4ecl3RZhOwC
2017-08-04 17:49:22 +09:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Luciano Italiani
7480cc09d7 Bug 1374671 - Enable the ESLint no-whitespace-before-property rule across mozilla-central. r=standard8
MozReview-Commit-ID: 4WkNg0YrgHx
2017-07-27 23:01:13 -03:00
Andrew Halberstadt
86f21296a2 Bug 1383120 - Enable no-arbitrary-setTimeout eslint rule on xpcshell tests, r=mossop
MozReview-Commit-ID: 6DqLaZ9n5EM
2017-07-26 09:08:07 -04:00
Andrew Swan
8438182e63 Bug 1358907 Part 3 Avoid reading XPI database at startup r=Dexter,kmag
Switch telemetry and experiments from AddonManager.getAddonsByTypes()
to AddonManager.getActiveAddons() which gives us less detailed information
in the environment during startup but also means we don't need to load the
extensions database until startup is complete.

MozReview-Commit-ID: 4SxdPHSPovB
2017-05-18 13:08:58 -07:00
Wes Kocher
e3b0ffb8d2 Backed out 3 changesets (bug 1358907) for devtools failures in leakcheck a=backout
Backed out changeset 529eccc2bc69 (bug 1358907)
Backed out changeset 5368cc2c4f38 (bug 1358907)
Backed out changeset d112bc46842f (bug 1358907)

MozReview-Commit-ID: D2oHpM7GgrW
2017-07-03 14:43:57 -07:00
Andrew Swan
71ec676492 Bug 1358907 Part 3 Avoid reading XPI database at startup r=Dexter
Switch telemetry and experiments from AddonManager.getAddonsByTypes()
to AddonManager.getActiveAddons() which gives us less detailed information
in the environment during startup but also means we don't need to load the
extensions database until startup is complete.

MozReview-Commit-ID: 4SxdPHSPovB
2017-05-18 13:08:58 -07:00
Florian Quèze
c0468168f5 Bug 1368456 - remove Promise.jsm imports in tests, r=mconley. 2017-06-23 11:25:52 +02:00
Florian Quèze
c30094cdf7 Bug 1374282 - script generated patch to remove generators from add_task in browser/ and toolkit/, r=Mossop. 2017-06-22 12:51:43 +02:00
Florian Quèze
15feaa278a Bug 1362882 - script-generated patch to switch from Promise.defer() to new Promise() where it's straightforward, rs=Mossop. 2017-05-12 14:55:27 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Quèze
4ff7b0abff Bug 1353542 - pre-script hand-written cleanup patch, r=Mossop. 2017-05-12 14:41:20 +02:00
Mark Banner
ca95cdd557 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx
2017-04-19 12:06:16 +01:00
Wes Kocher
c94cafc922 Backed out changeset e1c9c6e89f50 (bug 1348097) for asan failures in test_SubsessionChaining.js a=backout
MozReview-Commit-ID: AiAjjlBmODC
2017-04-20 13:34:16 -07:00
Mark Banner
a436ee25b7 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx
2017-04-19 12:06:16 +01:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6
2017-01-09 10:12:26 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
b6817d7876 Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: 1mhCWplknyN
2016-11-07 22:34:25 -05:00
Iris Hsiao
d24e67dbe4 Backed out changeset f6f28be8d8f2 (bug 1315781) for XPCShell test timed out 2016-11-10 14:53:46 +08:00
Jared Wein
0c41af265f Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: DnpVQRrG9Ec
2016-11-07 22:34:25 -05:00
Sebastian Hengst
d1c538318e Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM
MozReview-Commit-ID: LDNr97hKpc8
2016-11-05 11:29:13 +01:00
Mark Banner
d4b538c2b7 Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree. r=miker
MozReview-Commit-ID: FlbJ8yzWXlw
2016-10-26 09:46:40 +01:00
Mark Banner
58280be44c Bug 1312277 - Enable no-unused-vars eslint rule for browser/experiments. r=mossop
MozReview-Commit-ID: FUcMgWy8Vv7
2016-10-17 22:17:05 +01:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Kris Maglione
47312ecab3 Bug 1294811: Fix external tests that import head_addons.js. r=rhelmer
MozReview-Commit-ID: EWo7Gv9oSsz
2016-08-16 17:02:44 -07:00