Commit Graph

2081 Commits

Author SHA1 Message Date
Noemi Erli
d4cd5ed7fd Merge inbound to mozilla-central. a=merge 2018-02-15 21:29:11 +02:00
Johann Hofmann
516f9821f7 Bug 1421737 - Part 4 - Update site data manager tests to include cookies. r=Gijs
This adds a dedicated test for showing and deleting cookies in site data
management as well as amending tests for sorting, grouping, etc.

MozReview-Commit-ID: 59mN3uASwPP
2018-02-09 00:04:03 +01:00
Johann Hofmann
4b2d20aff9 Bug 1421737 - Part 3 - Simplify the "remove selected sites" dialog in site data management. r=Gijs
We are no longer implicitly deleting cookies when removing site data because
cookies are now listed as part of the site data manager. We're also no longer
deleting cookies based on the base domain, which makes most of the UI in the
removal dialog unnecessary. Instead of a tree box with sub domains we're now
showing a simple listbox domains to be deleted.

MozReview-Commit-ID: GWv5QVxEiiy
2018-02-05 17:42:54 +01:00
Johann Hofmann
eea4ca7873 Bug 1421737 - Part 2 - Convert the siteListItem XBL binding to plain JS and add a cookies row. r=Gijs
This commit primarily intends to add cookies to the site data manager,
but while touching this code I transformed the siteListItem XBL binding to plain JS.

This also removes the #SiteDataRemoveSelectedDialog binding rule, because it is
unnecessary, <dialog> elements already have this binding.

MozReview-Commit-ID: EpTd2E0vPN9
2018-02-09 20:56:04 +01:00
Johann Hofmann
1c4206a397 Bug 1421737 - Part 1 - Include cookies in SiteDataManager.jsm. r=Gijs
MozReview-Commit-ID: HovCREaRbgL
2018-02-09 20:47:07 +01:00
Mark Striemer
1c2934d1bf Bug 1412873 - Disarm JSONFile when trying to discard changes in preferences tests r=aswan
MozReview-Commit-ID: 5l0yRop3guh
2018-02-12 15:51:48 -06:00
Johann Hofmann
08312ab421 Bug 1422160 - Merge cache and site data in about:preferences. r=jaws
This commit removes most of the cache section in about:preferences,
following the UX concept from bug 1421690. This is in the general
interest of de-cluttering privacy preferences and giving users controls
that are easier to understand and use.

The cache size is instead shown in the site data section and the cache
can be cleared using the "Clear Data" button in that same section.

MozReview-Commit-ID: 7PDTDgllFFI
2018-02-13 12:33:29 +01:00
Zibi Braniecki
85527f89ee Bug 1424682 - Migrate the chrome of Preferences to the new Localization API. r=flod,jaws
MozReview-Commit-ID: ALnFUmnJMDB
2017-12-18 23:19:13 -08:00
Gijs Kruitbosch
2a804a92ae Bug 1438103 - fix UI for error reporting pref, r=Pike
MozReview-Commit-ID: FCNy3dY7y1a
2018-02-14 09:42:36 +00:00
Bob Silverberg
2d9369ad83 Bug 1436165 - Change extensionControlled strings for home page and new tab page, r=jaws,mstriemer
MozReview-Commit-ID: KcWiCm5nbeB
2018-02-07 14:03:23 -05:00
Jared Wein
db0a992247 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8
MozReview-Commit-ID: 66sXxnOWDgw
2018-02-08 12:57:31 -05:00
Drew Willcoxon
35710a6d36 Bug 1437967 - "Microsoft Translator" image in "Translations by" checkbox in translate/language preferences is vertically stretched, has wrong aspect ratio. r=jaws
MozReview-Commit-ID: FDC2TGFGywc
2018-02-13 10:40:25 -08:00
Michael Kelly
895bcde6ef Bug 1426482 Report browser errors in Nightly to Mozilla. r=gijs
Errors are collected via nsIConsoleService, shaped to a Sentry-compatible
format, and sent off. Reporting is on by default, and can be disabled using a
checkbox added to the privacy prefs in about:preferences.

Collected errors are sampled to avoid overloading the collection service; the
sample rate was determined by a previous Shield study that measured the number
of errors occurring in Nightly.

The feature is hard-disabled outside of Nightly and local builds, and the
preference is disabled by default in local builds. It is intended as a prototype
that will be evaluated and replaced by a more robust collection system if it
proves helpful.

Differential Revision: https://phabricator.services.mozilla.com/D561

MozReview-Commit-ID: 6aqUatXyuYs
2018-02-12 10:59:47 -08:00
Tooru Fujisawa
d7f90d66d4 Bug 1431960 - Forcibly construct the frame for browser to construct browser binding in preferences subdialog. r=bz 2018-02-10 11:59:57 +09:00
Dão Gottwald
22cfe90814 Bug 1432716 - Group the "Show search suggestions ahead of browsing history in address bar results" checkbox with other search suggestion checkboxes. ui=shorlander r=adw
MozReview-Commit-ID: CSuNpA0Yq0w
2018-02-09 10:44:28 +01:00
Csoregi Natalia
e67e472427 Backed out changeset 98b4549200aa (bug 1432716) expected to fail. 2018-02-09 11:46:03 +02:00
Dão Gottwald
a55620e3b3 Bug 1432716 - Group the "Show search suggestions ahead of browsing history in address bar results" checkbox with other search suggestion checkboxes. ui=shorlander r=adw
MozReview-Commit-ID: 6Xt8MixhV3x
2018-01-24 08:48:27 +01:00
Edouard Oger
1666fb5941 Bug 1427674 - Unify FxA content server URL preferences. r=markh,tcsc
MozReview-Commit-ID: 3zhHGAzQr0R
2018-01-30 13:21:35 -05:00
Bob Silverberg
2777c6ca53 Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Bob Silverberg
313de813ef Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Myk Melez
c20189c2c1 Bug 1435786 - ensure Request English checkbox syncs to/from pref r=jaws
MozReview-Commit-ID: FVcsPOSS01T
2018-02-05 14:04:43 -08:00
Mark Banner
4fd95a27c9 Bug 1230369 - Manually fix some remaining instances of Ci/Cc/Cu definitions and switch Components.* to using the shorthand in some places. r=florian
MozReview-Commit-ID: 9SmoR9RlvZE
2018-02-07 09:24:15 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
1affbb39f9 Backed out 2 changesets (bug 1429593) for for mass failing browser-chrome, e.g. browser/components/preferences/in-content/tests/browser_extension_controlled.js on a CLOSED TREE
Backed out changeset 9ce1b89f8744 (bug 1429593)
Backed out changeset fa845d221e7a (bug 1429593)
2018-02-07 16:03:58 +02:00
Bob Silverberg
bef60f3f6e Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Bob Silverberg
fa349f8a38 Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Michael Kohler
96c7a7663d Bug 1432759 - 'Remove selected' should be greyed out if no item is selected in the site data manager r=johannh
MozReview-Commit-ID: 5MejSmaVJeA
2018-02-05 20:39:28 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Gurzau Raul
82749346c0 Backed out 2 changesets (bug 1429593) for l10n issues
Backed out changeset 9dfaa0724a42 (bug 1429593)
Backed out changeset 20829d727fdf (bug 1429593)
2018-02-06 22:03:23 +02:00
Bob Silverberg
66f573d494 Bug 1429593 - Part 2: Show that a WebExtension is managing the proxy config setting, r=jaws,mstriemer
Update the general page of about:preferences, as well as the Connection Settings panel, to show
when an extension is controlling proxy settings, and allow a user to disable the extension to
regain control.

This also updates some of the strings to use the phrase "is controlling" rather than "controls".

MozReview-Commit-ID: HKYPkg78IOK
2018-01-22 11:49:42 -05:00
Bob Silverberg
e9b15452db Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Johann Hofmann
09692183ea Bug 1422163 - Part 2 - Make a new test for clearing all site data with the new dialog. r=Gijs
MozReview-Commit-ID: 6Lt3hPZ1YiO
2018-01-10 12:25:04 +01:00
Johann Hofmann
05a5aaecc3 Bug 1422163 - Part 1 - Make a new confirm dialog for clearing all site data that allows you to clear cache. r=Gijs
MozReview-Commit-ID: G9xQXlfT9Ay
2018-01-10 12:24:40 +01:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
hemant
40d2910989 Bug 1417937 - Remove unnecessary LoadContextInfo.jsm r=standard8
MozReview-Commit-ID: EnY0uKD4UD1
2018-01-31 23:16:46 +05:30
arthur.iakab
384e070ea5 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Sebastian Hengst
0d326c178e merge mozilla-inbound to mozilla-central. r=merge a=merge 2018-01-31 00:22:27 +02:00
Francois Marier
ff03815521 Bug 1410522 - Enable download protection on non-official builds too. r=gcp,johannh
This reverts the change introduced in bug 1394053.

Google has made the download protection lists available to everyone
and so we no longer need to restrict the download protection feature
to official builds.

MozReview-Commit-ID: CQcG5Ip1mDV
2018-01-29 15:51:14 -08:00
Kris Maglione
5298bb7ac5 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
pubkeypin
5930d4e37f Bug 1433596 - Include the header for "Data Collection and Use" in about:preferences#privacy only, if there is content to display. r=jaws 2018-01-27 00:59:06 +01:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
5e845929cf Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
3aa3c6fff8 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Csoregi Natalia
202969bf21 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-01-30 18:22:51 +02:00