Commit Graph

2453 Commits

Author SHA1 Message Date
Marco Bonardo
36ec58e083 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW
2018-03-22 14:13:07 +01:00
Mark Banner
654a153c5b Bug 1439697 - Make the warning about attempting to move an unmovable places node be restricted to our own places flavors only. r=mak
MozReview-Commit-ID: 1zdVIIXWmYI
2018-03-28 11:41:28 +01:00
Mark Banner
a301479611 Bug 1439697 - Always send the item guid in serialized copy data, and make the copy algorithm clearer as to what items use which methods. r=mak
MozReview-Commit-ID: 4dwJB2x2qyp
2018-03-28 11:25:40 +01:00
Mark Banner
629be5dc74 Bug 1439697 - Re-organise the copy/paste & drag/drop algorithm to make it easier to understand. r=mak
MozReview-Commit-ID: BrQEU2e4Nr0
2018-03-27 22:49:01 +01:00
Marco Bonardo
67025f9c64 Bug 1448810 - Rename the Places sidebar files and merge sidebarUtils into PlacesUIUtils. r=standard8
MozReview-Commit-ID: GsPPBhiTPul
2018-03-26 21:15:41 +02:00
Mark Banner
c674e1b442 Bug 1432435 - Remove synchronous Bookmarks::getBookmarkURI. r=mak
MozReview-Commit-ID: GSQOoSoeibq
2018-03-23 17:32:37 +00:00
shindli
b6fd93ae8c Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-03-25 12:52:14 +03:00
Tooru Fujisawa
10a26abe3d Bug 1402380 - Set text/x-moz-url flavor of data transfer for places container with URLs inside it. r=enndeakin 2018-03-25 17:23:48 +09:00
Brendan Dahl
3930802738 Bug 1443971 - Remove allDownloadsViewOverlay.xul. r=Paolo
This overlay was used in two places: places.xul and
contentAreaDownloadsView.xul. Move the commandset, menuppop and
downloadsRichListBox into include files. Inline the scripts and
DTDs.

MozReview-Commit-ID: LroiQlRTE2T
2018-03-19 16:21:50 -07:00
Marco Bonardo
59a5035ca3 Bug 1448362 - Remove some unused code from Places. r=standard8
MozReview-Commit-ID: DQCoYyZIvGD
2018-03-23 16:26:56 +01:00
Mark Banner
af5b04521b Bug 1448212 - Correctly disable browser_library_delete.js on ccov and also disable browser_library_new_bookmark.js due to failures. r=mak
MozReview-Commit-ID: ESIFN9BxDPo
2018-03-23 09:24:56 +00:00
Mark Banner
e36ae6ef4b Bug 1446630 - Disable browser_editBookmark_keywords.js on ccov due to intermittent failures. r=mak
MozReview-Commit-ID: 68KEnivP16F
2018-03-22 09:21:13 +00:00
Marco Bonardo
fc61b0aea0 Bug 1446951 - 8 - Reduce the number of query node constructors to one. r=standard8
MozReview-Commit-ID: ICDxftFlePN
2018-03-20 11:29:54 +01:00
Marco Bonardo
9378cf4109 Bug 1446951 - 4 - Make QueriesToQueryString and QueryStringToQueries singular. r=standard8
MozReview-Commit-ID: K8x2x0kARDn
2018-03-16 18:43:57 +01:00
Marco Bonardo
39cfa2a663 Bug 1446951 - 2 - Change nsINavHistoryQueryResultNode::GetQueries to a query attribute. r=standard8
MozReview-Commit-ID: 77xEeAE13xW
2018-03-16 16:20:22 +01:00
Marco Bonardo
6925512606 Bug 1446951 - 1 - Remove nsINavHistory::ExecuteQueries. r=standard8
MozReview-Commit-ID: ATQLGKzMtnn
2018-03-16 15:38:05 +01:00
Mark Banner
a8659a2b7c Bug 1425555 - Avoid a database fetch after showing the new bookmark dialog. r=mak
MozReview-Commit-ID: 1pjynkFFSOd
2018-03-20 23:52:58 +00:00
Brendan Dahl
d78cd08299 Bug 1442829: Remove macBrowserOverlay.xul. r=Gijs
Move all of the overlay pieces into an include file except for the
DTD's that could not be put there. Inline the DTD's into the files
where they were used. Update comments in macWindow.inc.xul and browser.xul
to more accurately reflect the current state.

MozReview-Commit-ID: HZIeSf29Yl
2018-03-19 08:57:12 -07:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Brendan Dahl
95e9cd9668 Bug 1443901 - Remove downloadsViewOverlay.xul. r=Paolo
This overlay was only used in places.xul and can be inlined there.

MozReview-Commit-ID: AYvmu99lqh5
2018-03-07 11:59:51 -08:00
Mark Banner
8c97713db8 Bug 1437516 - Rename browser_library_batch_delete.js now that it isn't testing batches. r=mak
MozReview-Commit-ID: 9L5e71yZaaL
2018-03-13 21:39:47 +00:00
Mark Banner
f190c32a0e Bug 1437516 - Remove nsINavHistoryService/nsINavBookmarksService::runInBatchMode. r=mak
MozReview-Commit-ID: D1H3xdjpMAx
2018-03-13 16:19:33 +00:00
Brendan Dahl
2021b6eed4 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN
2018-03-16 09:26:49 -07:00
Coroiu Cristina
d6640f68b6 Merge mozilla-central to autoland a=merge on a CLOSED TREE 2018-03-16 01:43:13 +02:00
Noemi Erli
0d60573524 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-03-15 19:43:12 +02:00
Brendan Dahl
8a8bb26748 Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn
2018-03-12 10:43:35 -07:00
Marco Bonardo
56b7e7f43e Bug 1445905 - Remove some no more useful code from nsBrowserGlue. r=dao
MozReview-Commit-ID: GhWS7ROvkc4
2018-03-14 11:03:46 +01:00
Mark Banner
346b271473 Bug 1445652 - Re-enable some places tests for code coverage. r=marco,RyanVM
MozReview-Commit-ID: IgHeK9kwXxC
2018-03-12 16:22:31 +00:00
Kit Cambridge
1e89ded632 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90
2018-03-01 13:37:13 -08:00
Mark Banner
8bda7e6d85 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Dorel Luca
37af71af05 Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
2018-03-14 18:23:46 +02:00
Mark Banner
60c4119b69 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Paul Silaghi
cf9a1541fb Bug 1444912 - Add automated test to check that bookmarks can be opened from the Library r=standard8 2018-03-12 17:04:13 +02:00
Paul Silaghi
daf26cfa3e Bug 1444226 - skip win10-ccov in browser.ini for bug 1440703 r=standard8 2018-03-13 16:10:15 +02:00
Mike Conley
82b8a07b09 Bug 1358719 - Get rid of synchronous layout flush in browserPlacesViews.js. r=mak
This uses promiseDocumentFlushed to make it easier to query for
layout information for the overflowing bookmark toolbar without
causing sync layout flushes. All DOM operations on the toolbar
have been moved to run within a requestAnimationFrame in order
to reduce the likelihood that other JavaScript that's about to
run will cause style or layout flushes.

MozReview-Commit-ID: 1GrARVc4RMJ
2018-02-27 19:09:27 -05:00
Margareta Eliza Balazs
71e26c30ef Merge inbound to mozilla-central. a=merge 2018-03-13 01:10:10 +02:00
Mark Banner
db677b4cc5 Bug 1444599 - Fix opening bookmark folders from the sidebar by middle/ctrl/cmd clicking. r=mak
MozReview-Commit-ID: 4B611oRaCOH
2018-03-12 12:33:32 +00:00
manikishan
02874947cf Bug 1431050 - Replace NS_ASSERT with conditional exceptions/console.assert and remove the debug.js module. r=mak
console.assert keeps the same semantics as NS_ASSERT in that it doesn't throw an exception,
but a lot of the places code was using it in a way that would be better served by throwing
an exception when the condition is false.

MozReview-Commit-ID: DEF5HSfYO36
2018-02-03 11:32:25 +05:30
Paolo Amadini
6d49378793 Bug 1443189 - Places subviews are not updated while they are open. r=Gijs
MozReview-Commit-ID: 5WHDqKsHjDJ
2018-03-07 22:01:58 +00:00
Paul Silaghi
cb38fd19da Bug 1440703 - Add automated test to check that the Bookmarks Toolbar and Sidebar can be enabled from the Bookmarks Menu. r=Standard8 2018-03-07 10:47:43 +02:00
Marco Bonardo
b95c6ee9ad Bug 1440644 - Fix a typo preventing the bookmark dialog storing a keyword. r=standard8
MozReview-Commit-ID: KULAKtzipxY
2018-03-06 11:39:30 +01:00
Marco Bonardo
52c5458d95 Bug 1442945 - Fix DND in Places menus. r=standard8
MozReview-Commit-ID: 1fFYgsWOJMV
2018-03-04 12:22:57 +01:00
Brendan Dahl
6021e79769 Bug 1441378 - Replace baseMenuOverlay.xul with inlining and preprocessing. r=Gijs
The overlay defined two elements (helpMenu, menu_ToolsPopup) for all
platforms and three others (windowMenu, baseMenuCommandSet, baseMenuKeyset)
that were MacOS only. The two all platform elements and windowMenu were only
used once and inlined into browser-menubar.inc. The rest of the MacOS only
elements were conditionally inlined into browser-sets.inc.

MozReview-Commit-ID: D2uyCrnepuH
2018-02-26 16:49:34 -08:00
Mark Banner
906afa7a46 Bug 1442597 - Can't drag/copy the Mobile bookmarks folder shortcut. r=mak
MozReview-Commit-ID: OqKDMEqxeA
2018-03-02 15:42:25 +00:00
Michael Kaply
97e2f5fdd4 Bug 1432355 - Add a policy to disable private browsing. r=Gijs
MozReview-Commit-ID: AprbL6usEv5
2018-03-01 10:20:38 -06:00
Tiberius Oros
744d81c0ac Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-03-01 19:34:54 +02:00
Tiberius Oros
0e49912cc8 Merge inbound to mozilla-central. a=merge 2018-03-01 19:29:00 +02:00
Marco Bonardo
c3e32f13de Bug 1439315 - eslint followup. r=mak 2018-03-01 17:01:21 +01:00
Marco Bonardo
b303f85036 Bug 1439315 - 8 - Remove some dangling NetUtil usage. r=standard8
MozReview-Commit-ID: A8WcjKkFhVA
2018-02-28 15:20:05 +01:00
Marco Bonardo
648dc600d4 Bug 1439315 - 7 - Don't import PlacesUtils on PlacesUIUtils import. r=standard8
MozReview-Commit-ID: 9xSkXWkSMBU
2018-02-28 15:10:45 +01:00