Commit Graph

1433 Commits

Author SHA1 Message Date
Peter Van der Beken
5fb60d9c57 Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz. 2017-11-23 16:27:27 +01:00
Shane Caraveo
d86aa77f96 Bug 1324255 make webextension panels focused when opened, r=Gijs,rpl 2018-02-15 09:52:54 -07:00
Jan Odvarko
66dc3cbede Bug 1311171 - Implement the devtools.network.onRequestFinished API event; r=jdescottes,rpl
MozReview-Commit-ID: IymuzcUg0VN
2018-02-14 11:32:10 +01:00
Shane Caraveo
25ea7fe605 Bug 1436720 use sessionstore to track controlling extension, r=Gijs
MozReview-Commit-ID: ACzGfNDVFXm
2018-02-13 15:43:31 -07:00
Mark Striemer
de4cbaa8f3 Bug 1429590 - Only allow one homepage to be set by extensions r=aswan
MozReview-Commit-ID: 8DTj8ceWAr8
2018-01-31 20:21:32 -06:00
Tom Ritter
5918a1f53d Bug 1435296 Address xpcshell test failures from increasing timer precision r=baku
See the comment on "Address test failures caused by bumping timer precision to 2 ms"
for more details.

MozReview-Commit-ID: LrsucEPdZIo
2018-02-12 11:41:38 -06:00
Tom Ritter
b414702f22 Bug 1435296 Address test failures caused by bumping timer precision to 2 ms r=baku
There are a few different reasons why tests needed updating (not an exhaustive list):

- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.

In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648

An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)

In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.

MozReview-Commit-ID: J59c7xQtZZJ
2018-02-12 11:39:41 -06:00
Cristian Brindusan :cristian_brindusan
94708142bf Bug 1434590 - disable browser/components/extensions/test/browser/browser_ext_tabs_lastAccessed.js for frequent failures r=gbrown 2018-02-11 12:44:44 -07:00
Mark Striemer
72a365d7a0 Bug 1421811 - Part 3: Update shortcut in sidebar on update r=Gijs,mixedpuppy
MozReview-Commit-ID: 4y02mCqwacg
2018-02-06 12:55:40 -06:00
Mark Striemer
e17882a01b Bug 1421811 - Part 2: Support commands.reset() to reset a command's updates r=mixedpuppy
MozReview-Commit-ID: 4hWGo1ZH6tn
2018-01-31 15:49:20 -06:00
Mark Striemer
569fc39619 Bug 1421811 - Part 1: Support commands.update() to modify a command r=mixedpuppy
MozReview-Commit-ID: 5A6ZmvNT294
2018-01-31 15:48:32 -06:00
Luca Greco
69bdca380e Bug 1403130 - Allow DOMNodes and cyclic objects to be rendered with the sidebar.setExpression API method. r=aswan
MozReview-Commit-ID: AjHn7KfVhas
2017-10-12 15:55:47 +02:00
Andrew McCreight
1d9e026e96 Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files. r=florian
MozReview-Commit-ID: IKKb9zr2OSf
2018-02-06 15:03:13 -08:00
Nathan Watson
5d40195377 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc
2018-01-31 22:03:05 -08:00
Drew Willcoxon
e1ca839f9c Bug 1435992 - Disabled page actions still show extension context menu items. r=mixedpuppy
MozReview-Commit-ID: JmC6PXtW1SK
2018-02-06 11:15:50 -08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Johann Hofmann
0013a2e800 Bug 1167238 - Part 3 - Clean up usage of sanitize.js to properly use Sanitizer.jsm. r=mak
This replaces all non-test usage of sanitize.js or legacy Sanitizer.jsm
to use the new Sanitizer.jsm module which does not hold internal state
and instead receives all configuration through function arguments (or by reading prefs).

MozReview-Commit-ID: KitMVptuIG3
2018-01-18 16:02:04 +01:00
Mark Striemer
640c45418e Bug 1344815 - Show sidebar shortcut in menus r=mixedpuppy
MozReview-Commit-ID: C6q0FBtCmRK
2018-01-31 19:41:32 -06:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Luca Greco
6e0b50bc26 Bug 1420485 - Fix 'message manager count' failure when browser_ext_tabs_insertCSS.js is executed first. r=mixedpuppy
MozReview-Commit-ID: HEWS8Lxldbi
2018-01-29 17:24:57 +01:00
Luca Greco
3a58b725a6 Bug 1420485 - Fix browser.test.notifyFailure is not defined in tabs.insertCSS/removeCSS tests. r=mixedpuppy
This patch fix a type in the tests related to tabs.insertCSS/removeCSS,
the test function is actually named browser.test.notifyFail.

MozReview-Commit-ID: 8DpOFBpm795
2017-11-27 15:37:45 +01:00
Luca Greco
5da4428014 Bug 1420485 - Fix an exception raised by browser_ext_tabs_insertCSS.js on injecting the same cached preloaded stylesheet twice. r=mixedpuppy
MozReview-Commit-ID: Jq2JdXwt7zC
2017-11-24 19:19:27 +01:00
Luca Greco
744c5d42ee Bug 1420485 - Added new tabs.insertCSS test case to ensure that the injected CSS are cleaned up. r=mixedpuppy
MozReview-Commit-ID: EPTTA2MnZ6O
2017-11-27 15:38:45 +01:00
Shane Caraveo
37e445644c Bug 1408194 prevent using find api on about urls 2018-01-30 16:55:54 -07:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
d59dbba7eb Bug 1345081 - update use of spellchecker 'editable' flags, r=zombie
MozReview-Commit-ID: Hxgc0UuIOPj
2018-01-12 18:51:41 +00:00
Andreea Pavel
27898fe230 Backed out changeset 5421387a997d (bug 1345081)for failing browser chrome browser/components/extensions/test/browser/browser_ext_menus_events.js on a CLOSED TREE 2018-01-26 17:23:27 +02:00
Gijs Kruitbosch
8f3cf68607 Bug 1345081 - update use of spellchecker 'editable' flags, r=zombie
MozReview-Commit-ID: Hxgc0UuIOPj
2018-01-12 18:51:41 +00:00
Rob Wu
d07a37a836 Bug 1215376 - fix linting and test issues from rebase r=mixedpuppy
- Work-around in browser_ext_menus_events.js for bug 1428213
- Fix indentation issues (eslint)
- Hide the "pageUrl" property for bookmark menu events
  (fixes test failure in test_bookmark_contextmenu).

MozReview-Commit-ID: 4YHJci0J7Rh
2018-01-05 01:13:04 +01:00
Rob Wu
71f6c75403 Bug 1215376 - Test menu event order: onShown, onClicked, onHidden r=mixedpuppy
This test ensures that the menu events will always be fired in the
natural event order.

Two menus are tested:
- A context menu in the page.
- The tools menu.

MozReview-Commit-ID: 4sLyvgMYMtE
2017-09-26 19:25:22 +02:00
Rob Wu
7411473343 Bug 1215376 - Fire menus.onShown for every menu r=mixedpuppy
This commit lifts the restriction that onShown is only fired for
extensions with a visible menu item.

MozReview-Commit-ID: Ao4MgBoRWLR
2017-09-14 18:28:36 +02:00
Rob Wu
979499e4bc Bug 1215376 - refactor: re-use onShown event generator for onClicked r=mixedpuppy
The logic in onClicked had some flaws:
- editable can be undefined instead of a boolean.
- linkText, linkUrl is set in non-link contexts.
- srcUrl is set even in non-media contexts.

This change does not add new tests, because test coverage for the
event data generator is provided by:
browser/components/extensions/test/browser/browser_ext_menus_events.js

There is one observable change here.
Previously, linkUrl and linkText would also be set for non-link context
if the selected text contained a URL. When this happens, then
nsContextMenu.js sets onPlainTextLink=true.
With this refactor, linkText and linkUrl are only set if the context is
"link" (onLink=true).

MozReview-Commit-ID: 2xf1F41bn0U
2017-09-14 16:41:14 +02:00
Rob Wu
e5749a5a53 Bug 1215376 - Add more contextual information to onShown r=mixedpuppy
- Adds most of the OnClickData properties to the onShown event parameter
  (except for menu-specific properties such as parentMenuId / checked).
- Add tests to verify the values of these properties.

MozReview-Commit-ID: 7705sJyAOIJ
2017-09-14 16:37:57 +02:00
Rob Wu
fa82f4d484 Bug 1215376 - Always use old contextData upon refresh r=mixedpuppy
MozReview-Commit-ID: K1wfFCYpMqB
2017-09-14 02:11:29 +02:00
Rob Wu
81c67108a1 Bug 1215376 - Add menus.refresh to update menus r=mixedpuppy
Together with the previous patches that introduced menus.onShown,
this enabled extensions to update/remove menu items after a menu
has been shown.

At this point, it is not yet possible to add a menu item if an
extension has not shown a menu item before; this can be added later.

MozReview-Commit-ID: E0JrE9gd4gS
2017-09-13 03:14:00 +02:00
Rob Wu
9dbb913876 Bug 1215376 - Refactor gMenuBuilder.build r=mixedpuppy
Splot gMenuBuilder.build in three separate functions because the
individual functionality is needed later.

This is just moving some code around, nothing interesting to see.

MozReview-Commit-ID: Lo6QmLQBtO5
2017-09-12 02:34:41 +02:00
Rob Wu
b73320a628 Bug 1215376 - Ensure that menu elements have a unique ID r=mixedpuppy
Previously, there was no guarantee for the uniqueness of the ID.
Now the ID is unique, and always set.

See https://bugzil.la/1358213#c6 and #c7 for examples of collisions.

MozReview-Commit-ID: 7CHP6tWFDUg
2017-09-11 01:01:41 +02:00
Rob Wu
1100f72997 Bug 1215376 - Add onShown and onHidden to contextMenus/menus API r=mixedpuppy
This commit adds the bare minimum to support the onShown and onHidden
methods in the contextMenus and menus API (plus tests).

The onShown event data may be extended in a separate commit, to make it
easier to see how the additional properties are reflected in the tests.

MozReview-Commit-ID: 20VJS2YLhTN
2017-09-10 01:38:45 +02:00
Rob Wu
957197a2c4 Bug 1215376 - allow itemToSelect to be null in menu closing test utility r=mixedpuppy
Most close*Menu methods in browser tests allow itemToSelect to be null.
Some did not.
Now they do (after this commit)

MozReview-Commit-ID: 2jSGAi2R3ZD
2017-09-09 19:41:56 +02:00
dw-dev
a8fc24ed04 Bug 1415507 - changes to tabs.saveAsPDF(); r=mixedpuppy
There are three changes:

1. Adds a print progress listener to tabs.saveAsPDF() in ext-tabs.js so that the
  'saved' or 'replaced' status is not returned until the PDF file has been saved.

2. Adds four more "edge" properties to the  pageSettings object to allow positioning
   of the page headers and footers.

3. Adds automated tests for tabs.saveAsPDF() in browser_ext_tabs_saveAsPDF.js that
   cover all returned statuses: saved, replaced, canceled, not_saved, not_replaced.

MozReview-Commit-ID: iljvT8wp11
2018-01-19 14:13:33 +00:00
Jan Odvarko
0461788e8d Bug 1311177 - Implement the devtools.network.getHAR API method; r=jdescottes,rickychien,rpl
MozReview-Commit-ID: gUtGjbr0FQ
2018-01-22 18:30:46 +01:00
Tooru Fujisawa
3ad961e114 Bug 1431961 - Wait for the extension startup code before starting tests in browser/components/extensions/test/browser/browser_ext_user_events.js r=kmag 2018-01-21 14:29:42 +09:00
Oriol Brufau
4791668dc2 Bug 1424538 - Allow pageAction and sidebarAction set* methods to accept a null value (desktop). r=mixedpuppy
MozReview-Commit-ID: FqcRrFDYqWp
2017-12-18 20:41:10 +01:00
Margareta Eliza Balazs
b3373e3395 Backed out changeset 32daec7fd5b6 (bug 1311177) for bc5 failures in browser/components/extensions/test/browser/test-oop-extensions/browser_ext_devtools_network.js on a CLOSED TREE 2018-01-19 11:54:43 +02:00
Noemi Erli
c2251ea4d5 Backed out changeset 9687e3d987be (bug 1415507) for bc failures in browser/components/extensions/test/browser/browser_ext_tabs_saveAsPDF.js on a CLOSED TREE 2018-01-19 10:22:14 +02:00
Jan Odvarko
36b111ba95 Bug 1311177 - Implement the devtools.network.getHAR API method; r=jdescottes,rickychien,rpl
MozReview-Commit-ID: I9F4tGSwBrt
2018-01-17 13:32:42 +01:00