Commit Graph

292 Commits

Author SHA1 Message Date
Drew Willcoxon
c74d0af0ad Bug 1449947 - The "Add Search Engine" page action button doesn't respond to clicks when it's in the urlbar. r=Gijs
MozReview-Commit-ID: 5H9XfRXq8eO
2018-03-30 09:34:47 -07:00
Drew Willcoxon
bd8f7faa4e Bug 1221539 - Add search engine discovery to the page action menu. Part 2: Add the new action. r=Gijs
MozReview-Commit-ID: DEEZBwmV0JD
2018-03-28 11:28:20 -07:00
Drew Willcoxon
0a460e67a4 Bug 1221539 - Add search engine discovery to the page action menu. Part 1: Page action changes. r=Gijs
MozReview-Commit-ID: DGy3sBibpRW
2018-03-28 11:28:13 -07:00
Kit Cambridge
e195fe535f Bug 1448929 - Fix first sync check in gSync.syncConfiguredAndLoading. r=eoger
MozReview-Commit-ID: 8Xk6DMHroTm
2018-03-26 09:35:29 -07:00
Edouard Oger
8578b6545b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh
2018-03-20 17:08:16 -04:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Tooru Fujisawa
baa9db1950 Bug 1442465 - Part 2: Use BrowserTestUtils.{waitForTabClosing,waitForSessionStoreUpdate} instead of BrowserTestUtils.tabRemoved. r=dao 2018-03-19 11:12:13 +09:00
Kris Maglione
9d5b9190a5 Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc
2018-03-07 19:31:28 -08:00
Kris Maglione
c52d401bb4 Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley
MozReview-Commit-ID: 4ojwvjw9XGT
2018-03-14 14:35:05 -07:00
Andreea Pavel
cce81a7740 Merge mozilla-inbound to mozilla-central. a=merge on a CLOSED TREE 2018-03-09 21:33:50 +02:00
Kris Maglione
50e184c485 Bug 1315887: Temporarilly disable browser_ext_locationBarExternalLoad for surge in intermittents. r=me
MozReview-Commit-ID: 9Vb5nQ9lwpq
2018-03-09 08:21:36 -08:00
Dão Gottwald
acbba514e2 Bug 1443404 - Fix browser_urlbarFocusedCmdK.js intermittent failure. r=Gijs
MozReview-Commit-ID: AA31YY6nUPc
2018-03-09 11:24:06 +01:00
Kris Maglione
96ee075269 Bug 1443964: Follow-up: Attempt 3 to fix intermittent timing issues, this time with rr chaos mode.
MozReview-Commit-ID: 8BJq7VT8PPJ
2018-03-08 20:37:10 -08:00
Kris Maglione
80e4b2599b Bug 1443964: Follow-up: Another attempt at fixing intermittent timing issue after removal of sync messaging from shims. r=bustage
MozReview-Commit-ID: 2WUsb7DIqk7
2018-03-08 19:01:48 -08:00
Kris Maglione
f27c007eda Bug 1443983: Follow-up: Add preferredRemoteType to addTab call to fix another unexpected intermittent. r=bustage
MozReview-Commit-ID: Fh5p3pC2Ofq
2018-03-08 17:34:11 -08:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Gijs Kruitbosch
c1dcbfb787 Bug 1439396, r=mak 2018-02-21 12:18:40 +00:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Marco Bonardo
14b23bd662 Bug 1433938 - Move Synced Tab matches above general history matches in the Address Bar. r=adw
Puts Remote (Synced) Tab matches before other history results.
Changes deduping algorithm to replace simple history matches with tab matches when the url is the same.
Keeps overriding a Remote Tab with a Local Tab when the url is the same.

MozReview-Commit-ID: 76urDklKtRF
2018-02-13 14:34:44 +01:00
Drew Willcoxon
4ace839400 Bug 1438329 - Problem(s) with delayed key handling in urlbar. r=mak
MozReview-Commit-ID: CwvnsLJGgG6
2018-02-16 11:13:21 -08:00
Masayuki Nakano
53a40055b6 Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK
2018-02-09 19:17:26 +09:00
Tom Ritter
b414702f22 Bug 1435296 Address test failures caused by bumping timer precision to 2 ms r=baku
There are a few different reasons why tests needed updating (not an exhaustive list):

- Tests assume that successive operations take place at different times.
- Tests assume that an operation took a minimum amount of time.
- Tests hardcodes a specific delay.

In most cases we hardcode the preference off. In some cases this is the best approach,
in others, we would like to improve. The bug for tracking those improvements is Bug 1429648

An improvement that is present in some tests is to hardcode a specific precision reduction
that is acceptable based on the confides of the test. (Obviously this needs to be a fix for
the test framework and not a requirement on the feature being tested.)

In a few places, the test itself can be fixed, for example to no longer require the end
time of an operation to be strictly greater than the start time, and allows it to be equal
to it.

MozReview-Commit-ID: J59c7xQtZZJ
2018-02-12 11:39:41 -06:00
Paolo Amadini
ed0806abfd Bug 1434883 - Part 1 - Fix tests for the activated page action panel. r=Gijs
The promisePanelEvent function was unreliable because it did not raise an error if the provided panel did not exist, which caused one of the callers to ignore a missing panel silently. All the callers have now been updated based on whether they expect the panel to exist or not.

MozReview-Commit-ID: AGT4rHls4OB
2018-02-04 16:32:20 +00:00
Andrew McCreight
1d9e026e96 Bug 1436184 - Remove definitions of Ci, Cr, Cc, and Cu from httpd.js and .sjs files. r=florian
MozReview-Commit-ID: IKKb9zr2OSf
2018-02-06 15:03:13 -08:00
Nathan Watson
5d40195377 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc
2018-01-31 22:03:05 -08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Cosmin Sabou
27ede269b6 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
2018-02-06 16:30:56 +02:00
Paolo Amadini
d6f647dbbf Bug 1427350 - Part 2 - Rename _matchCount to matchCount. r=mak
MozReview-Commit-ID: 2oo0Nxp3Qot
2018-02-04 15:00:58 +00:00
Paolo Amadini
e798559ae2 Bug 1434883 - Part 1 - Fix tests for the activated page action panel. r=Gijs
The promisePanelEvent function was unreliable because it did not raise an error if the provided panel did not exist, which caused one of the callers to ignore a missing panel silently. All the callers have now been updated based on whether they expect the panel to exist or not.

MozReview-Commit-ID: AGT4rHls4OB
2018-02-04 16:32:20 +00:00
Yuri Khan
9d5fd8c815 Bug 1394304: Part 2 - Add tests for _whereToOpen. r=adw 2018-02-04 18:42:54 +07:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Mark Banner
141e18e4e7 Bug 1434449 - Removed some unused code in jsm files in browser/base and browser/modules. r=florian
MozReview-Commit-ID: 9VhKxnpdzCD
2018-01-30 22:09:02 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Paolo Amadini
f8ef353e81 Bug 1432015 - Part 1 - Fix anchor handling for the action feedback panel. r=Gijs
Commands started from an activated action panel should not be anchored to the main button, and regression tests should simulate the case where both the main action panel and the individual action button are visible and the action is invoked from the main action panel.

MozReview-Commit-ID: Eg1wP2rRe2d
2018-01-21 17:01:59 +00:00
Kris Maglione
1046270983 Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE
MozReview-Commit-ID: 5ubE9EMQpZ9
2018-01-24 22:04:59 -08:00
Kris Maglione
50ace7f99d Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
MozReview-Commit-ID: 8V1ZT53ReiP
2018-01-24 15:48:47 -08:00
Marco Bonardo
3c4c8ae83c Bug 1416305 - Copying a search suggestion from the address bar gives back an http url. r=adw
MozReview-Commit-ID: DBfZvVOxmzE
2018-01-16 12:23:09 +01:00
Marco Bonardo
afcf9c1e9e Bug 1416041 - Collapse one-offs buttons if only the current engine is active and don't select search settings when collapsed. r=florian
MozReview-Commit-ID: 9aOM19NPRzt
2018-01-11 18:11:34 +01:00
Gijs Kruitbosch
9e84a956ff Bug 1422643 - deal with tabs in the protocol in js paste detection code, r=florian,valentin
MozReview-Commit-ID: Ax5LGkIedkY
2017-12-20 18:57:48 +00:00
Andreea Pavel
75e4899e8a Backed out 1 changesets (bug 1422643) for failing browser/base/content/test/urlbar/browser_removeUnsafeProtocolsFromURLBarPaste.js r=backout on a CLOSED TREE
Backed out changeset 6ad5ec88a898 (bug 1422643)
2018-01-05 02:13:10 +02:00
Gijs Kruitbosch
87ee1fc631 Bug 1422643 - deal with tabs in the protocol in js paste detection code, r=florian,valentin
MozReview-Commit-ID: Ax5LGkIedkY
2017-12-20 18:57:48 +00:00
Florian Quèze
3f662053f3 Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Neil Deakin
c6f8af3264 Bug 1419925, implement a promise-oriented version of waitForClipboard, promiseClipboardChange, change a selection of tests to use this instead. Simplify some other clipboard tests that were unreliable before the fix for 1394757. r=jmaher 2017-12-07 08:39:50 -05:00
Andreea Pavel
26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00