corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
874,488 Commits 1 Branch 0 Tags
32c95bd4584a521d26f1d0b51c022c9c40d66d7b
Commit Graph

145 Commits

Author SHA1 Message Date
Ryan Safaeian
ccd363c347 Bug 1900009 - Dispatch DOMPossibleUsernameInputAdded event for valid text and email inputs. r=dimi,edgar 
Differential Revision: https://phabricator.services.mozilla.com/D214821
 2024-07-12 17:38:48 +00:00
Tom Schuster
c223046d21 Bug 1835157 - Ignore target names which contain both newline and < characters. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D210480
 2024-05-24 08:09:36 +00:00
Vincent Hilla
b77cb74b4c Bug 1876792 - Report invisible input fields only when invalid. r=jjaschke,dom-core,edgar 
Differential Revision: https://phabricator.services.mozilla.com/D199962
 2024-03-05 11:51:09 +00:00
Emilio Cobos Álvarez
7506fc5879 Bug 1881011 - Refactor UnbindFromTree to take a context argument. r=smaug 
Much like BindToTree.

This will be useful because I need to pass more information through
UnbindFromTree() to speed up dir=auto for bug 1874040.

Differential Revision: https://phabricator.services.mozilla.com/D202215
 2024-02-20 15:05:40 +00:00
Emilio Cobos Álvarez
1df8c0453d Bug 1879579 - Clean up CompareTreePosition and related code. r=smaug 
Make TreeOrderedArray support what the form controls stuff needs, and
use it instead of custom nsContentUtils stuff.

Differential Revision: https://phabricator.services.mozilla.com/D201261
 2024-02-12 20:01:36 +00:00
Noemi Erli
1637a997a2 Backed out changeset 1acc95286189 (bug 1879579) for causing mass failures CLOSED TREE 2024-02-12 17:25:21 +02:00
Emilio Cobos Álvarez
97dc4d46da Bug 1879579 - Clean up CompareTreePosition and related code. r=smaug 
Make TreeOrderedArray support what the form controls stuff needs, and
use it instead of custom nsContentUtils stuff.

Differential Revision: https://phabricator.services.mozilla.com/D201261
 2024-02-12 00:01:23 +00:00
Emilio Cobos Álvarez
a0f699ef4d Bug 1878900 - Simplify AnchorAreaFormRelValues. r=dom-core,edgar 
Having a base class with a single static member doesn't buy us much, and
actually MSVC-compatible compilers don't optimize empty base classes out
(plus the empty base is at the end so it might even take space on Linux
and macOS, untested).

Just put the values in Element.h / Element.cpp which is the common base
class of the relevant elements.

Differential Revision: https://phabricator.services.mozilla.com/D200825
 2024-02-06 16:47:38 +00:00
Emilio Cobos Álvarez
b9aedffc24 Bug 1850295 - Update :user-{valid,invalid} to follow the spec. r=smaug 
(Modulo open spec issues linked in comments)

Differential Revision: https://phabricator.services.mozilla.com/D196986
 2024-01-16 11:09:01 +00:00
jneuberger
5e86299d08 Bug 1863801 - P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D193308
 2023-12-06 14:55:01 +00:00
Issam Mani
03b2ed51e3 Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D194768
 2023-12-04 11:39:19 +00:00
Noemi Erli
5cc944ee91 Backed out 7 changesets (bug 1863801, bug 1865876) for causing failures in browser_creditCard_doorhanger_iframe.js CLOSED TREE 
Backed out changeset 395e2da83ee8 (bug 1865876)
Backed out changeset c27de56bd433 (bug 1863801)
Backed out changeset 8d297207efc7 (bug 1863801)
Backed out changeset 193d5c08a17f (bug 1863801)
Backed out changeset dd78261ec1d8 (bug 1863801)
Backed out changeset 5f6ad20da89e (bug 1863801)
Backed out changeset 31e08bae4ce6 (bug 1863801)
 2023-12-01 22:16:15 +02:00
jneuberger
22a0fc66c2 Bug 1863801 - P2. Add DOMFormRemoved event listener after successful fetch or XHR request r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D193308
 2023-12-01 19:12:54 +00:00
Vincent Hilla
5fa2e02f27 Bug 1648733 - Report invalid and hidden form controls to console. r=dom-core,jjaschke 
Differential Revision: https://phabricator.services.mozilla.com/D189459
 2023-10-30 11:48:49 +00:00
Adam Vandolder
a1cf2d6b5d Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-28 15:47:11 +00:00
Natalia Csoregi
51f7d1bb14 Backed out changeset 8f8492410799 (bug 1685926) for causing bustage on SVGAnimatedPathSegList.cpp. CLOSED TREE 2023-09-28 10:40:31 +03:00
Adam Vandolder
aee8834b7a Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-28 06:35:44 +00:00
Cristian Tuns
f84b646496 Backed out changeset 37ade77d181e (bug 1685926) for causing build bustages in PerformanceEventTiming.cpp CLOSED TREE 2023-09-25 12:40:22 -04:00
Adam Vandolder
305c6a88bf Bug 1685926 - Group disconnected radio buttons together. r=saschanaz,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D162349
 2023-09-25 14:39:08 +00:00
Vincent Hilla
53f2c918c1 Bug 1066940 - Align return type of HTMLFormElement::elements with spec. r=dom-core,webidl,peterv 
Differential Revision: https://phabricator.services.mozilla.com/D188246
 2023-09-14 16:37:14 +00:00
Emilio Cobos Álvarez
72f00fc947 Bug 1850293 - Make validity states non-intrinsic. r=smaug 
Add a RAII helper to notify of multiple state changes together for
these.

The UpdateState CustomElementInternals calls that are getting removed
are unnecessary (the state should be up-to-date by then, there's nothing
changing there particularly).

Same for the call in nsGenericHTMLFormElement::UnbindFromTree. ClearForm
already does an state update.

Differential Revision: https://phabricator.services.mozilla.com/D187033
 2023-08-30 09:18:32 +00:00
Emilio Cobos Álvarez
76e9b5e83c Bug 1850293 - Make CHECKED/DEFAULT states not intrinsic. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D186933
 2023-08-30 09:18:31 +00:00
avandolder
8898fd2eec Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-03 01:52:19 +00:00
Narcis Beleuzu
ed85f561c2 Backed out changeset 013278adabc7 (bug 1837540) for build bustages on mochitest.ini . CLOSED TREE 2023-08-03 02:25:53 +03:00
avandolder
9d805ab56a Bug 1837540 - Make radio button group navigation follow tree-order. r=sefeng,smaug 
Differential Revision: https://phabricator.services.mozilla.com/D183426
 2023-08-02 23:04:07 +00:00
Emilio Cobos Álvarez
c1c1e7460b Bug 1829225 - Make BeforeSetAttr take the parsed nsAttrValue. r=smaug 
ParseAttribute ideally would be const (see bug 1829138), but the SVG and
SMIL code is rather messy. Still, now that BeforeSetAttr can't really
fail, swapping the order of ParseAttribute and BeforeSetAttr shouldn't
really change behavior.

Sorry for the extra `virtual` keyword removal and such. I had to do this
one by hand unlike the dependent bugs, and I went a bit drive-by, lmk if
you want me to split those changes.

Differential Revision: https://phabricator.services.mozilla.com/D176086
 2023-04-21 09:25:17 +00:00
Emilio Cobos Álvarez
c881eb2941 Bug 1829189 - Make BeforeSetAttr infallible. r=smaug 
rg BeforeSetAttr -l | xargs sed -i 's/nsresult BeforeSetAttr/void BeforeSetAttr/g'
  rg ::BeforeSetAttr -l | xargs sed -i 's/nsresult \(.*\)::BeforeSetAttr/void \1::BeforeSetAttr/g'

Plus trivial fixes, plus clang-format.

The only meaningful changes are in nsXULElement::BeforeSetAttr. Two
things could fail:

chromemargin: I removed it because we don't use the parsed attribute any
other place than here:

  https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/dom/xul/ChromeObserver.cpp#136

And that deals just fine with it not being parsed.

usercontextid: We have a debug assertion that we don't dynamically change it.
I kept it but I don't think it's worth failing to set the attribute on release for that

Differential Revision: https://phabricator.services.mozilla.com/D176069
 2023-04-21 08:56:27 +00:00
Adam Vandolder
bf597b83c9 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-18 16:41:04 +00:00
Butkovits Atila
d84b895e9a Backed out changeset 704407d7ca31 (bug 1509346) for causing wpt failures at put-forwards.html. 2023-01-17 20:04:52 +02:00
Adam Vandolder
65a2df9059 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-17 16:11:06 +00:00
Sandor Molnar
d53ceaad55 Backed out changeset 5ad22146a015 (bug 1509346) for causing failures in docshell/base/nsDocShell.cpp 2023-01-17 03:16:20 +02:00
Adam Vandolder
4d4a650750 Bug 1509346 - Add support for <form rel>. r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D166489
 2023-01-16 21:32:19 +00:00
Emilio Cobos Álvarez
1c58e2a928 Bug 1773070 - Unify Gecko and Servo EventState/ElementState bits. r=smaug 
Add a dom/base/rust crate called just "dom" where we can share these.

Most of the changes are automatic:

  s/mozilla::EventStates/mozilla::dom::ElementState/
  s/EventStates/ElementState/
  s/NS_EVENT_STATE_/ElementState::/
  s/NS_DOCUMENT_STATE_/DocumentState::/

And so on. This requires a new cbindgen version to avoid ugly casts for
large shifts.

Differential Revision: https://phabricator.services.mozilla.com/D148537
 2022-06-07 23:09:52 +00:00
Kagami Sascha Rosylight
fc713c1725 Bug 1539884 - Part 11: Mark HTMLFormElement::Reset as CAN_RUN_SCRIPT r=masayuki 
Depends on D133921

Differential Revision: https://phabricator.services.mozilla.com/D133922
 2021-12-16 17:17:08 +00:00
Butkovits Atila
0f55d2ea96 Backed out 8 changesets (bug 1539884) for causing build bustages at Document.cpp. CLOSED TREE 
Backed out changeset ad65ce9208ce (bug 1539884)
Backed out changeset 15d728ef97ca (bug 1539884)
Backed out changeset de9e2829d42a (bug 1539884)
Backed out changeset a8cfa2201751 (bug 1539884)
Backed out changeset ca21c5838f37 (bug 1539884)
Backed out changeset 3d3019f61b5a (bug 1539884)
Backed out changeset ca7c808621d6 (bug 1539884)
Backed out changeset 57068a40f3c9 (bug 1539884)
 2021-12-16 08:12:15 +02:00
Kagami Sascha Rosylight
9aa7c5b6f1 Bug 1539884 - Part 11: Mark HTMLFormElement::Reset as CAN_RUN_SCRIPT r=masayuki 
Depends on D133921

Differential Revision: https://phabricator.services.mozilla.com/D133922
 2021-12-16 02:58:48 +00:00
Kagami Sascha Rosylight
95253f2665 Bug 1743439 - Part 5: Mark callers in dom/events and dom/html as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D133364
 2021-12-09 19:56:09 +00:00
Alexandru Michis
b3616631ef Backed out 6 changesets (bug 1743439) for causing bustages in AnimationEventDispatcher.h 
CLOSED TREE

Backed out changeset 792c405d4afc (bug 1743439)
Backed out changeset 0376e73c7dce (bug 1743439)
Backed out changeset 23202094bc00 (bug 1743439)
Backed out changeset ba0fa3a8fa0e (bug 1743439)
Backed out changeset 7ad2746ec876 (bug 1743439)
Backed out changeset a919ef50cf33 (bug 1743439)
 2021-12-09 19:36:12 +02:00
Kagami Sascha Rosylight
1da93efca6 Bug 1743439 - Part 5: Mark callers in dom/events and dom/html as MOZ_CAN_RUN_SCRIPT_BOUNDARY r=masayuki 
Differential Revision: https://phabricator.services.mozilla.com/D133364
 2021-12-09 17:16:50 +00:00
Emilio Cobos Álvarez
1d054196f6 Bug 1740230 - Remove some prefs for pseudo-classes that we have shipped/unshipped successfully. r=dholbert 
And remove code for :-moz-submit-invalid completely.

Differential Revision: https://phabricator.services.mozilla.com/D130737
 2021-11-10 13:27:47 +00:00
Edgar Chen
4929cc1a94 Bug 1556351 - Part 5: Make nsGenericHTMLFormControlElement implement nsIFormControl; r=smaug 
nsGenericHTMLFormElement doesn't implement nsIFormControl now as HTMLElement would
inherit it to be able to be added into HTMLFormElement and HTMLFieldSetElement and
support some common form feature.

So some places that call the nsIFormControl method on nsGenericHTMLFormElement
directly would need to queryInterface it to nsIFormControl first, this should be
fine as those places are not in a hot path.

Differential Revision: https://phabricator.services.mozilla.com/D124788
 2021-10-04 20:51:27 +00:00
Edgar Chen
71042191bf Bug 1729008 - Part 2: Make HTMLFormElement::IsLastActiveElement take nsGenericHTMLFormElement as argument; r=smaug 
Depends on D124459

Differential Revision: https://phabricator.services.mozilla.com/D124462
 2021-09-03 17:21:44 +00:00
Edgar Chen
2f052986f8 Bug 1729008 - Part 1: Make HTMLFormElement::IsDefaultSubmitElement take nsGenericHTMLFormElement as argument; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D124459
 2021-09-03 17:21:44 +00:00
Edgar Chen
82070f5956 Bug 1728081 - Part 4: Make HTMLFormElement::GetDefaultSubmitElement return nsGenericHTMLFormElement; r=smaug 
so that the callers don't need to queryInterface it back to nsIContent.

Differential Revision: https://phabricator.services.mozilla.com/D123952
 2021-08-30 18:44:51 +00:00
Edgar Chen
c791a38187 Bug 1728081 - Part 3: Merge nsIForm into HTMLFormElement; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D123951
 2021-08-30 18:44:51 +00:00
Edgar Chen
efa48fcbc4 Bug 1728081 - Part 2: Remove nsIForm::GetElementAt; r=smaug 
as it is only used internally.

Depends on D123949

Differential Revision: https://phabricator.services.mozilla.com/D123950
 2021-08-30 18:44:51 +00:00
Edgar Chen
6536c5442c Bug 1728081 - Part 1: Remove nsIForm::GetElementCount; r=smaug 
as it is only used internally.

Differential Revision: https://phabricator.services.mozilla.com/D123949
 2021-08-30 18:44:50 +00:00
Edgar Chen
2a45c41a27 Bug 1721349 - Move mSubmitter from HTMLFormSubmission to FormData and make it participate in cycle collection; r=mccr8 
Differential Revision: https://phabricator.services.mozilla.com/D120334
 2021-07-21 09:52:20 +00:00
Edgar Chen
48de72fff7 Bug 1720314 - Part 2: Remove HTMLFormElement::mWebProgress; r=smaug 
Depends on D119776

Differential Revision: https://phabricator.services.mozilla.com/D119777
 2021-07-13 16:32:51 +00:00
Edgar Chen
691e17dbb8 Bug 1720314 - Part 1: Remove HTMLFormElement::mSubmittingRequest; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D119776
 2021-07-13 16:32:51 +00:00