Commit Graph

1786 Commits

Author SHA1 Message Date
Ehsan Akhgari
d42f0f9e4e Bug 659828 - Part 1: Apply table margins to the outer table frame instead of the inner table frame (also fixes bug 87277); r=dbaron
Outer table frames act as CSS2.1 table wrapper boxes.  We used to lay them out
without taking their margins into the account, which meant that their width was
always equal to the available width.  This breaks horizontal positioning of
absolutely positioned kids of a table frame.

The main purpose of this patch is to apply the margins of tables to their outer
frame, instead of the inner frame.  This means that the inner table frame will
always have a zero margin, which means that a lot of the stuff which used to
rely on the fact that table margins are applied to the inner frame need to
change.

In particular, in order to get the computed margins of a table, we used to query
the inner table frame, and this patch corrects that.  Also, when shrink wrapping
tables, we used to not take the margins of the inner table frame into account,
which is fixed by this patch too.  nsBlockReflowState::
ComputeReplacedBlockOffsetsForFloats also needed to be changed to read the
margin values from the outer frame too.

Also, as part of this patch, we start to respect the CSS2.1 margin model for
captions on all sides.  This means that in particular, the top/bottom margins on
the top-outside and bottom-outside captions will not be collapsed with the
top/bottom margins of the table, and that the margins of the caption element
contribute to the width and height of the outer table frame.  The
427129-table-caption reftest has been modified to match this new behavior.

Another side effect of this bug is fixing bug 87277, and the reftests for that
bug are marked as passing in this patch.
2011-05-31 19:02:56 -04:00
Ehsan Akhgari
de3e3fd8ee Bug 10209 - Part 6: Implement the CSS "containing block" concept correctly as a binary relation, as opposed to a unary relation; r=bzbarsky 2011-05-12 00:04:30 -04:00
Ehsan Akhgari
5d50ff6078 Bug 10209 - Part 5: Allow table elements to act as absolute positioning containers; r=roc 2011-05-09 20:36:10 -04:00
Ehsan Akhgari
a9088e07c1 Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc 2011-04-29 19:02:33 -04:00
Michael Wu
0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Boris Zbarsky
80ab68db8d Bug 688405. Allow rowspans up to 65534, up from our current 8190. r=bernd 2011-09-26 00:52:33 -04:00
Mats Palmgren
18c7c202f3 Bug 685901 - Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly. r=roc 2011-09-12 09:08:07 -07:00
Mats Palmgren
073c2eb0c8 Bug 685154 - Cleanup nsIFrame::GetParentStyleContextFrame and related code. r=roc
Make nsCSSFrameConstructor::ConstructTable return a null frame if
creating the inner table frame fails.  Simplify some code since we can
now depend on the invariant that a properly created outer table frame
always has a non-null inner table frame.
2011-09-12 09:08:07 -07:00
Mats Palmgren
886a8f934d Bug 685154 - Cleanup nsIFrame::GetParentStyleContextFrame and related code. r=roc
Make nsIFrame::GetParentStyleContextFrame return the frame directly
instead of indirectly through an out parameter.  Remove the unused
nsPresContext parameter.
2011-09-12 09:08:07 -07:00
Masayuki Nakano
249d3a0682 Bug 669028 part.13 layout should use mozilla::LookAndFeel rather than nsILookAndFeel r=roc 2011-09-09 11:27:13 +09:00
Felix Fung
fa05b7e0f3 Bug 577266 - Correct misspellings in source code 2011-09-06 17:20:35 -07:00
Boris Zbarsky
58ab48ce7f Bug 683952. Speed up iterating over the continuations of the frame when scrolling to it. r=roc 2011-09-06 22:57:46 -04:00
Phil Ringnalda
271f5f65cb Back out fc945dec50bb and de06684dabc4 (bug 642551), 64c328251a24 (bug 683952) and 9d0d13998ebb (bug 684544) for orange on a CLOSED TREE 2011-09-06 21:42:54 -07:00
Boris Zbarsky
58cddca1c7 Bug 683952. Speed up iterating over the continuations of the frame when scrolling to it. r=roc 2011-09-06 22:57:46 -04:00
Ms2ger
820319977a Bug 684807 - Annotate crashtest assertions on Android; r=philor 2011-09-06 18:35:43 +02:00
Michael Wu
34247e34f4 Bug 676188 - Misc misuses of PRBool caught by the compiler, r=jimm,jst,bz,dougt,roc,mak 2011-08-30 11:55:14 -07:00
Mats Palmgren
4e2a044a66 Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
Mats Palmgren
1bfd788e19 Bug 653649 - New way of getting child lists from frames. (part 3/5) r=roc
Update GetAdditionalChildListName consumers to use the new
child list iterator instead.
2011-08-24 22:54:29 +02:00
Mats Palmgren
8c07e2e92b Bug 653649 - New way of getting child lists from frames. (part 2/5) r=roc sr=dbaron
Implement GetChildList(ChildListID) and GetChildLists(nsTArray<ChildList>*)
for various frame classes.  Remove GetAdditionalChildListName(PRInt32)
methods and associated macros and list index constants.
2011-08-24 22:54:29 +02:00
Bernd
c934e454e7 bug 675490 - push nonplaced tfoots and mark them as nonrepeating r=bz 2011-08-13 18:37:43 +02:00
Bernd
7ca9abb02a bug 678447 - prevent splitting of tables inside columnsets during printing r=roc 2011-08-13 18:37:43 +02:00
Malini Das
643e305d72 Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- plain tests 2/2. r=jmaher, a=test-only 2011-08-12 12:21:44 -04:00
Ehsan Akhgari
03f689dea6 Bug 677661 - Remove nsTPtrArray and add a SafeElementAt(index_type) API to nsTArray when it's instantiated with a pointer type; r=sicking 2011-08-10 01:36:00 -04:00
Bernd
c89cbf6c89 Bug 642088 - Subtract the caption height and vertical margins from the available height before reflowing the inner table frame. r=bzbarsky 2011-07-26 19:22:46 +02:00
Ms2ger
7b4c8739c0 Bug 670500 - Make nsCellMap::Init return void; r=roc 2011-07-15 12:18:33 +02:00
Ms2ger
095d1a25fa No bug - Fix assertion in nsCellMapColumnIterator::GetNextFrame; r=bz 2011-07-03 11:53:39 +02:00
Ehsan Akhgari
b8774f8312 Back out bug 10209 and bug 656875 (its regression fix) from Aurora because the work on this bug has not been finished yet 2011-06-01 16:18:15 -04:00
Bas Schouten
ad529f7339 Bug 651858 - Part 1: Add the Azure API and Direct2D backend. r=jrmuizel sr=roc 2011-06-24 19:41:16 +02:00
Dominic Fandrey
532ec73933 Bug 645398 - Substitute PR_(MAX|MIN|ABS|ROUNDUP) macro calls; r=roc 2011-06-02 14:56:50 +02:00
Craig Topper
2d3a050e8b Bug 658143 - Part 1: Changes nsCOMPtr<nsFrameSelection> to nsRefPtr. r=roc 2011-05-18 20:10:49 -07:00
Ehsan Akhgari
8c373030bb Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc 2011-04-29 19:02:33 -04:00
Robert O'Callahan
bb51b2359c Bug 641426. Part 6: Rename Empty to SetEmpty. r=cjones 2011-04-19 15:07:23 +12:00
Robert O'Callahan
414edefebf Bug 641426. Part 4.2: Rename BaseMargin::side to BaseMargin::Side. r=cjones 2011-04-19 15:07:22 +12:00
Robert O'Callahan
6844dfc18d Bug 641426. Part 3.5: Remove usage of nsMargin::TopLeft and nsMargin::IsZero. r=dbaron 2011-04-19 15:07:22 +12:00
Zack Weinberg
3e3bff664d Bug 266236 part 9: Move nsBoundingMetrics to its own header and prune inclusions of nsRenderingContext.h. 2011-04-07 18:04:40 -07:00
Jan Küchler
8774547613 Bug 266236 part 3: Mechanical rename of nsIRenderingContext and nsThebesRenderingContext to nsRenderingContext. Mechanical substitution of nsRefPtr<nsRenderingContext> for nsCOMPtr<nsRenderingContext>. 2011-04-07 18:04:40 -07:00
Jan Küchler
ed48629385 Bug 266236 part 1: Preliminary API cleanup on nsIRenderingContext. 2011-04-07 18:04:39 -07:00
8de1b4032d Bug 618830 initial assignment to kidNextInFlow is useless in nsTableFrame::ReflowChildren
r=bz
2011-03-28 16:50:13 -04:00
Boris Zbarsky
6474b590ed Bug 644576. Make sure that when we set up our iterator we don't decide we're done if the first row in our damage range contains no cells in our damage range. r=roc 2011-03-28 10:49:48 -04:00
5b6ae1c5ce Bug 620311 crash [@ nsTableFrame::MatchCellMapToColCache | nsTableFrame::RemoveFrame] because cellMap guard did not cover MatchCellMapToColCache
r=bernd
2011-03-26 00:37:35 -04:00
5485111bba Bug 620259 - add fall through comments to nsTableCellMap::SetNotTopStart and rename to nsTableCellMap::ResetTopStart
r=bernd a=dbaron
2011-02-16 14:14:18 +01:00
d72d5fbee6 Bug 620312 crash [@ nsTableFrame::InsertCol] because lastColGroup guard did not cover lastColGroup->GetColCount() r=bernd a=dbaron 2011-02-15 19:35:52 -05:00
Alexander Surkov
5d41370232 Bug 628922 - layout should use cached nsIAccessibilityService, r=davidb, sr=roc, a=roc 2011-01-28 12:38:14 +08:00
Jesse Ruderman
396f663f8a Bug 533380 - add crashtest 2010-12-12 12:54:27 -08:00
76170dc28e Bug 617637 nsTableFrame::PushChildren imagines it can pass null to [@ nsFrameList::RemoveFrame] violating its preconditions
r=bz
2010-12-09 11:57:03 +01:00
Boris Zbarsky
77d8583289 Bug 614397. Always descend through all placeholders while doing any sort of selection display list. r=roc, a=roc 2010-12-07 08:54:50 -05:00
57a9bccb02 Bug 615265: unused variable textStyle in nsTableCellFrame::VerticallyAlignChild. r=bz a=bz 2010-11-30 21:27:29 -08:00
Bernd
ec0aa5a568 Test for bug 595758. a=test 2010-11-14 19:26:36 +01:00
Martijn Wargers
c249954bee Test for bug 595758. a=test 2010-11-14 19:26:36 +01:00
Mats Palmgren
0e30d2f701 Bug 595758 - Crash [@ nsTableFrame::MarkIntrinsicWidthsDirty] on print preview. r=dbaron a=blocking2.0:betaN 2010-11-14 19:26:36 +01:00