corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
759,949 Commits 1 Branch 0 Tags
30bf1aec41315173f075c38cec8da2c1b9d2b164
Commit Graph

3397 Commits

Author SHA1 Message Date
William Durand
7382b32c34 Bug 1795285 - Remove skip-if = condprof on test_ext_manifest.js. r=robwu 
That was introduced in Bug 1793925 to workaround a pre-existing issue.

Differential Revision: https://phabricator.services.mozilla.com/D159663
 2022-10-19 13:10:12 +00:00
Cosmin Sabou
ba255c1975 Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js. 2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
fc9a32fdd5 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-18 21:44:48 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
William Durand
d8658dc7dd Bug 1793925 - Warn about complex versioning formats used in manifest. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D158834
 2022-10-18 08:06:08 +00:00
Butkovits Atila
b4f413e615 Backed out changeset 6f112c0942b0 (bug 1793925) for causing build bustages. CLOSED TREE 2022-10-17 16:04:08 +03:00
Tomislav Jovanovic
8e28939a01 Bug 1795597 - MV2 extensions should never flag for attention, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D159476
 2022-10-17 12:21:20 +00:00
William Durand
d6968c4f9b Bug 1793925 - Warn about complex versioning formats used in manifest. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D158834
 2022-10-17 11:19:00 +00:00
Cristian Tuns
d3ff37595e Backed out changeset f8554e4080f2 (bug 1793629) for causing mochitest failures on browser_preferences_usage.js CLOSED TREE 2022-10-15 16:14:29 -04:00
Tomislav Jovanovic
1afb6235b3 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-15 19:05:26 +00:00
Norisz Fay
4c718323c1 Backed out changeset c5a9bca461ce (bug 1793629) for causing multiple mochitest failures CLOSED TREE 2022-10-15 01:56:26 +03:00
Tomislav Jovanovic
8958e06b79 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158938
 2022-10-14 21:03:23 +00:00
Alexandre Poirot
bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D158582
 2022-10-14 12:19:42 +00:00
Tomislav Jovanovic
a16d5052dd Bug 1777343 - Implement simple origin controls attention indicator, r=willdurand,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D158476
 2022-10-13 22:04:52 +00:00
William Durand
0e48bdc4e2 Bug 1794504 - Fix a localized string. r=zombie 
I didn't version the string because this is still a "preview" file.

Differential Revision: https://phabricator.services.mozilla.com/D159044
 2022-10-12 06:29:05 +00:00
Alexandre Poirot
0a2f14ed30 Bug 1700909 - [devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes,extension-reviewers,willdurand 
This migrate gDevTools.showToolbox, but also the Toolbox now receives a commands right away,
and no longer need to create commands out of the descriptor front.

I'm removing browser_two_tabs as it is focusing on testing Tab Descriptors (RootFront.listTabs+getTab)
and Tab targets (TabDescriptor.getTarget).
Using getTarget on descriptor is legacy codepath for a while now.
We should now rather cover commands instead of these low level RDP methods.

Differential Revision: https://phabricator.services.mozilla.com/D157796
 2022-10-11 20:33:53 +00:00
Alexandre Poirot
e0366a6c18 Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-10-11 20:33:51 +00:00
William Durand
b1f7f2cb7f Bug 1794085 - Disable action button in unified extensions panel when extension already has permission. r=zombie 
Differential Revision: https://phabricator.services.mozilla.com/D158826
 2022-10-10 16:21:45 +00:00
Cristian Tuns
c136da03a9 Backed out 5 changesets (bug 1700909) for causing mochitest failures CLOSED TREE 
Backed out changeset a49f15f66ed4 (bug 1700909)
Backed out changeset 5a6b15eb1e12 (bug 1700909)
Backed out changeset 67b12d0e350b (bug 1700909)
Backed out changeset 4e6312ea547a (bug 1700909)
Backed out changeset c49eab385e1c (bug 1700909)
 2022-10-10 10:38:03 -04:00
Alexandre Poirot
0ad9d97fbc Bug 1700909 - [devtools] Migrate gDevTools.showToolbox from descriptor to commands. r=jdescottes,extension-reviewers,willdurand 
This migrate gDevTools.showToolbox, but also the Toolbox now receives a commands right away,
and no longer need to create commands out of the descriptor front.

I'm removing browser_two_tabs as it is focusing on testing Tab Descriptors (RootFront.listTabs+getTab)
and Tab targets (TabDescriptor.getTarget).
Using getTarget on descriptor is legacy codepath for a while now.
We should now rather cover commands instead of these low level RDP methods.

Differential Revision: https://phabricator.services.mozilla.com/D157796
 2022-10-10 11:28:08 +00:00
Alexandre Poirot
62214956c9 Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-10-10 11:28:05 +00:00
William Durand
3050551a02 Bug 1784218 - Add origin controls information to the unified extensions panel. r=zombie,Itiel,desktop-theme-reviewers 
In addition to adding messages for origin controls, this patch slightly
changes the UI to account for long l10n strings. As a result, the name
of the extension is no longer truncated with CSS (ellipsis). This isn't
a big problem as these names cannot exceed 45 characters (max 2 lines of
text). This allows us to better handle long permission messages and
(Windows) scrollbars. UX is OK with that at the moment.

We also retain the "default" height of the message below the name of an
extension (using the `min-height` property) to avoid flickering as per
UX guidelines.

Differential Revision: https://phabricator.services.mozilla.com/D156808
 2022-10-06 13:35:15 +00:00
Cristian Tuns
9acdf5eaf2 Backed out changeset 9862aaa671f1 (bug 1784218) for causing mochitest failures on browser_ext_activeScript.js CLOSED TREE 2022-10-05 04:54:16 -04:00
William Durand
ff3e52f2fb Bug 1784218 - Add origin controls information to the unified extensions panel. r=zombie,Itiel,desktop-theme-reviewers 
In addition to adding messages for origin controls, this patch slightly
changes the UI to account for long l10n strings. As a result, the name
of the extension is no longer truncated with CSS (ellipsis). This isn't
a big problem as these names cannot exceed 45 characters (max 2 lines of
text). This allows us to better handle long permission messages and
(Windows) scrollbars. UX is OK with that at the moment.

We also retain the "default" height of the message below the name of an
extension (using the `min-height` property) to avoid flickering as per
UX guidelines.

Differential Revision: https://phabricator.services.mozilla.com/D156808
 2022-10-05 07:09:29 +00:00
Tomislav Jovanovic
b7982ff5b6 Bug 1793494 - Activate content scripts on action click with activeTab permission, r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D158533
 2022-10-04 20:06:13 +00:00
William Durand
21aec6c831 Bug 1788994 - Remove promiseUnifiedExtensionsInitialized() in tests. r=rpl 
Depends on D157185

Differential Revision: https://phabricator.services.mozilla.com/D157935
 2022-10-04 08:45:58 +00:00
Shane Caraveo
a05882f6aa Bug 1779305 - Fix intermittent browseraction keyclick test. r=rpl 
Co-authored-by: William Durand <will+git@drnd.me>

Differential Revision: https://phabricator.services.mozilla.com/D153772
 2022-09-29 19:44:13 +00:00
Andreea Pavel
734e00a91f Backed out 5 changesets (bug 1700909) for failing browser_ext_addon_debugging_netmonitor.js on a CLOSED TREE 
Backed out changeset 9bc3e4820f59 (bug 1700909)
Backed out changeset 998c0ec4f9d3 (bug 1700909)
Backed out changeset 6f6fe066fc38 (bug 1700909)
Backed out changeset e53aaf8ffe5b (bug 1700909)
Backed out changeset 3dbeffe25878 (bug 1700909)
 2022-09-29 19:40:43 +03:00
Alexandre Poirot
0d20bb1ccb Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-09-29 14:43:24 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Alexandre Poirot
633eb069ef Bug 1791832 - [devtools] Convert devtools/startup JSM to ES Modules. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D157911
 2022-09-26 10:48:05 +00:00
Brian
0b327f0974 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Emilio Cobos Álvarez
20021a15f0 Bug 1790920 - Minor fixes to toolbar key navigation. r=Gijs,extension-reviewers,willdurand 
This is the last fix needed for this.

The issue is that command events now are triggered by synthetic click
events (which was not the case before pretty much by chance, a side
effect of how these events were implemented).

If we open a panel by a command event triggered by the synthetic click
event, rather than the real keypress event, we end up not detecting that
it is really a keyboard activation, and not focusing the first navigable
element in the panel for example, which is unfortunate.

This was caught by browser_toolbarButtonKeyPress.js.

We could keep the old behavior of not triggering commands from
dispatchEvent()-ed clicks, but honestly that's kind of bizarre.

Differential Revision: https://phabricator.services.mozilla.com/D157596
 2022-09-19 17:02:38 +00:00
Joel Maher
1325c90046 Bug 1790868 - clean up 32 bit annotations for tests that don't run on 32 bit, and general cleanup. r=aryx 
Differential Revision: https://phabricator.services.mozilla.com/D157352
 2022-09-16 12:40:13 +00:00
William Durand
313a3beac7 Bug 1784223 - Move unified extensions button "after" the overflow menu. r=rpl,dao 
This patch also adjusts some `min-width` rules like it was done for the
downloads button. It should work with either buttons OR both, which is
going to happen since the unified extensions button will be most likely
always visible in the toolbar.

Differential Revision: https://phabricator.services.mozilla.com/D154360
 2022-09-15 16:34:38 +00:00
William Durand
4a4c05ab8a Bug 1789407 - Always anchor defaultsearch popup to the urlbar. r=rpl 
Depends on D156960

Differential Revision: https://phabricator.services.mozilla.com/D156952
 2022-09-09 18:50:32 +00:00
Alexandre Poirot
059764322b Bug 1789595 - [devtools] Convert devtools/server JSM to ES Modules. r=nchevobbe 
This is the result of:
$ ./mach esmify devtools/server/

Differential Revision: https://phabricator.services.mozilla.com/D156826
 2022-09-09 10:13:15 +00:00
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Mathew Hodson
23d098346b Bug 1762444 - Replace setUp tasks with add_setup in browser mochitests. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D150330
 2022-08-29 08:54:54 +00:00
Shane Caraveo
2a74411693 Bug 1786587 Fix browser action panel when toolbar is overflowed r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D155527
 2022-08-26 15:31:01 +00:00
Emilio Cobos Álvarez
0676d5d593 Bug 1780876 - Try to deal with DOM/widget state mismatch on macOS. r=robwu 
The patch that that regressed this started using the widget state rather
than the DOM state to return full-screen. It seems on macOS they
sometimes can get out of sync, in the failure from comment 0 the window
is really full-screen.

We seemed to account for some of this in:

  https://searchfox.org/mozilla-central/rev/00e504083572d47f2199168f0f79c75c0ddaefb3/browser/components/extensions/test/browser/browser_ext_windows_create.js#31-36

Make sure we exit full-screen as appropriate if DOM thinks we're
fullscreen. This passes verify and at worst it should be harmless.

Differential Revision: https://phabricator.services.mozilla.com/D155353
 2022-08-23 22:13:19 +00:00
Luca Greco
f2e2e6955d Bug 1760608 - Restrict actions API setPopup urls allowed for MV3 extensions. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D154547
 2022-08-23 10:35:57 +00:00
Shane Caraveo
c114951f8b Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D154179
 2022-08-22 18:55:59 +00:00
Dão Gottwald
6097357267 Bug 1786011 - Show the "List all tabs" button unconditionally. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D155076
 2022-08-22 14:48:49 +00:00
William Durand
acc4dff795 Bug 1785988 - Display message when hovering/focusing the menu button in the unified extensions panel. r=rpl,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D155055
 2022-08-19 18:52:19 +00:00
William Durand
eb8b86f19c Bug 1785204 - Separate primary and secondary buttons in the unified extensions panel. r=Itiel,Jamie,rpl,desktop-theme-reviewers 
Depends on D154282

Differential Revision: https://phabricator.services.mozilla.com/D154873
 2022-08-19 13:57:12 +00:00
William Durand
64389ba498 Bug 1784292 - Anchor extension popups to the unified extensions button. r=mconley,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D154408
 2022-08-19 06:25:13 +00:00