Commit Graph

33466 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
30bf1aec41 Bug 1779695 - Use modern flex on in-content pages. r=Gijs,dao
This fixes the edit bookmarks dialog by properly allowing stuff to wrap once
the dialog width has been fixed.

Let's try to do this and opt-out any specific pages that may hit issues,
rather than opting-in one by one, now that's early in the cycle?

Differential Revision: https://phabricator.services.mozilla.com/D159690
2022-10-19 17:45:11 +00:00
Gijs Kruitbosch
450ac5ac39 Bug 1794757 - autoplay dialog should wait for translation to finish before showing and determining size to avoid buttons being cut off, r=kpatenio
The sitePermissions code is reused, and all dialogs work OK except the autoplay one.
This is because the autoplay code adds extra content not present in the other
dialogs, and localizes it.
The SubDialog code relies on determining the size of the dialog once the
mozSubDialogReady promise resolves, which it does before fluent puts in l10n data
for the content that was just added. This patch fixes that.

It also, as a driveby, correctly pauses and resumes observing l10n attributes
in the doc when making modifications, to avoid fluent doing a second pass for
the same content.

Differential Revision: https://phabricator.services.mozilla.com/D159543
2022-10-19 14:59:22 +00:00
Mike Conley
810d9bf588 Bug 1795780 - Add the ability to disable a browser migrator at runtime via a pref. r=NeilDeakin,Gijs
It seems that at build time, we already make decisions about what migrators we register
with XPCOM in browser/components/migration/components.conf. This doesn't, however, give
us the ability to turn off a migrator that happens to be misbehaving, nor make it easy
for us to do development of a new migrator without exposing it to the migration dialog
(without doing binary recompiles).

This adds another layer to the enable-ment of our migrators so that they must both
be registered AND enabled in order to appear in the import dialog.

Differential Revision: https://phabricator.services.mozilla.com/D159544
2022-10-19 14:48:46 +00:00
Ben Hearsum
f59763a8d2 Bug 1792163: Private window does not use private icon on taskbar when opening a link from "private" Library into a new private window r=mak
Differential Revision: https://phabricator.services.mozilla.com/D158149
2022-10-19 13:24:08 +00:00
William Durand
7382b32c34 Bug 1795285 - Remove skip-if = condprof on test_ext_manifest.js. r=robwu
That was introduced in Bug 1793925 to workaround a pre-existing issue.

Differential Revision: https://phabricator.services.mozilla.com/D159663
2022-10-19 13:10:12 +00:00
stransky
a7d1331615 Bug 1791529 Ignore empty elements when drop target indicator position is calculated r=emilio
On Wayland drop target position can be a negative value. Drop target area can contain empty elements located at 0,0 with zero size.
If we hit such combination the drop element is placed at 0,0 and we don't consider other valid elements located at negative positions.
That leads to incorrect drop target indicatop placement; it's located at 0,0 coordinates.

In this patch we ignore empty elements and iterate through valid ones only so we correctly place drop indicator even when screen coordinates are negative.

Differential Revision: https://phabricator.services.mozilla.com/D159698
2022-10-19 12:49:37 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
2022-10-19 11:55:29 +00:00
Tom Schuster
d7f0f33918 Bug 1617611 - Fix all tests using laxByDefault=false under browser/. r=freddyb
This turned out to be more complicated than expected, because:
- SameSite=None requires https://
- Many test were using the mochi.test domain, which is not reachable via https

Differential Revision: https://phabricator.services.mozilla.com/D157637
2022-10-19 08:59:38 +00:00
Cosmin Sabou
ba255c1975 Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js. 2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
fc9a32fdd5 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-18 21:44:48 +00:00
Mike Conley
f2c0de0fe7 Bug 1744584 - Remove old sidebar theme-ing workaround. r=bigiri
These workarounds were due to an issue where the sidebar documents weren't having
the LightweightThemeChild instantiated for them on the `pageshow` event. This was
fixed by bug 1596852 about a year ago, so we can remove these workarounds now.

Differential Revision: https://phabricator.services.mozilla.com/D159622
2022-10-18 20:10:00 +00:00
Drew Willcoxon
d7aafbd006 Bug 1795803 - Expose the Merino provider pref to Nimbus. r=daisuke
This adds a Nimbus variable corresponding to `browser.urlbar.merino.providers`.

I noticed that when we added a Nimbus variable for client variants (bug
1743685), we didn't actually use it in the provider. Instead we use its fallback
pref. I fixed that too.

Differential Revision: https://phabricator.services.mozilla.com/D159557
2022-10-18 19:58:53 +00:00
Kelly Cochrane
ff59c7c418 Bug 1795299 - Update Fx View logo container to full width with centered logo in narrower viewports r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159595
2022-10-18 15:17:37 +00:00
Katherine Patenio
6ef8e8b39e Bug 1779714 - Defer re-rendering about:addons themes list view when active theme changes while ColorwayCloset modal dialog is open. r=rpl,dao
Differential Revision: https://phabricator.services.mozilla.com/D152127
2022-10-18 14:40:30 +00:00
Shane Hughes
7a6dea3750 Bug 1787532 - Let Feature Callouts perform actions on page events. r=mviar
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
  {
    params: {
      type: string,
      selectors: string,
      options?: {
        capture?: boolean,
        once?: boolean,
        preventDefault?: boolean,
      },
    },
    action: {
      type?: string,
      data?: object,
      dismiss?: boolean,
      etc...
    },
  },
]
```

Differential Revision: https://phabricator.services.mozilla.com/D158899
2022-10-18 14:29:27 +00:00
James Teow
7f98b4909c Bug 1788953 - Part 3: Modify revert test and add new background tab test - r=adw
Depends on D157486

Differential Revision: https://phabricator.services.mozilla.com/D157487
2022-10-18 13:38:50 +00:00
James Teow
8448fad066 Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
2022-10-18 13:38:49 +00:00
issammani
229e33b7f7 Bug 1775903 - Reuse waitForMP function and authenticate instead of canceling MP prompt. r=dimi,credential-management-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D159558
2022-10-18 12:16:13 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
43be0848c3 Bug 1792341 - Migrate most of the rest of toolkit/modules/ to be system ES modules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158451
2022-10-18 11:21:25 +00:00
William Durand
d8658dc7dd Bug 1793925 - Warn about complex versioning formats used in manifest. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D158834
2022-10-18 08:06:08 +00:00
Mark Banner
dd58975736 Bug 1445134 - Load policy engines from enterprise policies at search service startup. r=mkaply,mcheang
Rather than having the enterprise policy push engine information to the search service, this pulls it from the policies whilst initialisation is in progress. This will ensure the search service always has the correct information for policy engines even if the search settings file is modified.

Differential Revision: https://phabricator.services.mozilla.com/D156538
2022-10-18 07:21:47 +00:00
Mark Banner
0fdad6488f Bug 1445134 - Move most of browser_policy_search_engine.js to an xpcshell-test as it doesn't need to be run as mochitest. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158859
2022-10-18 07:21:45 +00:00
Sam Foster
0d9a297863 Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159528
2022-10-18 00:22:26 +00:00
Emilio Cobos Álvarez
c36fff83db Bug 1795260 - Also clear the inNavbar pref so that following test keeps working.
MANUAL PUSH: Trivial orange fix CLOSED TREE
2022-10-17 23:28:10 +02:00
Cristian Tuns
39cbafb6a7 Backed out changeset d734d1d10478 (bug 1795752) for causing mochitest failures on browser_feature_callout.js CLOSED TREE 2022-10-17 17:17:49 -04:00
Emilio Cobos Álvarez
299ce96ba4 Bug 1795260 - Test that the searchbar doesn't overflow the toolbar even with a big user-imposed size. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159521
2022-10-17 20:59:59 +00:00
Sam Foster
1969a620bf Bug 1795752 - Use fx-view rather than firefoxview as the entry point param for FxA signin/signup. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159528
2022-10-17 20:35:31 +00:00
Tim Giles
9fa180f7e9 Bug 1794474 - Force tabs sync when a user reloads Firefox View. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D159401
2022-10-17 18:39:27 +00:00
BryanMacoy
7bc5b9a567 Bug 1788928 - Convert BlockedSite JSM modules to ESMs. r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D157046
2022-10-17 17:57:27 +00:00
BryanMacoy
a8dc112c6e Bug 1788922 - Convert AboutProtections JSM modules to ESMs. r=mconley,kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D157035
2022-10-17 17:51:57 +00:00
Evan
0c28f32ec7 Bug 1790227 -Coverted DecoderDoctor JSM modules to ESM modules. r=NeilDeakin,media-playback-reviewers,chunmin.
Differential Revision: https://phabricator.services.mozilla.com/D158406
2022-10-17 17:22:38 +00:00
Emilio Cobos Álvarez
73834cb895 Bug 1795199 - Make searchbar take something closer to the resized width. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159381
2022-10-17 17:18:22 +00:00
Emilio Cobos Álvarez
8021f0ab2a Bug 1795260 - Make a too-big searchbar not push the rest of the UI out. r=Gijs
For that, we need to min-width: 0 the nav-bar target, which itself
requires us to tweak the overflow detection so that we look at all
children of the customization target, not only the target itself.

Differential Revision: https://phabricator.services.mozilla.com/D159377
2022-10-17 17:07:15 +00:00
Angel_V129
58683267b5 Bug 1790274 - Convert browser/actors/DOMFullscreen* JSM modules to ESMs. r=mconley,kpatenio.
Differential Revision: https://phabricator.services.mozilla.com/D159015
2022-10-17 15:55:47 +00:00
negin
c8bf42e95d Bug 1792667 - The “Tab Pickup” callout message points to another section when the “Tab Pickup” section is collapsed r=mviar,emcminn
try: https://hg.mozilla.org/try/rev/92340ece620dd2d64e2f2c9826a4f6d9a387acc6

Differential Revision: https://phabricator.services.mozilla.com/D158699
2022-10-17 15:18:39 +00:00
Butkovits Atila
46c834c673 Backed out 6 changesets (bug 1445134) for causing xpcshell failures. CLOSED TREE
Backed out changeset 59f902b761b5 (bug 1445134)
Backed out changeset 2ec41e23c593 (bug 1445134)
Backed out changeset b0dc583fff47 (bug 1445134)
Backed out changeset a09ccaf19501 (bug 1445134)
Backed out changeset 2d736481d13d (bug 1445134)
Backed out changeset 57ec56757493 (bug 1445134)
2022-10-17 17:54:39 +03:00
Mark Banner
c09198c67b Bug 1445134 - Load policy engines from enterprise policies at search service startup. r=mkaply,mcheang
Rather than having the enterprise policy push engine information to the search service, this pulls it from the policies whilst initialisation is in progress. This will ensure the search service always has the correct information for policy engines even if the search settings file is modified.

Differential Revision: https://phabricator.services.mozilla.com/D156538
2022-10-17 12:56:07 +00:00
Mark Banner
920a4a27fb Bug 1445134 - Move most of browser_policy_search_engine.js to an xpcshell-test as it doesn't need to be run as mochitest. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D158859
2022-10-17 12:56:05 +00:00
Butkovits Atila
b4f413e615 Backed out changeset 6f112c0942b0 (bug 1793925) for causing build bustages. CLOSED TREE 2022-10-17 16:04:08 +03:00
Tomislav Jovanovic
8e28939a01 Bug 1795597 - MV2 extensions should never flag for attention, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D159476
2022-10-17 12:21:20 +00:00
William Durand
d6968c4f9b Bug 1793925 - Warn about complex versioning formats used in manifest. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D158834
2022-10-17 11:19:00 +00:00
Cristian Tuns
d3ff37595e Backed out changeset f8554e4080f2 (bug 1793629) for causing mochitest failures on browser_preferences_usage.js CLOSED TREE 2022-10-15 16:14:29 -04:00
Tomislav Jovanovic
1afb6235b3 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-15 19:05:26 +00:00
Norisz Fay
4c718323c1 Backed out changeset c5a9bca461ce (bug 1793629) for causing multiple mochitest failures CLOSED TREE 2022-10-15 01:56:26 +03:00
Tomislav Jovanovic
8958e06b79 Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-14 21:03:23 +00:00
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
2022-10-14 18:45:45 +00:00
Emilio Cobos Álvarez
cc91358870 Bug 1795294 - Allow places menupopups to shrink under the available size. r=dao
I can also just drop min-width/height: 0 in the inline style if you'd
rather do that.

Differential Revision: https://phabricator.services.mozilla.com/D159402
2022-10-14 15:09:51 +00:00
Kelly Cochrane
044d219619 Bug 1793638 - Collapse synced tabs list to single column on narrower viewports r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D159327
2022-10-14 14:09:02 +00:00
Alexandre Poirot
bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D158582
2022-10-14 12:19:42 +00:00