Commit Graph

3059 Commits

Author SHA1 Message Date
Andreas Farre
2fb0a6c70f Bug 1590782 - Switch process when InternalLoad finds oop BrowsingContext. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D50945
2019-11-12 21:52:18 +00:00
Matt Woodrow
fe12d7ee86 Bug 1594166 - Enable DocumentChannel for ftp, file and blob. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D51902
2019-11-07 19:01:43 +00:00
Matt Woodrow
16f0a21197 Bug 1593560 - Allow data urls with DocumentChannel. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D51547
2019-11-06 22:37:06 +00:00
Dorel Luca
116f107e5b Backed out changeset b2026c2b563f (bug 1594529) for Browser-chrome failures in workspace/build/src/docshell/base/nsDocShell. CLOSED TREE 2019-11-07 03:45:01 +02:00
Jonathan Kingston
cf53fe6298 Bug 1594529 - Adding in asserts for LoadURI to ensure we have the correct contentPolicyType r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D52088
2019-11-06 23:47:06 +00:00
Dorel Luca
c4c3d1ed72 Backed out changeset eaee8979fdc4 (bug 1594529) for Browser-chrome in toolkit/components/passwordmgr/test/browser/browser_doorhanger_crossframe.js. CLOSED TREE 2019-11-07 02:12:16 +02:00
Kris Maglione
184f4783e8 Bug 1594529: Infer nsDocShell::IsFrame from BrowsingContext. r=nika
This fixes the content policy type for document loads in these frames, where
the explicit mIsFrame flag was not set, due to DocShell creation taking a
different code path in remote frames than in in-process frames.

Differential Revision: https://phabricator.services.mozilla.com/D52093
2019-11-06 20:34:36 +00:00
Coroiu Cristina
c2912e226b Backed out 7 changesets (bug 1593560) for crashtest failures at tests/layout/base/crashtests/446328.html on a CLOSED TREE
Backed out changeset 7dfae085a4cb (bug 1593560)
Backed out changeset 9842c80c98d8 (bug 1593560)
Backed out changeset d67a10437af7 (bug 1593560)
Backed out changeset 3e3948e9531c (bug 1593560)
Backed out changeset a7d04e276b44 (bug 1593560)
Backed out changeset 9f52c9f6dc54 (bug 1593560)
Backed out changeset 90572c49d464 (bug 1593560)
2019-11-07 00:32:53 +02:00
Matt Woodrow
46f931aa7a Bug 1593560 - Allow data urls with DocumentChannel. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D51547
2019-11-06 18:22:00 +00:00
Andreas Tolfsen
46e958bbf3 bug 1549708: docshell: add nsIDocShell.isForceReloading; r=bzbarsky
Exposes a new nsIDocShell API, isForceReloading, to determine if
the loaded document was force-reloaded or not.

It relies on the underlying behaviour of nsDocShell::IsForceReloading(),
which again relies on nsDocShell::IsForceReloadType(mLoadType).

The getter is used in the remote agent to test that
Page.reload({ignoreCache: true}) works as intended.

Differential Revision: https://phabricator.services.mozilla.com/D51435
2019-11-04 13:28:23 +00:00
Sebastian Hengst
84c9c8b5c1 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-11-06 15:00:06 +01:00
Sebastian Hengst
ebf630f398 Merge mozilla-inbound to mozilla-central. a=merge 2019-11-06 14:54:44 +01:00
Andreas Farre
230e07715f Bug 1582716 - Remove nsDocShell::GetIsOnlyToplevelInTabGroup. r=nika
We can remove isOnlyToplevelInTabGroup entirely since we have
BrowsingContext/BrowsingContextGroup exposed through
chrome-webidl. Checking if a browsing context is the only top level
(auxilliary or otherwise) is only a matter of checking that there
isn't a parent, and that the size of the browsing context group is 1.

Differential Revision: https://phabricator.services.mozilla.com/D46590
2019-11-06 10:54:49 +00:00
Brendan Dahl
ef30c33394 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-05 17:56:28 +00:00
Mihai Alexandru Michis
5803a050c4 Backed out 2 changesets (bug 1470510) for causing bustages in widget/cocoa/nsChildView.mm CLOSED TREE
Backed out changeset a343f30c34a3 (bug 1470510)
Backed out changeset 4da64790094d (bug 1470510)
2019-11-05 09:24:26 +02:00
Brendan Dahl
b484de8fe7 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-04 23:37:31 +00:00
Peter Van der Beken
731f764552 Bug 1588491 - Associate session history entries with a session history object from creation. Continue to allow docshells to create session history entries even if the root docshell doesn't have a session history object. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D50574
2019-10-24 09:17:19 +02:00
Peter Van der Beken
2d52b5901a Bug 1588491 - Associate session history entries with a session history object from creation. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D49170
2019-10-17 20:03:49 +02:00
Dorel Luca
bcbec745b9 Backed out 2 changesets (bug 1470510) for build bustage on /build/src/widget/cocoa/nsChildView.mm. CLOSED TREE
Backed out changeset 5967bf633574 (bug 1470510)
Backed out changeset 067a556bb614 (bug 1470510)
2019-11-04 19:18:56 +02:00
Brendan Dahl
4f87b88cc6 Bug 1470510 - Rename nsXULWindow and nsIXULWindow to AppWindow and nsIAppWindow. r=smaug
nsXULWindow is no longer XUL specific and is somewhat confusing name.

Differential Revision: https://phabricator.services.mozilla.com/D51486
2019-11-04 16:52:35 +00:00
Dragana Damjanovic
95bc2237cb Bug 1581637 - Part 2 - Add NS_ERROR_NET_HTTP3_PROTOCOL_ERROR error. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46647
2019-11-01 14:55:54 +00:00
Paul Bone
ec62d8d93f Bug 1588412 - (part 2) moz:// documents should use documentchannel r=mattwoodrow
the URL moz://a redirects to mozilla's website, Because it redirects to
https we want to use documentchannel.

Depends on D49100

Differential Revision: https://phabricator.services.mozilla.com/D51227
2019-10-31 18:36:56 +00:00
Cosmin Sabou
40b045555d Backed out changeset 36a8c8887629 (bug 1588220) for causing a spike in browser chrome failures (eg: Bug 1592741). 2019-10-31 14:53:40 +02:00
Christoph Kerschbaumer
9545b113fa Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-31 08:28:35 +00:00
Andreea Pavel
ad4a095848 Backed out 13 changesets (bug 1581637) for xpchell failures at test_anonymous-coalescing.js on a CLOSED TREE
Backed out changeset 3a458217248d (bug 1581637)
Backed out changeset a5df33ec7393 (bug 1581637)
Backed out changeset c5d8950b4a4b (bug 1581637)
Backed out changeset 97ff4a06c2da (bug 1581637)
Backed out changeset 496ec0c5a60f (bug 1581637)
Backed out changeset 63b7f1ff1714 (bug 1581637)
Backed out changeset 6b80553abc74 (bug 1581637)
Backed out changeset 6b6b75fbec7f (bug 1581637)
Backed out changeset f09b9a4ba633 (bug 1581637)
Backed out changeset 21b721e37d39 (bug 1581637)
Backed out changeset 58ca75a25253 (bug 1581637)
Backed out changeset c28174eaccbe (bug 1581637)
Backed out changeset e6ff3db0a421 (bug 1581637)
2019-10-31 02:45:42 +02:00
Dragana Damjanovic
e10150a41c Bug 1581637 - Part 2 - Add NS_ERROR_NET_HTTP3_PROTOCOL_ERROR error. r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D46647
2019-10-30 20:52:36 +00:00
Razvan Maries
29f5ebb20d Backed out changeset 5f185a11889b (bug 1584998) for perma fails on browser_bug593387.js. CLOSED TREE 2019-10-30 23:26:01 +02:00
Christoph Kerschbaumer
e153436cc8 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 17:54:36 +00:00
Daniel Varga
5ad67b3c4d Backed out changeset ac8f6632f7e0 (bug 1584998) on request by dev. On a CLOSED TREE 2019-10-30 19:33:29 +02:00
Kris Maglione
7aedcd09ad Bug 1588220: Keep track of last active inner window when BrowsingContext is discarded. r=bzbarsky
Any number of outer windows may be attached to a BrowsingContext over its
lifetime. While the BrowsingContext is alive, it's easy to keep track of which
of these is active, and therefore which of its inner windows is active. After
it has been discarded, though, it discards its docShell reference, so all we
can tell about an inner window is whether it is active for its own outer
window, but not whether it should be considered active for its
BrowsingContext.

This patch updates the BrowsingContext detach logic to store a flag on the
current inner window recording that it was active when its BrowsingContext was
detached, and then later checks that flag to determine if it is the current
window for a detached BrowsingContext.

Differential Revision: https://phabricator.services.mozilla.com/D49032
2019-10-30 17:22:37 +00:00
Christoph Kerschbaumer
bf3d7aada0 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 14:47:19 +00:00
Edgar Chen
3dc70dd58e Bug 1587062 - Move SandboxFlags from DocShell to BrowsingContext; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D50663
2019-10-28 11:48:30 +00:00
Andreas Farre
a737baed0b Bug 1575051 - Part 4: Expose JS stack access check control on FindWithName. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D49286
2019-10-25 15:34:30 +00:00
Andreas Farre
3262edc078 Bug 1575051 - Part 1: Remove nsIDocShellTreeItem.findItemWithName. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-10-24 14:53:07 +00:00
Paul Zuehlcke
eb43d30ff5 Bug 1588461 - Added OA StripAttributes flag for privateBrowsingId. r=johannh,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D49174
2019-10-24 14:18:54 +00:00
Matt Woodrow
165dde9a8d Bug 1590748 - Setup result principal URI on the content process LoadInfo as well as the parent process one, since ServiceWorkers depends on it there. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D50372
2019-10-24 00:46:37 +00:00
Matt Woodrow
f2b2716c7f Bug 1583700 - Copy hasNonEmptySandboxingFlags across with DocumentChannel so that it can be set on the nHttpChannel in the parent. r=JuniorHsu,valentin
Depends on D49870

We fail coop-sandbox.https.html  without this, since the changes in bug 1566868 don't apply to DocumentChannel.

Differential Revision: https://phabricator.services.mozilla.com/D49871
2019-10-22 19:16:28 +00:00
Matt Woodrow
261a71e6d7 Bug 1583700 - Move CSP setup code to run in both processes. r=nika,ckerschb,mattwoodrow
We want this to run in both processes so that we set the cspToInherit on the LoadInfo within the child as well as the parent.

Differential Revision: https://phabricator.services.mozilla.com/D47355
2019-10-22 01:03:18 +00:00
Mihai Alexandru Michis
7078263d1a Backed out 7 changesets (bug 1583700) for causing raptor dom failures.
Backed out changeset 48ceb0dd5d09 (bug 1583700)
Backed out changeset c662a369062f (bug 1583700)
Backed out changeset dc9e317da307 (bug 1583700)
Backed out changeset 41e07201a158 (bug 1583700)
Backed out changeset 015ec42c311a (bug 1583700)
Backed out changeset cfb571dd120a (bug 1583700)
Backed out changeset b9d06db6d43c (bug 1583700)
2019-10-22 03:57:07 +03:00
Matt Woodrow
07a66b59a9 Bug 1583700 - Copy hasNonEmptySandboxingFlags across with DocumentChannel so that it can be set on the nHttpChannel in the parent. r=JuniorHsu,valentin
Depends on D49870

We fail coop-sandbox.https.html  without this, since the changes in bug 1566868 don't apply to DocumentChannel.

Differential Revision: https://phabricator.services.mozilla.com/D49871
2019-10-21 20:47:28 +00:00
Matt Woodrow
c8c8d04045 Bug 1583700 - Move CSP setup code to run in both processes. r=nika,ckerschb,mattwoodrow
We want this to run in both processes so that we set the cspToInherit on the LoadInfo within the child as well as the parent.

Differential Revision: https://phabricator.services.mozilla.com/D47355
2019-10-15 07:52:09 +00:00
Boris Zbarsky
66d0320937 Bug 1589309. Pass XPCOM strings, not buffer pointers, to notifyJSRunToCompletionStart. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D49650
2019-10-18 02:50:45 +00:00
Nika Layzell
2653b16f9a Bug 1576714 - Part 3: Initiate subframe process switches from the parent, r=kmag
This flips the direction in which the BrowserBridge actor is generally created
such that it is generally created in the parent and sent down to a child
process.

This is done by making the decision about what kind of switch to perform in the
parent, and sending messages down to child processes async to orchestrate these
process changes.

Process launching is changed to use an async `MozPromise`-returning API in this
patch, though the actual process launching still occurs synchronously. A future
patch will enable performing async process launching through the
NewOrUsedBrowserProcess mechanism.

I know of at least a few timing issues which exist with the new logic,
especially around the state of the BrowsingContext during the process
transition. I decided to not try to fix all of these issues in this patch, as
many are complex and will require changing how we manage the lifecycle of
BrowsingContext substantially. I do, however, think that the new logic is more
reliable and has fewer timing issues than the previous logic.

Differential Revision: https://phabricator.services.mozilla.com/D47310
2019-10-15 16:19:16 +00:00
Junior Hsu
354783fc72 Bug 1566868 - network error for non empty sandboxing flag and non-null COOP r=valentin
Adjust for new spec change (comment 23)

Differential Revision: https://phabricator.services.mozilla.com/D49222
2019-10-15 06:09:26 +00:00
Narcis Beleuzu
8b503ffdd0 Backed out 3 changesets (bug 1575051) for bc failures on browser_browsingContext-getWindowByName.js . CLOSED TREE
Backed out changeset 67aaf4a157af (bug 1575051)
Backed out changeset e01256038537 (bug 1575051)
Backed out changeset 0c8f70f9328b (bug 1575051)
2019-10-14 19:19:05 +03:00
Andreas Farre
967275c308 Bug 1575051 - Part 1: Remove nsIDocShellTreeItem.findItemWithName. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D46285
2019-10-14 12:07:14 +00:00
Marco Bonardo
24261f2d48 Bug 1586681 - Ensure URIFIxup uses the right engine when there's a separate PB engine. r=Standard8,Gijs
Add a new FIXUP_FLAG_PRIVATE_CONTEXT to nsIURIFixup, make it use the default
private search engine when it's set.
Update consumers to pass the new flag when necessary.

Differential Revision: https://phabricator.services.mozilla.com/D48741
2019-10-12 12:37:51 +00:00
Kris Maglione
2da6eab878 Bug 1586911: Silence SHEntry assertion after local->remote->local iframe navigation. r=peterv
When we have a parser-created iframe which starts out in-process, transitions
to remote, and then transitions back to in-process, we create separate
DocShells for the first and last in-process loads. Since both are
network-created, and have the same child index, they both try to add
themselves as children to their parent's SHistory at the same index. And since
the entry for the first DocShell already exists at that index when we try to
add the second, that triggers an assertion.

This isn't really ideal, but it is expected given the current state of session
history under Fission. It should hopefully be solved more gracefully when the
Fission-aware session history rewrite is done, but in the mean time, I think
we should just ignore the conflict, since it's expected.

Differential Revision: https://phabricator.services.mozilla.com/D48437
2019-10-11 19:32:02 +00:00
Matt Woodrow
72d26be23d Bug 1578624 - P4: Add an option to set mIsNavigating on the docshell when loading using BrowsingContext. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44760
2019-10-11 02:27:05 +00:00
Matt Woodrow
19bae1ea39 Bug 1578624 - P3: Move conversion from LoadURIOptions processing into a static constructor for nsDocShellLoadState. r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D44759
2019-10-11 02:27:03 +00:00