Commit Graph

223 Commits

Author SHA1 Message Date
Neil Deakin
2f5fea237e Bug 1482389, replace TreeBoxObject with XULTreeElement inherited from XULElement, r=peterv,paolo 2018-12-04 11:25:30 -05:00
James Lee
9366fd6f82 Bug 1507809 - Remove 'ExcludeReadOnlyFolders' option from places' queries r=Standard8
Removed all references to 'ExcludeReadOnlyFolders' since Firefox doesn't
(and will not) support read only folders.

Differential Revision: https://phabricator.services.mozilla.com/D12821
2018-11-26 13:18:05 +00:00
Tim Nguyen
790f9a6593 Bug 1508142 - Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D12225
2018-11-22 09:59:02 +00:00
Mark Banner
8cd25e0609 Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D9701
2018-10-26 07:40:15 +00:00
Mark Banner
7e98ad6bc5 Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796
2018-08-22 15:44:43 +00:00
Brian Grinstead
0ae3afe87d Bug 1476030 - Part 1 - Expose xulStore through Services;r=Gijs
This lets us use Services.xulStore instead of requiring
Cc["@mozilla.org/xul/xulstore;1"].getService(Ci.nsIXULStore);

MozReview-Commit-ID: 2eXifCPhlGs
2018-07-18 09:43:38 -07:00
Mark Banner
9272396ce0 Bug 1471215 - Remove now unnecessary classInfo definition in PlacesTreeView. r=mak
MozReview-Commit-ID: 2BJGohgrA2l

Differential Revision: https://phabricator.services.mozilla.com/D1828
2018-06-26 20:45:41 +00:00
Mark Banner
47dd667387 Bug 1465347 - Remove the ability to sort results by annotation as it is no longer used. r=mak
MozReview-Commit-ID: bl588eAmkD

Differential Revision: https://phabricator.services.mozilla.com/D1662
2018-06-15 07:39:32 +00:00
Mark Banner
8853e86675 Bug 1463738 - Remove the Bookmark description UI. r=dao
This removes the bookmark description UI, but leaves the backend in-place for a release or two, so that users have time to save anything they want (e.g. via backup).
The backend will be removed in bug 1402890.

MozReview-Commit-ID: La4AYFar7eK
2018-05-23 17:15:09 +01:00
Kris Maglione
c03fa450d6 Bug 1460092: Add ESLint rule to enforce use of ChromeUtils.generateQI. r=Gijs
Also fixes existing code which fails the rule.

MozReview-Commit-ID: CkLFgsspGMU
2018-05-08 18:36:22 -07:00
Marco Bonardo
2e80ffbe53 Bug 1453545 - Properties option disabled when right-clicking a bookmarks folder. r=standard8
MozReview-Commit-ID: 30JmVhO7sh9
2018-04-19 00:16:48 +02:00
Marco Bonardo
3382b7442d Bug 1293445 - 5 - Rename RESULTS_AS_TAG_QUERY. r=standard8
MozReview-Commit-ID: 7HwPKkGvAvv
2018-04-04 16:14:20 +02:00
Marco Bonardo
36ec58e083 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW
2018-03-22 14:13:07 +01:00
Brendan Dahl
8a8bb26748 Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn
2018-03-12 10:43:35 -07:00
Mark Banner
8bda7e6d85 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
Dorel Luca
37af71af05 Backed out 2 changesets (bug 1310295) for Mochitest and TV failures on browser/components/places/tests/browser/browser_bookmark_folder_moveability.js
Backed out changeset a277657bfffa (bug 1310295)
Backed out changeset b1af75c617ea (bug 1310295)
2018-03-14 18:23:46 +02:00
Mark Banner
60c4119b69 Bug 1310295 - Make left pane queries virtual in the Places Library window. r=kitcambridge,mak
MozReview-Commit-ID: DcEMAlrXu8R
2018-02-16 20:30:04 +00:00
manikishan
02874947cf Bug 1431050 - Replace NS_ASSERT with conditional exceptions/console.assert and remove the debug.js module. r=mak
console.assert keeps the same semantics as NS_ASSERT in that it doesn't throw an exception,
but a lot of the places code was using it in a way that would be better served by throwing
an exception when the condition is false.

MozReview-Commit-ID: DEF5HSfYO36
2018-02-03 11:32:25 +05:30
Marco Bonardo
c03dbb59bd Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8
MozReview-Commit-ID: D7J6hY7Akro
2018-02-28 13:51:28 +01:00
Marco Bonardo
47da5f79b5 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC
2018-02-28 12:10:12 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
8b297fe619 Bug 1434261 - Disable user actions on the places trees not in the library window to avoid accidential/unintentional actions. r=mak
MozReview-Commit-ID: ILo09hwWRsZ
2018-02-21 17:51:23 +00:00
Mark Banner
7b945e40de Bug 1423896 - Make the new All Bookmarks folder query only update on the mobile folder status change for better performance. r=mak
MozReview-Commit-ID: 4sIR6d0ZabJ
2018-02-05 17:19:26 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
e6086011ae Bug 1423896 - Make the new All Bookmarks folder query only update on the mobile folder status change for better performance. r=mak
MozReview-Commit-ID: 4sIR6d0ZabJ
2018-02-05 17:19:26 +00:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
dbe8b88641 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak
MozReview-Commit-ID: 9EKNvA8Q9jo
2018-01-22 13:36:41 +00:00
Marco Bonardo
e312491935 Bug 1428342 - Make Places queries directly inherit options from their parent. r=standard8
Rather then trying to guess options from the parent or the root node, make query nodes directly
inherit some options from their parent.

MozReview-Commit-ID: 1YgDjrrMqGY
2017-12-14 10:06:37 -06:00
Mark Banner
a2e7e2b0da Bug 517719 - Remove unnecessary nsINavHistoryResultTreeViewer interface. r=mak
MozReview-Commit-ID: E7TyD4o8dSK
2018-01-19 17:27:48 +00:00
Tim Nguyen
0f11886f22 Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao
MozReview-Commit-ID: 3hydkeoneC0
2018-01-18 10:36:05 +00:00
Zibi Braniecki
20c66877f9 Bug 1428172 - Align mozIntl with Intl when working with constructors. r=nalexander
MozReview-Commit-ID: 5jGk1jXKkay
2018-01-04 13:01:43 -08:00
Mark Banner
087063908b Bug 1428040 - Allow PlacesUtils.isRootItem to take guids as well as ids. r=mak
MozReview-Commit-ID: 9ZMA2A879O8
2017-12-21 09:16:48 +00:00
Mark Banner
ad0aef3c26 Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak
MozReview-Commit-ID: 2Q1rIpIhmmM
2017-11-02 10:37:14 +00:00
Marco Bonardo
dcbda9bca0 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Sebastian Hengst
7a15678a21 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 2017-10-17 00:55:53 +02:00
Marco Bonardo
6652796654 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Mark Banner
a37a0a7508 Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak
MozReview-Commit-ID: HpN0v0jSwdK
2017-09-27 15:26:35 +01:00
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8
MozReview-Commit-ID: 2pSbYtPGtYx
2017-08-03 12:16:36 +02:00
Marco Bonardo
a90abdc771 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8
MozReview-Commit-ID: 7vli02K19bt
2017-07-18 19:18:02 +02:00
Mark Banner
4f4a9acb16 Bug 1376925 - In the bookmarks folder tree of the edit dialog, don't invalidate elements whilst we are editing. Also improve the stability of browser_bookmarksProperties.js. r=mak
MozReview-Commit-ID: IRDgLVACMxG
2017-07-04 14:27:44 +01:00
MilindL
1dd6c0123c Bug 1107364 - remove findNodeByDetails and maintain a map to fetch a node by details speedily, r=mak
This patch removes the interface/header/implementation.

This adds a Map to PlacesTreeView to maintain the relation between node
details and the nodes, based on changes in `this._rows` or on
node details changed events. The Map exists from node details
to nodes (not rows).

MozReview-Commit-ID: EUNiXNIB5rN
2017-06-08 20:51:51 +05:30
Paolo Amadini
7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
milindl
43d5bef69e Bug 1368754 - fix consumers which wait for NodeHistoryDetailsChanged/NodeURIChanged to be called to use node for new values, r=mak
Updated time, access count and uri can be accessed using the node passed to the method.
There is no need to access the other arguments, which contain the old values of the
quantities changed.

MozReview-Commit-ID: 3WEwAs8gQ0w
2017-05-30 23:51:09 +05:30
Marco Bonardo
800b491d50 Bug 1356440 - Favicons of bookmarks views don't update on visit. r=mrbkap,past,enndeakin
MozReview-Commit-ID: 8j5yLqr7MTc
2017-04-19 11:41:49 +02:00