corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
902,050 Commits 1 Branch 0 Tags
2e7c7849b7776d91b9aaa5e207ff96175655dccf
Commit Graph

58 Commits

Author SHA1 Message Date
Vasish Baungally
2e7c7849b7 Bug 1956073 - Add Opt-in & additional telemetry for Smart Tab Grouping r=rrando,dwalker,tabbrowser-reviewers 
- Telemetry for opt-in
     - For each onboarding step
- Telemetry updates for existing
     - Clicking away with ML group name without explicitly clicking "done" or "cancel"
     - When there are no suggestions for "suggest other tabs"
     - Add group id to ml telemetry
     - Move stg telemetry under tab group telemetry
     - Remove num_ from events

Differential Revision: https://phabricator.services.mozilla.com/D242784
 2025-03-26 15:41:49 +00:00
Stephen Thompson
78282be03c Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers 
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
 2025-03-25 21:16:37 +00:00
Rolf Rando
6457c1eed4 Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod 
Differential Revision: https://phabricator.services.mozilla.com/D241922
 2025-03-23 04:03:31 +00:00
Nick Grato
a637f54059 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones 
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
 2025-03-21 16:03:03 +00:00
Francesco Lodolo (:flod)
2dc7e3ee3a Bug 1955573 - Don't generate Fluent IDs at run-time for Tab Group colors, r=tabbrowser-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D242520
 2025-03-21 15:33:38 +00:00
Butkovits Atila
a1232f30d3 Backed out changeset e2836c2d1f98 (bug 1951524) for causing failures at browser_all_files_referenced.js. 2025-03-21 08:37:42 +02:00
Nick Grato
2a66d14721 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones 
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
 2025-03-21 03:23:11 +00:00
Sandor Molnar
53925bf70d Backed out changeset 272d0dd8b6a7 (bug 1954648) for causing bc failures @ browser_experimental_features.js 2025-03-19 23:36:30 +02:00
Rolf Rando
07417b054d Bug 1954648 - Smart Tab Group settings in Preferences->Tabs r=ngrato,fluent-reviewers,settings-reviewers,tabbrowser-reviewers,dwalker,flod 
Differential Revision: https://phabricator.services.mozilla.com/D241922
 2025-03-19 17:14:19 +00:00
Nick Grato
207d8697bf Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao 
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
 2025-03-06 15:38:51 +00:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D240479
 2025-03-06 13:18:26 +00:00
Butkovits Atila
b6264adeb4 Backed out changeset 79e3d8d9befa (bug 1949808) for causing failures at browser_tab_grouping_telemetry.js. CLOSED TREE 2025-03-06 13:53:35 +02:00
Nick Grato
be9d852d84 Bug 1949808 - Prevent smart tab topic output from replacing group label if user starts typing r=vazish,tabbrowser-reviewers,dao 
adding additional check before populating input

Differential Revision: https://phabricator.services.mozilla.com/D240223
 2025-03-06 10:30:44 +00:00
Nick Grato
43e8b7b8e6 Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers 
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
 2025-03-04 17:49:34 +00:00
Gijs Kruitbosch
dcb8be8cff Bug 1950871 - switch browser/components/tabbrowser to use moz-src, r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239926
 2025-03-03 12:47:49 +00:00
Butkovits Atila
d22beded8a Backed out changeset 130ec750949d (bug 1949590) for causing Lint failures. CLOSED TREE 2025-02-22 01:51:44 +02:00
Nick Grato
3553e3994e Bug 1949590 - STG pref need to be watched to update UI not just on init r=vazish,tabbrowser-reviewers 
adding a watcher to the lazy pref getter

Differential Revision: https://phabricator.services.mozilla.com/D239187
 2025-02-21 23:03:55 +00:00
Vasish Baungally
7f96278c2f Bug 1949010 - Add Glean Metrics for Smart Tab Grouping. r=rrando,ngrato,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238803
 2025-02-21 21:29:47 +00:00
Vasish Baungally
45db6f6e22 Bug 1949274 - Fix default tab group actions for Smart Tab Groups r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D238818
 2025-02-19 22:04:14 +00:00
Nick Grato
37d617a207 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-18 18:45:45 +00:00
Stanca Serban
24a38fdf6a Backed out changeset 7dac3dae07a0 (bug 1946523) for causing mochitests failures in browser_startup_images.js. 2025-02-15 23:17:28 +02:00
Nick Grato
9f4d386cb1 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-15 16:18:57 +00:00
Alexandru Marc
785a1b0b4c Backed out 2 changesets (bug 1946523) for causing bc failures @ browser_startup_images.js CLOSED TREE 
Backed out changeset f42c3c3bcfd9 (bug 1946523)
Backed out changeset 3dae4114d6ac (bug 1946523)
 2025-02-15 12:34:09 +02:00
Nick Grato
10159f4959 Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-15 05:04:46 +00:00
Goloman Adrian
eb3e8e70f1 Backed out changeset 7bc709851769 (bug 1946523) for causing bc failures @browser_parsable_css.js. 2025-02-15 03:33:36 +02:00
Nick Grato
a80b3b326c Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-15 00:53:01 +00:00
Goloman Adrian
d7633e63e5 Backed out changeset bcbeff80890c (bug 1946523) for causing bc failures @browser_tab_groups_a11y.js. CLOSED TREE 2025-02-15 02:39:16 +02:00
Nick Grato
6cf0bc44df Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-14 23:37:56 +00:00
Jeremy Swinarton
566b514ef6 Bug 1946761: Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237588
 2025-02-11 13:43:27 +00:00
Nick Grato
7f9c942b8d Bug 1945223 - Browser Pref for Smart Tab Grouping r=tabbrowser-reviewers,dao 
Add a feature flag for turning on/off the UI for smart tab grouping. Updating formatting for the HTML. Due to the use of XUL the html has no syntax highlighting and is extremely difficult to read when not formatted vertically. More UI is comming and this helps pave the way for a more readable file.

Differential Revision: https://phabricator.services.mozilla.com/D236383
 2025-02-05 18:25:34 +00:00
Nick Grato
00132688f5 Bug 1944154 - State Machine for tab states r=tabbrowser-reviewers,dao 
To prep for the transition of code migrating from Larch to Central, for STG (Smart Tab Grouping), the best technique would be to implement peace by peace not to overwhelm a single patch.

This bug is the beginning of said work by setting the ground work for the state machine that manages the many additional states used by the STG feature.

Differential Revision: https://phabricator.services.mozilla.com/D235712
 2025-02-03 18:11:17 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn 
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
 2025-01-29 19:09:19 +00:00
Dão Gottwald
5e253e3ce8 Bug 1944083 - Clicking outside the tab group create panel should keep the new group. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235667
 2025-01-28 11:39:14 +00:00
Dão Gottwald
f32e1c5b18 Bug 1943635 - Set tooltips on color options in the tab group panel. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D235464
 2025-01-24 23:27:41 +00:00
Dão Gottwald
ff3720f743 Bug 1942170 - Properly label tab group color radio buttons. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D234965
 2025-01-22 12:45:40 +00:00
Dão Gottwald
f88b753dc2 Bug 1942156 - Fix tab group dialog's role and name. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234954
 2025-01-21 15:23:55 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234505
 2025-01-17 14:46:24 +00:00
Dão Gottwald
83741f2f76 Bug 1940740 - Dispatch event when accepting the tab group creation panel. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233663
 2025-01-09 14:58:03 +00:00
Dão Gottwald
1a4c207141 Bug 1939677 - Correctly add toolbarbuttons to TAB key order. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233089
 2025-01-03 17:34:14 +00:00
Dão Gottwald
e9e9d3a05a Bug 1926254 - Esc key should cancel rather than accept the tab group create panel. r=sthompson,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233185
 2025-01-03 17:15:50 +00:00
Dão Gottwald
3336bd457a Bug 1937203 - Tab group panel should close when expanding/collapsing a group. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232657
 2024-12-19 20:30:41 +00:00
Dão Gottwald
5cae56eb21 Bug 1933547 - Adjust group menu position for vertical tabs. r=tabbrowser-reviewers,jswinarton 
Basically copied this from TabHoverPreviewPanel::#popupOptions.

Differential Revision: https://phabricator.services.mozilla.com/D230399
 2024-11-28 15:15:43 +00:00
Dão Gottwald
3245dd9a52 Bug 1928189 - Let Firefox View show tabs from collapsed groups. r=sthompson,fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D229896
 2024-11-26 16:45:56 +00:00
DJ
7da91bc6c5 Bug 1923652 - enable save & close for tab groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D229721
 2024-11-22 16:46:19 +00:00
Dão Gottwald
304c11a239 Bug 1923653 - tab group UI: enable "delete group". r=tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D229507
 2024-11-21 11:56:31 +00:00
Cosmin Sabou
48f9c79723 Backed out changeset ffc3435411be (bug 1923653) for causing mass test failures. 2024-11-20 20:32:20 +02:00
Dão Gottwald
05669b79ee Bug 1923653 - tab group UI: enable "delete group". r=tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D229507
 2024-11-20 16:51:30 +00:00
Dão Gottwald
574d406c84 Bug 1931370 - Rename "Add tab to group" to "New tab in group". r=dwalker,fluent-reviewers,tabbrowser-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D229123
 2024-11-15 14:38:52 +00:00
DJ
181219c0f1 Bug 1923651 - implement "move group to new window" in tabgroup edit menu. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226325
 2024-10-31 15:01:07 +00:00
Dão Gottwald
387c997901 Bug 1926248 - Opening the tab group create or edit panel should focus the name field, and Enter should close the panel. r=sthompson,jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D226455
 2024-10-22 15:50:24 +00:00