corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
448,906 Commits 1 Branch 0 Tags
2d4bfac20e46e11f70cc9335b86bd901b8aad6ea
Commit Graph

33 Commits

Author SHA1 Message Date
Sylvestre Ledru
0f65f2ab6c Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
79a067af86 Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
1672d883a9 Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
a15f1c5d08 Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Wes Kocher
b620596e75 Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout CLOSED TREE 
Backed out changeset a3fe53641526 (bug 1318004)
Backed out changeset a5d1676b6f88 (bug 1318004)
Backed out changeset b56b37f0f4d7 (bug 1318004)
Backed out changeset fb5254baf1cb (bug 1318004)
 2016-11-21 16:15:38 -08:00
Sylvestre Ledru
7ccbd595c5 Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
b48ac2ed6f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
9851572dbc Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
eaf1a1bb8c Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Wes Kocher
13642ca8af Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout 
Backed out changeset 6995bd33872b (bug 1318004)
Backed out changeset 9be5c856bc78 (bug 1318004)
Backed out changeset 365b0b7f289a (bug 1318004)
Backed out changeset 2f2ebf176eac (bug 1318004)
 2016-11-21 12:23:17 -08:00
Sylvestre Ledru
ea83e5e8bd Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
9fbcdd2d4f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
057d135c4c Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
c30faf12df Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
 2016-09-02 17:12:24 +10:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
 2016-08-24 14:47:04 +08:00
Chris Peterson
c35faf4632 Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj 2016-07-08 14:39:53 -07:00
Alessio Placitelli
38c5e57c95 Bug 1242084 - nsTerminator::UpdateTelemetry() leaks 8 byte nsStringBuffer when app.update.channel gets set to Beta. r=gfritzsche 2016-03-14 06:12:00 +01:00
David Rajchenbach-Teller
1cbb83de61 Bug 1252382 - Get rid of PR_Sleep in the terminator;r=froydnj 
The terminator currently makes use of PR_Sleep. As it turns out, late
in shutdown, this can cause infinite recursions and finally exit(-11) . This
patch replaces PR_Sleep with usleep(3) and Sleep().

MozReview-Commit-ID: 3SybinpQUVl
 2016-03-01 09:01:22 +01:00
Timur Valeev
9a6e557701 Bug 1232285 - The Terminator's notion of ticks is incorrect. r=Yoric 2015-12-22 10:32:00 +03:00
Birunthan Mohanathas
ac37dec517 Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Birunthan Mohanathas
a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
 2015-07-13 08:25:42 -07:00
Alessio Placitelli
bc31318d43 Bug 1134279 - Change Telemetry data producers to use the correct recording flags. r=vladan 2015-03-23 04:39:00 +01:00
Ehsan Akhgari
6ef7b88a88 Bug 1109746 - Fix more bad implicit constructors in some random code across the tree 2014-12-13 14:17:04 -05:00
David Rajchenbach-Teller
2823529631 Bug 1044020 - Add duration of shutdown phases to Telemetry. r=froydnj 2014-11-10 13:58:14 +01:00
Chris Peterson
f4d98cf41a Bug 1095878 - Fix -Wunused-variable warning in toolkit/components/terminator and mark as FAIL_ON_WARNINGS. r=froydnj 2014-11-01 12:16:27 -07:00
Wes Kocher
68a29c45b1 Backed out 2 changesets (bug 1044020) for xpcshell-2 permaorange on b2g desktop a=backout 
Backed out changeset 7cbdd8fc831c (bug 1044020)
Backed out changeset 4f9d8d2279e9 (bug 1044020)
 2014-11-06 16:56:03 -08:00
David Rajchenbach-Teller
f8186b9009 Bug 1044020 - Add duration of shutdown phases to Telemetry. r=froydnj 2014-10-21 13:12:15 +02:00
Ed Morley
0bc7871e05 Backed out changeset 0ec9bd8e9880 (bug 1044020) for asan failures 2014-09-30 17:35:44 +01:00
David Rajchenbach-Teller
1f81e703df Bug 1044020 - Add the duration of shutdown phases to Telemetry. r=froydnj 2014-09-30 11:43:46 +02:00
Ed Morley
8f1f45ab44 Backed out changeset 49b1465d3e5e (bug 1044020) for compilation failures 2014-09-29 15:41:54 +01:00
David Rajchenbach-Teller
5d72e87593 Bug 1044020 - Add the duration of shutdown phases to Telemetry. r=froydnj 2014-09-25 17:19:34 +02:00
David Rajchenbach-Teller
eedde0ff80 Bug 1038342 - Add a Shutdown watchdog. r=froydnj, r=ted, sr=bsmedberg 2014-08-26 14:54:43 +02:00