Commit Graph

5 Commits

Author SHA1 Message Date
Mike Conley
466a772cdb Bug 1296638 - Make Form Autocomplete popup use a richlistbox instead of a tree. r=MattN
MozReview-Commit-ID: 6ybBqAwxlmb
2016-08-19 17:15:56 -04:00
Mike Conley
cae7deca5e Bug 1296638 - AutoCompletePopup in browser-content.js and AutoCompletePopup.jsm need to have popupOpen be in sync. r=MattN
The opening of the AutoCompletePopup will always start from content, but closing the
popup can occur in the parent (for example, if the user switches focus from the browser),
or in content (the user hits Esc, for example, which tells the parent to close the popup).

This relationship between content and the popup has been true for a while, but the
patch in bug 1294502 didn't account for it. In particular, before this patch, it was
possible for AutoCompletePopup in browser-content.js and AutoCompletePopup.jsm to get
out of sync on whether or not the popup is open.

Mainly, this is because the parent wasn't telling the content that the popup had
hidden if the hide was initialized by the parent. The other reason, was because
the popupOpen state in browser-content.js was being set immediately, instead
of waiting for the parent to report that the popup had indeed opened or closed.

MozReview-Commit-ID: CRkg49lP1Hd
2016-09-17 12:44:04 -04:00
Jonathan Kingston
638b77683a Bug 1305050 - Removing chrome error in deleting password autocomplete and improving testing to catch issues. r=MattN,mconley
MozReview-Commit-ID: JEX5gly6bTA
2016-10-05 00:27:19 +01:00
Mike Conley
1d8e575221 Bug 1298204 - Make sure the form autocomplete popup tree gets updated when invalidated. r=MattN
Bug 1294502 recently refactored the form autocomplete code to
combine the e10s and non-e10s mechanisms. The new combined
mechanism works using something mostly similar to what we
used for e10s, except that we forgot to re-set the nsITreeView
when the autocomplete results are invalidated.

MozReview-Commit-ID: 4veXklEgLGl
2016-08-30 22:57:26 -04:00
Mike Conley
9db9ea2cff Bug 1294502 - Use the same AutoCompletePopup logic for e10s and non-e10s. r=MattN
MozReview-Commit-ID: B0QQLEn3yS
2016-08-18 10:50:58 -04:00