Commit Graph

43 Commits

Author SHA1 Message Date
Andi-Bogdan Postelnicu
c9d74fd535 Bug 1319408 - Replace integer literals which are cast to bool in embedding/. r=myk
MozReview-Commit-ID: 3PLvkLGG45T
2016-11-22 14:57:41 +02:00
Andi-Bogdan Postelnicu
9104429c68 Bug 1319408 - Replace default bodies of special member functions with = default; in embedding/. r=myk
MozReview-Commit-ID: HUOfzBiwxBB
2016-11-22 14:56:19 +02:00
Andi-Bogdan Postelnicu
93d7327cd6 Bug 1319408 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in embedding/. r=myk
MozReview-Commit-ID: GJSRXaQCDXS
2016-11-22 14:55:44 +02:00
Eric Rahm
6ba6ab16cc Bug 1315812 - Mark nsISupportsArray, nsICollection, nsIEnumerator as deprecated. r=froydnj
This marks the idl classes as deprecated, removes an unnecessary include that
was triggering deprecation warnings and wraps a necessary include in
XPCOMInit.cpp that is used for registering the component in deprecation
disabling pragmas.

MozReview-Commit-ID: BbNU5q8O4Q4
2016-11-10 13:15:33 -08:00
Nicholas Nethercote
392da94467 Bug 1297300 - Add missing checks to GetSpec() calls in embedding/. r=bz. 2016-08-31 09:08:52 +10:00
Michael Layzell
d32dafff26 Bug 1018486 - Part 8: Various other changes, r=smaug
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
Nicholas Nethercote
887efe04d5 Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Paul Bignier
cf23868402 Bug 1289757 - [Uninitialized scalar field] In constructor nsWebBrowserPersist(). r=mconley
* Only pushing this file because it's the only "Uninitialized scalar field" defect in the "embedding" module that is fixed that way.
2016-07-27 05:12:00 +02:00
Christoph Kerschbaumer
9707ba1a13 Bug 1282554 - Provide helper function to check if channel can be openen using open2() and asyncOpen2() r=bholly 2016-06-28 19:03:56 +02:00
Jonathan Watt
9c5b8de022 Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Andrea Marchesini
ec48e677ef Bug 1272298 - nsFormSubmission should support "\0" input string, r=smaug 2016-05-13 22:48:03 +02:00
Philip Chee
785d1d67eb Bug 1269412 - In nsWebBrowserPersist::EndDownload set mCompleted = true before issuing the state stop notification r=jld 2016-05-06 03:54:11 +08:00
Kyle Huey
b972c94d0f Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-05-05 01:45:00 -07:00
Carsten "Tomcat" Book
aadd508ffe Backed out changeset 85ce8cb0639a (bug 1268313) 2016-04-29 14:21:16 +02:00
Kyle Huey
e62a0823c9 Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj 2016-04-28 14:08:25 -07:00
Daniel Holbert
a55da3acce Bug 1247866: Avoid modifying hashtable during iteration, when iterating over redirects for saved files, to avoid tripping fatal assertion. r=njn
Modifying a structure while iterating over it is generally dangerous (so we have assertions to catch it), though in this case it was probably fine, because we stopped iterating as soon as we made the modification.
2016-02-12 16:19:53 -08:00
Nicholas Nethercote
278662f322 Bug 1186794 (part 6) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz. 2015-11-01 18:42:54 -08:00
Nicholas Nethercote
0ec1e1da90 Bug 1186794 (part 5) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz. 2015-11-01 18:42:41 -08:00
Nicholas Nethercote
4bf06c85ee Bug 1186794 (part 4) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz. 2015-11-01 18:42:28 -08:00
Nicholas Nethercote
e4966ebfee Bug 1186794 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz. 2015-11-01 18:42:08 -08:00
Nicholas Nethercote
5651e6aaa3 Bug 1186794 (part 2) - Replace nsBaseHashtable::EnumerateRead() calls in embedding/ with iterators. r=bz. 2015-11-01 18:41:57 -08:00
Birunthan Mohanathas
d382a21947 Bug 1217320 - Remove more XPIDL signature comments in .cpp files. r=froydnj
Comment-only, DONTBUILD.
2015-10-27 06:54:25 +02:00
Nathan Froyd
4e6d8f6705 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Jed Davis
38fdb3cf3b Bug 1207864 - Fix nsWebBrowserPersist's onStateChange callback in error cases. r=billm 2015-10-07 12:49:53 -07:00
Christoph Kerschbaumer
1320eb4095 Bug 1206146 - Use channel->AsyncOpen2() in embedding/components/webbrowserpersist/nsWebBrowserPersist.cpp (r=sicking) 2015-09-19 20:24:39 -07:00
john
0fac331ec7 Bug 236989 - Ensure persisted subdocuments correctly fixup relative links. r=bzbarsky
The URI of the document being serialized must be taken into account within
GetLocalURI on URIData. This method previously returned its path relative to
the document in which it is first visited, resulting in a bug when subdocuments
stored in different locations also linked to it. By passing in mTargetBaseURI
GetLocalURI can ensure it is returning a path relative to the document
currently being serialized.
2015-09-02 23:53:38 -07:00
Jed Davis
7db4b75058 Bug 1192654 - Fix nsWebBrowserPersist handling of nonpersistable subdocuments. r=billm
The patch for bug 1101100, in converting this code to be asynchronous
and distributed, accidentally dropped the check for `data` being null;
this patch restores it, and adds a regression test.
2015-08-13 08:38:19 -07:00
Jed Davis
e32b5dab07 Bug 1101100 - Multiprocess-enable nsWebBrowserPersist. r=billm
The high-level overview is that the parts of nsWebBrowserPersist which
access the DOM have been factored out (as WebBrowserPersistLocalDocument)
and abstracted (nsIWebBrowserPersistDocument) such that they can be
implemented in the cross-process case using IPC.
2015-08-05 14:25:39 -07:00
Birunthan Mohanathas
a0f7c73250 Bug 1191100 - Remove XPIDL signature comments in .cpp files. r=ehsan
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Jed Davis
98826d7fe0 Bug 1179967 - Always rewrite links to absolute in nsWebBrowserPersist instead of side-effecting document. r=jst 2015-07-15 12:15:48 -07:00
Emanuel Hoogeveen
b30abdc582 Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell 2015-07-07 04:17:00 +02:00
Jed Davis
cccc0585cd Bug 1170334 - Re-escape entities in nsWebBrowserPersist XML stylesheet handling. r=hsivonen 2015-06-10 18:33:00 +02:00
Michal Novotny
6ebc2c926a Bug 1156493 - e10s: move .cacheKey to nsICacheInfoChannel so child channels can get/set it, r=jduell 2015-05-10 02:26:39 +02:00
Andrew McCreight
776b608244 Bug 1155765 - Get rid of gratuitous goto from nsWebBrowserPersist::MakeFilenameFromURI(). r=smaug 2015-04-17 15:22:00 +02:00
Andrea Marchesini
6b10d5e43e Bug 1134280 - Get rid of Tag() - patch 1 - Is{HTML,XUL,MathML,SVG}Element and IsAnyOf{HTML,XUL,MathML,SVG}Elements, r=smaug 2015-03-03 11:08:59 +00:00
Christoph Kerschbaumer
eaea5361d1 Bug 1099296 - Attach LoadInfo to remaining callers of ioService and ProtocolHandlers - in embedding/ (r=bsmedberg) 2015-02-17 10:09:08 -08:00
Patrick McManus
c870cb3fa4 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz
These scriptable interfaces use uint_64 arguments with sentinel values
of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot
be gatewayed to/from javascript - so they cannot be used
correctly. Change them to use signed 64 bit numbers and -1 as the
sentinnel. C++ implementations ought to be enough to audit as the
special value could never be used correctly in JS anyhow - also
audited OnProgressChange() uses for downstream use of this data.
---
 dom/base/nsXMLHttpRequest.cpp                      | 19 +++++++----
 dom/base/nsXMLHttpRequest.h                        | 10 +++---
 dom/plugins/base/nsPluginStreamListenerPeer.cpp    |  4 +--
 .../webbrowserpersist/nsWebBrowserPersist.cpp      | 14 ++++----
 image/src/imgLoader.cpp                            |  4 +--
 modules/libjar/nsJARChannel.cpp                    |  3 +-
 netwerk/base/public/nsIProgressEventSink.idl       |  8 ++---
 netwerk/base/public/nsITransport.idl               |  8 ++---
 netwerk/base/public/nsNetUtil.h                    | 24 ++++++++++++++
 netwerk/base/src/Dashboard.cpp                     |  2 +-
 netwerk/base/src/nsBaseChannel.cpp                 | 12 +++----
 netwerk/base/src/nsIncrementalDownload.cpp         |  4 +--
 netwerk/base/src/nsSocketTransport2.cpp            |  5 +--
 netwerk/base/src/nsStreamTransportService.cpp      | 38 +++++++++++++---------
 netwerk/base/src/nsTransportUtils.cpp              | 12 +++----
 netwerk/protocol/file/nsFileChannel.cpp            |  8 +++--
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  4 +--
 netwerk/protocol/http/Http2Push.cpp                |  2 +-
 netwerk/protocol/http/Http2Session.cpp             |  2 +-
 netwerk/protocol/http/HttpChannelChild.cpp         | 31 +++++++++---------
 netwerk/protocol/http/HttpChannelChild.h           |  6 ++--
 netwerk/protocol/http/HttpChannelParent.cpp        |  4 +--
 netwerk/protocol/http/HttpChannelParent.h          |  4 +--
 netwerk/protocol/http/NullHttpTransaction.cpp      |  2 +-
 netwerk/protocol/http/PHttpChannel.ipdl            |  2 +-
 netwerk/protocol/http/SpdyPush31.cpp               |  2 +-
 netwerk/protocol/http/SpdySession31.cpp            |  2 +-
 netwerk/protocol/http/TunnelUtils.cpp              |  2 +-
 netwerk/protocol/http/nsAHttpTransaction.h         |  4 +--
 netwerk/protocol/http/nsHttpChannel.cpp            | 30 +++++++++++------
 netwerk/protocol/http/nsHttpConnection.cpp         |  4 +--
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  4 +--
 netwerk/protocol/http/nsHttpPipeline.cpp           |  4 +--
 netwerk/protocol/http/nsHttpPipeline.h             |  6 ++--
 netwerk/protocol/http/nsHttpResponseHead.cpp       |  2 +-
 netwerk/protocol/http/nsHttpResponseHead.h         |  2 +-
 netwerk/protocol/http/nsHttpTransaction.cpp        | 32 +++++++++---------
 netwerk/protocol/http/nsHttpTransaction.h          |  2 +-
 netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp   |  2 +-
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  3 +-
 netwerk/test/TestIncrementalDownload.cpp           |  7 ++--
 uriloader/base/nsDocLoader.cpp                     | 14 ++++----
 42 files changed, 203 insertions(+), 151 deletions(-)
2015-01-08 14:48:52 -05:00
Sid Stamm
7327eccdb3 Bug 704320 - Add referrer policy support for nsIWebBrowserPersist and its consumers. (r=jst) 2014-11-18 08:47:14 -05:00
Blake Kaplan
1bd13f9ab8 Bug 1049299 - Correctly calculate 3rd-party cookie status for content-process HTTP channels. r=jduell 2014-10-28 14:23:00 +01:00
Christoph Kerschbaumer
17e43a4437 Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst) 2014-10-15 19:11:45 -07:00
Christoph Kerschbaumer
5786da257e Bug 1038756: Callsites creating a channel in /embedding/ (r=bz) 2014-09-21 09:46:16 -07:00
Ehsan Akhgari
276d45afcd Bug 1061059 - Fix more bad implicit constructors in embedding; r=bsmedberg 2014-09-02 18:22:57 -04:00
Birunthan Mohanathas
dbfed04531 Bug 1054703 - Part 6: Flatten embedding/components/webbrowserpersist/{public,src}/ into parent directory. r=bsmedberg 2014-08-20 10:27:17 -07:00