Commit Graph

604 Commits

Author SHA1 Message Date
Gijs Kruitbosch
898e262c96 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak
MozReview-Commit-ID: FVy2MMpvV65
2016-12-20 22:49:05 +00:00
Gijs Kruitbosch
a9c9eea221 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7c7e220663 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
e6f654cf66 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X
2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
e5b59d7fbd Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Sebastian Hengst
e906b9416f Backed out changeset 61029bd1995a (bug 1285577) for failing test_autofill_https_upgrade.html at least on Linux. r=backout 2016-12-20 22:56:02 +01:00
Sebastian Hengst
13307cb1ae Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00
Sebastian Hengst
5148a28841 Backed out changeset 78a3cd5bf313 (bug 1285577) 2016-12-20 22:54:31 +01:00
Sebastian Hengst
0d72a880f2 Backed out changeset 10388e609fe3 (bug 1285577) 2016-12-20 22:54:26 +01:00
Sebastian Hengst
cea8d53329 Backed out changeset 1ffe78f2ab5a (bug 1285577) 2016-12-20 22:53:48 +01:00
Sebastian Hengst
1567d13434 Backed out changeset e66794fae8f7 (bug 1285577) 2016-12-20 22:53:30 +01:00
Gijs Kruitbosch
9f204aa4f0 Bug 1285577 - followup: Fix eslint complaining about unused vars and spaces, rs=bustage a=bustage
MozReview-Commit-ID: KtjRdtulyLN
2016-12-20 19:56:54 +00:00
Gijs Kruitbosch
a71437c514 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak
MozReview-Commit-ID: FVy2MMpvV65
2016-12-19 21:56:20 +00:00
Gijs Kruitbosch
362bb9cc96 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak
MozReview-Commit-ID: 7HCA7cKhws4
2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
95acef5be1 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN
MozReview-Commit-ID: JZbOkmZ7ZZG
2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
477f5615db Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak
MozReview-Commit-ID: 8pKlBmDVX5X
2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
c8e3816d11 Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Gijs Kruitbosch
b3e435695e Bug 1122124 - fix default profile setting after reset, keep profile name, r=MattN
MozReview-Commit-ID: 9h1ktdUUVZH
2016-05-10 10:09:46 +01:00
Henrik Skupin
620e1de054 Bug 1320073 - Rename marionette-client to marionette-harness and release version 4.0.0. r=gps,maja_zf,mtseng,SingingTree
MozReview-Commit-ID: L6V3b5h8RWm
2016-12-12 13:05:34 +01:00
Gijs Kruitbosch
1b441533b6 Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB
2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
1329c154ed Bug 1319788 - fix typo in getting a telemetry histogram, r=mak
MozReview-Commit-ID: 22CFX0Ueo1q
2016-11-23 14:47:55 +00:00
Wes Kocher
390c1f407f Merge inbound to m-c a=merge CLOSED TREE 2016-11-16 17:07:26 -08:00
Gijs Kruitbosch
be4f40c56e Bug 1276705 - rm IE/safari settings importers, r=Dolske
MozReview-Commit-ID: 2YcaxJkbTwj
2016-11-14 13:04:06 +00:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
bbe7bf32d1 Bug 1316882: Turn on rest-spread-spacing eslint rule. r=felipe
MozReview-Commit-ID: EbRmrGz1G0a
2016-11-10 15:12:47 -08:00
Dave Townsend
b0f59ac265 Bug 1316882: Turn on func-call-spacing eslint rule. r=bgrins
MozReview-Commit-ID: GIkQnRX9woD
2016-11-10 15:05:32 -08:00
Andrea Marchesini
1f24189283 Bug 1303518 - Remove the chrome only constructor for File, r=qdot 2016-11-11 18:56:44 +01:00
Jared Wein
2dfc7371c2 Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
MozReview-Commit-ID: 2Xuj5nxuQdO
2016-11-08 15:14:19 -05:00
Sebastian Hengst
d1c538318e Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM
MozReview-Commit-ID: LDNr97hKpc8
2016-11-05 11:29:13 +01:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Gijs Kruitbosch
1eb867efaf Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Wes Kocher
5d8f248c21 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
cf59a894b6 Bug 1314237 - detect nightly/devedition as 'firefox' in migration code, r=mikedeboer
MozReview-Commit-ID: 6vQa59i81Gb
2016-11-01 11:57:30 +00:00
Gijs Kruitbosch
f0e91ab90a Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
72cef5f839 Bug 1309617 - add telemetry indicating when we show the 'would you like to undo automigration' notification, r=bsmedberg,Dolske
MozReview-Commit-ID: 7RdDyn9dQNq
2016-10-19 23:10:46 +01:00
Mark Banner
d4b538c2b7 Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree. r=miker
MozReview-Commit-ID: FlbJ8yzWXlw
2016-10-26 09:46:40 +01:00
Eric Rahm
114396aac2 Bug 1308327 - Avoid passing a null value to nsDependentString. r=mak
The internal version of nsDependentString will assert if a null value is
passed in. An empty string should be okay though.

MozReview-Commit-ID: CZYdmsVisrc
2016-10-19 13:02:19 -07:00
Gijs Kruitbosch
bbf79f28ea Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3
2016-10-18 16:03:06 +01:00
Gijs Kruitbosch
ac3e073240 Bug 1309614 - finish initializing places before we import stuff, r=mak
MozReview-Commit-ID: JucE0HjQdwC
2016-10-13 17:02:29 +01:00
Gijs Kruitbosch
474d127fb6 Bug 1310596 - actually import OS.File in the 360se profile migrator code, r=mikedeboer
Also removing a useless console.jsm import from the chrome migrator that I spotted when looking through the changes from bug 1276694

MozReview-Commit-ID: 78qkflg4KWn
2016-10-18 11:55:30 +01:00
Gijs Kruitbosch
4b8d3a7152 Bug 1310596 - do not allow errors in reporting migrator data recency to break the rest of the migration, r=mikedeboer
MozReview-Commit-ID: eWr0abwU7p
2016-10-18 11:54:22 +01:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Gijs Kruitbosch
e195450df1 Bug 1274633 - remove windows 10 welcome page, r=MattN
MozReview-Commit-ID: HI8mqzRmV45
2016-09-28 16:53:46 +01:00
Gijs Kruitbosch
529d9db2c4 Bug 1305770 - make cookies and passwords import from Chrome without locking, r=mak
MozReview-Commit-ID: CbozmZHwAgz
2016-10-03 16:17:06 +01:00
Gijs Kruitbosch
c376eb21e5 Bug 1307382 - fix sync case for automigration undo telemetry, r=markh
MozReview-Commit-ID: GcJw83YnhN6
2016-10-04 10:44:28 +01:00
Enes Goktas
9205ec54b0 Bug 1302855 - Fold browsercomps into xul; r=bsmedberg
MozReview-Commit-ID: 8oaVngXFfh3
2016-09-27 19:54:37 -07:00
Gijs Kruitbosch
8e887a3fe8 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK
2016-09-23 16:27:20 +01:00
Wes Kocher
297b6a4a72 Backed out 3 changesets (bug 1279240) for leaks on Windows VM mochitests a=backout
Backed out changeset 4b69e32e3a83 (bug 1279240)
Backed out changeset d0d5180dc062 (bug 1279240)
Backed out changeset dc1b725b47d4 (bug 1279240)
2016-09-29 17:44:41 -07:00
Gijs Kruitbosch
27c451ade9 Bug 1279240 - use registry key to deduce default browser when possible, r=jaws
MozReview-Commit-ID: 7kDMRrt5JNK
2016-09-23 16:27:20 +01:00