corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
819,564 Commits 1 Branch 0 Tags
2bc2cff6984d62ab22bf2478dbe1b12d4fa320d5
Commit Graph

646 Commits

Author SHA1 Message Date
Cristian Tuns
7a00471ac3 Backed out changeset 4099afcff2be (bug 1881925) for causing gecko decision task failures in browser.toml CLOSED TREE 2024-02-29 16:49:46 -05:00
Joel Maher
e325923409 Bug 1881925 - standardize on more manifest conditions. r=aryx,credential-management-reviewers,devtools-reviewers,dom-storage-reviewers,omc-reviewers,nchevobbe,janv,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D202663
 2024-02-29 21:25:17 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-26 20:06:56 +00:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Mark Banner
82e3203f19 Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in browser window scopes. r=Gijs,extension-reviewers,application-update-reviewers,rpl,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D197486
 2024-01-05 09:22:33 +00:00
Michael Hughes
5ea9a03802 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-12-01 20:07:08 +00:00
Cosmin Sabou
e276c6b6b9 Backed out 2 changesets (bug 1801954, bug 1863980) for bc failures on browser_setDefaultBrowser.js. CLOSED TREE 
Backed out changeset b96506a6d950 (bug 1801954)
Backed out changeset 306a649fcc00 (bug 1863980)
 2023-12-01 02:34:26 +02:00
Michael Hughes
9cc9c079f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers 
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
 2023-11-30 22:22:16 +00:00
Jonathan Watt
61ff6ba12e Bug 1866011 p2. Rename nsIDocShell.contentViewer. r=emilio,credential-management-reviewers,devtools-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D194370
 2023-11-24 09:10:52 +00:00
Mark Banner
68df7c5501 Bug 1861865 - Fix ESLint valid-jsdoc issues in UITour code. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D192161
 2023-11-01 17:20:41 +00:00
Anna Yeddi
6677fcac0f Bug 1854525 - Temporarily fail-if one Tier 2 a11y_checks for Onboarding. r=Mardak 
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.

This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific bug 1854526
- Explore capturing click events for a11y_checks: bug 1692110

Depends on D188921

Differential Revision: https://phabricator.services.mozilla.com/D188922
 2023-10-09 18:20:18 +00:00
Cristian Tuns
896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE 
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
 2023-10-07 14:43:05 -04:00
Anna Yeddi
4480e8eef0 Bug 1854525 - Temporarily disable one Tier 2 a11y_checks for Onboarding. r=Mardak 
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, component-specific bug 1854526
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D188922
 2023-10-06 18:11:36 +00:00
Masatoshi Kimura
8262afb8c6 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 19:00:07 +00:00
Noemi Erli
8561f7ec9a Backed out 3 changesets (bug 1856187, bug 1856100, bug 1856104) for causing newtab failures 
Backed out changeset db28784a1734 (bug 1856187)
Backed out changeset bd11e14dca63 (bug 1856104)
Backed out changeset 2741311b6055 (bug 1856100)
 2023-10-02 21:16:25 +03:00
Masatoshi Kimura
89e9a36583 Bug 1856104 - Remove useless version checks from JavaScript code. r=Gijs,webcompat-reviewers,settings-reviewers,search-reviewers,Standard8,twisniewski 
Differential Revision: https://phabricator.services.mozilla.com/D189696
 2023-10-02 17:36:27 +00:00
Masatoshi Kimura
c2dc436126 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D189678
 2023-10-02 16:56:42 +00:00
Tom Marble
ad50861ef9 Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D188427
 2023-09-21 22:47:07 +00:00
Marco Bonardo
6874dffc71 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE 
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
 2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49 Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao 
This should make a bit clearer that it is only starting the load, not waiting
for its completion.

Differential Revision: https://phabricator.services.mozilla.com/D188213
 2023-09-14 16:33:13 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Harshit Sohaney
2a8d2a4397 Bug 1839240 - Removed hardcoded uitour permissions and added a migration script to reset defaults. r=pbz,Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D182921
 2023-07-26 17:57:44 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Mike Conley
109bfe3289 Bug 1837407 - Workaround UITour default permissions overridden by UNKNOWN_ACTION for SUMO. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D180328
 2023-06-09 16:19:11 +00:00
Mike Conley
09b84fc7a6 Bug 1835105 - Regression test for UITourChild permission check change. r=pbz 
Differential Revision: https://phabricator.services.mozilla.com/D179964
 2023-06-05 15:36:59 +00:00
Mike Conley
95235af915 Bug 1835105 - Use document principal when testing for trusted origins in UITourChild. r=permissions-reviewers,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D179233
 2023-06-05 15:36:59 +00:00
Rob Wu
bad812f243 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski 
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
 2023-06-04 13:44:45 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D177025
 2023-05-20 12:26:49 +00:00
Katherine Patenio
2e593c5af4 Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D178362
 2023-05-18 18:34:51 +00:00
Eemeli Aro
4562dff30c Bug 1831851 - Migrate accounts.properties strings used by browser-sync.js to Fluent. r=sync-reviewers,fluent-reviewers,flod,markh 
Differential Revision: https://phabricator.services.mozilla.com/D177601
 2023-05-11 06:27:41 +00:00
Mike Conley
cec4bc0c94 Bug 1830783 - Allow UITour pages to hear when the FxA sign-in state changes. r=Gijs,markh 
Differential Revision: https://phabricator.services.mozilla.com/D176921
 2023-05-02 17:00:57 +00:00
anwar
1d2e079021 Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D176459
 2023-05-02 16:13:24 +00:00
Mark Banner
85d8bc064f Bug 1826702 - Convert PermissionTestUtils to an ES module. r=permissions-reviewers,settings-reviewers,media-playback-reviewers,pbz,padenot 
Differential Revision: https://phabricator.services.mozilla.com/D174846
 2023-04-06 15:07:56 +00:00
Bilal
28cbc537bd Bug 1816994 - ESMified UITour JSMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D173571
 2023-03-29 17:32:27 +00:00
CanadaHonk
de0de3489c Bug 1801379 - Migrate Sinon.jsm to an ES module r=extension-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,fxview-reviewers,devtools-reviewers,Standard8,nchevobbe,sclements,dimi,mconley,bytesized,robwu 
Migrated `testing/modules/Sinon.sys.mjs` to an ES module.

`testing` should now be 100% ESM 🎉

Differential Revision: https://phabricator.services.mozilla.com/D173643
 2023-03-29 07:34:10 +00:00
Mark Banner
81e5d26ac3 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 16:34:43 +00:00
Cristian Tuns
b9ee007450 Backed out 6 changesets (bug 1816934, bug 1817182, bug 1817179, bug 1817183) for causing dt failures in browser_jsterm_autocomplete_null.js CLOSED TREE 
Backed out changeset 17d4c013ed92 (bug 1817183)
Backed out changeset cfed8d9c23f3 (bug 1817183)
Backed out changeset 62fe2f589efe (bug 1817182)
Backed out changeset 557bd773fb85 (bug 1817179)
Backed out changeset 7f8a7865868b (bug 1816934)
Backed out changeset d6c1d4c0d2a0 (bug 1816934)
 2023-02-17 10:51:33 -05:00
Mark Banner
c8baa7a866 Bug 1817183 - Update consumers of services/fxaccounts to import ES modules directly. r=markh,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D170062
 2023-02-17 09:01:45 +00:00
Joel Maher
417438b9cf Bug 1816191 - Skip tests in order to keep win7 running @ azure. r=gbrown,necko-reviewers,settings-reviewers,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,nalexander,sgalich,alwu 
Differential Revision: https://phabricator.services.mozilla.com/D169523
 2023-02-14 23:44:12 +00:00
Gijs Kruitbosch
a396f8a867 Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato 
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
 2023-02-13 23:50:40 +00:00
Cristina Horotan
f062495d94 Backed out 9 changesets (bug 1810141) for several test failures on a CLOSED TREE 
Backed out changeset 8781a0d1254d (bug 1810141)
Backed out changeset 131037295784 (bug 1810141)
Backed out changeset 3852fbe290f4 (bug 1810141)
Backed out changeset 118f131a524a (bug 1810141)
Backed out changeset ab5d76846e10 (bug 1810141)
Backed out changeset dce3aa683445 (bug 1810141)
Backed out changeset 4dc41d90dbb3 (bug 1810141)
Backed out changeset 50b57ba1a061 (bug 1810141)
Backed out changeset 569de94781e4 (bug 1810141)
 2023-02-13 16:05:30 +02:00
Gijs Kruitbosch
6122444136 Bug 1810141 - fix loadURI callers that already have an nsIURI reference or where creating one is clearly safe, r=mossop,geckoview-reviewers,extension-reviewers,settings-reviewers,mconley,m_kato 
There are 3 types of changes in this commit:

- from `loadURI(foo.spec)` to `loadURI(foo)`, as there's already a URI
- from `loadURI("string")` to `loadURI(Services.io.newURI("string"))` as the URL is hardcoded
- one or two where there is perhaps an intermediate variable but the patch
  context should still make it trivial to ascertain the change is correct.

Depends on D168393

Differential Revision: https://phabricator.services.mozilla.com/D168394
 2023-02-13 12:55:24 +00:00