corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
819,564 Commits 1 Branch 0 Tags
2bc2cff6984d62ab22bf2478dbe1b12d4fa320d5
Commit Graph

66 Commits

Author SHA1 Message Date
Niklas Baumgardner
4a088b2a9e Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D198467
 2024-02-14 15:16:12 +00:00
Niklas Baumgardner
bb40d6b5a8 Bug 1791086 - Select elements within iframes in screenshots. r=sfoster,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D195165
 2024-02-09 22:02:51 +00:00
Niklas Baumgardner
d4bf26d83f Bug 1878141 - Move focus by key in screenshots. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D200381
 2024-02-06 14:37:21 +00:00
Iulian Moraru
0f47785cac Backed out changeset 4726abbc0c2c (bug 1874026) for causing multiple frequent bc failures. CLOSED TREE 2024-02-02 21:23:59 +02:00
Niklas Baumgardner
6b3e9794e8 Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D198467
 2024-02-02 14:16:53 +00:00
Niklas Baumgardner
1b14ee1867 Bug 1874380 - Fix HCM for screenshots initial state. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D198868
 2024-02-01 22:10:12 +00:00
Cristian Tuns
e2d969d64e Backed out changeset e1b248076131 (bug 1874026) for causing bc failures in browser_test_resize.js CLOSED TREE 2024-01-30 17:16:32 -05:00
Niklas Baumgardner
3f4770864a Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D198467
 2024-01-30 21:30:04 +00:00
Niklas Baumgardner
9b5daf0abd Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 22:08:30 +00:00
Natalia Csoregi
eb2e3cf8cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
729c5b4066 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-19 00:07:46 +00:00
Iulian Moraru
e1d66150c9 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00
Niklas Baumgardner
6dd5c4f60b Bug 1867644 - Focus last used button for screenshots UI. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D197348
 2024-01-18 17:47:54 +00:00
Niklas Baumgardner
4dcf953f2c Bug 1873977 - Reset hover element region when retrying screenshot. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198202
 2024-01-17 16:17:42 +00:00
Niklas Baumgardner
92d29713f0 Bug 1873882 - Canceling screenshots selected state should go to crosshairs state. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198468
 2024-01-17 01:18:08 +00:00
Niklas Baumgardner
929276bfad Bug 1872764 - Screenshots should always get events. r=sfoster,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D197802
 2024-01-12 02:24:43 +00:00
Niklas Baumgardner
cfe93676db Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-12-01 16:07:25 +00:00
Stanca Serban
64e390b1b0 Backed out changeset 87051213c0bc (bug 1801954) for causing mochitests failures in browser_overlay_keyboard_test.js and on OSX. CLOSED TREE 2023-12-01 03:44:32 +02:00
Niklas Baumgardner
1b10dae70a Bug 1801954 - Make screenshots selection movable via the keyboard. r=sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D192109
 2023-11-30 22:11:53 +00:00
Niklas Baumgardner
472611a2c2 Bug 1864889 - Only allow left mouse button on screenshots overlay. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D193680
 2023-11-28 02:33:17 +00:00
Niklas Baumgardner
59a1e1e591 Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-14 15:57:46 +00:00
Norisz Fay
1b95461566 Backed out changeset 9ec09eb75c9f (bug 1842037) for causing bc failures on browser_screenshots_drag_test.js CLOSED TREE 2023-11-14 04:06:58 +02:00
Niklas Baumgardner
80c28a9bea Bug 1842037 - Update screenshots telemetry. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191679
 2023-11-13 23:57:17 +00:00
Niklas Baumgardner
f9babae778 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-02 18:06:38 +00:00
Norisz Fay
15564eb9be Backed out changeset 80cec114b8a6 (bug 1859882) for causing bc failures on browser_screenshots_telemetry_tests.js 2023-11-01 18:00:54 +02:00
Niklas Baumgardner
5f8d4b6939 Bug 1859882 - Make sure screenshots overlay isn't bigger than document. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D191349
 2023-11-01 15:06:22 +00:00
Niklas Baumgardner
8331e6faf7 Bug 1855313 - Show current selection size in screenshots overlay. r=sfoster,fluent-reviewers,desktop-theme-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D189312
 2023-10-20 23:25:37 +00:00
Niklas Baumgardner
6ec1dd524f Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Cosmin Sabou
059db96270 Backed out changeset 08bb959c7dca (Bug 1857946) for being partially backed out by merge back commit. 2023-10-19 07:47:11 +03:00
Niklas Baumgardner
7902d47e40 Bug 1857946 - Use position sticky for screenshots preview container. r=sfoster,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D190491
 2023-10-19 02:11:48 +00:00
Emilio Cobos Álvarez
66cd465db8 Bug 1858752 - Simplify screenshots component markup. r=niklas 
This doesn't fix the issue at hand, but makes stuff easier to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D191137
 2023-10-17 17:24:22 +00:00
Emilio Cobos Álvarez
b12b572bf0 Bug 1859058 - Fix button position after showing them on both sides. r=niklas 
Drive-by, but I noticed it while poking so might as well fix it.

Depends on D191138

Differential Revision: https://phabricator.services.mozilla.com/D191139
 2023-10-17 14:49:22 +00:00
Sam Foster
c20c018e69 Bug 1845796 - Rework the flow in ScreenshotsUtils to make exit an explicit outcome rather than a side-effect. r=niklas 
* Add a UIPhases / getUIPhase to figure out where we are in the flow, and get the UI into the right state
* Refactor to get rid of a bunch of implicit side-effects:
  - Separate out getting the panel from creating it
  - closePanel only closes the buttons panel
  - Add a closeOverlay so we do that and only that when needed
* When the preview dialog closes, we expect to exit unless exitOnPreviewClose was set false
* Keep some state for each browser using a weakmap so we can better handle re-entry (and later, re-focusing)

Differential Revision: https://phabricator.services.mozilla.com/D185379
 2023-09-19 00:14:27 +00:00
Niklas Baumgardner
8464bcdbb9 Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-27 16:15:02 +00:00
Sebastian Hengst
945cff3a90 Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js. Complete backout. CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:24:18 +02:00
Norisz Fay
b81bfc15de Backed out 2 changesets (bug 1844171) for causing mochitest failures on browser_quickactions.js CLOSED TREE 
Backed out changeset 2989a10ac4e6 (bug 1844171)
Backed out changeset 9bc360cfb992 (bug 1844171)
 2023-07-26 21:58:58 +03:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Niklas Baumgardner
51b2d1bafb Bug 1844171 - Refactor screenshots component. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D183313
 2023-07-26 15:37:45 +00:00
Emilio Cobos Álvarez
c8d2c23403 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-09 11:34:05 +00:00
Stanca Serban
27c720052b Backed out changeset 1c835137f532 (bug 1824886) for causing multiple failures. CLOSED TREE 2023-07-06 02:11:59 +03:00
Emilio Cobos Álvarez
8053b896a6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 21:59:44 +00:00
Cosmin Sabou
20fa44fbeb Backed out 2 changesets (bug 1824886) for causing failures on browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 650ef77d1c4d (bug 1824886)
Backed out changeset 1c835137f532 (bug 1824886)
 2023-07-06 00:42:53 +03:00
Emilio Cobos Álvarez
b1433254b6 Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 
Subtle things:

 * We now have shadow trees in NAC, inception! Only a couple lines of
   code in the style system had to be changed to match :host rules and
   so properly.

 * Had to make highlighters.css contentaccessible, because otherwise we
   can't load it from the shadow tree. I don't think it's a big deal.

 * I removed some of the code from highlighters.css that claimed that
   stuff inherited from the html element. That's just no longer true.

 * Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
   This is needed because CSSOM from chrome code bypasses CSP (as
   AnonymousContent did), but setAttribute() doesn't, see bug 1424474.

Differential Revision: https://phabricator.services.mozilla.com/D173998
 2023-07-05 18:21:31 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Niklas Baumgardner
f0190facaa Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 15:30:21 +00:00
Iulian Moraru
7237840464 Backed out 2 changesets (bug 1824430, bug 1812631) for causing multiple mochitest failures. CLOSED TREE 
Backed out changeset 500e6e1d7092 (bug 1824430)
Backed out changeset 6d0d5de3be6e (bug 1812631)
 2023-03-30 04:44:53 +03:00
Niklas Baumgardner
5ea1b4a087 Bug 1824430 - Update screenshots buttons styling. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D173708
 2023-03-30 00:36:32 +00:00
Niklas Baumgardner
1e559272b1 Bug 1811953 - Scroll when resizing near the edge. r=sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D167614
 2023-03-22 21:02:49 +00:00