Commit Graph

259 Commits

Author SHA1 Message Date
Tim Huang
8e73dafdc8 Bug 1830054 - Disable Email tracking protection if tracking protection is disabled on the ETP Custom UI. r=anti-tracking-reviewers,pbz
We surface the email tracking protection using the existing tracking
protection UI on the protection panel, but we don't disable email
tracking protection if tracking protection is disabled. So, users will
still see blocked trackers if tracking protection is disabled for
private windows. To provide a way to disable email tracking protection
in private windows, we also use the existing tracking protection checkbox
UI to disable the email tracking protection.

This patch implements that disabling the tracking protection via the
tracking protection checkbox also disables email tracking protection.

Differential Revision: https://phabricator.services.mozilla.com/D177520
2023-05-16 07:06:01 +00:00
Valentin Gosu
92b83ac2cd Bug 1829905 - Add telemetry for DoH settings UI interaction r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176505
2023-05-05 13:21:42 +00:00
Narcis Beleuzu
33e0b4677c Backed out changeset f1fd6f277c40 (bug 1829427) for bc failure on browser_privacy_relayIntegration.js . CLOSED TREE 2023-04-24 22:02:15 +03:00
Sergey Galich
2ee025cb9a Bug 1829427 - Update Relay integration checkbox in Settings r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,jneuberger,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176192
2023-04-24 16:31:13 +00:00
Valentin Gosu
08f7c165d0 Bug 1826749 - DoH Settings UI tests r=Gijs,settings-reviewers
This adapts previous test cases from the connection UI to the privacy UI.

Additional improvements:
- Set the ROLLOUT_URI_Pref to empty string to avoid DoHConfig reset setting it to undefined.
- Always set network.trr.uri even if it matches the default_provider_uri if it's a user choice.
- If the value of network.trr.uri doesn't match any of the providers, then set custom_uri so
  it shows up in the input text field. This can happen when it's set by a policy.

Differential Revision: https://phabricator.services.mozilla.com/D174876
2023-04-16 19:52:18 +00:00
Kershaw Chang
8350aaff2d Bug 1596847 - DoH settings UI for excluded domains, r=fluent-reviewers,settings-reviewers,Gijs,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D173521
2023-04-11 09:57:29 +00:00
Valentin Gosu
ad3a1f023d Bug 1610741 - Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
- Patch changes TRRService::MaybeSetPrivateURI so that it doesn't bail
  if the URL is invalid. That could lead us into a state where the
  network.trr.uri pref has been set to some invalid URL, but we continue
  using the previous domain (or even the default TRR provider) instead.
- Updates the DoH settings UI to not set the network.trr.uri pref to "",
  as that will cause the TRRService to use the value of
  the network.trr.default_provider_uri pref instead.

Differential Revision: https://phabricator.services.mozilla.com/D174111
2023-04-11 09:57:29 +00:00
Valentin Gosu
e93296a122 Bug 1610741 - DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
- The patch saves the confirmation channel's status and skipReason in the TRR Service
- The UI queries the status and displays the stringified version in the Not Available (reason) label
- Introduces doh-status-label CSS rule so the Learn-More link isn't off center

Differential Revision: https://phabricator.services.mozilla.com/D174110
2023-04-11 09:57:28 +00:00
Valentin Gosu
6e6d3ea038 Bug 1610741 - DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ
Figma: https://www.figma.com/file/qE8FEIOv2Q0pm8e1euItd1/DoH-UI-Improvements?node-id=15%3A3479&t=8tJjft2zfvDJcV2N-0


This change adds a DNS over HTTPS section to about:preferences#privacy
The UI is intended to have the same style as the Enhanced Tracking Protection
choices.
The old DoH UI is going to be removed in a followup patch.

Differential Revision: https://phabricator.services.mozilla.com/D172966
2023-04-11 09:57:27 +00:00
Cosmin Sabou
50de03a558 Backed out 7 changesets (bug 1816948, bug 1596847, bug 1610741) for causing build bustages on TRRService.cpp. CLOSED TREE
Backed out changeset a7341379f263 (bug 1610741)
Backed out changeset 5689f1b0d016 (bug 1816948)
Backed out changeset 7746c3a39e92 (bug 1596847)
Backed out changeset 8e85f984f46c (bug 1610741)
Backed out changeset b9b738076d55 (bug 1610741)
Backed out changeset 403f22e3a0a0 (bug 1610741)
Backed out changeset 8ec3cfe29b61 (bug 1610741)
2023-04-07 00:45:15 +03:00
Kershaw Chang
1f78f73904 Bug 1596847 - DoH settings UI for excluded domains, r=fluent-reviewers,settings-reviewers,Gijs,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D173521
2023-04-06 12:57:51 +00:00
Valentin Gosu
2570da8854 Bug 1610741 - Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
- Patch changes TRRService::MaybeSetPrivateURI so that it doesn't bail
  if the URL is invalid. That could lead us into a state where the
  network.trr.uri pref has been set to some invalid URL, but we continue
  using the previous domain (or even the default TRR provider) instead.
- Updates the DoH settings UI to not set the network.trr.uri pref to "",
  as that will cause the TRRService to use the value of
  the network.trr.default_provider_uri pref instead.

Differential Revision: https://phabricator.services.mozilla.com/D174111
2023-04-06 12:57:51 +00:00
Valentin Gosu
e9e25c81c0 Bug 1610741 - DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
- The patch saves the confirmation channel's status and skipReason in the TRR Service
- The UI queries the status and displays the stringified version in the Not Available (reason) label
- Introduces doh-status-label CSS rule so the Learn-More link isn't off center

Differential Revision: https://phabricator.services.mozilla.com/D174110
2023-04-06 12:57:50 +00:00
Valentin Gosu
bf771234dc Bug 1610741 - DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ
Figma: https://www.figma.com/file/qE8FEIOv2Q0pm8e1euItd1/DoH-UI-Improvements?node-id=15%3A3479&t=8tJjft2zfvDJcV2N-0


This change adds a DNS over HTTPS section to about:preferences#privacy
The UI is intended to have the same style as the Enhanced Tracking Protection
choices.
The old DoH UI is going to be removed in a followup patch.

Differential Revision: https://phabricator.services.mozilla.com/D172966
2023-04-06 12:57:49 +00:00
Cristian Tuns
87c1f7746b Backed out 7 changesets (bug 1610741, bug 1816948, bug 1596847) for causing xpcshell failures in test_dooh.js CLOSED TREE
Backed out changeset 8596bc4554df (bug 1610741)
Backed out changeset 1a9baaa49d3d (bug 1816948)
Backed out changeset d72b9cdfbb1e (bug 1596847)
Backed out changeset e2e564f584b3 (bug 1610741)
Backed out changeset e9e331ccc7ab (bug 1610741)
Backed out changeset 44218f91e7cf (bug 1610741)
Backed out changeset 6f296319409a (bug 1610741)
2023-04-05 15:14:36 -04:00
Kershaw Chang
6e5b163a62 Bug 1596847 - DoH settings UI for excluded domains, r=fluent-reviewers,settings-reviewers,Gijs,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D173521
2023-04-05 17:13:54 +00:00
Valentin Gosu
898d4c855e Bug 1610741 - Allow setting invalid URL in TRRService and show it in settings r=Gijs,fluent-reviewers,settings-reviewers,flod
- Patch changes TRRService::MaybeSetPrivateURI so that it doesn't bail
  if the URL is invalid. That could lead us into a state where the
  network.trr.uri pref has been set to some invalid URL, but we continue
  using the previous domain (or even the default TRR provider) instead.
- Updates the DoH settings UI to not set the network.trr.uri pref to "",
  as that will cause the TRRService to use the value of
  the network.trr.default_provider_uri pref instead.

Differential Revision: https://phabricator.services.mozilla.com/D174111
2023-04-05 17:13:53 +00:00
Valentin Gosu
8a341f3413 Bug 1610741 - DoH Settings UI: Show error reason in Not Available label r=Gijs,kershaw,fluent-reviewers,necko-reviewers,settings-reviewers,flod
- The patch saves the confirmation channel's status and skipReason in the TRR Service
- The UI queries the status and displays the stringified version in the Not Available (reason) label
- Introduces doh-status-label CSS rule so the Learn-More link isn't off center

Differential Revision: https://phabricator.services.mozilla.com/D174110
2023-04-05 17:13:53 +00:00
Valentin Gosu
590ab2eebf Bug 1610741 - DoH setting UI r=kershaw,settings-reviewers,Gijs,pbz,flod
Project plan: https://docs.google.com/document/d/12IGABt1eXI276qHduXXbVZqRFrhLN7Ad3gKEgxz81sE
Copy deck: https://docs.google.com/document/d/130UTox8bQbybjYIwvltR4qBg2hWjsGhuNUHypLwUAEQ
Figma: https://www.figma.com/file/qE8FEIOv2Q0pm8e1euItd1/DoH-UI-Improvements?node-id=15%3A3479&t=8tJjft2zfvDJcV2N-0


This change adds a DNS over HTTPS section to about:preferences#privacy
The UI is intended to have the same style as the Enhanced Tracking Protection
choices.
The old DoH UI is going to be removed in a followup patch.

Differential Revision: https://phabricator.services.mozilla.com/D172966
2023-04-05 17:13:52 +00:00
ui.dev
d06616a895 Bug 1824389 - Remove _initCookieBannerHandlingLearnMore() function from privacy.js. r=tgiles.
Differential Revision: https://phabricator.services.mozilla.com/D173621
2023-03-28 20:09:05 +00:00
Barret Rennie
0604905647 Bug 1818738 - Make the feature update event API more ergonomic r=aminomancer,settings-reviewers,search-reviewers,Gijs,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D172035
2023-03-16 22:20:14 +00:00
Karl Tomlinson
61a43fc8cb Bug 1804352 add blocking speaker selection permissions to about:preferences#privacy r=fluent-reviewers,desktop-theme-reviewers,flod,dao,pbz
This patch adds support only for BLOCK permissions because ALLOW permissions
are double-keyed and will be included via a subsequent patch.

Support for a global BLOCK permission is not added here because of
inconsistencies in the way this interacts with device-specific ALLOW
permissions.

Differential Revision: https://phabricator.services.mozilla.com/D170303
2023-03-15 22:07:23 +00:00
issammani
7b4986bae9 Bug 1804502 - Add relevant telemetry events to relay integration. r=credential-management-reviewers,dimi,sgalich,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D163911
2023-03-06 23:50:44 +00:00
Marian-Vasile Laza
287601a93f Backed out 2 changesets (bug 1804502) for bc failures on browser_relay_telemetry.js. CLOSED TREE
Backed out changeset 58235f400c11 (bug 1804502)
Backed out changeset 8131e1111608 (bug 1804502)
2023-03-06 01:07:24 +02:00
issammani
480ffa2523 Bug 1804502 - Add relevant telemetry events to relay integration. r=credential-management-reviewers,dimi,sgalich,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D163911
2023-03-05 20:37:06 +00:00
Dão Gottwald
8118df361c Bug 1817401 - Implement "Dismissed suggestions" handling in Firefox Suggest preferences section. r=adw,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D170671
2023-03-01 09:58:25 +00:00
DJ
1f0a93691a Bug 1817201 - sync PBM service.mode pref with base service.mode pref on settings page. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D170113
2023-02-17 18:59:35 +00:00
Jared Hirsch
16a4cf443a Bug 1816138 - Disable cookie banner detect only mode in about:preferences. r=settings-reviewers,mconley
It turns out the detect-only pref must be unset for cookie banner
handling to actually work, and while the onboarding doorhanger does
disable this pref, the about:preferences checkbox does not. This patch
corrects the issue, disabling the detect-only pref when the checkbox is
checked, so that users who discover the feature in about:preferences can
successfully enable it.

Differential Revision: https://phabricator.services.mozilla.com/D169645
2023-02-13 20:59:34 +00:00
Jared Hirsch
e1c9146780 Bug 1812819 - Update cookie banner preferences checkbox to toggle reject-only mode. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D168285
2023-01-30 18:51:58 +00:00
Tim Giles
15388b009a Bug 1801929 - Replace 'Top pick' link with support-link. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167439
2023-01-25 18:56:21 +00:00
Tim Giles
cf14d1a7ba Bug 1801929 - Replace 'HTTPS-Only Mode' link with support-link. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167438
2023-01-25 18:56:21 +00:00
Tim Giles
e1601de357 Bug 1801929 - Replace 'Block dangerous and' link with support-link. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167437
2023-01-25 18:56:20 +00:00
Tim Giles
805c3ab46b Bug 1801929 - Replace 'personalized extension' link with support-link. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167436
2023-01-25 18:56:20 +00:00
Tim Giles
e85efc391e Bug 1801929 - Replace 'Notifications' link with support-link. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167435
2023-01-25 18:56:20 +00:00
Tim Giles
996a763c19 Bug 1801929 - Remove unused href assignment code for Firefox Suggest section. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167434
2023-01-25 18:56:19 +00:00
Tim Giles
e751bd66d3 Bug 1801929 - Replace 'Quick actions' learn more link with support-link. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167431
2023-01-25 18:56:18 +00:00
Tim Giles
30c372508c Bug 1801929 - Replace 'Allow Windows single sign-on' link with support-link r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167427
2023-01-25 18:56:16 +00:00
Tim Giles
197e363e8f Bug 1801929 - Replace 'Use a Primary Password' link with support-link. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167426
2023-01-25 18:56:15 +00:00
Tim Giles
16dc0cd6e1 Bug 1801929 - Replace 'Show alerts about passwords' link with support-link r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167425
2023-01-25 18:56:15 +00:00
Tim Giles
4ed91e983a Bug 1801929 - Replace link under 'Cookies and Site Data' section with support-link r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D167424
2023-01-25 18:56:14 +00:00
Tim Giles
334c52a455 Bug 1801929 - Replace learn more link under 'Custom' option with support-link. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D167422
2023-01-25 18:56:14 +00:00
Tim Giles
72d63afdb2 Bug 1801929 - Replace 'Total Cookie Protection' learn more link with support-link. r=pbz,mconley,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D167420
2023-01-25 18:56:13 +00:00
Tim Giles
237bd9a817 Bug 1801929 - Refactor 'Enhanced Tracking Protection' link with support-link r=settings-reviewers,mconley,mstriemer
We need the .learnMore class here, otherwise the "Learn more" link does
not move to a new line, which is the current behavior.

Differential Revision: https://phabricator.services.mozilla.com/D167419
2023-01-25 18:56:12 +00:00
Paul Zuehlcke
c561bb7d44 Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-20 12:22:09 +00:00
Marian-Vasile Laza
70fd2af8ea Backed out 2 changesets (bug 1809700) for causing automation/mochitest/marionette failures. CLOSED TREE
Backed out changeset 7d58f9afe4b7 (bug 1809700)
Backed out changeset 8a37c048a169 (bug 1809700)
2023-01-19 21:33:08 +02:00
Paul Zuehlcke
2071ac660b Bug 1809700 - Refactor detect-only mode into separate pref. r=timhuang,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D166831
2023-01-19 17:12:00 +00:00
Jared Hirsch
42530ae257 Bug 1800675 - Add about:preferences entry for cookie banner handling. r=fluent-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D164632
2023-01-11 15:54:01 +00:00
Sergey Galich
67b3c1d994 Bug 1751763 - Firefox Relay integration r=dimi,flod,mconley,desktop-theme-reviewers,dao,sfoster,geckoview-reviewers,jonalmeida
Differential Revision: https://phabricator.services.mozilla.com/D158155
2022-12-16 18:41:58 +00:00
Hannah Peuckmann
c3f83197da Bug 1797513 - TCP rollout clean up TCP-in-standard checkbox. r=pbz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D161683
2022-12-14 10:50:02 +00:00
Stanca Serban
286084d46e Backed out 2 changesets (bug 1797513) for causing mochitests failures in browser_identityBlock_focus.js. CLOSED TREE
Backed out changeset 897cd9d90f9f (bug 1797513)
Backed out changeset 2819090e4f0f (bug 1797513)
2022-12-13 12:32:30 +02:00