This patch makes us commit to the deemphasized color descriptive pattern throughout settings.
I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.
Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.
Differential Revision: https://phabricator.services.mozilla.com/D197615
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.
I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.
Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.
Differential Revision: https://phabricator.services.mozilla.com/D197615
This is the only element in the deck which has plain inlines inside.
Make them a block, which is more similar to what the about dialog does
too, anyways.
Differential Revision: https://phabricator.services.mozilla.com/D194604
This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.
This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).
Just move this to the UA sheet properly.
Differential Revision: https://phabricator.services.mozilla.com/D188326
When an element is re-translated, the textContent is currently dropped.
To avoid that, make it an explicit part of the message.
This requires changing the l10n message ID.
Ideally, the message ID wouldn't change, but that is not possible until
the content can be preserved as a feature, i.e.
https://github.com/projectfluent/fluent.js/issues/169
Differential Revision: https://phabricator.services.mozilla.com/D179323
When an element is re-translated, the textContent is currently dropped.
To avoid that, make it an explicit part of the message.
This requires changing the l10n message ID.
Ideally, the message ID wouldn't change, but that is not possible until
the content can be preserved as a feature, i.e.
https://github.com/projectfluent/fluent.js/issues/169
Differential Revision: https://phabricator.services.mozilla.com/D179323
Adds a new button and panel for managing Translations
settings to the about:preferences panel.
Manages always-translate languages, never-translate
languages, and never-translate sites.
Depends on D178228
Differential Revision: https://phabricator.services.mozilla.com/D177854
Adds a new button and panel for managing Translations
settings to the about:preferences panel.
Manages always-translate languages, never-translate
languages, and never-translate sites.
Depends on D178228
Differential Revision: https://phabricator.services.mozilla.com/D177854
Adds a new button and panel for managing Translations
settings to the about:preferences panel.
Manages always-translate languages, never-translate
languages, and never-translate sites.
Depends on D178228
Differential Revision: https://phabricator.services.mozilla.com/D177854
The spacers are unnecessary if there's a <label> or <description> that
flexes.
Since we allow labels/descriptions to shrink now they'd distribute the
space along with the spacer, which caused unnecessarily small labels.
Differential Revision: https://phabricator.services.mozilla.com/D173937
In a setup with:
<hbox>
<something flex="1"/>
<something-else/>
</hbox>
Before bug 1822131 <something flex="1"> ended up with flex-basis: auto,
but was the only thing able to shrink, so <something-else> stayed the
same size.
After that bug however <something-else> is able to shrink too, so both
elements shrink. This wouldn't happen if flex="1" actually worked like
flex: 1 does.
However flex: 1 causes stuff like explicit main sizes to be
(effectively) ignored, so we need to fix up a few cases where now we'd
start flexing too much. For that, add a debug assert to
nsFlexContainerFrame to catch the would-be behavior changes here.
For the most part they're actually no-op since they're setting tiny
sizes, but preferences and devtools needed a couple real fixes.
The profile selection spacer is useless (zero-size).
Hopefully the last xul.css change I need to do :')
Differential Revision: https://phabricator.services.mozilla.com/D172704
