Commit Graph

199 Commits

Author SHA1 Message Date
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 10:10:09 +00:00
Jules Simplicio
7adf282ac7 Bug 1880223 - Set auto min-height in textareas and fix heading sizing in connection settings r=desktop-theme-reviewers,settings-reviewers,emilio
This fixes an existing scrollbar issue pointed out on this patch's bug that became more predominant with some of the heading standardization work in bug 1877793.

I'm making sure the heading looks like how it used to. I also noticed textareas had a very small min-height that seemed to be causing this issue.

Differential Revision: https://phabricator.services.mozilla.com/D202018
2024-02-20 20:39:19 +00:00
Jules Simplicio
23705875ae Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 15:39:26 +00:00
Norisz Fay
77b1e70097 Backed out 2 changesets (bug 1872788) for causing mochitest failure on test_moz_button_group.html CLOSED TREE
Backed out changeset a9528d76a91b (bug 1872788)
Backed out changeset 4fde278ae659 (bug 1872788)
2024-01-30 15:59:23 +02:00
Jules Simplicio
eaaed0558d Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 05:28:27 +00:00
Jaydeep Das
95cda128bf Bug 328707 - Allow only valid IP/Hostname for Proxy Config, r=mconley,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D198425
2024-01-22 14:28:41 +00:00
Javier Rueda
d6535e0523 Bug 1764694 - Disable 'Remove' button when there are no accepted languages. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D197635
2024-01-04 23:50:16 +00:00
Olivia Hall
16d733113b Bug 1865727 - GeckoView Runtime Never Translate Site Option r=geckoview-reviewers,settings-reviewers,translations-reviewers,gregtatum,owlish,boek
This patch adds an option for GeckoView to change site settings outside
of the session. These APIs should be used for global modifications to
the "never translate these sites" list.

Additionally, this patch moves some Desktop translations logic to the
toolkit for shared use.

Differential Revision: https://phabricator.services.mozilla.com/D195790
2023-12-13 14:50:08 +00:00
jneuberger
7cccf3fb15 Bug 1869300 - Remove (desktop only) from sync-engine-payment-methods r=credential-management-reviewers,fluent-reviewers,settings-reviewers,dimi,flod
Differential Revision: https://phabricator.services.mozilla.com/D196046
2023-12-12 16:47:26 +00:00
jneuberger
5946f0e354 Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195279
2023-12-12 16:02:06 +00:00
Sandor Molnar
5e9ca11c9d Backed out 5 changesets (bug 1867017, bug 1867019, bug 1867018, bug 1867020) for causing bc failures at browser/components/preferences/tests/browser_search_subdialogs_within_preferences_5.js CLOSED TREE
Backed out changeset 0c4bc9a698ba (bug 1867017)
Backed out changeset ea95d41995f0 (bug 1867017)
Backed out changeset 56289937eb65 (bug 1867020)
Backed out changeset 022c1f63a6fe (bug 1867019)
Backed out changeset fa5b89f2d1b6 (bug 1867018)
2023-12-12 05:54:37 +02:00
jneuberger
777f61f0ec Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195279
2023-12-11 21:54:34 +00:00
Johannes J. Schmidt
0b4bf0b0eb Bug 1867015 - Update Strings for about:preferences - Sync page - r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195118
2023-12-04 13:55:36 +00:00
Dale Harvey
3abcf233ac Bug 1794752 - Increase status column width. r=Gijs,settings-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192598
2023-11-04 11:25:19 +00:00
Emilio Cobos Álvarez
f8e535d8d7 Bug 1860346 - Simplify site permissions markup and styling. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191564
2023-10-25 11:08:08 +00:00
Emilio Cobos Álvarez
ed873d6616 Bug 1644612 - Add a height and cleanup languages listbox styling. r=desktop-theme-reviewers,dao
The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Differential Revision: https://phabricator.services.mozilla.com/D180890
2023-10-24 11:11:18 +00:00
Dave Townsend
108be2cdee Bug 1857999: Manually fix some spacing and comments. r=Gijs,settings-reviewers,places-reviewers,Standard8
Manually re-apply comments and spacing that existed prior to the automated
changes.

Differential Revision: https://phabricator.services.mozilla.com/D190682
2023-10-18 07:04:42 +00:00
Dave Townsend
f2f7777e96 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00
Sandor Molnar
099f0fd4c3 Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend
23fed3a46c Bug 1857999: Manually fix some spacing and comments. r=Gijs,settings-reviewers,places-reviewers,Standard8
Manually re-apply comments and spacing that existed prior to the automated
changes.

Differential Revision: https://phabricator.services.mozilla.com/D190682
2023-10-16 09:43:27 +00:00
Dave Townsend
92c3ea0f78 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-16 09:43:26 +00:00
Emilio Cobos Álvarez
096711b4c3 Bug 1853731 - Use html:img for message-bar-icon. r=Gijs,dao,settings-reviewers,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D188521
2023-09-19 06:54:52 +00:00
Emilio Cobos Álvarez
4eb43ef123 Bug 1853323 - Remove browser.underline_anchors. r=settings-reviewers,mconley
This is weirdly placed in the colors dialog, and adds a global selector
to the UA sheet for no great reason.

This sub-setting doesn't really make a lot of sense. We don't let you
force underlines in any way, so any site CSS will override it (unlike
colors, where you can actually override the site).

Just move this to the UA sheet properly.

Differential Revision: https://phabricator.services.mozilla.com/D188326
2023-09-15 15:37:15 +00:00
Emilio Cobos Álvarez
6f60d63a46 Bug 1852092 - Add some min height to permission lists. r=mconley,dao,settings-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D188322
2023-09-15 15:13:53 +00:00
Malte Juergens
60c41e84f9 Bug 1844978 - Discard permission dialog inputs which start with a http(s) scheme and can't be turned into a principal r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184800
2023-08-08 09:12:14 +00:00
Malte Juergens
36733ae0a2 Bug 1720458: Do not isolate https-only-load-insecure by origin attributes r=fluent-reviewers,settings-reviewers,flod,ckerschb,Gijs
Do not isolate `https-only-load-insecure` by origin attributes. This way the HTTPS-Only exceptions will behave similar to the `cookie` permission. This means that exceptions set in the system settings will also apply to private windows, but exceptions set in private windows via the identity pane will be reset after closing the browser.

Depends on D182761

Differential Revision: https://phabricator.services.mozilla.com/D183745
2023-07-24 13:31:19 +00:00
Malte Juergens
72bf8c2b4e Bug 1757297: Only work with http scheme for HTTPS-Only exceptions r=freddyb,settings-reviewers,Gijs
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D182761
2023-07-24 13:31:19 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Gijs Kruitbosch
d71337df6a Bug 1838632 - fix connection dialog autologin checkbox to have a tooltip as intended, r=fluent-reviewers,flod,mconley
Depends on D181228

Differential Revision: https://phabricator.services.mozilla.com/D181229
2023-06-19 16:30:16 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Rob Wu
bad812f243 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Mark Banner
232facd440 Bug 1824613 - Convert consumers of toolkit/mozapps/extensions/ to import ES modules directly. r=extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,sync-reviewers,sgalich,bytesized,robwu,skhamis
Depends on D179819

Differential Revision: https://phabricator.services.mozilla.com/D179820
2023-06-02 20:00:35 +00:00
Greg Tatum
bd594a17f3 Bug 1821038 - Expose the translations.ftl file to localization; r=nordzilla,fluent-reviewers,flod
Note that this does not expose the about:translations localization file
since that is a developer-focused view that's not ready or planned for
general usage.

Differential Revision: https://phabricator.services.mozilla.com/D179360
2023-05-29 19:19:55 +00:00
Stanca Serban
e8e8ffbc64 Backed out 9 changesets (bug 1831963, bug 1821038) for causing mochitests failures in browser_preferences_usage.js. CLOSED TREE
Backed out changeset 8e03224a019c (bug 1821038)
Backed out changeset 2b8bba99a0df (bug 1831963)
Backed out changeset 44cd611f57ce (bug 1831963)
Backed out changeset 5b15a7632c91 (bug 1831963)
Backed out changeset 522ef5669a6b (bug 1831963)
Backed out changeset f730091705fd (bug 1831963)
Backed out changeset 493c07c8a519 (bug 1831963)
Backed out changeset c4811197740c (bug 1831963)
Backed out changeset baaaaff4b660 (bug 1831963)
2023-05-29 21:32:21 +03:00
Greg Tatum
cc5911885c Bug 1821038 - Expose the translations.ftl file to localization; r=nordzilla,fluent-reviewers,flod
Note that this does not expose the about:translations localization file
since that is a developer-focused view that's not ready or planned for
general usage.

Differential Revision: https://phabricator.services.mozilla.com/D179360
2023-05-29 15:04:39 +00:00
Erik Nordin
195bd58b5b Bug 1829691 - Add Translations settings panel to about:preferences r=gregtatum,fluent-reviewers,settings-reviewers,Gijs,flod
Adds a new button and panel for managing Translations
settings to the about:preferences panel.

Manages always-translate languages, never-translate
languages, and never-translate sites.

Depends on D178228

Differential Revision: https://phabricator.services.mozilla.com/D177854
2023-05-24 01:22:43 +00:00
Erik Nordin
549b3cf760 Bug 1829691 - Copy Translation Exceptions code to new files r=gregtatum,settings-reviewers,Gijs
Copies the code for Translation exceptions in about:preferences
to new files to preserve the git-blame history so that they can be
modified in a subsequent patch

Depends on D178723

Differential Revision: https://phabricator.services.mozilla.com/D178228
2023-05-24 01:22:43 +00:00
Dão Gottwald
3676502aae Bug 1834051 - Decommission --in-content-deemphasized-text and use --text-color-deemphasized instead. r=Itiel
Differential Revision: https://phabricator.services.mozilla.com/D178520
2023-05-23 15:32:33 +00:00
Butkovits Atila
3495b22475 Backed out 11 changesets (bug 1834014, bug 1829691) for causing failures at browser_console_content_object_in_sidebar.js.
Backed out changeset bd3077e43541 (bug 1834014)
Backed out changeset 96dc91b50ecf (bug 1834014)
Backed out changeset 6099ee399488 (bug 1829691)
Backed out changeset d3488c2d7309 (bug 1829691)
Backed out changeset a89ce140c316 (bug 1829691)
Backed out changeset 40d7f94265c2 (bug 1829691)
Backed out changeset e86660a6f994 (bug 1829691)
Backed out changeset 5c63d7e15cac (bug 1829691)
Backed out changeset 2e5a01539749 (bug 1829691)
Backed out changeset 1b53cac4d88b (bug 1829691)
Backed out changeset be4a4c19e24f (bug 1829691)
2023-05-23 03:20:38 +03:00
Erik Nordin
bf3bf6e5ef Bug 1829691 - Add Translations settings panel to about:preferences r=gregtatum,fluent-reviewers,settings-reviewers,Gijs,flod
Adds a new button and panel for managing Translations
settings to the about:preferences panel.

Manages always-translate languages, never-translate
languages, and never-translate sites.

Depends on D178228

Differential Revision: https://phabricator.services.mozilla.com/D177854
2023-05-22 21:11:11 +00:00
Erik Nordin
6d8fc6d0c4 Bug 1829691 - Copy Translation Exceptions code to new files r=gregtatum,settings-reviewers,Gijs
Copies the code for Translation exceptions in about:preferences
to new files to preserve the git-blame history so that they can be
modified in a subsequent patch

Differential Revision: https://phabricator.services.mozilla.com/D178228
2023-05-22 21:11:11 +00:00
Butkovits Atila
ca3a270f82 Backed out 10 changesets (bug 1834014, bug 1829691) for causing failures at browser_about_translations_debounce.js. CLOSED TREE
Backed out changeset 680e9579fca5 (bug 1834014)
Backed out changeset e9c17faebbe3 (bug 1834014)
Backed out changeset 6b3a514450af (bug 1829691)
Backed out changeset 58b154e4accc (bug 1829691)
Backed out changeset 749af53af3bd (bug 1829691)
Backed out changeset 252c0d70934b (bug 1829691)
Backed out changeset 6ed4a66b1e40 (bug 1829691)
Backed out changeset fb6112332b59 (bug 1829691)
Backed out changeset 70cb62814390 (bug 1829691)
Backed out changeset 7fb6e8f6251e (bug 1829691)
2023-05-22 23:30:46 +03:00