Commit Graph

4193 Commits

Author SHA1 Message Date
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 10:10:09 +00:00
Bojidar Marinov
4f5ad30178 Bug 1839845 - Add a few tests for about:settings behavior. r=Gijs,robwu,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203052
2024-02-29 10:09:59 +00:00
Bojidar Marinov
a02f6a1df5 Bug 1839845 - Add about:settings as alias of about:preferences. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202594
2024-02-29 10:09:58 +00:00
Gregory Pappas
9bd4fc9c87 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Gregory Pappas
c1ec40f95a Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
0428704119 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Harshit Sohaney
048922e69b Bug 1878111 - (part 2) Tests for remembering user prefs in the clear history dialog. r=pbz,settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D201275
2024-02-23 14:13:30 +00:00
Jules Simplicio
7adf282ac7 Bug 1880223 - Set auto min-height in textareas and fix heading sizing in connection settings r=desktop-theme-reviewers,settings-reviewers,emilio
This fixes an existing scrollbar issue pointed out on this patch's bug that became more predominant with some of the heading standardization work in bug 1877793.

I'm making sure the heading looks like how it used to. I also noticed textareas had a very small min-height that seemed to be causing this issue.

Differential Revision: https://phabricator.services.mozilla.com/D202018
2024-02-20 20:39:19 +00:00
Hanna Jones
8d97bdbd6a Bug 1849135 - make about:preferences search work with moz-toggle + custom elements r=settings-reviewers,Gijs
I started hitting search issues with my change in D196494 and with other experiments to use more reusable components in about:preferences. We'll likely have to keep adding new elements to `searchWithinNode`, but changing `textNodeDescendants` to look for text nodes in the shadow DOM seems like a generally helpful change + gets the highlighting working properly.

Differential Revision: https://phabricator.services.mozilla.com/D197120
2024-02-20 16:38:03 +00:00
Meera Murthy
5bbca8744d Bug 1872860 - [translations] Add basic elements to Translations settings page. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D197750
2024-02-09 17:04:12 +00:00
Morgan Rae Reschenberg
272affe059 Bug 1864445: Add text zoom only warning r=dholbert,fluent-reviewers,desktop-theme-reviewers,dao,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D196116
2024-02-08 01:44:42 +00:00
Dale Harvey
27c8990068 Bug 1878279 - Have preferences recognise Bing as engine that supports trending. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D200509
2024-02-06 20:57:33 +00:00
Gregory Pappas
ec549b100a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200328
2024-02-06 08:27:10 +00:00
Sandor Molnar
1e9196f7fa Backed out changeset 1ce5079e7de7 (bug 1877883) for causing bc failures at toolkit/mozapps/extensions/test/browser/browser_webapi_install.js CLOSED TREE 2024-02-05 21:39:56 +02:00
Gregory Pappas
5d5148317a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements
Differential Revision: https://phabricator.services.mozilla.com/D200328
2024-02-05 18:41:41 +00:00
Gijs Kruitbosch
b8e31c3dbe Bug 1869734 - update explainer text around deleting data and private browsing, r=pbz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D200171
2024-01-31 20:50:46 +00:00
Jules Simplicio
23705875ae Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 15:39:26 +00:00
Harshit Sohaney
6c978c9036 Bug 1854680 - Enable the new clear history dialog in nightly only. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D198600
2024-01-30 14:45:24 +00:00
Harshit Sohaney
9d22126f61 Bug 1876378 - Ensure the data size displayed in about:preferences#privacy is updated after data sanitization. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D199580
2024-01-30 14:45:24 +00:00
Norisz Fay
77b1e70097 Backed out 2 changesets (bug 1872788) for causing mochitest failure on test_moz_button_group.html CLOSED TREE
Backed out changeset a9528d76a91b (bug 1872788)
Backed out changeset 4fde278ae659 (bug 1872788)
2024-01-30 15:59:23 +02:00
Jules Simplicio
eaaed0558d Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 05:28:27 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
Jules Simplicio
48386fea6c Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
2024-01-26 04:09:59 +00:00
Stanca Serban
6bc6e24ee2 Backed out changeset 337d90568478 (bug 1872909) for causing mochitests failures in browser_experimental_features.js. CLOSED TREE 2024-01-25 04:17:13 +02:00
Jules Simplicio
10c04f95d5 Bug 1872909 - Commit to deemphasized descriptive text pattern in preferences that has already been introduced under Search settings in order to improve information architecture r=settings-reviewers,desktop-theme-reviewers,dao,Gijs
This patch makes us commit to the deemphasized color descriptive pattern throughout settings.

I also made some changes where some settings were using description and should most likely be using a label instead and vice versa.

Quick note that if the descriptive text is tied to an input such as a checkbox or toggle, as opposed to a section heading, we opt for the `.text-deemphasized` class/treatment where not only do we use the `--text-color-deemphasized` color but also shrink the font size. You'll see I opted for such treatment in the Experiments page checkbox list.

Differential Revision: https://phabricator.services.mozilla.com/D197615
2024-01-25 01:13:43 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Jaydeep Das
95cda128bf Bug 328707 - Allow only valid IP/Hostname for Proxy Config, r=mconley,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D198425
2024-01-22 14:28:41 +00:00
Meera Murthy
fe0b7efdd1 Bug 1869830 - [translations] Add a page for Translation Setting Preferences. r=nordzilla,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,translations-reviewers,Gijs,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D197048
2024-01-22 14:19:25 +00:00
Erik Nordin
87592ba425 Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198831
2024-01-19 02:15:34 +00:00
Erik Nordin
399f696700 Bug 1875090 - Rename ContentTaskUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich,kpatenio
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198830
2024-01-19 02:15:34 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
Punam Dahiya
61270d6cf0 Bug 1862023 - Update More From Mozilla product list to display Firefox Monitor r=settings-reviewers,desktop-theme-reviewers,fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D197977
2024-01-17 21:57:33 +00:00
Harshit Sohaney
3d88318d2d Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192282
2024-01-15 13:10:05 +00:00
Harshit Sohaney
e2e1067f1f Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D190862
2024-01-15 13:10:05 +00:00
DJ
ca9f42a177 Bug 1783521 - add card preview when inactive tab hovered. r=settings-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,fluent-reviewers,flod,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D184260
2024-01-12 19:29:18 +00:00
Sandor Molnar
a571c9506e Backed out changeset 44d7819ed242 (bug 1849135) for causing bc failures at browser/components/preferences/tests/browser_search_within_preferences_2.js CLOSED TREE 2024-01-12 00:39:50 +02:00
Hanna Jones
36faabe1c0 Bug 1849135 - make about:preferences search work with moz-toggle + custom elements r=settings-reviewers,Gijs
I started hitting search issues with my change in D196494 and with other experiments to use more reusable components in about:preferences. We'll likely have to keep adding new elements to `searchWithinNode`, but changing `textNodeDescendants` to look for text nodes in the shadow DOM seems like a generally helpful change + gets the highlighting working properly.

Differential Revision: https://phabricator.services.mozilla.com/D197120
2024-01-11 15:03:04 +00:00
Noemi Erli
5ee98305d6 Backed out 4 changesets (bug 1855068, bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE
Backed out changeset dbaf2b0da226 (bug 1856412)
Backed out changeset 8d040fd73abf (bug 1856412)
Backed out changeset 645f7ed438fb (bug 1855068)
Backed out changeset be41f5296dec (bug 1855068)
2024-01-11 03:20:27 +02:00