Commit Graph

99 Commits

Author SHA1 Message Date
Dão Gottwald
2b53d56022 Bug 1918676 - Disable tab opening / closing animations and tab size locking in vertical mode, properly set --tab-min-width rather than overriding min-width in vertical mode, and restrict some styles to horizontal mode. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,kcochrane,sclements,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D222202
2024-09-16 19:53:42 +00:00
Jonathan Sudiaman
15ad15eecf Bug 1898250 - Add telemetry to sidebar r=sidebar-reviewers,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D220720
2024-09-16 15:42:48 +00:00
Emilio Cobos Álvarez
2b868a8902 Bug 1918765 - Use ease-in-out easing for sidebar animation. r=sidebar-reviewers,kcochrane
Restores the easing from before the new animation work.

Differential Revision: https://phabricator.services.mozilla.com/D222185
2024-09-14 23:13:39 +00:00
Kelly Cochrane
16d633fe66 Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D219495
2024-09-13 17:51:03 +00:00
Iulian Moraru
2e1e9ca43c Backed out changeset e6b82ff4e092 (bug 1911889) for causing bc failures on browser_tabIconOverlayPiP.js. CLOSED TREE 2024-09-13 19:14:13 +03:00
Kelly Cochrane
744bb885ad Bug 1911889 - Update tab mute/soundplaying/activemedia-blocked icon styling r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D219495
2024-09-13 14:46:04 +00:00
Emilio Cobos Álvarez
3e676b7e1d Bug 1915230 - Make animation and duration configurable. r=#sidebar-reviewers CLOSED TREE
And tweak the default duration as per UX feedback.

Differential Revision: https://phabricator.services.mozilla.com/D221718

Depends on D221351
2024-09-12 19:14:23 +00:00
Emilio Cobos Álvarez
6bb5f60b53 Bug 1915230 - Use a translate transform only. r=#sidebar-reviewers!,mstange
This:

 * Works around the WebRender issue from bug 1916599.
 * Might be a bit simpler to reason about (the sidebar special-cases to
   keep the buttons at the right edge are a bit unfortunate but...).
 * Avoids the squishiness that Markus and Sam were discussing in
   #gfx-firefox).

There's still some flickering on the <browser> element, but I have a
good idea of how to fix it (basically, we're triggering resizes from
layout, but for remote iframes we really don't want to do that, because
it can cause raciness / flickering as observed).

Differential Revision: https://phabricator.services.mozilla.com/D221351

Depends on D220846
2024-09-12 10:02:04 +00:00
Emilio Cobos Álvarez
39dbb62d25 Bug 1915230 - Make sidebar animation use transforms. r=#sidebar-reviewers!,mconley!,dao!
This looks simpler, a lot smoother on my machine, and shouldn't cause
content resizes. It also doesn't set custom properties on the root which
causes an expensive restyle, specially on big documents (like with many
tabs open).

Maybe eventually we can use view transitions for this, seems like a good
use-case.

We need to move the background to `#sidebar-main` rather than the
wrapper because during the shrinking animation the wrapper is small and
the `#sidebar-main` element would be transparent, which we don't want.

Differential Revision: https://phabricator.services.mozilla.com/D220846
2024-09-12 10:02:04 +00:00
Butkovits Atila
1a38648aa0 Backed out 3 changesets (bug 1915230) for causing failures at test_restore_sidebar.py. CLOSED TREE
Backed out changeset 05fe9b71651f (bug 1915230)
Backed out changeset 749011ce7a8a (bug 1915230)
Backed out changeset aaaae84198ae (bug 1915230)
2024-09-12 19:12:43 +03:00
Emilio Cobos Álvarez
b36505ece7 Bug 1915230 - Make animation and duration configurable. r=sidebar-reviewers,kcochrane
And tweak the default duration as per UX feedback.

Differential Revision: https://phabricator.services.mozilla.com/D221718
2024-09-12 10:02:05 +00:00
Emilio Cobos Álvarez
d9fad8f233 Bug 1915230 - Use a translate transform only. r=sidebar-reviewers,desktop-theme-reviewers,kcochrane,dao
This:

 * Works around the WebRender issue from bug 1916599.
 * Might be a bit simpler to reason about (the sidebar special-cases to
   keep the buttons at the right edge are a bit unfortunate but...).
 * Avoids the squishiness that Markus and Sam were discussing in
   #gfx-firefox).

There's still some flickering on the <browser> element, but I have a
good idea of how to fix it (basically, we're triggering resizes from
layout, but for remote iframes we really don't want to do that, because
it can cause raciness / flickering as observed).

Differential Revision: https://phabricator.services.mozilla.com/D221351
2024-09-12 10:02:04 +00:00
Emilio Cobos Álvarez
2fc55271bc Bug 1915230 - Make sidebar animation use transforms. r=mconley,dao,sidebar-reviewers,desktop-theme-reviewers,kcochrane
This looks simpler, a lot smoother on my machine, and shouldn't cause
content resizes. It also doesn't set custom properties on the root which
causes an expensive restyle, specially on big documents (like with many
tabs open).

Maybe eventually we can use view transitions for this, seems like a good
use-case.

We need to move the background to `#sidebar-main` rather than the
wrapper because during the shrinking animation the wrapper is small and
the `#sidebar-main` element would be transparent, which we don't want.

Differential Revision: https://phabricator.services.mozilla.com/D220846
2024-09-12 10:02:04 +00:00
Sam Foster
adb5a03beb Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo,tabbrowser-reviewers
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-11 16:27:08 +00:00
Micah Tigley
a22f833a97 Bug 1917709 - Rename megalist pref to contextual-password-manager. r=issammani,rsafaeian,firefox-desktop-core-reviewers ,sidebar-reviewers,dao,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D221554
2024-09-11 16:02:02 +00:00
Cristina Horotan
211657609a Backed out changeset 0c7c121f1fa3 (bug 1899346) for causing Mn failures at test_quit_restart.py CLOSED TREE 2024-09-04 05:34:33 +03:00
Sam Foster
5ebd63c578 Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
2024-09-04 00:12:07 +00:00
Ed Lee
d1d69b2d3a Bug 1895932 - Add sidebar prefs to nimbus r=sidebar-reviewers,Gijs,sclements
Add new SidebarManager singleton with init on import that allows setting user branch prefs specified in the nimbus variable for sidebar.

Differential Revision: https://phabricator.services.mozilla.com/D219903
2024-09-02 22:43:28 +00:00
Emilio Cobos Álvarez
f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
2024-09-02 13:47:45 +00:00
Kelly Cochrane
86f229c8a5 Bug 1915821 - Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D220736
2024-08-31 13:16:48 +00:00
Kelly Cochrane
fceef0f8b6 Bug 1915232 - Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D220735
2024-08-30 19:45:30 +00:00
Stanca Serban
37b5e2bd39 Backed out changeset f20f138ea4ac (bug 1915232) for causing mochitests failures in browser_history_sidebar.js. CLOSED TREE 2024-08-31 03:31:19 +03:00
Stanca Serban
1466a02554 Backed out changeset 8b97e9376724 (bug 1915821) for causing OS X mochitests failures in browser_toolbarButtonKeyPress.js. CLOSED TREE 2024-08-31 02:32:35 +03:00
Kelly Cochrane
0372b26dea Bug 1915232 - Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D220735
2024-08-30 19:45:30 +00:00
Kelly Cochrane
1e5899abe1 Bug 1915821 - Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D220736
2024-08-30 19:45:09 +00:00
Ed Lee
857840a797 Bug 1915335 - Display sidebar tool pref changes in existing windows r=sidebar-reviewers,jsudiaman
Detect pref change to refresh disabled state to update if any changed.

Differential Revision: https://phabricator.services.mozilla.com/D220370
2024-08-29 00:52:13 +00:00
Kelly Cochrane
04a3166151 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley
Differential Revision: https://phabricator.services.mozilla.com/D219887
2024-08-27 17:02:04 +00:00
Norisz Fay
a1d50a6697 Backed out changeset c540259f992c (bug 1913157) for causing bc failure on browser_sidebar_prefs.js CLOSED TREE 2024-08-27 17:31:26 +03:00
Kelly Cochrane
448c1dcaf6 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley
Differential Revision: https://phabricator.services.mozilla.com/D219887
2024-08-27 13:08:12 +00:00
Kelly Cochrane
9600083d6c Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215520
2024-08-26 19:16:07 +00:00
Tamas Szentpeteri
db26c1b7f0 Backed out changeset 4270bbbfb92d (bug 1898251) for causing frequent marionette failures on test_restore_sidebar.py. CLOSED TREE 2024-08-24 00:24:39 +03:00
Kelly Cochrane
9c271bfe95 Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215520
2024-08-23 15:56:40 +00:00
Iulian Moraru
6a5418ae50 Backed out changeset 0df1c4dc3e1e (bug 1898251) for causing marionette failures related to always_show. CLOSED TREE 2024-08-22 23:59:31 +03:00
Kelly Cochrane
19636d4e59 Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215520
2024-08-22 17:26:03 +00:00
Jonathan Sudiaman
0091e139e7 Bug 1909704 - Add three-dot menu to history and right-click menu for history and synced tabs r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,sclements
- Custom right-click menu for History and Synced Tabs.
- Three dot menu for changing sort option and clearing history.
- Tests for Synced Tabs and right-click menu in History.

Differential Revision: https://phabricator.services.mozilla.com/D218741
2024-08-22 15:19:02 +00:00
Nikki Sharpley
096c2ae629 Bug 1912229 - Move setPosition to sidebar init r=sidebar-reviewers,sclements
Previously we were only calling `setPosition` in `show()`. This meant
the "launcher" was not updated during session restore to be on the
correct side if "show on right" was set, because `SessionStore` only
calls `show()` if the sidebar panel is open.

To fix, `setPosition` has been moved to `init` instead.

Differential Revision: https://phabricator.services.mozilla.com/D219553
2024-08-20 15:44:10 +00:00
Sam Foster
40253cf104 Bug 1912017 - Avoid responding to pref changes in the sidebar when the window is closing. r=sidebar-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D219077
2024-08-15 06:03:05 +00:00
Sam Foster
f64b68c78d Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
2024-08-07 18:51:26 +00:00
Kelly Cochrane
f07a9b2932 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs. r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-06 14:21:04 +00:00
Noemi Erli
add41c1a33 Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE 2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7 Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures 2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15 Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 18:32:38 +00:00
Sandor Molnar
62ae38bb63 Backed out changeset 3b4a3a45aa1a (bug 1906140) @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 04:21:31 +03:00
Kelly Cochrane
6f31e3a9a9 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-01 00:34:29 +00:00
Sandor Molnar
daa46360f2 Backed out changeset 086cdcffa062 (bug 1906140) for causing bc failures @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 00:37:35 +03:00