Moves the sidebar padding into the moz-buttons.
This results in an accessibility improvement by giving users a larger
click surface for these buttons.
These changes prevent visual regressions in the sidebar by ensuring
visual consistency in the following cases:
- Pinned tabs in the expanded and collapsed states when using vertical
tabs
- Pinned tabs in the expanded and collapsed states when using
horizontal tabs
- New tab button, actual tabs, and action lists in the expanded and
collapsed states when using vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D219064
This:
* Works around the WebRender issue from bug 1916599.
* Might be a bit simpler to reason about (the sidebar special-cases to
keep the buttons at the right edge are a bit unfortunate but...).
* Avoids the squishiness that Markus and Sam were discussing in
#gfx-firefox).
There's still some flickering on the <browser> element, but I have a
good idea of how to fix it (basically, we're triggering resizes from
layout, but for remote iframes we really don't want to do that, because
it can cause raciness / flickering as observed).
Differential Revision: https://phabricator.services.mozilla.com/D221351
This looks simpler, a lot smoother on my machine, and shouldn't cause
content resizes. It also doesn't set custom properties on the root which
causes an expensive restyle, specially on big documents (like with many
tabs open).
Maybe eventually we can use view transitions for this, seems like a good
use-case.
We need to move the background to `#sidebar-main` rather than the
wrapper because during the shrinking animation the wrapper is small and
the `#sidebar-main` element would be transparent, which we don't want.
Differential Revision: https://phabricator.services.mozilla.com/D220846
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
On dates like August 31st, in order to create a "Last Month" card, we should use a date near the *end* of the previous month - rather than the beginning - in order to avoid exceeding 60 days of history. (At some point, we can hopefully expand or remove that limit.)
Differential Revision: https://phabricator.services.mozilla.com/D220920
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode
Differential Revision: https://phabricator.services.mozilla.com/D217161
This is also simpler because it makes various pref checks unneeded
(since browser-custom-colors.css gets loaded after this stylesheet).
Differential Revision: https://phabricator.services.mozilla.com/D220771
Add new SidebarManager singleton with init on import that allows setting user branch prefs specified in the nimbus variable for sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D219903
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.
Simplify how the devtools theme is set on the browser, so that it is set
on the root.
Differential Revision: https://phabricator.services.mozilla.com/D220769
This solves two problems. First we must make the tabbrowser-tabs instance
fill the remaining space in the sidebar while at the moment it is constrained
to the height of the tabs. Then we allow the double click event to be
handled when vertical tabs and tabs in titlebar are enabled.
Differential Revision: https://phabricator.services.mozilla.com/D220269
In Bug 1886847, there was a discussion on how best to separate chrome from content
from chrome whilst remaining true to the new look. We landed on usiong both a box
shadow and border.
Differential Revision: https://phabricator.services.mozilla.com/D218126
In Bug 1886847, there was a discussion on how best to separate chrome from content
from chrome whilst remaining true to the new look. We landed on usiong both a box
shadow and border.
Differential Revision: https://phabricator.services.mozilla.com/D218126
We can rely on the global pref for this. `setPosition` in `browswer-sidebar.js` looks
at the pref `sidebar-position_start` to determine "order" on `init` and on `reversePosition`
Differential Revision: https://phabricator.services.mozilla.com/D219906
- Custom right-click menu for History and Synced Tabs.
- Three dot menu for changing sort option and clearing history.
- Tests for Synced Tabs and right-click menu in History.
Differential Revision: https://phabricator.services.mozilla.com/D218741
