corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
906,146 Commits 1 Branch 0 Tags
29ef9eb1e38ca6fe0f73e8e7b5118f8afebc57d5
Commit Graph

134 Commits

Author SHA1 Message Date
Gijs Kruitbosch
29ef9eb1e3 Bug 1959298 - improve SERP search params handling, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D245040
 2025-04-24 22:56:11 +00:00
Iulian Moraru
0dae2e4ec5 Backed out 4 changesets (bug 1959298) for causing bc failures on browser_Manifest_install.js. CLOSED TREE 
Backed out changeset ef842ad5ff0c (bug 1959298)
Backed out changeset 37d6a257d32b (bug 1959298)
Backed out changeset cb96c92ac472 (bug 1959298)
Backed out changeset d9c8211f83fe (bug 1959298)
 2025-04-14 21:55:09 +03:00
Gijs Kruitbosch
78c9d99764 Bug 1959298 - improve SERP search params handling, r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D245040
 2025-04-14 16:16:06 +00:00
Iulian Moraru
ff3b90d82d Backed out changeset 030feec729dd (bug 1788088) for causing bc failures on browser_new_tab_insert_position.js. CLOSED TREE 2025-04-07 18:00:10 +03:00
Moritz Beier
274063e54e Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D243793
 2025-04-07 13:37:02 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D240333
 2025-03-05 09:24:37 +00:00
James Teow
5861251795 Bug 1949294 - Part 1: Move SERP categorization into its own component file - r=scunnane,search-reviewers 
This includes some renaming for consistency and reduce redundancy.

Differential Revision: https://phabricator.services.mozilla.com/D240039
 2025-03-04 04:05:41 +00:00
James Teow
8ddb33d76d Bug 1948490 - Reference browser element in subframe request - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D238404
 2025-02-22 01:54:25 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-10 15:24:32 +00:00
James Teow
af3320fb69 Bug 1943998 - Part 2: Observe clicks in sponsored subframes - r=Standard8 
Depends on D235730

Differential Revision: https://phabricator.services.mozilla.com/D235731
 2025-02-10 06:22:05 +00:00
Alexandru Marc
f01c71ca19 Backed out 2 changesets (bug 1943998) for causing wd failures @ phases.py CLOSED TREE 
Backed out changeset 9b48fbc77a42 (bug 1943998)
Backed out changeset 2b88f3b5d92f (bug 1943998)
 2025-02-08 17:15:48 +02:00
James Teow
2e28bcf87b Bug 1943998 - Part 2: Observe clicks in sponsored subframes - r=Standard8 
Depends on D235730

Differential Revision: https://phabricator.services.mozilla.com/D235731
 2025-02-07 23:02:08 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-04 08:25:28 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
 2024-11-29 15:18:25 +00:00
Stephanie Cunnane
bf65f406f8 Bug 1930629 - Fix Bing follow-on searches selected from suggestion list that are incorrectly recorded as organic:none in telemetry. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D228892
 2024-11-13 22:20:17 +00:00
Florian Quèze
938c54e883 Bug 1929129 - Remove the browser.search.data_transferred telemetry recording, r=search-reviewers,Standard8. 
Differential Revision: https://phabricator.services.mozilla.com/D228300
 2024-11-13 15:52:29 +00:00
Stephanie Cunnane
c873aefe60 Bug 1927151 - Fix Bing follow-on searches incorrectly recorded as organic:none in telemetry. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D227266
 2024-11-01 19:25:48 +00:00
Florian Quèze
8d2717cf5a Bug 1923028 - Migrate scalars to use Glean APIs for browser.search.{content,withads,adclicks}.*, r=chutten,search-reviewers,scunnane. 
Differential Revision: https://phabricator.services.mozilla.com/D226509
 2024-10-24 10:52:56 +00:00
James Teow
43f2904306 Bug 1915856 - Enable region restrictions for SERP categorization - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D220911
 2024-09-18 13:58:35 +00:00
Mark Banner
28e4ba7093 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 16:43:57 +00:00
Butkovits Atila
11a5a23896 Backed out 7 changesets (bug 1870226) for causing build bustages. CLOSED TREE 
Backed out changeset 619244623dba (bug 1870226)
Backed out changeset e85a5647cae4 (bug 1870226)
Backed out changeset 21ea9baf83ea (bug 1870226)
Backed out changeset a506c0f0ce28 (bug 1870226)
Backed out changeset 77c78201a206 (bug 1870226)
Backed out changeset 7a98dfef087f (bug 1870226)
Backed out changeset f64ad89c2406 (bug 1870226)
 2024-08-23 12:22:02 +03:00
Mark Banner
1ee70a0f13 Bug 1870226 - Upgrade eslint-plugin-jsdoc to version 43.2.0. r=frontend-codestyle-reviewers,credential-management-reviewers,issammani 
This switches from the deprecated/removed jsdoc/newline-after-description rule to using the replacement jsdoc/tag-lines rule.

Differential Revision: https://phabricator.services.mozilla.com/D219512
 2024-08-23 08:55:49 +00:00
Stephanie Cunnane
267a9c02e8 Bug 1900094 - Add telemetry for impressions missing due to domain-to-categories map issues. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D214868
 2024-07-25 04:49:43 +00:00
Stephanie Cunnane
cbe0471b10 Bug 1879667 - Record client's experiment information in the SERP categorization ping. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D209269
 2024-07-17 16:51:12 +00:00
James Teow
f10b831079 Bug 1901839 - Classify engagements from urls that aren't categorized but match ads as ad_uncategorized - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D213350
 2024-06-18 06:02:58 +00:00
Stephanie Cunnane
260f31ac91 Bug 1892332 - Distinguish between private and regular browsing modes wrt Google signed-in telemetry. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D212040
 2024-06-01 02:52:17 +00:00
James Teow
1e7012698d Bug 1899663 - Change _checkURLForSerpMatch and updateTrackingStatus to have less impression logic - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D212100
 2024-05-30 19:04:14 +00:00
James Teow
cfe7e470ff Bug 1851907 - Remove SERP Telemetry v1 feature gating pref - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D207947
 2024-05-01 17:41:04 +00:00
James Teow
b70500ad86 Bug 1892267 - Add ads hidden and ads loaded to the categorization event - r=scunnane 
This augments the existing metric that contains the number of ads that were visible at the
time the page was snapshot.

Differential Revision: https://phabricator.services.mozilla.com/D207935
 2024-04-19 00:11:56 +00:00
Stephanie Cunnane
924cbf7d28 Bug 1877494 - Collect telemetry on Google account signed-in status. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D207206
 2024-04-15 19:30:24 +00:00
James Teow
8c082e0c2c Bug 1889677 - Modify SERP categorization tests to wait for events - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D206909
 2024-04-08 19:24:50 +00:00
James Teow
0ff995ac8c Bug 1889940 - Add additional logging for domain extraction - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D206777
 2024-04-05 15:32:52 +00:00
James Teow
4935a2a56a Bug 1886095 - Store hashed domain to categories inside Sqlite - r=mak,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D205025
 2024-04-04 12:25:52 +00:00
James Teow
d668670dc8 Bug 1887227 - Allow the ability to reset CategorizationRecorder from tests - r=scunnane 
When turning the feature gating pref on and running tests, it revealed one oversight:
When test files are run and we reset telemetry, we don't properly unload the internal
state of CategorizationRecorder. Doing so means that we can keep the "threshold" variable
in a non-zero state despite reseting all telemetry, which can cause submit() to fire when
we don't expect it.

Differential Revision: https://phabricator.services.mozilla.com/D205507
 2024-03-26 17:25:19 +00:00
James Teow
14a4f21eb3 Bug 1887233 - Don't count non-sponsored components as visible ads - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D205570
 2024-03-26 01:57:31 +00:00
Stephanie Cunnane
14eeeccf77 Bug 1887686 - Add shopping page property to SERP categorization event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D205607
 2024-03-25 21:31:28 +00:00
Mark Banner
937ef9b2d2 Bug 1878834 - Rename search-telemetry-schema to include v2 and add ui schema tests. r=scunnane 
Depends on D205250

Differential Revision: https://phabricator.services.mozilla.com/D205341
 2024-03-25 14:06:37 +00:00
Stephanie Cunnane
ae45f2ecde Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-22 17:57:09 +00:00
Noemi Erli
10a10f24fb Backed out changeset bc969033195f (bug 1872935) for causing failures in test_ping_submitted.py 2024-03-21 00:56:09 +02:00
Stephanie Cunnane
b44b0f6d2d Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-20 21:12:19 +00:00
Cristian Tuns
6053c16cee Backed out changeset e38df2dd9c60 (bug 1872935) for causing bc failures in browser_search_glean_serp_event_telemetry_categorization_enabled_by_nimbus_variable.js CLOSED TREE 2024-03-20 16:33:47 -04:00
Stephanie Cunnane
6830f8d52e Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-20 19:26:39 +00:00
James Teow
e7c6bac76d Bug 1875287 - Extract urls from query param values in links when required - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D201841
 2024-03-12 01:31:11 +00:00
Karandeep
d54583fc7d Bug 1849371 - Add cookie banner as a possible serp.ad_impression component and the user choice as one of the serp.engagement targets. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D200862
 2024-03-08 11:47:46 +00:00
James Teow
f83afd1a47 Bug 1883811 - Move domain processing into child process - r=scunnane 
Fundamentally, there shouldn't be any differences in functionality. I removed the
unit test since it was covered by the browser test and added a couple scenarios.

Differential Revision: https://phabricator.services.mozilla.com/D203706
 2024-03-07 15:39:52 +00:00
James Teow
6e3cc010a2 Bug 1882528 - Convert domains to category map to use a different hashing algorithm - r=scunnane 
On top of making the conversion, instead of using raw values in the test which can be hard
to parse when making changes, I converted the raw values back to domains and then use a helper
to convert it before passing it to the Map. I also removed the external files and stored the
values inside either head.js or within the test.

Differential Revision: https://phabricator.services.mozilla.com/D203226
 2024-03-05 05:22:28 +00:00
Dave Townsend
ff1cd075a5 Bug 1864896: Autofix unused function arguments (search). r=search-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202983
 2024-03-01 23:43:52 +00:00
James Teow
771da539f9 Bug 1881675 - Allow the ability to ignore specific urls in the network observer - r=scunnane 
In rare cases, we may need to add event listeners in the content process which also trigger
a network event that would be parsed by the network observer. To avoid counting double
engagements, I propose we add a new array of regular expressions that when a URL matches, will
never be parsed by the SERP telemetry logic in the network observer. This would rely on the
content process events listeners to register the engagement event.

I think the regular expression should be specific enough that it shouldn't match something
in a search result lest we ignore a click on it.

Differential Revision: https://phabricator.services.mozilla.com/D202583
 2024-02-27 14:05:22 +00:00
James Teow
512aa69979 Bug 1880410 - Clean up parts of search telemetry - r=scunnane 
Largely non-functional changes:
- The pagehide callback can live in the top level pagehide event.
- Moving the submitted check into the callback will make it easier to refactor
  the helper that adds event listeners.
- Changing the callbacks to use target as the name will make it easier to
  remember that the target is potentially overwritable.
- waitForPageWithAction can be used in future tests.

Differential Revision: https://phabricator.services.mozilla.com/D202036
 2024-02-23 17:16:14 +00:00