Commit Graph

13 Commits

Author SHA1 Message Date
Kris Maglione
34adef4b39 Bug 1370752: Part 2 - Allow fallback serializer when JSON.serialize fails. r=aswan
Currently, we need to be able to handle serializing non-JSON-compatible
objects without catastrophically failing to save the storage file. Ideally, we
would ensure this in the ordinary toJSON method. However, that would require
a unnecessary extra calls to JSON.stringify for each object that needs to be
sanitized before returning a JSON-safe value, which is more expensive than we
can afford.

The fallback toJSONSafe method allows us to do this only when necessary, due
to an initial failed JSON serialization.

MozReview-Commit-ID: JXQ001dOGtW
2017-06-09 18:19:11 -07:00
Wes Kocher
a0b015fa22 Backed out 2 changesets (bug 1370752) for failures in test_ext_storage.js a=backout
Backed out changeset 42d3c1599af5 (bug 1370752)
Backed out changeset 9c4bf59ab966 (bug 1370752)

MozReview-Commit-ID: 4M6DsJvJ6RI
2017-07-10 14:34:56 -07:00
Kris Maglione
1266084333 Bug 1370752: Part 2 - Allow fallback serializer when JSON.serialize fails. r=aswan
Currently, we need to be able to handle serializing non-JSON-compatible
objects without catastrophically failing to save the storage file. Ideally, we
would ensure this in the ordinary toJSON method. However, that would require
a unnecessary extra calls to JSON.stringify for each object that needs to be
sanitized before returning a JSON-safe value, which is more expensive than we
can afford.

The fallback toJSONSafe method allows us to do this only when necessary, due
to an initial failed JSON serialization.

MozReview-Commit-ID: JXQ001dOGtW
2017-06-09 18:19:11 -07:00
Kris Maglione
86e4e80487 Bug 1358846: Part 2 - Allow using file compression with JSONFile.jsm. r=rhelmer
MozReview-Commit-ID: 5lHsZqBGq3E
2017-04-22 18:23:22 -07:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Kit Cambridge
704449ade9 Bug 1332024 - Add a method to explicitly finalize JSONFile objects. r=Paolo
MozReview-Commit-ID: QaRqLBGEft
2017-01-24 17:38:35 -08:00
Kit Cambridge
8bf3169107 Bug 1319175 - Add a data setter and beforeSave hook to JSONFile. r=MattN
* The `data` setter sets the backing data object to a new value, and
  flips `dataReady` so that `ensureDataReady` and `load` don't read
  stale data from disk. This can be used to clear existing data.
* The `beforeSave` hook is called from `_save`, as part of the deferred
  task. This can be used to create intermediate directories containing
  the file, or run other pre-save tasks that shouldn't be interrupted
  by shutdown.

MozReview-Commit-ID: AzOx7u2Rali
2016-12-19 08:32:29 -08:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Luke Chang
36e6375328 Bug 1309481 - Remove leftover code specific to Logins from JSONFile.jsm and add tests; r=Paolo
MozReview-Commit-ID: DjEPCN2PXA1
2016-10-17 18:26:35 +08:00
Luke Chang
7894cd3129 Bug 1304322 - Refactor LoginStore.jsm to make it reusable for Form Autofill; r=MattN
MozReview-Commit-ID: Kx8aALU7fu2
2016-09-21 17:29:48 +08:00