Commit Graph

1128 Commits

Author SHA1 Message Date
Xidorn Quan
5c533c7216 Bug 1258636 part 1 - Use structs to pass params for decoration-related functions in nsCSSRendering. r=jfkthame
MozReview-Commit-ID: 5EJJVmM1pyK
2016-03-22 16:51:15 +08:00
Xidorn Quan
ba620a636b Bug 1257121 part 4 - Use return value rather than out param to return font metrics. r=jfkthame
MozReview-Commit-ID: 6xrHYbgHGVd
2016-03-17 13:55:48 +08:00
Ting-Yu Lin
2b5db8a11e Bug 1251519 Part 1 - Remove nsTextFrameBase as an nsFrame alias. r=mats
Bug 655877 Part 20 made this deliberately to let nsTextFrame
QueryFrame-able. https://hg.mozilla.org/mozilla-central/rev/d8c6025c0881

But other types like nsPlaceholderFrame or nsBulletFrame are also
implemented QureyFrame, which do not have this inheritance indirection.
I guess it was for historical reason, and can be removed safely.

MozReview-Commit-ID: CPeQvpKzEKh
2016-03-10 17:38:31 +08:00
Xidorn Quan
c51b6be554 Bug 1251995 part 7 - Use struct to pass params for nsTextFrame::Paint*Shadow functions. r=jfkthame
MozReview-Commit-ID: 5Wa9U0Ile4L
2016-03-08 15:56:18 +08:00
Xidorn Quan
9ab7e4d458 Bug 1251995 part 6 - Use struct to pass params for nsTextFrame::PaintText* functions. r=jfkthame
MozReview-Commit-ID: NTEUm8TY8N
2016-03-08 15:56:18 +08:00
Xidorn Quan
f72864bd15 Bug 1251995 part 5 - Unify units of dirty rect used for painting text frame. r=jfkthame
MozReview-Commit-ID: BK7j6y7lBV3
2016-03-08 15:56:18 +08:00
Xidorn Quan
94d079bb70 Bug 1251995 part 4 - Use struct to pass params for nsTextFrame::DrawText* functions. r=jfkthame
MozReview-Commit-ID: LYshkPDrqYl
2016-03-08 15:56:18 +08:00
Xidorn Quan
30cecb5900 Bug 1251995 part 3 - Use struct to pass params for gfxTextRun::Draw. r=jfkthame
MozReview-Commit-ID: HAqtS3VXPHH
2016-03-08 15:56:18 +08:00
Xidorn Quan
0547ab650a Bug 1251995 part 2 - Add gfxTextRun::Range to replace parameter pairs like (offset, length) and (start, end). r=jfkthame
Although this makes some places more complicated, code should generally
be simpler and clearer. It could slightly improve performance on x64 for
functions with more than four parameters, since it makes more data be
passed via registers rather than the stack.

MozReview-Commit-ID: D0GM2Jyrr6W
2016-03-08 15:56:18 +08:00
Xidorn Quan
b4c925b144 Bug 1251995 part 1 - Add helper functions to simplify code. r=jfkthame
MozReview-Commit-ID: 6UBvmEpo12f
2016-03-08 15:56:18 +08:00
Carsten "Tomcat" Book
335b84b15e Backed out changeset d88221aad093 (bug 1251995) for reftest failures 2016-03-07 12:18:40 +01:00
Carsten "Tomcat" Book
1d112f4b74 Backed out changeset bf004c055beb (bug 1251995) 2016-03-07 12:18:19 +01:00
Carsten "Tomcat" Book
02494b6b36 Backed out changeset 3f9fbbef0294 (bug 1251995) 2016-03-07 12:18:17 +01:00
Carsten "Tomcat" Book
35c2f99d6a Backed out changeset 9b31d6fb1fcb (bug 1251995) 2016-03-07 12:18:16 +01:00
Carsten "Tomcat" Book
34a139b484 Backed out changeset ac1d42c669be (bug 1251995) 2016-03-07 12:18:14 +01:00
Carsten "Tomcat" Book
af2fd1e1ee Backed out changeset c36e12ded845 (bug 1251995) 2016-03-07 12:18:13 +01:00
Carsten "Tomcat" Book
8e9989e49a Backed out changeset 734559c25cb1 (bug 1251995) 2016-03-07 12:18:11 +01:00
Xidorn Quan
4a98d1fa4a Bug 1251995 part 7 - Use struct to pass params for nsTextFrame::Paint*Shadow functions. r=jfkthame
MozReview-Commit-ID: 5Wa9U0Ile4L
2016-03-02 09:41:43 +08:00
Xidorn Quan
046f53091c Bug 1251995 part 6 - Use struct to pass params for nsTextFrame::PaintText* functions. r=jfkthame
MozReview-Commit-ID: NTEUm8TY8N
2016-03-01 17:43:06 +08:00
Xidorn Quan
25d1c00994 Bug 1251995 part 5 - Unify units of dirty rect used for painting text frame. r=jfkthame
MozReview-Commit-ID: BK7j6y7lBV3
2016-03-01 16:28:27 +08:00
Xidorn Quan
283943571f Bug 1251995 part 4 - Use struct to pass params for nsTextFrame::DrawText* functions. r=jfkthame
MozReview-Commit-ID: LYshkPDrqYl
2016-03-02 13:27:17 +08:00
Xidorn Quan
cf80ca74a5 Bug 1251995 part 3 - Use struct to pass params for gfxTextRun::Draw. r=jfkthame
MozReview-Commit-ID: HAqtS3VXPHH
2016-02-29 19:06:05 +08:00
Xidorn Quan
15658bb242 Bug 1251995 part 2 - Add gfxTextRun::Range to replace parameter pairs like (offset, length) and (start, end). r=jfkthame
Although this makes some places more complicated, code should generally
be simpler and clearer. It could slightly improve performance on x64 for
functions with more than four parameters, since it makes more data be
passed via registers rather than the stack.

MozReview-Commit-ID: D0GM2Jyrr6W
2016-02-29 16:50:17 +08:00
Xidorn Quan
4e488c536b Bug 1251995 part 1 - Add helper functions to simplify code. r=jfkthame
MozReview-Commit-ID: 6UBvmEpo12f
2016-03-04 19:20:43 +08:00
Cameron McCormack
8a879b8032 Bug 1244068 - Part 4: Use StyleSetHandle instead of concrete style set class in most places. r=dholbert 2016-02-24 18:01:11 +11:00
Boris Chiou
16edfa82cd Bug 1244049 - Part 1: Define scoped enum for CSSPseudoElement type. r=dbaron 2016-02-16 23:07:00 +01:00
Mats Palmgren
0c285fc1aa Bug 1216001 part 3 - Cache the result of IsSelected() for the duration of painting. r=bz 2016-02-13 18:40:23 +01:00
Phil Ringnalda
6cdb00759a Back out 3 changesets (bug 1216001) for Win8 reftest failures in 1193519-sideways-lr-3.html and 1193519-sideways-lr-4.html and intermittent OS X failures in font-display-2.html
CLOSED TREE

Backed out changeset dbadb8fe5803 (bug 1216001)
Backed out changeset a30593ebd58e (bug 1216001)
Backed out changeset c1646ffa71b4 (bug 1216001)
2016-02-11 20:43:41 -08:00
Mats Palmgren
4bf6e26e18 Bug 1216001 part 3 - Cache the result of IsSelected() for the duration of painting. r=bz 2016-02-12 02:13:57 +01:00
Birunthan Mohanathas
7e3dfe6775 Bug 1235261 - Part 3: Switch remaining uses of AutoFallibleTArray to AutoTArray. r=froydnj
This is effectively a no-op because the affected array operations already use
`mozilla::fallible`.
2016-02-02 17:36:30 +02:00
Birunthan Mohanathas
bfee0fb40c Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
Alexander Surkov
6b49e14d46 Bug 1220502 - ignore not visible text nodes for tree update, r=tbsaunde, roc 2016-02-01 17:05:45 -05:00
Phil Ringnalda
d871b9515f Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
CLOSED TREE

Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
2b65ae7f2d Bug 1235261 - Part 3: Switch remaining uses of AutoFallibleTArray to AutoTArray. r=froydnj
This is effectively a no-op because the affected array operations already use
`mozilla::fallible`.
2016-01-31 17:12:12 +02:00
Birunthan Mohanathas
245cd6a02f Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-01-31 17:12:12 +02:00
Ting-Yu Lin
122e5b9aeb Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats 2016-01-29 22:42:14 +08:00
Xidorn Quan
0b78aca734 Bug 1230034 part 10 - Convert remaining frame properties to by typed and remove the unsafe declaring macro. r=dbaron 2016-01-28 14:23:59 +11:00
Xidorn Quan
c26e860288 Bug 1230034 part 6 - Convert all frame properties which do not hold pointer to be typed. r=dbaron 2016-01-28 14:23:59 +11:00
Xidorn Quan
ca146f45ac Bug 1230034 part 5 - Convert all frame properties which use DeleteValue and ReleaseValue as destructor to be typesafe. r=dbaron
By changing signature of those two functions, we make compiler complain about
all their existing uses, so we can find all of them and convert them.

Some of the callsites of Get() with those properties are also converted, but not
all of them. It is fine because if there is any incorrect conversion, compilers
is able to find out now. So they are completely typesafe.
2016-01-28 14:23:59 +11:00
Xidorn Quan
4dccb52f19 Bug 1230034 part 3 - Move some frame property declaration around. r=dbaron 2016-01-28 14:23:59 +11:00
Bogdan Postelnicu
0329310a32 Bug 1239251 - Initialize mCommonAncestorWithLastFrame with nullptr in constructor BuildTextRunsScanner. r=roc 2016-01-14 10:49:15 +02:00
Nicholas Nethercote
7fabd8754f Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.

The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:

- It adds a comment about the null check in
  gfxGlyphExtents::GetTightGlyphExtentsAppUnits().

- A couple of functions simply had an unused gfxContext or nsRenderingContext
  parameter removed, e.g. SetLineBreaks().
2015-12-15 13:56:41 -08:00
Nicholas Nethercote
be50c42d8b Bug 1232822 (part 4) - Remove unused argument from SetPotentialLineBreaks(). r=jfkthame. 2015-12-15 13:56:40 -08:00
Jonathan Kew
d582b157a0 Bug 1224669 - Clamp width to be non-negative during intrinsic width calculation. r=dholbert 2016-01-01 10:29:27 +00:00
Xidorn Quan
16dc7cb0c0 Bug 1235489 - Remove assertion which is breakable when reflow is interrupted. r=jfkthame 2015-12-31 10:50:32 +11:00
Xidorn Quan
1a0b030355 Bug 1225018 part 2 - Move GetFontMetricsOfEmphasisMarks to nsLayoutUtils. r=jfkthame 2015-12-08 12:55:01 -05:00
Nicholas Nethercote
fe73890223 Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow. 2015-12-06 14:13:57 -08:00
Xidorn Quan
79d8370f97 Bug 1229739 - Use the color of shadow if available for drawing emphasis marks in shadow. r=jfkthame 2015-12-04 16:28:34 +11:00
Xidorn Quan
a0dc4027f4 Bug 1224013 part 2 - Render text-emphasis outside ruby. r=jfkthame 2015-12-04 15:16:54 +11:00
Xidorn Quan
e2a9789117 Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013) for reftest failures on CLOSED TREE 2015-12-04 13:08:17 +11:00