Commit Graph

287 Commits

Author SHA1 Message Date
Daniel Holbert
620964f6a0 Bug 1269017 part 2 - [css-grid] Give grid an implementation of CSSAlignmentForAbsPosChild(). r=mats
This grid implementation is similar to the one on nsFlexContainerFrame, with a few simplifications:
 - We can simply use the LogicalAxis to decide between align-* vs justify-* prpoerties (whereas flexbox has extra abstraction from the flex axes).
 - We don't have to bother with "align-content" or "justify-content", since those apply to grid areas rather than to children. (And any grid area that's involved will be sized/positioned separately.)
 - Grid can unconditionally treat "flex-start" & "flex-end" as "start" & "end".

MozReview-Commit-ID: 9l1Wq9Cq5T0
2016-11-08 16:30:00 -08:00
Mats Palmgren
4ad1aee630 Bug 1313254 part 6 - [css-grid] A few comment tweaks. rs=dholbert 2016-11-05 02:57:08 +01:00
Mats Palmgren
d9df1bc378 Bug 1313254 part 2 - [css-align] Change "last-baseline" to "last baseline" in layout/ (scripted change). r=dholbert 2016-11-05 02:57:07 +01:00
Mats Palmgren
99afd7808d Bug 1300369 part 7 - [css-grid] Implement margin-box min-size clamping for grid item reflow. r=dholbert 2016-11-05 02:57:06 +01:00
Mats Palmgren
20ff06c736 Bug 1300369 part 3 - [css-grid] Implement margin-box min-size clamping during track sizing. r=dholbert 2016-11-05 02:57:06 +01:00
Daniel Holbert
087210301f Bug 1269046 part 8: Rewrite CSSAlignUtils::AlignJustifySelf to use a single "flags" arg instead of boolean args. r=mats
MozReview-Commit-ID: 5loE21U7FF6
2016-10-31 08:59:40 -07:00
Daniel Holbert
e6b037482a Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
MozReview-Commit-ID: 1Eh2CreOLTC
2016-10-31 08:58:18 -07:00
Mats Palmgren
e1a45160ab Bug 1305244 part 3 - [css-grid] Stop handling <flex> track min-sizing in layout since they can't occur anymore. r=dholbert 2016-10-29 01:30:10 +02:00
Mats Palmgren
0c8abdcea3 Bug 1228455 - [css-grid] Update the 'used flex fraction' for indefinite sizes to clamp flex factors less than 1 before dividing the base size (due to CSS Grid spec change). r=dholbert
CSS Grid spec change:
https://hg.csswg.org/drafts/rev/42427088d71f
2016-10-27 10:32:00 -04:00
Phil Ringnalda
04ae3c60e8 Backed out 12 changesets (bug 1269045, bug 1269046) as the most likely cause of Windows build bustage
CLOSED TREE

Backed out changeset 16db55b642a9 (bug 1269046)
Backed out changeset a0008dd33cf4 (bug 1269046)
Backed out changeset 75b58c4e61e6 (bug 1269046)
Backed out changeset fb7655f3e1cf (bug 1269046)
Backed out changeset 8088e5a9e6e3 (bug 1269046)
Backed out changeset eea6479452f0 (bug 1269046)
Backed out changeset eb4b52bf06ec (bug 1269046)
Backed out changeset 539db74e4a88 (bug 1269046)
Backed out changeset f57f9ac1435e (bug 1269045)
Backed out changeset 2162d5c9fb54 (bug 1269045)
Backed out changeset 7aa8199183fc (bug 1269045)
Backed out changeset 86a391e3e163 (bug 1269045)

MozReview-Commit-ID: HYL7Bh8l02E
2016-10-27 21:59:00 -07:00
Daniel Holbert
283027c536 Bug 1269046 part 1: Spin out some grid alignment code into a helper method, in a new CSSAlignUtils class. r=mats
MozReview-Commit-ID: 1Eh2CreOLTC
2016-10-27 18:58:26 -07:00
Daniel Holbert
b20c9edc66 Bug 1311865: Refactor the grid "same sides" code into a simpler WritingMode::ParallelAxisHasSamePolarity() utility function. r=mats
MozReview-Commit-ID: G9FRriSlZaG
2016-10-20 17:45:07 -07:00
Mats Palmgren
1cc0b37688 Bug 1302541 part 5 - [css-grid] Back-compute percentages when calculating the number of auto-fill/fit tracks. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
8a229c1d2d Bug 1302541 part 4 - [css-grid] Back-compute percentages for the intrinsic block size. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
377bbbd062 Bug 1302541 part 3 - [css-grid] Back-compute percentages for the intrinsic inline size. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
eb50d07d19 Bug 1302541 part 2 - [css-grid] Propagate track state bits and store the union of all tracks in each axis. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
12f963cdfa Bug 1302541 part 1 - [css-grid] Add a track state bit for percentage min-sizing that is treated as 'auto'. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
cdf12985a8 Bug 1309407 - [css-grid] Apply min/max-sizes after stretching <flex> grid items with an indefinite CB size and re-run the algo with a definite size if the grid size changed. r=dholbert 2016-10-19 04:20:48 +02:00
Mats Palmgren
402f678f51 Bug 1306906 - [css-grid] Get the relevant baseline from the grid item for the basline group. r=dholbert 2016-10-06 22:43:22 +02:00
Mats Palmgren
1e78e1e587 Bug 1307113 - [css-grid] Fix a typo in baseline track selection. r=dholbert 2016-10-04 21:13:53 +02:00
Carsten "Tomcat" Book
a2be0596bc merge mozilla-inbound to mozilla-central a=merge 2016-10-04 11:58:07 +02:00
David Keeler
283fd3d6e0 bug 1307226 - extend clang crash workaround to work around similar crash in SetGridItemCount r=mats
MozReview-Commit-ID: 1fHN2mpYyxz
2016-10-03 14:08:54 -07:00
Mats Palmgren
be61233121 Bug 1151204 part 5 - [css-grid] Fix a bug in the is-this-the-last-track check. r=dholbert 2016-10-01 02:26:39 +02:00
Mats Palmgren
250f9b064b Bug 1151204 part 4 - [css-grid] Implement Grid Container Baselines. r=dholbert 2016-10-01 02:26:39 +02:00
Mats Palmgren
679ec54f13 Bug 1151204 part 3 - [css-grid] Add a couple of members to record fragmentation state. r=dholbert 2016-10-01 02:26:39 +02:00
Mats Palmgren
78f2bc05a1 Bug 1151204 part 2 - [css-grid] Add methods for finding the first/last grid item in Grid Order in this fragment. r=dholbert 2016-10-01 02:26:39 +02:00
Mats Palmgren
7593483fa4 Bug 1151204 part 1 - [css-grid] Make GridItemCSSOrderIterator use nsFrameList iterators internally and make the specific type (forward/reverse) a template param. r=dholbert 2016-10-01 02:26:39 +02:00
Brad Werth
1148c21217 Bug 1304012 -- Part 2: Rename nsStyleStruct Computed**Self functions to Used**Self. r=dholbert
MozReview-Commit-ID: FCBuT2Z7sy6
2016-09-30 09:15:57 -07:00
Brad Werth
dd331658a6 Bug 1305844 - Make most align/justify nsStylePosition members public, and remove trivial accessors. r=dholbert 2016-10-03 13:05:35 -07:00
Mats Palmgren
a18380557e Bug 1303643 part 2 - [css-grid] Apply percentages to grid item min-content contributions. r=dholbert 2016-09-29 21:49:54 +02:00
Mats Palmgren
9725d87ef7 Bug 1255393 part 7 - [css-grid] Update intrinsic max track sizing for span>1 to the latest Grid spec. r=dholbert
Step 2.5 "For intrinsic maximums" now use the min-size contribution.
https://hg.csswg.org/drafts/diff/575fb847e29d/css-grid/Overview.bs
https://drafts.csswg.org/css-grid/#algo-content
2016-09-27 17:05:41 +02:00
Mats Palmgren
67f8bba634 Bug 1255393 part 6 - [css-grid] Update 'auto' min track sizing for span>1 to the latest Grid spec. r=dholbert
'auto' tracks now also gets an item's min/max-content contribution
(in 2.2/2.3) when sizing under a min/max-content constraint.
(Previously, 'auto' only got the min-size contribution under 2.1)
https://drafts.csswg.org/css-grid/#algo-content
2016-09-27 17:05:41 +02:00
Mats Palmgren
4d4bc2b734 Bug 1255393 part 5 - [css-grid] Remove dead code related to obsolete flex track min-sizing. r=dholbert 2016-09-27 17:05:41 +02:00
Mats Palmgren
5f2701d66c Bug 1255393 part 4 - [css-grid] Cache min/max-content and min-size contributions better. r=dholbert 2016-09-27 17:05:41 +02:00
Mats Palmgren
b4a6280e9d Bug 1255393 part 3 - [css-grid] Update 'auto' min track sizing for span=1 to the latest Grid spec. r=dholbert
Now it returns the min/max-content contribution for intrinsic sizing.
Otherwise, i.e. during Reflow, return the min-size contribution.
(Previously, it always returned the min-size contribution.)
https://drafts.csswg.org/css-grid/#algo-content
2016-09-27 17:05:40 +02:00
Mats Palmgren
f2718d6a3c Bug 1255393 part 2 - [css-grid] Update MinSize() to reflect the latest spec text for min-size contribution. r=dholbert
https://drafts.csswg.org/css-grid/#min-size-contributions
2016-09-27 17:05:40 +02:00
Mats Palmgren
48ac513c68 Bug 1255393 part 1 - [css-grid] Introduce a SizingConstraint enum type. r=dholbert 2016-09-27 17:05:40 +02:00
Brad Werth
6b92e7e217 Bug 1300877 - Expose removed grid auto-fit tracks to devtools API. r=mats, r=ehsan
MozReview-Commit-ID: 3E1au3BQyLw
2016-09-21 11:49:29 -07:00
Brad Werth
4a2c6bb432 Bug 1278461 - Prevent an assert from tripping when removing an overflowed frame during a partial reflow. r=mats 2016-09-22 12:37:35 -07:00
Mats Palmgren
961bd3edf0 Bug 1280798 part 2 - [css-grid] Take any specified [min-/max-]width/height into account when calculating the number of auto-fill/fit tracks for intrinsic sizing. r=dholbert 2016-09-21 02:14:40 +02:00
Mats Palmgren
d56c53f6eb Bug 1280798 part 1 - [css-grid] Simplify handling of min-size for repeat track calculation. r=dholbert 2016-09-21 02:14:39 +02:00
Mats Palmgren
c741905196 Bug 1299133 - [css-grid] Subtract the grid-gaps in the span when collecting growable tracks. r=dholbert 2016-09-12 23:13:08 +02:00
Wes Kocher
294ad5354d Backed out 2 changesets (bug 1299133) for win vm reftest failures a=backout CLOSED TREE
Backed out changeset fa010785b1ed (bug 1299133)
Backed out changeset 8898636baa30 (bug 1299133)
2016-09-12 15:53:52 -07:00
Mats Palmgren
280773d1b2 Bug 1299133 - [css-grid] Subtract the grid-gaps in the span when collecting growable tracks. r=dholbert 2016-09-12 23:13:08 +02:00
Brad Werth
9eb055d1ab Bug 1281446 - Resolved value of grid-template-columns/rows now lists removed auto-fit tracks as 0px. r=mats 2016-09-08 08:40:06 -07:00
Brad Werth
8aefcca6ff Bug 1297189 - Expose implicit grid areas via dev tools API. r=mats, r=bz 2016-09-02 16:28:27 -07:00
Nicholas Nethercote
887efe04d5 Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Mats Palmgren
36560b9509 Bug 1171419 part 10 - Rename RenumberLists() to RenumberList(). r=xidorn 2016-09-01 17:36:23 +02:00
Mats Palmgren
5f0014f4c1 Bug 1171419 part 8 - Implement list-item numbering for grid containers. r=xidorn 2016-09-01 17:36:23 +02:00
Wes Kocher
e079662c3f Merge inbound to central, a=merge 2016-08-26 16:20:50 -07:00