Sylvestre Ledru
9d4a84d778
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
2017-07-06 14:00:35 +02:00
Emilio Cobos Álvarez
3731858edf
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
2017-04-30 17:30:08 +02:00
Nathan Froyd
404078d785
Bug 1295192 - part 1 - remove CPP_THROW_NEW on layout struct operator new overloads that forward to nsPresShell::AllocateByObjectID; r=dholbert
...
Structs in our style system use an arena-style allocation system,
managed by the presshell to which they belong. All of the relevant
overloads that forward allocation requests to the presshell declare
themselves as CPP_THROW_NEW, which indicates that they do not throw
exceptions. The C++ specification states that operator new overloads
that declare themselves to not throw exceptions require a null check on
their return value. However, the relevant presshell allocation method,
AllocateByObjectID, is infallible and will never return a null pointer.
The callers of all of these methods are therefore doing useless
(compiler-generated) null checks. Let's get rid of those useless checks
by removing the CPP_THROW_NEW annotations. This change declares these
methods will return non-null pointers and throw exceptions in case of
errors--but as we don't use exceptions, and AllocateByObjectID will
abort on OOM, everything works out OK.
2016-08-17 15:28:45 -04:00
Wes Kocher
63041461e3
Backed out 4 changesets (bug 1295192) for being a possible cause of crashtest assertions CLOSED TREE
...
Backed out changeset 7f10779fe019 (bug 1295192)
Backed out changeset e683dce4197a (bug 1295192)
Backed out changeset 67d12eaa8074 (bug 1295192)
Backed out changeset 44f143a01f78 (bug 1295192)
2016-08-16 11:22:04 -07:00
Nathan Froyd
dabc06ebd0
Bug 1295192 - part 1 - remove CPP_THROW_NEW on layout struct operator new overloads that forward to nsPresShell::AllocateByObjectID; r=dholbert
...
Structs in our style system use an arena-style allocation system,
managed by the presshell to which they belong. All of the relevant
overloads that forward allocation requests to the presshell declare
themselves as CPP_THROW_NEW, which indicates that they do not throw
exceptions. The C++ specification states that operator new overloads
that declare themselves to not throw exceptions require a null check on
their return value. However, the relevant presshell allocation method,
AllocateByObjectID, is infallible and will never return a null pointer.
The callers of all of these methods are therefore doing useless
(compiler-generated) null checks. Let's get rid of those useless checks
by removing the CPP_THROW_NEW annotations. This change declares these
methods will return non-null pointers and throw exceptions in case of
errors--but as we don't use exceptions, and AllocateByObjectID will
abort on OOM, everything works out OK.
2016-08-16 17:05:39 -04:00
Cameron McCormack
2092fefbc0
Bug 1203766 - Part 1: Generate nsPresArena::ObjectIDs with a preprocessor-included file. r=bzbarsky
2015-09-17 12:08:19 +10:00
Birunthan Mohanathas
a29151dc87
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
Jonathan Kew
fd9f4bada9
Bug 1111525 - Remove unused lineFlags returned by nsILineIterator. r=roc
2014-12-19 14:55:30 +00:00
Simon Montagu
3c04c06924
Bug 1100071 patch 3: don't pass around bidi levels when we only need the direction, r=dholbert
2014-11-20 12:45:23 +02:00
Simon Montagu
4c365d8f67
Bug 1100071 patch 2: add macros for common tests whether bidi level is odd and whether two bidi levels have the same parity, r=dholbert
2014-11-20 12:45:22 +02:00
Mats Palmgren
2bf4caa0e2
Bug 508665 - part 6, Require a nsContainerFrame* for aParent in nsFrameList methods. r=roc
2014-05-24 22:20:40 +00:00
Mats Palmgren
a73e99dbc1
Bug 508665 - part 1, Change the signature of SetParent/GetParent from nsIFrame* to nsContainerFrame*. r=roc
2014-05-24 22:20:39 +00:00
Ehsan Akhgari
c01e9369ee
Bug 491863 - Remove IBMBIDI; r=roc
2014-04-23 21:15:29 -04:00
Timothy Nikkel
6d096d724f
Bug 962443. Make layout frame tree dumping code work better for Fennec and b2g. r=mats
2014-01-26 16:07:02 -06:00
Mats Palmgren
a56486443d
Bug 956447 - Make it possible to get frame dumps in non-DEBUG builds. r=roc
2014-01-05 23:31:14 +00:00
Ehsan Akhgari
06d49ffd4d
Bug 907883 - Minimize #includes in layout/generic; r=roc
2013-08-22 14:32:52 -04:00
Mats Palmgren
868d2c33cd
Bug 729519 - Allocate heap nsFrameLists from the shell arena. r=bzbarsky
...
"new nsFrameList()" becomes "new (shell) nsFrameList()".
"delete list" becomes "if (list) list->Delete(shell)" - note also that
an additional assertion was added that list is empty when deleted.
"nsAutoPtr<nsFrameList> list(StealSomeFrames())" becomes
"AutoFrameListPtr list(aPresContext, StealSomeFrames())"
2013-04-01 17:26:02 +02:00
Mats Palmgren
0ea4a880c3
Bug 729519 - Allocate nsFrameList::sEmptyList from the .rodata segment, not the heap. r=bzbarsky
2013-04-01 17:26:02 +02:00
Mats Palmgren
7d8b692140
Bug 838706 - Remove Destroy/RemoveFrameIfPresent O(n) methods. All consumers are now using Start/ContinueRemoveFrame instead which are O(1). r=bzbarsky
2013-02-28 00:05:45 +01:00
Mats Palmgren
d4deaee2e3
Bug 838642 - Introduce nsFrameList::StartRemoveFrame/ContinueRemoveFrame that can be used in concert to remove a frame in O(1) time from a set of frame lists when its exact frame list is unknown. Use them to make nsContainerFrame::StealFrame O(1). r=bzbarsky
2013-02-28 00:05:44 +01:00
Ehsan Akhgari
243c878d26
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
8b4a23fc4c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Gervase Markham
cb6a072c2a
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Daniel Holbert
8ebfc81c53
Bug 738705: Remove dead helper-class CompareByContentOrderComparator. r=bz
2012-03-23 11:17:33 -07:00
Ehsan Akhgari
478ad1a412
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
0fe7772ece
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
2011-09-28 23:19:26 -07:00
Simon Montagu
1f18554f1f
Make all nsBidiPresUtils methods static. Bug 624798, r=roc
2011-04-13 12:23:49 +03:00
Craig Topper
5f134c2838
Bug 654369 - Part 5: Make nsFrameList::Init return void r=bz
2011-05-01 23:32:59 -07:00
Simon Montagu
b5f2348b59
Back out bug 263359 and bug 624798 because of performance regressions (bug 650189)
2011-04-27 11:47:18 +03:00
Simon Montagu
d03542b94f
Make all nsBidiPresUtils methods static. Bug 624798, r=roc
2011-04-13 12:23:49 +03:00
L. David Baron
21310c2cf6
Add checks to VerifyList that previous siblings match next siblings. (Bug 563584, patch 21) r=roc
2010-08-05 21:59:20 -07:00
L. David Baron
986e330c40
Make nsFrameList::RemoveFramesAfter(nsnull) remove the whole list. (Bug 563584, patch 11.5) r=roc
2010-08-05 21:59:19 -07:00
Ehren Metcalfe
97778d4898
Bug 556446: Remove dead code in layout. r=roc,bz
2010-04-03 07:36:19 -04:00
fantasai
f76a01be55
Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc
2009-12-24 00:21:15 -05:00
fantasai
9e51dfaf9b
Bug 508473 Part II: Remove DeletingFrameSubtree r=bz sr=roc
2009-12-24 00:20:41 -05:00
Robert O'Callahan
0cbb49a1df
Bug 526072. Guard super-expensive nsFrameList assertions with #ifdef DEBUG_FRAME_LIST so debug builds don't completely suck. r=bz
2009-11-04 07:39:41 +13:00
Boris Zbarsky
8e9c649afe
Bug 512336. Make frame lists doubly-linked. r=roc,fantasai
2009-10-02 12:27:37 -04:00
Mats Palmgren
150878f763
Remove unused methods. b=516976 r=bzbarsky
2009-09-20 23:37:30 +02:00
Mats Palmgren
f85d73c25c
Bug 233463, patch 5 - Remove nsFrameList(nsIFrame*) ctor. r=bzbarsky
2009-09-18 13:09:36 +02:00
Mats Palmgren
54e643ff5b
Bug 233463, patch 3 - Make Destroy/RemoveFrame() methods void and assert that the frame to remove is present. r=bzbarsky
2009-09-18 13:09:36 +02:00
Mats Palmgren
6f16626d51
Bug 233463, patch 2 - Introduce nsFrameList::mLastChild member for fast access to the last sibling frame. r=bzbarsky
2009-09-18 13:09:36 +02:00
Mats Palmgren
6247c7c4c6
Bug 233463, patch 0 - Use nsFrameList methods instead of nsIFrame::SetNextSibling. r=bzbarsky
2009-09-18 13:09:35 +02:00
Zack Weinberg
18f8b8b129
Bug 510651: Fold nsIFrameDebug into nsFrame. r=dbaron sr=mrbkap
2009-08-20 14:52:48 -07:00
Boris Zbarsky
03729316a0
Bug 504972. Remove some redundant code. r=roc
2009-07-28 08:53:20 -04:00
Boris Zbarsky
5a510c0676
Bug 504221 part 11. Switch the {ib}-split list munging to nsFrameList. r=fantasai,roc
2009-07-28 08:53:19 -04:00
Boris Zbarsky
b6729ff0a3
Bug 504221 part 10. Switch the first-line frame list munging to nsFrameList. r=fantasai, r+sr=roc
2009-07-28 08:53:19 -04:00
Boris Zbarsky
8735e07de7
Bug 504221 part 7. Make nsFrameItems inherit from nsFrameList. rfantasai, r+sr=roc
2009-07-28 08:53:18 -04:00
Boris Zbarsky
2eb38e3023
Bug 504221 part 3. Switch overflowFrames storage to nsFrameList. r=fantasai, r+sr=roc
2009-07-28 08:51:09 -04:00
Boris Zbarsky
a8f71ee00d
Bug 504221 part 1. Introduce framelist slice and enumerator classes and make the framelist versions of nsFrameList::AppendFrames/InsertFrames return a slice for the new frames. r=fantasai, r+sr=roc
2009-07-28 08:51:08 -04:00
Robert O'Callahan
d132a799f6
Bug 384037. Eliminate nsFrameNavigator and switch XUL splitters to using nsFrameList instead. Also add a check so that we don't crash when a splitter's parent is not a XUL box. r+sr=dbaron
2009-04-25 20:33:32 +12:00