Commit Graph

46 Commits

Author SHA1 Message Date
Kartikaya Gupta
42cf0f4da6 Bug 1382200 - Eliminate LayerMetricsWrapper::IsScrollInfoLayer entirely by inlining it. r=botond
MozReview-Commit-ID: KX35cjOAQw7
2017-07-19 09:24:28 -04:00
Kartikaya Gupta
4b62d02981 Bug 1382200 - Change implementation of the LayerMetricsWrapper IsScrollInfoLayer to use the metrics flag. r=botond
This also updates the WebRenderScrollDataWrapper function as it is meant
to be semantically equivalent to the LayerMetricsWrapper one, which
allows removal of a flag propagation.

MozReview-Commit-ID: 9DBx4qbhq5A
2017-07-19 09:24:24 -04:00
Botond Ballo
34b6714af1 Bug 1352863 - Propagate the visible region from Layer to HitTestingTreeNode. r=kats
The propagation happens via LayerMetricsWrapper or WebRenderScrollDataWrapper.

MozReview-Commit-ID: GBZUnNn3zjN
2017-05-24 15:47:14 -04:00
Kartikaya Gupta
77a667f0b9 Bug 1364525 - Send the animation id for scrollbar thumbs over to the parent in the scroll data. r=botond
This propagates the animation id for a scroll thumb's stacking context over to
the APZ code, and stores it in the HitTestingTreeNode.

MozReview-Commit-ID: 5O13Xko2Bph
2017-05-23 10:50:41 -04:00
Botond Ballo
e4bae78e25 Bug 1349750 - Store the entire ScrollThumbData in HitTestingTreeNode. r=kats
This is preparation for future changes that will add fields to ScrollThumbData
that will be accessed via HitTestingTreeNode.

To accomplish this, this patch also exposes the entire ScrollThumbData via
LayerMetricsWrapper and WebRenderScrollDataWrapper.

MozReview-Commit-ID: 1Ed8Z80Wk1V
2017-05-03 20:25:09 -04:00
Botond Ballo
50e80233ca Bug 1349750 - Group scroll thumb-related information in Layer into a ScrollThumbData structure. r=kats
The patch also renames Layer::SetScrollbarData() to Layer::SetScrollThumbData()
for clarity.

MozReview-Commit-ID: DVwJ3DMl3Zs
2017-05-10 14:02:15 -04:00
Kartikaya Gupta
961e3cdbf2 Merge m-c to graphics
MozReview-Commit-ID: GdyXEYZsVuX
2017-04-25 08:32:48 -04:00
Kartikaya Gupta
041cb2ac76 Bug 1357754 - Replace LayerMetricsWrapper::AsRefLayer with GetReferentId. r=botond
This further abstracts away the direct dependence on particular layer
types. This is needed in particular for the APZCTreeManager call site
since it will need to operate on non-layer-tree data which is hard if it
relies specifically on RefLayer.

MozReview-Commit-ID: zbK3oTNHJc
2017-04-20 10:38:05 -04:00
Botond Ballo
b4155ad21e Bug 1355374 - Remove the no-longer-used LayerMetricsWrapper::GetScrollThumbLength() and HitTestingTreeNode::mScrollThumbLength. r=kats
MozReview-Commit-ID: ICm2Q1hnKD6
2017-04-21 13:59:32 -04:00
Kartikaya Gupta
5ae0ffc6e3 Bug 1357530 - Remove unused code in LayerMetricsWrapper.h. r=botond
MozReview-Commit-ID: EkZsUapSqWO
2017-04-18 16:09:37 -04:00
David Anderson
d46521f0e5 Move ScrollDirection to LayersTypes.h and make it a proper enum. (bug 1332567 part 1, r=kats) 2017-01-24 16:41:17 -08:00
Kevin Wern
ecc77f4e3d bug 1249162 - Fix unwanted thumb shifts when starting APZ drag r=botond
Fix thumb position determination in these places:
- nsSliderFrame::StartAPZDrag() -- Constrain sliderTrack using
  GetXULClientRect() to match dimensions used in
  SetCurrentThumbPosition() and DoXULLayout(). This is what caused
  the scaling/offset mismatch.
- nsSliderFrame::StartAPZDrag() -- Adjust nonsensical calculation of
  cssSliderTrack. Should be sliderFrame + scrollbarFramePosition -
  compositionBoundsPosition, to get coordinates relative to the same
  region as that of APZ event coordinates.
- AsyncDragMetrics -- Make mScrollTrack and mScrollbarDragOffset float
  instead of int coordinates.
- AsyncPanZoomController::HandleDragEvent() -- Use
  GetAxisLength(scrollTrack) instead of GetAxisEnd(scrollTrack) in
  calculation of scrollMax.
- AsyncPanZoomController::HandleDragEvent() -- Only change position on
  MOUSE_MOVE.

Additional refactors:
- Rename HitTestingTreeNode::GetScrollSize() to GetScrollThumbLength(),
  along with related functions/variables.
- Rename AsyncPanZoomController::GetAxisSize() to GetAxisLength().
- Rename cf to scrollFrame in nsSliderFrame::StartAPZDrag().

MozReview-Commit-ID: CIsU8Pj6qfa
2016-11-27 20:48:08 -05:00
Kartikaya Gupta
1209a4391f Bug 1219296 - Followup to fix stale code comments. r=me and DONTBUILD
MozReview-Commit-ID: 65hNR0nUQP
2016-10-24 13:07:01 -04:00
Michelangelo De Simone
ee23d98646 Bug 1120059 - Remove unnecessary MOZ_EXPLICIT_CONVERSION macros. r=jwalden
MozReview-Commit-ID: 7CX1VnBRDpk
2016-07-13 15:07:52 -07:00
Botond Ballo
b38e478209 Bug 1267438 - Use the layer's scrolled clip during compositor hit testing. r=mstange
MozReview-Commit-ID: 2nodwaZHeWZ
2016-05-04 17:30:26 -04:00
Kartikaya Gupta
bc3edd540f Bug 1270955 - When hit-testing on fixed-pos layers, find the root APZC for the scroll container rather than the layers id. r=botond
MozReview-Commit-ID: IvcMbpINOBI
2016-05-11 17:28:04 -04:00
Botond Ballo
bfe2706b4f Bug 1257288 - Have APZ hit testing respect scroll clips. r=kats
MozReview-Commit-ID: AZU5TEMvySG
2016-04-20 18:38:25 -04:00
Kartikaya Gupta
7a3556b6a3 Bug 1258851 - Update HitTestingTreeNode::IsScrollbarNode to include the scrollbar track layers. r=rbarker
MozReview-Commit-ID: CmyeeEPPYAq
2016-04-14 16:42:24 -04:00
Botond Ballo
4b6e207842 Bug 1219296 - Make ScrollMetadata::sNullMetadata a StaticAutoPtr so that ScrollMetadata can admit nsTArray members. r=kats
MozReview-Commit-ID: LOZdnAhL5xH
2016-03-30 17:04:10 -04:00
Botond Ballo
aa2fd58a6a Bug 1219296 - Split fields not needed for repaints out from FrameMetrics. r=kats
MozReview-Commit-ID: DymHOSI6yYK
2016-03-28 19:14:52 -04:00
Botond Ballo
4cd217e380 Bug 1236750 - Add typed getters for layer transform matrices. r=kats 2016-01-06 18:56:58 -05:00
Kartikaya Gupta
5f35a63965 Bug 1228602 - Ensure that we pick up the presShell resolution from the layer if there isn't a metrics. r=botond 2015-12-09 17:29:03 -05:00
Sunny Sidhu
2ba69faae0 Bug 1220873 - Make Layer::mVisibleRegion a LayerIntRegion. r=botond 2015-11-29 02:07:55 -05:00
Botond Ballo
0eabeea36c Bug 1168263 - Exclude perspective transforms from the transform used to convert from screen coordinates to an APZC's coordinate space. r=kats 2015-11-02 15:08:01 -05:00
Benoit Girard
f17e123549 Bug 1199885 - Part 4: Let the hit testing tree know about the scroll thumb. r=kats 2015-09-28 14:44:36 -04:00
Kearwood (Kip) Gilbert
d3ad55b783 Bug 1181240 - Part 3: Replace gfx3DMatrix with Matrix4x4 in gfx,r=vlad
- Refactored code to use Matrix4x4 instead of gfx3DMatrix.
- There is not expected to be any functional effect.
2015-07-10 17:06:35 -07:00
Birunthan Mohanathas
a29151dc87 Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
The bulk of this commit was generated by running:

  run-clang-tidy.py \
    -checks='-*,llvm-namespace-comment' \
    -header-filter=^/.../mozilla-central/.* \
    -fix
2015-07-13 08:25:42 -07:00
Ying-Ruei Liang (KK)
2c219b4aaf Bug 1143522 - Convert Layer::mClipRect to ParentLayerIntRect. r=botond
Change interface of getter/setter for mClipRect,
also necessary modification for codes that use these resources.

* * *
Bundle mUseClipRect and mClipRect as Maybe<ParentLayerIntRect> mClipRect
2015-04-11 22:03:00 -04:00
Kartikaya Gupta
25dec44afb Bug 1130982 - Ensure the clip rect on a multi-metrics layer belongs to the bottommost layer. r=botond 2015-03-11 13:36:12 -04:00
Kartikaya Gupta
6510ab7fc0 Bug 1137203 - Ignore the critical displayport when a layer is subject to OMTA relative to the scrolling ancestor. r=BenWa 2015-02-26 17:45:37 -05:00
Ryan VanderMeulen
e08fc71c94 Backed out changesets ddf965a90c07 and 305e676779f8 (bug 1137203) for being the likely cause of bug 1137952.
CLOSED TREE
2015-03-02 12:34:39 -05:00
Kartikaya Gupta
d518e1207c Bug 1137203 - Ignore the critical displayport when a layer is subject to OMTA relative to the scrolling ancestor. r=BenWa 2015-02-26 17:45:37 -05:00
Kartikaya Gupta
78e10f689b Bug 1131840 - Replace the shouldForceDispatchToContent flag with a bitset enum. r=roc,botond 2015-02-16 21:30:02 -05:00
Kartikaya Gupta
1fc7eae9b2 Bug 1125422 - Read the force-dispatch-to-content flag from the layer tree and use it in the APZ code. r=botond 2015-02-10 16:28:07 -05:00
Ehsan Akhgari
d133ad4de1 Backed out changeset 11aebde6e809 (bug 1120059) because of build bustage on Windows 2015-01-13 00:26:16 -05:00
Birunthan Mohanathas
dc636674b2 Bug 1120059 - Remove MOZ_{HAVE_,}EXPLICIT_CONVERSION. r=Waldo 2015-01-13 06:41:15 +02:00
Kartikaya Gupta
48b48965a7 Bug 1090398 - Add support for using the layer event regions for hit testing. r=botond
When the event-regions are provided by layout, use them to populate the APZ-side
hit testing regions. The existing code is still used when event-regions are not
provided by layout.
2014-11-14 07:40:14 -05:00
Markus Stange
a15e939a69 Bug 1073103 - Rename ThebesLayer to PaintedLayer. r=roc 2014-09-26 13:06:08 -04:00
Robert O'Callahan
5d986cf2b8 Bug 967844. Part 2: Move mContentDescription from Layer to FrameMetrics. r=kats 2014-08-30 00:23:25 +12:00
Phil Ringnalda
ef7af0d5d8 Backed out 3 changesets (bug 967844) for robopan bustage
Backed out changeset 6b53305f1c42 (bug 967844)
Backed out changeset dff3eb181f33 (bug 967844)
Backed out changeset 4d4b03442eaf (bug 967844)
2014-09-01 15:20:13 -07:00
Robert O'Callahan
9f1c69dd7f Bug 967844. Part 2: Move mContentDescription from Layer to FrameMetrics. r=kats 2014-08-30 00:23:25 +12:00
Kartikaya Gupta
ba16305db9 Bug 1055760 - Update AsyncCompositionManager's scrollbar-adjusting code to deal with multiple FrameMetrics. r=botond 2014-08-27 22:13:42 -04:00
Kartikaya Gupta
4921622f56 Bug 1055760 - Update AsyncCompositionManager's async-transform application code to deal with multiple FrameMetrics. r=botond 2014-08-27 22:13:41 -04:00
Kartikaya Gupta
c11731dee2 Bug 1055760 - Replace GetPrimaryScrollableLayer with functions that are more appropriate. r=BenWa 2014-08-27 22:13:41 -04:00
Kartikaya Gupta
9d9e2ce30a Bug 1055760 - Update tiling code to use LayerMetricsWrapper. r=botond,BenWa 2014-08-27 22:13:41 -04:00
Kartikaya Gupta
b080c61c52 Bug 1055760 - Add a LayerMetricsWrapper and fix up APZCTreeManager FrameMetrics accessing. r=botond,BenWa 2014-08-27 22:13:41 -04:00