Commit Graph

145 Commits

Author SHA1 Message Date
Punam Dahiya
77134726ce Bug 1775847 - Fix intermittent milestone message and accessibility cfr test failure r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D208761
2024-04-26 16:38:10 +00:00
Shane Hughes
ca7244fbbc Bug 1892402 - Make newtab feature callouts handle old themes more gracefully. r=omc-reviewers,negin
The newtab page is styled according to a `lwt-newtab-brighttext`
attribute, which until now is only present in the newtab page, and not
exposed to the chrome. This is a problem for elements like feature
callouts, which we want to fit in with the newtab content, even though
they exist in the chrome. That's okay in many cases, because the
callouts also use theme properties, and there's usually a concordance
between `lwt-newtab-brighttext` and the content color scheme. But in a
few older (but very popular) themes, there are missing theme properties,
and it's possible for the newtab page to be very dark even though
prefers-color-scheme is not dark.

This patch resolves the issue by exposing `lwt-newtab-brighttext` to the
chrome, and using that attribute to theme newtab callouts.

Differential Revision: https://phabricator.services.mozilla.com/D208256
2024-04-24 20:54:02 +00:00
Barret Rennie
0633e0cca7 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-24 20:15:19 +00:00
gravyant
e950fb5069 Bug 1869065 - Re-visit some of the element property names used in moz-message-bar. r=hjones,reusable-components-reviewers,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207897
2024-04-23 21:27:46 +00:00
Nipun Shukla
87498965b0 Bug 1888263 - Disable Firefox launch on login for MSIX builds r=nrishel,settings-reviewers,mconley,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207595
2024-04-23 14:08:52 +00:00
Iulian Moraru
b2f394db04 Backed out changeset 89b76affef99 (bug 1883673) for causing multiple bc failures. CLOSED TREE 2024-04-22 22:12:59 +03:00
Barret Rennie
b288396795 Bug 1883673 - Remove majorRelease2022 Nimbus feature r=aminomancer,omc-reviewers,win-reviewers,gstoll,pbz,firefox-desktop-core-reviewers
This feature is no longer intended for experimentation and some of the things
it controls are no longer in product.

Differential Revision: https://phabricator.services.mozilla.com/D204514
2024-04-22 17:57:31 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Maxx Crawford
f7bf5949e2 Bug 1824019 - Adjust hover/focus/active states for HNT card context menu buttons r=home-newtab-reviewers,desktop-theme-reviewers,dao,nbarrett,thecount
This patch adjusts the background-color/border/outline of the three different context menu buttons across the HNT page: top sites, pocket stories and recent activity cards.

It addresses the different link states: :hover, :focus (inlcuding :focus-visible), and :active for this button. This patch also includes attribute values for dark mode.

Differential Revision: https://phabricator.services.mozilla.com/D207067
2024-04-18 19:54:22 +00:00
Shane Hughes
1b4265e316 Bug 1863384 - Implement offset_x and offset_y for panel feature callout. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207075
2024-04-15 16:40:50 +00:00
Nicholas Rishel
f1a859cab6 Bug 1890066 - Show notification when users need to finish setting Firefox as the default in Windows Settings. r=nalexander,omc-reviewers,fluent-reviewers,flod,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D206828
2024-04-11 17:13:02 +00:00
Nathan Barrett
ae3e1aa169 Bug 1881588 - Add Wallpaper component r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount,maxxcrawford
Differential Revision: https://phabricator.services.mozilla.com/D205373
2024-04-11 14:01:18 +00:00
Mark Banner
4eac7c7090 Bug 1557040 - Remove eslint-plugin-fetch-options from the tree. r=Gijs,omc-reviewers,aminomancer,home-newtab-reviewers,frontend-codestyle-reviewers,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202628
2024-04-09 08:11:10 +00:00
Emily McMinn
17efb5e7e2 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-28 16:26:14 +00:00
Punam Dahiya
6a384e0ba4 Bug 1859302 - NimbusRolloutMessageProvider should be listed as a generated file r=omc-reviewers,aminomancer
Patch invokes `import-rollouts` script that import Nimbus Rollout messages into NimbusRolloutMessageProvider.sys.mjs when running test using ` ./mach npm run test --prefix browser/components/asrouter`

Differential Revision: https://phabricator.services.mozilla.com/D205777
2024-03-27 22:12:31 +00:00
Cristina Horotan
55e65e2992 Backed out changeset 4577a311fab7 (bug 1886856) for causing newtab failures at asrouter CLOSED TREE 2024-03-27 23:21:01 +02:00
Emily McMinn
ecc39fdb91 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-27 20:00:04 +00:00
Norisz Fay
f3d83af181 Backed out changeset 66d93ead16c4 (bug 1886856) for causing node newtab failure in bundles CLOSED TREE 2024-03-27 21:08:57 +02:00
Emily McMinn
6817fbac59 Bug 1886856 - Allow about:messagepreview to decode non-latin text r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D205344
2024-03-27 17:19:10 +00:00
Jason Prickett
bb433baf3f Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-25 23:05:05 +00:00
Emily McMinn
e2a3a80e3e Bug 1887066 - Reformat schema files in ASRouter r=barret,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D205470
2024-03-25 15:07:52 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Mark Banner
1ad86cf71a Bug 1881816 - Rename ActorConstants.sys.mjs to ActorConstants.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203401
2024-03-19 17:01:38 +00:00
Mark Banner
fb8a38fb26 Bug 1881816 - Rename Actions.sys.mjs to Actions.mjs. r=amy,omc-reviewers,aminomancer
This better reflects the file is being accessed from both content and system scopes.

Differential Revision: https://phabricator.services.mozilla.com/D203400
2024-03-19 17:01:37 +00:00
scottdowne
b61912d7a1 Bug 1882830 - Home and newtab adding message variants for sponsored content. r=nbarrett
Differential Revision: https://phabricator.services.mozilla.com/D203297
2024-03-15 06:50:09 +00:00
Natalia Csoregi
4bf66df843 Backed out changeset 4707e617d389 (bug 1876173) for causing newtab failures on aboutwelcome. CLOSED TREE 2024-03-14 00:38:01 +02:00
Jason Prickett
faeefc390a Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 21:28:06 +00:00
Natalia Csoregi
a6b8803582 Backed out changeset d488b0a57d95 (bug 1876173) for causing fxms failures. CLOSED TREE 2024-03-13 21:17:52 +02:00
Jason Prickett
9f76e777a7 Bug 1876173 - Add attribute to allow RDM to be disabled for aboutwelcome spotlight r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D201902
2024-03-13 18:23:44 +00:00
Mark Banner
d534b7b6ee Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie
Differential Revision: https://phabricator.services.mozilla.com/D204441
2024-03-13 17:38:28 +00:00
Jason Prickett
d559850e2d Bug 1882662 - Add checkDefaultBrowser pref check to fox doodle message targeting r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204268
2024-03-11 19:42:05 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204182
2024-03-11 15:26:28 +00:00
Punam Dahiya
bda9f1263a Bug 1877210 - Remove unused asrouter components r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D204122
2024-03-08 23:06:14 +00:00
hanna alemu
3facefbc9c Bug 1877788 - Record reach for all messaging experiment features r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203829
2024-03-08 16:51:20 +00:00
Shane Hughes
1a451ad5bc Bug 1775847 - Fix Glean timeout in browser_asrouter_cfr.js. r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D202078
2024-03-07 19:03:28 +00:00
negin
e825f3bfde Bug 1878072 - Increase karma.mc branch coverage to 80 percent r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D202631
2024-03-07 19:00:18 +00:00
Mark Banner
383e208b95 Bug 1883371 - Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer
Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Differential Revision: https://phabricator.services.mozilla.com/D203456
2024-03-05 16:56:57 +00:00
Dave Townsend
35c104ff31 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-03 09:09:08 +00:00
Punam Dahiya
d3035fa703 Bug 1879638 - Update Old references to asrouter and aboutwelcome files r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D203330
2024-03-02 02:36:24 +00:00
negin
601a737f68 Bug 1877557 - Extra configurations for LinkParagraph component for about:welcome r=omc-reviewers,emcminn,pdahiya
Adds styling for legal copy and updates above_button_config so it renders after tiles/MultiSelect but before action buttons.

Differential Revision: https://phabricator.services.mozilla.com/D200078
2024-03-01 21:03:23 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Shane Hughes
9c7d018917 Bug 1879655 - Fix microsurvey group structure, a11y, and randomization. r=omc-reviewers,emcminn
Change how microsurveys are structured. This ensures that screen readers
perceive a single logical collection, which contains all the radio
buttons and is labeled by the question, which is no longer defined by
subtitle but by tiles.label. This also changes how survey randomization
works. Instead of randomizing the entire set, we randomize specific
items. Any adjacent items with randomize will be randomized in-place. So
if there are 4 items with randomize, followed by 1 nonrandom item, the 4
will be randomized but the 5th will stay at the bottom. Finally, this
patch saves the randomized order so that it persists between back and
forward navigation on about:welcome. That should avoid some jank if we
show surveys in about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D202513
2024-02-27 03:29:29 +00:00
Mark Banner
aefd647018 Bug 1881265 - Enable ESLint recommended rule getter-return. r=mossop,extension-reviewers,devtools-reviewers,omc-reviewers,nchevobbe,aminomancer,robwu
Differential Revision: https://phabricator.services.mozilla.com/D202318
2024-02-26 11:35:40 +00:00
Mark Banner
1d4856edef Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers
An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Differential Revision: https://phabricator.services.mozilla.com/D202656
2024-02-24 12:21:20 +00:00
Mark Banner
d1f4ef701d Bug 1881573 - Drop use of ESLint rule max-depth from newtab/asrouter/aboutwelcome. r=pdahiya,thecount,Gijs,devtools-reviewers,omc-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D202474
2024-02-24 10:04:46 +00:00