Commit Graph

62 Commits

Author SHA1 Message Date
joe@retrovirus.com
28e71dd1d2 Changes to bookmark properties dialog:
* Customized bookmark properties dialog for add vs. edit cases
* Added support for changing URI of bookmark (annotations not carried over yet)
* Add support for viewing properties of history entries
* Changed from tag-style control to folder tree for folder selection,
  yielding layout and accessibility improvements
* Switched to using standard dialog buttons

bug=329272
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-10 17:36:41 +00:00
beng@bengoodger.com
de13bd15cc 329956 - add bookmark button on toolbar no longer works. r=joe@retrovirus.com 2006-03-09 22:02:21 +00:00
beng@bengoodger.com
268b6e977b 329586 - browser shim cleanup, tidies up some UI update notification in the browser, fixes a few menu items here and there, removes unnecessary initialization, moves places to its own window, removes all code to do with maintaining places as a tab, renames osme objects and member variables, formatting issues, creates a browser controller for updating commands. r=annie.sullivan@gmail.com 2006-03-09 02:08:45 +00:00
annie.sullivan@gmail.com
29243bdeb2 Fixes JavaScript warnings about trailing commas and redefined variables. bug=329171 r=ben@mozilla.org 2006-03-07 23:20:08 +00:00
beng@bengoodger.com
75afec6589 329587 - controllers registered after places controller cannot execute any commands due to places controller consuming all. r=fritz@google.com 2006-03-07 18:24:28 +00:00
joe@retrovirus.com
8f7b3936ca * Allows the user to access Bookmark Properties dialog from context menus.
* Adds support for editing the bookmark shortcut (formerly keyword) in the Bookmark Properties dialog.
* Improves the appearance of the Bookmark Properties dialog.
* Removes dead code from PlacesBrowserShim in browser.js

NOTE: This doesn't reflect the final UI for this functionality; rather,
this change is intended to add functionality for users of the nightlies.

bug=322988
r=annie.sullivan@gmail.com
sr=bugs@bengoodger.com
2006-03-07 00:52:35 +00:00
annie.sullivan@gmail.com
edc2180ac1 Adds menuitem for Open In Tabs.
Reorganizes code so that command/click handlers for toolbar/menu bindings can be attached by overlays.
r=ben@mozilla.org bug=327034
2006-03-04 01:12:05 +00:00
annie.sullivan@gmail.com
edc0a47409 Fixes problems with bookmark menus and toolbarbuttons not working correctly on mac. bug=327036 r=ben@mozilla.org 2006-02-23 18:30:40 +00:00
annie.sullivan@gmail.com
5030e95c4e Checking in patch by mossop@blueprintit.co.uk to allow middle click to open links in tabs. bug=325781 sr=beng 2006-02-17 22:58:13 +00:00
annie.sullivan@gmail.com
cc3aec4e24 Fixed drag and drop support for toolbars and menus. Added lots more visual feedback when dragging and dropping.
bug=318052 r=beng
2006-02-17 18:31:06 +00:00
beng@bengoodger.com
35ac93355f 326598 - tree D&D massively broken. r=annie.sullivan@gmail.com. checked in on the branch earlier, checking in now to the trunk. 2006-02-14 21:36:04 +00:00
beng@bengoodger.com
ebfbe24fa8 324948 - should not be able to do edit operations on immutable containers (delete, paste, cut). Make sure we check if a container has readonly children, or the folder itself (if it is a bookmark folder) is readonly before enabling commands for cut, copy and paste. Also assert that activeView is non-null, for safety. r=annie.sullivan@gmail.com 2006-02-09 21:32:24 +00:00
beng@bengoodger.com
7c823c9c0e 320655 - changing the history view displayed should also update the sorting r=annie.sullivan@gmail.com 2006-02-09 19:29:10 +00:00
beng@bengoodger.com
e5d391b859 326346 - javascript error when selecting text on a page. r=annie.sullivan@gmail.com 2006-02-08 01:52:41 +00:00
bryner@brianryner.com
dc2b6bdc33 Add support for bookmark separators (bug 320261). r=brettw, ben. 2006-02-08 01:10:57 +00:00
brettw@gmail.com
07495f4424 Bug 325161 r=annie.sullivan Make all nsINavHistoryResultNodes support URI attribute, remove nsINavHistoryURIResultNode. 2006-02-07 01:56:36 +00:00
annie.sullivan@gmail.com
27b6cde5bd bug=325169 r=brettw@gmail.com keywords=fixed1.8.1 Fix Livemark icons 2006-02-01 02:13:34 +00:00
beng@bengoodger.com
f05c577626 317633 - undo/redo for Places. Make sure the various transactions work better - e.g. folder undo should save a list of its child nodes for restoration. Also ensure that bookmark edits done in the places tab aren't undone when another tab is selected and Ctrl+Z hit by implementing a transaction manager in the browser window that filters out places-tab transactions if the places tab isn't selected. Make the goDo*Command utility functions in globalOverlay.js consult the window looking for applicable controllers, not just the focused element. r=sullivan. Also 320085 - search menu keybindings for places: allow find bar to be turned off using a state variable, which prevents the opening of the strip but fires an event which other applications like places can listen to: 'find-activated'. 2006-01-31 18:00:06 +00:00
brettw@gmail.com
27fde2f6eb [for joe@retrovirus.com] Bug 324743, r=brettw. Result roots are closed by default. 2006-01-31 03:05:02 +00:00
annie.sullivan@gmail.com
572011fc10 Fixes to toolbar and menu to work with new history backend.
r=brettw sr=ben bug=209804
2006-01-27 18:30:51 +00:00
brettw@gmail.com
738be3534d Bug 323492 r=bryner,beng Places history result node refactor, dynamic updates, performance improvements. 2006-01-24 01:24:15 +00:00
annie.sullivan@gmail.com
edf1de8fc6 Fixed JavaScript errors which were breaking copy/paste/delete.
bug=324056 r=beng
2006-01-20 17:03:45 +00:00
beng@bengoodger.com
8a704d0243 save selection across delete operations (not done automatically by the view object)... , also restyle parts of the band across the top of the places view to make the content clearer. 2006-01-18 00:11:25 +00:00
beng@bengoodger.com
f9a35c3fec rejigger places UI a bit, add a title bar across the top of the places view, adjust the default entries in the listbox, etc. also fix icons for generic queries and generic non-favicon pages. r=brettw for changes to the cpp. NPOB 2006-01-13 20:47:18 +00:00
brettw@gmail.com
68f107e02b Bug 320422 r=annie.sullivan: Rename nav-history/nsINavHistory to nav-history-service/nsINavHistoryService 2005-12-16 00:40:48 +00:00
annie.sullivan@gmail.com
6c2c9fe5ff Added nsIBookmarksContainer interface which allows custom bookmarks types.
Implemented nsILivemarksService as a nsIBookmarksContainer.
bug=317837 r=beng sr=bryner
2005-12-15 20:56:18 +00:00
brettw@gmail.com
9f9b61b6da Bug 317840, r=ben Delete history itens frontend 2005-12-15 17:53:31 +00:00
beng@bengoodger.com
0e561e2819 fix braindead bug in nodeIsQuery function in controller.js, make sure to return result. r=brettw 2005-12-14 18:36:43 +00:00
beng@bengoodger.com
5b0280dfd7 Including 318809 - group by site/group by page is not sticky in places. r=annie 2005-12-14 18:29:41 +00:00
bryner@brianryner.com
b1e09ce0ea Make bookmark and history views update dynamically (bug 317826 and 317827), r=brettw. 2005-12-09 23:48:44 +00:00
beng@bengoodger.com
e6c19a6cdc better D&D handling - make sure insertion point index is adjusted properly when rearranging items within a container. also lots of documentation and reorganization. NPOB 2005-12-02 18:32:27 +00:00
beng@bengoodger.com
5cfb653628 fix D&D to toolbar NPOB 2005-12-02 00:01:56 +00:00
beng@bengoodger.com
5ec0cc99fa 315940 - more D&D fixes. makes sure the right elements are selected post drop, fix js errors and save selection. NPOB 2005-12-01 23:58:02 +00:00
beng@bengoodger.com
c323497b6a more d&d polish NPOB 2005-12-01 02:22:14 +00:00
beng@bengoodger.com
edfbd8bd51 more improvements to d&d NPOB 2005-12-01 01:54:32 +00:00
beng@bengoodger.com
9b452c7291 more d&d feedback... select dropped items NPOB 2005-12-01 00:39:15 +00:00
beng@bengoodger.com
e0c75d0801 more work on selection saving across view reloading, also as part of 317633 store txmgr on history service for global txn stack. r=brettw for that NPOB 2005-12-01 00:09:29 +00:00
annie.sullivan@gmail.com
8161c25ad1 Fixes "open links in tabs" attempting to open folders.
Fixes open commands sometimes being disabled because they're not up to date
with the activeView
Work on fixing pasting of folders.
2005-11-30 19:24:44 +00:00
bryner@brianryner.com
882175fecd Fix some regressions from bug 317878, r=brettw. 2005-11-29 17:12:02 +00:00
bryner@brianryner.com
29b826e062 Make folder nodes just be a type of query node. Make nsNavHistoryResult inherit from QueryNode instead of ResultNode, to get rid of some redundancy. Bug 317878 / 314553, r=brettw. 2005-11-29 00:35:31 +00:00
beng@bengoodger.com
47c23270b2 315940 - move tree binding into its own file, like menu and toolbar NPOB 2005-11-28 23:24:56 +00:00
beng@bengoodger.com
c8de8b79e1 315940 consolidate insertion point computation functions in treeview NPOB 2005-11-28 23:15:41 +00:00
beng@bengoodger.com
901e99c8f1 315940 - implement index restrict in the places tree to prevent drop of items at certain indices NPOB 2005-11-28 18:29:42 +00:00
beng@bengoodger.com
a2d8b4ad72 315940 allow links and places to be dropped onto the toolbar. NPOB. 2005-11-28 07:30:30 +00:00
beng@bengoodger.com
ad197c3408 315940 more D&D support: drag from toolbar. NPOB 2005-11-28 06:55:16 +00:00
beng@bengoodger.com
46f16ea1e0 315940 - allow bookmarks to be dropped _into_ left list folders. NPOB 2005-11-28 00:36:21 +00:00
beng@bengoodger.com
5ab4b09d77 315940 - allow bookmarks to be dropped _into_ left list folders. NPOB 2005-11-28 00:33:37 +00:00
beng@bengoodger.com
2d543e230a 315940 - make sure you can't paste leaf items into the left list. NPOB 2005-11-28 00:23:06 +00:00
beng@bengoodger.com
97abd5908c 315940 - correct typo bryner spotted. NPOB 2005-11-27 22:36:40 +00:00
beng@bengoodger.com
e8c7964441 315940 - hook up dummy personal toolbar NPOB 2005-11-27 06:47:54 +00:00