Commit Graph

316 Commits

Author SHA1 Message Date
Jared Hirsch
a78e75d919 Bug 1933264 - Copy data preferences between profiles in a group. r=profiles-reviewers,fluent-reviewers,settings-reviewers,mossop,bolsson
Also add an explanatory note to preferences.

Differential Revision: https://phabricator.services.mozilla.com/D241902
2025-03-20 17:17:57 +00:00
Gijs Kruitbosch
afe72e45e7 Bug 1953531 - update crash reporter and technical plus interaction data links, r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D241245
2025-03-18 13:04:10 +00:00
Drew Willcoxon
cf70175727 Bug 1949297 - Update the Firefox Suggest settings UI. r=settings-reviewers,reusable-components-reviewers,urlbar-reviewers,fluent-reviewers,bolsson,daisuke,mstriemer
This makes the following primary changes to the Suggest settings in the search
pane:

* Remove the infobox
* Remove the learn-more link from the dismissed-suggestions description
* Add a learn-more link to the Address Bar section's description but show it
  only when Suggest is enabled
* Add `#w_what-setting-is-opt-in` fragment to the learn-more URL for the online
  toggle so it links directly to the appropriate section

It also makes these related changes:

Remove the unnecessary `vbox` containers for the toggle switches. I had to
modify some reusable-components CSS. Note that there are two copies of the
Suggest toggle, one in the search pane and one in the privacy pane.

Rename the sponsored and nonsponsored checkbox strings so they're consistent
with the other checkbox strings: `addressbar-locbar-foo-option`

Remove test tasks that click checkboxes and make sure the appropriate prefs are
updated and vice versa. Now that the infobox is gone, there's no need for
Suggest-specific tests to worry about that.

Similarly, remove test tasks that click the learn-more links and make sure the
right page is opened. No need for Suggest-specific tests to do that either.

Differential Revision: https://phabricator.services.mozilla.com/D238847
2025-02-26 15:49:16 +00:00
Drew Willcoxon
07c0872acb Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
2025-02-18 20:05:11 +00:00
Alexandru Marc
eb7e658712 Backed out changeset dbfd15553a78 (bug 1948166) for causing bc failures @ browser_search_firefoxSuggest.js CLOSED TREE 2025-02-18 19:58:24 +02:00
Drew Willcoxon
cf1c98539b Bug 1948166 - Allow Suggest online settings UI to be hidden. r=daisuke,settings-reviewers,urlbar-reviewers,mossop
This replaces `quickSuggestHideSettingsUI` with `quickSuggestSettingsUi`. Like
the old variable, we can show or hide all Suggest settings UI, and now we can
also hide UI that pertains only to Suggest online. This is necessary because as
we start to roll out Suggest to more regions, online (Merino) won't be available
for them initially.

Differential Revision: https://phabricator.services.mozilla.com/D238159
2025-02-18 16:11:30 +00:00
Valentin Gosu
2b6ee476f3 Bug 1900013 - Remove DoH fallback warning prefs from privacy settings UI r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D237692
2025-02-12 14:30:27 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-10 15:24:32 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth
Differential Revision: https://phabricator.services.mozilla.com/D233071
2025-02-04 08:25:28 +00:00
Simon Friedberger
e968ab8747 Bug 1934587: Clear up HTTPS-Only UI for HTTPS-First, r=maltejur,fluent-reviewers,settings-reviewers,bolsson,hjones,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234074
2025-01-28 15:10:11 +00:00
Gijs Kruitbosch
50f4376ab8 Bug 1921218 - Part 1: Add settings checkbox for usage/DAU ping in Firefox Desktop. r=fluent-reviewers,settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D226354
2025-01-15 23:13:24 +00:00
Helena
651b2cfe37 Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 21:55:20 +00:00
Butkovits Atila
7d5fe6b5ca Backed out changeset 9e414abada40 (bug 1915672) for causing failures at browser_glean_metrics_exist.js. 2025-01-15 16:03:47 +02:00
Helena
48a5fff8dd Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 12:27:33 +00:00
Harshit Sohaney
11deb510cf Bug 1888466 - (Part 1) Unmerge form data from the history and downloads pref. r=fluent-reviewers,bolsson,manuel
Differential Revision: https://phabricator.services.mozilla.com/D220980
2025-01-09 12:52:45 +00:00
Benjamin VanderSloot
2fb04528e4 Bug 1932741 - Remove legacy DNT UI when GPC "functionality.enabled" preference is false - r=anti-tracking-reviewers,settings-reviewers,mossop,timhuang
Instead, hide the whole thing! Long live GPC!

Differential Revision: https://phabricator.services.mozilla.com/D231148
2024-12-06 13:25:26 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Benjamin VanderSloot
9a76de256c Bug 1928087 - Remove DNT control from about:preferences#privacy - r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D227343
2024-11-25 13:16:45 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Florian Quèze
63f0aa00cc Bug 1918702 - Migrate telemetry events to use Glean APIs for relay_integration, r=settings-reviewers,credential-management-reviewers,dimi,Gijs.
Differential Revision: https://phabricator.services.mozilla.com/D223211
2024-09-27 08:44:45 +00:00
Florian Quèze
165920b94c Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 10:00:41 +00:00
Sandor Molnar
5095328e2d Backed out 5 changesets (bug 1918702) for causing bc failures @ browser_aaa_eventTelemetry_run_first.js CLOSED TREE
Backed out changeset f55480885aeb (bug 1918702)
Backed out changeset db1eaf09430d (bug 1918702)
Backed out changeset a9179f6e684d (bug 1918702)
Backed out changeset f9d3349e6fe3 (bug 1918702)
Backed out changeset 10d2957bbfe8 (bug 1918702)
2024-09-25 12:38:05 +03:00
Florian Quèze
3cf2dde6da Bug 1918702 - Migrate telemetry events to use Glean APIs for password manager, r=chutten,settings-reviewers,credential-management-reviewers,mossop,mtigley,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D222608
2024-09-25 07:19:05 +00:00
Florian Quèze
38c9b923b4 Bug 1918702 - Migrate telemetry events to use Glean APIs for security.doh.settings events, r=chutten,settings-reviewers,mconley.
Depends on D222125

Differential Revision: https://phabricator.services.mozilla.com/D222126
2024-09-20 13:58:13 +00:00
Gijs Kruitbosch
0f506dab3a Bug 1916813 - visibly disable the studies checkbox if telemetry upload is disabled to reflect reality, r=mossop,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221328
2024-09-18 12:18:43 +00:00
Drew Willcoxon
333d2a9ac1 Bug 1915766 - Add a Nimbus variable that hides the Suggest UI. r=daisuke,settings-reviewers,mossop
This makes `browser_search_firefoxSuggest.js` more realistic by installing a
Nimbus experiment to change the Suggest scenario instead of manually setting the
scenario via the helper function. (The "scenario" just means whether Suggest is
enabled or not, basically. "history" means it's not enabled; "offline" and
"online" mean it's enabled. The difference between the latter two is that in
"online" the user has opted in to the Merino server, and that only means one of
the Suggest prefs is true instead of false.)

I noticed `browser_privacy_firefoxSuggest.js` does not check the visibility of
its Suggest section at all, so I added similar tasks to it and factored out the
common helpers into `head.js`.

Depends on D221097

Differential Revision: https://phabricator.services.mozilla.com/D221099
2024-09-11 19:40:01 +00:00
Norisz Fay
77d6f50252 Backed out changeset c35f4e167d98 (bug 1916813) for causing bc failures on browser_about_preferences.js 2024-09-11 19:04:46 +03:00
Gijs Kruitbosch
4d3210fc70 Bug 1916813 - visibly disable the studies checkbox if telemetry upload is disabled to reflect reality, r=mossop,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221328
2024-09-11 13:53:25 +00:00
Malte Jürgens
3809a1239b Bug 1910312 - Unbreak privacy and security settings when MOZ_DATA_REPORTING is disabled r=settings-reviewers,mossop
Disabling `MOZ_DATA_REPORTING` results in the `PREF_UPLOAD_ENABLED` pref not
being loaded with `Preferences.add`. This means
`Preferences.get(PREF_UPLOAD_ENABLED)` can possibly be `null`, which was
previously not handled and resulted in an error for the whole privacy.js file.

So only call `dataCollectionCheckboxHandler` for the `privateAttribution`
checkbox if `MOZ_DATA_REPORTING` is enabled (otherwise the `privateAttribution`
checkbox also just doesn't exist). Also move the call into separate
`initPrivateAttributionCheckbox` function to be more consistent with previous
code.

Differential Revision: https://phabricator.services.mozilla.com/D218265
2024-08-09 12:45:27 +00:00
Mathew Hodson
3897b0e480 Bug 1830673 - Use support-page attribute for telemetry article link r=settings-reviewers,mconley
This prevents two tabs from being opened.

Differential Revision: https://phabricator.services.mozilla.com/D218268
2024-08-01 21:37:44 +00:00
Malte Juergens
7d71bae2f3 Bug 1907517 - Update strings in HTTPS-Only settings to make users aware of HTTPS-First r=freddyb,fluent-reviewers,settings-reviewers,mossop
In light of us being in the process of enabling HTTPS-First by default, these strings have been proposed by content design to make it more clear to the user that if they disable HTTPS-Only, upgrades may still be happening.

The description generally has been updated, but the labels for the radio buttons only get the new strings in this patch when HTTPS-First is also enabled.

Differential Revision: https://phabricator.services.mozilla.com/D216381
2024-07-19 12:34:09 +00:00
Gijs Kruitbosch
a295abd9b9 Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r=bgrins,settings-reviewers,firefox-desktop-core-reviewers ,mossop
Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Differential Revision: https://phabricator.services.mozilla.com/D216801
2024-07-17 16:00:47 +00:00
Mike Kaply
3ba79c24af Bug 1675077 - Add policy for PrivateBrowsingModeAvailability. r=kcochrane,fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D216315
2024-07-15 15:58:18 +00:00
Sean
a41f1de616 Bug 1900672 - DNS-over-HTTPS (DoH, TRR) provider OFF should default to fallbackProviderURI r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D213838
2024-06-18 14:15:43 +00:00
Emilio Cobos Álvarez
07889c29e7 Bug 1901068 - Setting for privacy-preserving attribution. r=mt,settings-reviewers,fluent-reviewers,mconley,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D211656
2024-06-06 17:22:07 +00:00
Sidharth Sachdev
70d35a30e4 Bug 1898884 - Disabling and hiding the OS Authentication checkboxes when "security.nocertdb" is true. r=Gijs,settings-reviewers,credential-management-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D212744
2024-06-06 14:44:25 +00:00
Sean
05c9da18d0 Bug 1861285 - DNS-over-HTTPS (DoH, TRR) provider change from default to increased/max protection set network.trr.uri to fallbackProviderURI while maintaining other mode changes r=edgul,valentin,settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D209805
2024-06-05 13:03:11 +00:00
Harshit Sohaney
052d9f0b26 Bug 1892947 - Align clear on shutdown for cookies and site data section prefs to the new clear on shutdown prefs. r=pbz,settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D208410
2024-05-25 15:19:13 +00:00
Sidharth Sachdev
98e0d52b70 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
2024-05-07 04:21:31 +00:00
Cristina Horotan
65bc72d8e5 Backed out 7 changesets (bug 1802809, bug 1890883, bug 1877720, bug 1403081, bug 1877717) for causing bc failures at browser_primaryPassword.js CLOSED TREE
Backed out changeset 7bdafce80724 (bug 1877717)
Backed out changeset 4969f17f935c (bug 1877717)
Backed out changeset d700fbbd7541 (bug 1877717)
Backed out changeset 98e31d4cd373 (bug 1802809)
Backed out changeset c1e8c6c34fcc (bug 1877720)
Backed out changeset 0d8d5e77a93c (bug 1403081)
Backed out changeset 594b7bbecd22 (bug 1890883)
2024-05-06 20:59:20 +03:00
Sidharth Sachdev
0176b1dcff Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
2024-05-06 15:58:23 +00:00
Stanca Serban
fdfaad305b Backed out 7 changesets (bug 1802809, bug 1877717, bug 1403081, bug 1890883, bug 1877720) for causing localization checks failures in aboutLogins.ftl. CLOSED TREE
Backed out changeset 62eeb65b23bd (bug 1877717)
Backed out changeset 4fde845a1182 (bug 1877717)
Backed out changeset d3124d383693 (bug 1877717)
Backed out changeset 344ac200b360 (bug 1802809)
Backed out changeset 754a1bf3b55e (bug 1877720)
Backed out changeset 961a1121017e (bug 1403081)
Backed out changeset 19b2252a4ccf (bug 1890883)
2024-05-06 18:27:03 +03:00
Sidharth Sachdev
6fd74c4252 Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
2024-05-06 14:54:16 +00:00
Cosmin Sabou
2873243069 Backed out 6 changesets (bug 1877717, bug 1802809, bug 1890883, bug 1877720, bug 1403081) for causing failures on browser_creditCard_doorhanger_action.
Backed out changeset 8ee572259ac8 (bug 1877717)
Backed out changeset dad0f115e953 (bug 1877717)
Backed out changeset d792b9335db3 (bug 1802809)
Backed out changeset 7610115f0011 (bug 1877720)
Backed out changeset 9c53bcd6a763 (bug 1403081)
Backed out changeset aa4981999347 (bug 1890883)
2024-05-05 20:37:16 +03:00
Sidharth Sachdev
8716cffc2b Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod
Depends on D207219

Differential Revision: https://phabricator.services.mozilla.com/D201276
2024-05-05 15:59:35 +00:00
Stanca Serban
ba7ef6bf02 Backed out 6 changesets (bug 1802809, bug 1890883, bug 1877717, bug 1403081, bug 1877720) multiple mochitests failures. CLOSED TREE
Backed out changeset 8b238dd69206 (bug 1877717)
Backed out changeset c6e16bf303ed (bug 1877717)
Backed out changeset e4d8856edf45 (bug 1802809)
Backed out changeset 9a6a418a1e45 (bug 1877720)
Backed out changeset b587dcaf8f9f (bug 1403081)
Backed out changeset 17febe56cad6 (bug 1890883)
2024-05-03 22:01:28 +03:00
Sidharth Sachdev
2ca5d5e1dd Bug 1403081 - Optionally protect filling of saved logins with OS authentication (including biometrics). r=sgalich,settings-reviewers,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D201276
2024-05-03 17:23:48 +00:00