Commit Graph

86 Commits

Author SHA1 Message Date
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Prathiksha
aa7c19d5af Bug 1365957 - Pressing backspace on the cookies dialog to delete a cookie no longer removes the dialog. r=johannh
MozReview-Commit-ID: LDwIljC7Ji7
2017-07-17 17:01:36 +05:30
Jorg K
5f167b3f03 Bug 1383463 - Use mozIntl for cookies and page info. r=zibi 2017-07-22 23:18:00 -04:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Fischer.json
71a3493ba7 Bug 1338757 - "Remove All Shown" and button in about:preferences should use its own accesskey, r=jaws
MozReview-Commit-ID: 2ucF0GqOCJV
2017-02-13 11:43:37 +08:00
Fischer.json
5b645d203b Bug 1338036 - Switch button label from "Remove All" to "Remove All Shown" when filtering by keyword in about:preferences, r=jaws
MozReview-Commit-ID: 8iK6bg8i0uT
2017-02-09 12:00:12 +08:00
Fischer.json
01d51048f2 Bug 1312377 - Remove selected site data in Settings of Site Data, r=jaws
MozReview-Commit-ID: 2MlnZfajM4t
2016-12-19 16:57:34 +08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7
2016-11-03 11:51:48 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Mark Banner
66092fae61 Bug 1313634 - Fix undefined variables issues in cookies.js that lead to the cookies window not updating properly when open. r=jaws
MozReview-Commit-ID: RBhuCbjrYT
2016-10-29 14:49:17 +01:00
Jonathan Kew
f1f4742feb Bug 1301655 - pt 5 - Replace use of nsIScriptableDateFormat for cookie date formatting. r=gandalf 2016-10-28 12:04:07 +01:00
William CS
a95802aad6 Bug 1295000 - Clean up for-loops in cookies.js. r=Standard8
MozReview-Commit-ID: KO3KTaPXLpS
2016-10-19 15:47:58 +01:00
Gijs Kruitbosch
b1f4d0193d Bug 1307132 - import AppConstants.jsm, r=jaws
MozReview-Commit-ID: DQZtraWCZnK
2016-10-03 17:10:07 +01:00
Jared Wein
7b4c22ac1c Bug 1294989 - Enable eslint for browser/components/preferences. r=Gijs
MozReview-Commit-ID: 62ymdZhluHx
2016-08-13 21:58:42 -04:00
Jonathan Hao
9416581c41 Bug 1285587 - Cookies set by thumbnails shouldn't appear. r=jdm 2016-07-26 20:09:00 +02:00
Tim Huang
9d0bd9c921 Bug 1285889 - Moving the ContextualIdentityService.jsm from from browser/components/contextualidentity into tookit/components/contextualidentity. r=baku 2016-07-11 20:03:00 +02:00
Andrea Marchesini
f6de188c7f Bug 1267923 - Move the CSS rules to ContextualIdentityService, r=mconley 2016-05-17 15:03:43 +02:00
Andrea Marchesini
0d6b911fbc Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-10 05:46:07 +01:00
Ryan VanderMeulen
f16cc2b8b7 Backed out changeset 7d5f1e9ce04c (bug 1259169) for various cookie-related crashes and test failures. 2016-04-09 15:36:07 -04:00
Andrea Marchesini
c505892d92 Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-09 19:09:49 +01:00
Carsten "Tomcat" Book
4643fcd169 Backed out changeset 74330da56b82 (bug 1259169) for assertion failures in nsCookieService.cpp:2390 2016-04-08 14:47:39 +02:00
Andrea Marchesini
8100cd23b7 Bug 1259169 - nsICookieManager::remove() should be back-compatible, r=jdm 2016-04-08 12:38:15 +01:00
Andrea Marchesini
5685489215 Bug 1245184 - nsICookieManager.remove should use the OriginAttributes, r=sicking 2016-02-25 16:41:13 +01:00
Carsten "Tomcat" Book
a50632893b Backed out changeset 27f3968ae8b2 (bug 1245184) 2016-02-19 15:55:23 +01:00
Andrea Marchesini
9111a1ecc9 Bug 1245184 - CookieManager should remove cookies only if they match the userContextId, r=sicking 2016-02-19 14:49:50 +01:00
Andrea Marchesini
c7e3830277 Bug 1244795 - adding a string for the default container under cookie manager, part 2, r=me 2016-02-09 06:49:58 +00:00
Andrea Marchesini
abf61ee498 Bug 1244795 - adding a string for the default container under cookie manager, r=paolo 2016-02-08 16:55:33 +00:00
Sebastian Hengst
49cce92dad Backed out changeset 9494bdf52cc6 (bug 1244795) for browser chrome failures. r=backout 2016-02-08 17:45:08 +01:00
Sebastian Hengst
c75aca1e9e Backed out changeset cc1cda7b777c (bug 1244795) for browser chrome failures. r=backout 2016-02-08 17:44:05 +01:00
Andrea Marchesini
4b09c91fda Bug 1244795 - adding a string for the default container under cookie manager - part 2, r=paolo 2016-02-08 14:25:43 +00:00
Andrea Marchesini
577976340e Bug 1244795 - adding a string for the default container under cookie manager, r=paolo 2016-02-08 14:24:19 +00:00
Andrea Marchesini
770ed24606 Bug 1239606 - Implement UserContextUI.jsm, r=paolo 2016-01-14 14:23:54 +00:00
Andrea Marchesini
53e35de533 Bug 1199466 - part 2 - Cookie manager in FF preferences should show the userContextId, r=paolo 2016-01-14 08:05:08 +00:00
Sebastian Hengst
ac61332d33 Bug 1119747 - Fix up selected cookie count. r=dao 2015-01-09 20:28:03 +01:00
Sebastian Hengst
583eb02909 Bug 1118226 - Allow to add number to string for removing selected cookies to improve localizability. r=dao 2015-01-07 12:40:29 +01:00
Sebastian Hengst
7732653a29 Bug 1103314 - Clarify label of "Remove All Cookies" button to indicate whether it removes all cookies or just removes the cookies shown. r=dao 2014-12-27 17:35:24 +01:00