Simon Giesecke
2634de766d
Bug 1691913 - Rename nsClassHashtable::LookupOrAdd to GetOrInsertNew. r=xpcom-reviewers,nika
...
It should be called "Get" rather than "Lookup" because it returns
UserDataType. "Add" is called "Insert" in the other methods.
Differential Revision: https://phabricator.services.mozilla.com/D105470
2021-02-22 12:07:47 +00:00
Simon Giesecke
e9ec81a5b1
Bug 1679987 - Use nsTokenizedRange where easily possible. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D98308
2020-12-16 19:10:34 +00:00
Sylvestre Ledru
68b806d604
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 17:04:01 +00:00
Butkovits Atila
a6e7dcc53f
Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE
2020-11-04 10:54:36 +02:00
Sylvestre Ledru
8f709b39e8
Bug 1674637 - Use nested namespaces in dom/ r=sg,andi
...
Also add some missing namespace qualifications
Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')
Differential Revision: https://phabricator.services.mozilla.com/D95456
2020-11-04 08:29:00 +00:00
Simon Giesecke
535b627ea9
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-02 13:23:49 +00:00
Sebastian Hengst
07e61ece2b
Backed out 5 changesets (bug 1666219, bug 1665347) for crashing hazard task. CLOSED TREE.
...
Backed out changeset c261ec06a826 (bug 1665347)
Backed out changeset 212c9df41410 (bug 1665347)
Backed out changeset 435f02d9f1d7 (bug 1665347)
Backed out changeset 7b36a79247b7 (bug 1666219)
Backed out changeset af8025162523 (bug 1665347)
2020-10-01 23:17:19 +02:00
Simon Giesecke
8b03004195
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 15:37:50 +00:00
Bogdan Tara
7bbd692ffa
Backed out 5 changesets (bug 1666219, bug 1665347) for indexedDB related bustage CLOSED TREE
...
Backed out changeset 5cd7e2d67f91 (bug 1665347)
Backed out changeset 9159fdd05097 (bug 1665347)
Backed out changeset 64a086636738 (bug 1665347)
Backed out changeset 5ef18af381ec (bug 1666219)
Backed out changeset 3b81349a5f39 (bug 1665347)
2020-10-01 17:41:23 +03:00
Simon Giesecke
ed2c55bd64
Bug 1666219 - Renamed QM_TRY_VAR etc. to QM_TRY_UNWRAP etc. r=dom-workers-and-storage-reviewers,ttung,janv
...
Also change some left-over QM_TRY_VAR uses with const target declarations to
QM_TRY_INSPECT et al.
Differential Revision: https://phabricator.services.mozilla.com/D90873
2020-10-01 12:02:26 +00:00
Jeff Walden
1760d6f90a
Bug 1663365 - Move various Object-related functions to a new js/public/Object.h header. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D89333
2020-09-08 22:55:38 +00:00
Jan Varga
d27ab653b9
Bug 1662087 - Replace explicit error handling involving mozilla::Result::isErr with IDB_TRY/IDB_TRY_VAR in IndexedDatabaseManager.cpp; r=dom-workers-and-storage-reviewers,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D88824
2020-09-07 15:52:19 +00:00
Jan Varga
cc66b161be
Bug 1651016 - Convert remaining NS_ENSURE_SUCCESS to IDB_TRY in dom/indexedDB; r=dom-workers-and-storage-reviewers,ttung,sg
...
Differential Revision: https://phabricator.services.mozilla.com/D84315
2020-07-24 11:49:27 +00:00
Simon Giesecke
5aa1eeff6f
Bug 1650076 - Move ProfilerHelpers implementation into cpp file. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82014
2020-07-03 09:38:41 +00:00
Cosmin Sabou
ac68fa95fe
Backed out 4 changesets (bug 1650076) for build bustages on indexedDB/ProfilerHelpers.h. CLOSED TREE
...
Backed out changeset 42951b61e9dc (bug 1650076)
Backed out changeset 18b34fb0ddbd (bug 1650076)
Backed out changeset 1d378f2af866 (bug 1650076)
Backed out changeset 42df520d1cff (bug 1650076)
2020-07-03 11:49:58 +03:00
Simon Giesecke
3c49319206
Bug 1650076 - Move ProfilerHelpers implementation into cpp file. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D82014
2020-07-03 08:06:59 +00:00
Simon Giesecke
57e2f9a7eb
Bug 1648432 - Simplify code using LookupOrAdd(FromFactory). r=dom-workers-and-storage-reviewers,ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D81295
2020-06-26 15:15:24 +00:00
Chris Peterson
6a1ecad80a
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-23 01:49:16 +00:00
Simon Giesecke
3648ad17f4
Bug 1628716 - Use range-based for and STL algorithms with hashtables. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D70378
2020-04-22 13:52:52 +00:00
Dorel Luca
323f221095
acked out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE
2020-04-22 08:41:47 +03:00
Chris Peterson
03ad9a920b
Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg
...
Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Differential Revision: https://phabricator.services.mozilla.com/D71713
2020-04-22 05:22:44 +00:00
Simon Giesecke
b9883a12fd
Bug 1623278 - Use SafeRefPtr for IDBFactory. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D66972
2020-04-01 09:54:43 +00:00
Simon Giesecke
cef77da21d
Bug 1623278 - Use SafeRefPtr for FileManager. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65549
2020-04-01 09:52:54 +00:00
Mihai Alexandru Michis
6c0bae252a
Backed out 10 changesets (bug 1623278, bug 1617170, bug 1620273, bug 1597954) for causing bustages.
...
CLOSED TREE
Backed out changeset 50c0e58dd654 (bug 1623278)
Backed out changeset b31ddbcdd2f2 (bug 1597954)
Backed out changeset 8b03993a9234 (bug 1623278)
Backed out changeset ad7b08acadd6 (bug 1623278)
Backed out changeset bb094a6084b3 (bug 1623278)
Backed out changeset 7fdf38a403bb (bug 1623278)
Backed out changeset d69cf5fcb571 (bug 1620273)
Backed out changeset 5abef9862e60 (bug 1617170)
Backed out changeset 11d9ccb4ddd8 (bug 1617170)
Backed out changeset 6df7028b41d0 (bug 1617170)
2020-03-19 13:30:26 +02:00
Simon Giesecke
de5f39c621
Bug 1623278 - Use SafeRefPtr for FileManager. r=dom-workers-and-storage-reviewers,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D65549
2020-03-19 09:32:53 +00:00
Simon Giesecke
e9db85e39b
Bug 1617170 - Remove unused slice ref-count. r=dom-workers-and-storage-reviewers,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D64401
2020-03-17 11:26:27 +00:00
Simon Giesecke
f8e62fefd1
Bug 1617170 - Make FileInfo more testable by removing the dependency on FileManager. r=dom-workers-and-storage-reviewers,janv
...
Also removes the dependency of FileManager(Base)/FileInfo on
IndexedDatabaseManager, based on contributions by janv@mozilla.com
Differential Revision: https://phabricator.services.mozilla.com/D64347
2020-03-17 11:50:58 +00:00
Simon Giesecke
9754419e89
Bug 1617170 - Fix non-unified build. r=janv,dom-workers-and-storage-reviewers
...
Based on a patch supplied by janv@mozilla.com
Differential Revision: https://phabricator.services.mozilla.com/D67129
2020-03-17 11:28:49 +00:00
Eric Rahm
daeb56f35b
Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D59042
2020-01-13 19:18:56 +00:00
Simon Giesecke
aa7ae9aad3
Bug 1600283 - Remove uses of already_AddRefed. r=dom-workers-and-storage-reviewers,ytausky
...
Differential Revision: https://phabricator.services.mozilla.com/D55498
2019-12-19 09:24:22 +00:00
Gabriele Svelto
eb403b8785
Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
...
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.
find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
if [ -n "$interfaces" ]; then
if [[ "$interfaces" == *$'\n'* ]]; then
regexp="\("
for i in $interfaces; do regexp="$regexp$i\|"; done
regexp="${regexp%%\\\|}\)"
else
regexp="$interfaces"
fi
interface=$(basename "$path")
rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
if [ $hits -eq 0 ]; then
echo "Removing ${interface} from ${path2}"
grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
mv -f "$path2".tmp "$path2"
fi
done
fi
done
Differential Revision: https://phabricator.services.mozilla.com/D55442
2019-12-06 09:24:56 +00:00
Simon Giesecke
03b999130d
Bug 1596129 - Introduce DatabaseNameMatchPredicate function to reduce code duplication. r=dom-workers-and-storage-reviewers,ytausky
...
Depends on D52874
Differential Revision: https://phabricator.services.mozilla.com/D52875
2019-12-04 11:22:00 +00:00
Dorel Luca
67889e1013
Backed out changeset f6e53d1c6518 (bug 1600545) for Android build bustage. CLOSED TREE
2019-12-04 17:32:27 +02:00
Gabriele Svelto
dc6fa2e86c
Bug 1600545 - Remove useless inclusions of header files generated from IDL files in dom/ r=Ehsan
...
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.
find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
if [ -n "$interfaces" ]; then
if [[ "$interfaces" == *$'\n'* ]]; then
regexp="\("
for i in $interfaces; do regexp="$regexp$i\|"; done
regexp="${regexp%%\\\|}\)"
else
regexp="$interfaces"
fi
interface=$(basename "$path")
rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
if [ $hits -eq 0 ]; then
echo "Removing ${interface} from ${path2}"
grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
mv -f "$path2".tmp "$path2"
fi
done
fi
done
Differential Revision: https://phabricator.services.mozilla.com/D55442
2019-12-04 15:01:19 +00:00
Simon Giesecke
de74a5de2a
Bug 1596129 - Make use of std::find_if in FileManagerInfo::InvalidateAndRemoveFileManager. r=dom-workers-and-storage-reviewers,ttung,janv
...
Differential Revision: https://phabricator.services.mozilla.com/D52874
2019-11-29 12:23:42 +00:00
Simon Giesecke
9f8da5c1d0
Bug 1596129 - Make use of std::find_if in FileManagerInfo::GetFileManager. r=dom-workers-and-storage-reviewers,ttung
...
Depends on D52872
Differential Revision: https://phabricator.services.mozilla.com/D52873
2019-11-29 09:22:03 +00:00
Simon Giesecke
86be0d8b6b
Bug 1168606 - Increase default maximum number of extra records to preload to 64. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43467
2019-11-14 15:50:33 +00:00
Simon Giesecke
479a111a2e
Bug 1168606 - Introduce preference for maximum number of extra records to preload, defaulting to 0/off for now. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43466
2019-11-05 14:40:33 +00:00
Cosmin Sabou
1078f19412
Backed out 12 changesets (bug 1168606) for causing build bustages on ActorsParent.cpp and Assertions.h. CLOSED TREE
...
Backed out changeset 307bd8d24407 (bug 1168606)
Backed out changeset a2ae085f929f (bug 1168606)
Backed out changeset 8fdc4a3d3ecb (bug 1168606)
Backed out changeset 918dc7cce5e9 (bug 1168606)
Backed out changeset 8c776a5cb5db (bug 1168606)
Backed out changeset dffe1e6c58bd (bug 1168606)
Backed out changeset 41f1bef0f019 (bug 1168606)
Backed out changeset 96cb7140a4f6 (bug 1168606)
Backed out changeset 6818224b9b11 (bug 1168606)
Backed out changeset f1be81af7d6b (bug 1168606)
Backed out changeset 8dc185488801 (bug 1168606)
Backed out changeset 9d8b02674d45 (bug 1168606)
2019-11-05 16:34:22 +02:00
Simon Giesecke
3f9a2b4a65
Bug 1168606 - Introduce preference for maximum number of extra records to preload, defaulting to 0/off for now. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43466
2019-11-05 13:24:31 +00:00
Nicholas Nethercote
99a55e2d1c
Bug 1587162 - Fix UBSAN complaints about pref callbacks. r=erahm
...
Lots of these callbacks have a non-`void*` final parameter, which UBSAN
complains about. This commit changes them to have a `void*` parameter.
This requires undoing the machinery added in the first two commits of bug
1473631: `TypePrefChangeFunc` and `PREF_CHANGE_METHOD`. The resulting code is
simpler (which is good) and more boilerplate-y (which is bad) but avoids the
undefined behaviour (which is good).
Differential Revision: https://phabricator.services.mozilla.com/D50901
2019-11-01 02:57:20 +00:00
Gabriele Svelto
652cb568da
Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D47678
2019-09-30 22:06:47 +00:00
Jan Varga
eab0a35473
Bug 1561876 - Remove support for de-serializing WebAssembly.Modules in IDB; r=asuth
...
This patch removes support for de-serialization of WebAssembly.Modules. The
preprocessing which was added just for WebAssembly.Modules is not removed since
it can be reused for more efficient de-serialization of big structured clones
which are stored as standalone files. (standalone files can be read and
uncompressed in content process instead of the parent process). So this patch
also adjusts the preprocessing to support that. However the preprocessing is not
fully implemented (we lack support for indexes and cursors) and there's a
theoretical problem with ordering of IDB requests when preprocessing is
involved, so this feature is kept behind a pref for now.
Differential Revision: https://phabricator.services.mozilla.com/D36879
2019-07-03 12:23:33 +02:00
Andrea Marchesini
18a24375f9
Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
2019-03-29 18:05:11 +00:00
Daniel Varga
11153391d9
Backed out changeset 98452610cfcc (bug 1539407) for browser-chrome failure at /builds/worker/workspace/build/src/dom/indexedDB/IDBRequest.cpp:284. On a CLOSED TREE
2019-03-29 18:01:58 +02:00
Andrea Marchesini
d59b949c32
Bug 1539407 - Use the correct global for DOMEventTargetHelper in IndexedDB, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D25041
2019-03-29 14:12:04 +00:00
Jan Varga
e0bb3bdf6f
Bug 1526891 - Part 11: Initiate asynchronous deletion of unreferenced files in IDB databases directly on the PBackground thread instead of going through the main thread; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D20920
2019-02-23 17:25:48 +01:00
Ehsan Akhgari
498e2df734
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
e5a134f73a
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
2018-11-30 11:46:48 +01:00
Gabriele Svelto
7e234e998c
Bug 1510582 - Remove useless inclusions of Services.h r=erahm
...
Differential Revision: https://phabricator.services.mozilla.com/D13240
2018-11-28 17:25:23 +00:00