Commit Graph

81 Commits

Author SHA1 Message Date
Boris Zbarsky
23db8f4fa3 Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron 2009-07-30 13:23:32 -04:00
Boris Zbarsky
6155045800 Bug 491180. <button> should not clip overflowing contents. r=roc 2009-07-22 21:31:45 -04:00
Robert O'Callahan
0d073a71fe Bug 494667. Don't apply optimization to shrink drawn background area to exclude solid borders, if we're not going to draw those borders (e.g. in tables with collapsing borders). r+sr=dbaron,a=beltzner 2009-05-28 17:01:42 +12:00
Benjamin Smedberg
0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
dbaron@dbaron.org
a4cc40910e Clean up IsFrameOfType methods to call their base class IsFrameOfType methods reliably. b=341326 r+sr=roc 2007-02-24 18:33:33 +00:00
bzbarsky@mit.edu
ec0b8c50c7 Remove some no longer needed code. Bug 368273, r+sr=dbaron 2007-01-30 05:52:27 +00:00
dbaron@dbaron.org
d21cb374bd Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213. 2006-12-08 05:38:33 +00:00
mats.palmgren@bredband.net
7ad743157e Remove the special painting code for a 165-twips checkbox. Move the remaining parts of nsFormControlHelper to its consumers and remove nsFormControlHelper.{cpp,h} from the tree. b=343495 r+sr=roc (r=me on roc's part) 2006-07-06 10:43:51 +00:00
bzbarsky@mit.edu
7a214013bb Give HTMLButtonControlFrames their own frame type. Bug 335419, r+sr=dbaron 2006-04-25 19:56:45 +00:00
roc+@cs.cmu.edu
24f6f0ed12 Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc 2006-04-10 00:16:29 +00:00
roc+@cs.cmu.edu
54d3415318 Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc 2006-03-26 21:30:36 +00:00
pavlov@pavlov.net
93222d8d4f backing out roc's patch for bug 328926 due to crash running tests on vc8 machines. 2006-03-15 06:43:36 +00:00
roc+@cs.cmu.edu
c92e50faf4 Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc 2006-03-15 03:14:02 +00:00
roc+@cs.cmu.edu
79c7894a78 Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell 2006-03-09 18:55:21 +00:00
roc+@cs.cmu.edu
a1b6a30f14 Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others 2006-01-26 02:29:17 +00:00
bmlk@gmx.de
5b8ee77062 Avoid reframing inside button frames and move the frame creation entirely into the frame constructor, bug 51767, r=mats sr=roc 2006-01-13 07:58:12 +00:00
cvshook@sicking.cc
aa95e1bf2f Bug 321294: Remove unused ReplaceFrame codepaths.
r/sr=roc
2006-01-10 22:58:37 +00:00
roc+@cs.cmu.edu
358bfc2241 Bug 254755. deCOMtaminate nsIFormControlFrame. patch by jpl24, r+sr=roc 2005-12-12 23:53:06 +00:00
bzbarsky@mit.edu
1b622da905 Treat inline and block buttons more uniformly. Bug 304004, r+sr=dbaron 2005-11-22 23:39:48 +00:00
roc+@cs.cmu.edu
5d1b988569 Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman. 2005-09-19 02:15:54 +00:00
jst@mozilla.jstenback.com
f54c1fc9b1 Fixing bug 289940. Make chrome event handlers only receive trusted events by default. r=jonas@sicking.cc, sr=peterv@propagandism.org, a=chofmann@mozilla.org 2005-04-28 23:48:28 +00:00
roc+@cs.cmu.edu
c83463d37f Bug 267037. Buttons should delegate child frames to the wrapped block, and tell the style system that legends are always blocks. Fixes a couple of crashes. r+sr=bzbarsky 2005-03-07 19:08:26 +00:00
bzbarsky@mit.edu
9e69ad849c Remove prescontext args for some nsIFrame methods
(Append/Insert/Remove/ReplaceFrames) and for some methods in table land.  Patch
by Vidar Braut Haarr <bugmail@q1n.org>, r+sr=bzbarsky
2005-02-07 01:58:25 +00:00
neil@parkwaycc.co.uk
ab8be2367d Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron 2005-01-01 17:26:29 +00:00
cbiesinger@web.de
26dff24a40 no bug - remove unused header includes, and remove an unused local variable.
r+sr=bz
2004-10-14 18:48:42 +00:00
bryner@brianryner.com
6cde4639f0 Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
rbs@maths.uq.edu.au
6026676857 Cleanup font usage in form input controls, b=251637, r=jshin, sr=bzbarsky 2004-07-21 01:05:44 +00:00
gerv@gerv.net
a1ec040a65 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
roc+@cs.cmu.edu
e719dd34eb Bug 227838. Remove unused RequiresWidget method from nsIFormControlFrame. r+sr=bzbarsky 2004-04-13 03:11:05 +00:00
dbaron@dbaron.org
92743fad12 DeCOMify nsIFrame::IsPercentageBase and rename to IsContainingBlock. b=237169 r+sr=bzbarsky a=brendan 2004-03-12 04:40:17 +00:00
roc+@cs.cmu.edu
55eb628e8d Bug 53966. Remove unnecessary view creation from nsImageControlFrame, and remove unused fields and functions from nsImageControlFrame/nsHTMLButtonControlFrame. r+sr=bzbarsky 2004-02-28 15:01:38 +00:00
bryner@brianryner.com
180d96f792 Get rid of nsIFrameManager abstract interface to the frame manager. Bug 233972, r+sr=roc. 2004-02-23 21:29:06 +00:00
bzbarsky@mit.edu
7563f70754 Make sure to properly delegate all framelist updates to our anonymous div. Bug
226016/98239, r+sr=dbaron
2003-11-18 02:12:24 +00:00
uid502
4fc4723244 Bug 190735. DeCOMtaminate nsIFrame::GetFrameType. r+sr=bzbarsky 2003-10-31 20:19:18 +00:00
bzbarsky@mit.edu
2ffa7c1620 Make shrink-wrap reflow for buttons correctly reflow the kids a second time at
the constrained shrink-wrap width.  Bug 26650 and dependencies, patch by
arunan_bala@hotmail.com (Arunan Bala), r=jkeiser, sr=bzbarsky
2003-02-22 19:48:29 +00:00
bryner@netscape.com
ba58162e96 Remove nsIStyleContext (bug 114713), r/sr=dbaron. Changed lots of methods to use nsStyleContext* or already_AddRefed<nsStyleContext> as return values, depending on whether a reference is returned. Turn on nsRefPtr (bug 104346), and change nsDerivedSafe to not declare AddRef and Release explicitly virtual, r=jag, sr=dbaron. 2003-02-22 00:32:13 +00:00
dbaron@dbaron.org
1c37d177d4 Replace computation of max-element-size (height and width) with max-element-width alone, since the max-element-height is practically unused and not meaningful for layout. b=186953 r+sr=bzbarsky 2003-01-09 14:26:32 +00:00
jkeiser@netscape.com
4abefda8a3 Make GetType() return int instead of nsresult (bug 167762), r=peterl@netscape.com, sr=kin@netscape.com 2002-12-18 23:38:09 +00:00
bzbarsky@mit.edu
508da80739 <button> should be a containing block. Bug 180301, r=jkeiser, sr=dbaron 2002-11-19 03:39:44 +00:00
bzbarsky@mit.edu
f8f860f5d7 Align text inputs, buttons, comboboxes to baseline with respect to the
text around them (bug 167236).  Fix width sizing issues for <input
type="button/reset/submit"> (bugs 79927, 36364).  Fix nonuniform heights
of form controls (bug 70251).  Patch is on bug 167236, r=jkeiser,
sr=roc+moz, moa=rods
2002-11-12 19:17:51 +00:00
jkeiser@netscape.com
3a3675d79e Make default wrap soft again, fix up text reflow, remove cruft from button reflow (bug 164641), r=rods@netscape.com, sr=kin@netscape.com 2002-09-16 06:23:52 +00:00
dbaron@fas.harvard.edu
6ccb4ee1ec Clean up unneeded includes of nsStyleUtil.h, and some other include cleanup in MathML. r=rbs b=71257 (|#include| changes only) 2002-08-16 11:52:20 +00:00
jkeiser@netscape.com
1672ad6e7e Remove nsFormFrame forever. bug 125578, r=alexsavulov@netscape.com, sr=jst@netscape.com 2002-06-04 00:44:04 +00:00
jst@netscape.com
78ccba6821 Fixing bug 146034. Getting rid of nsHTMLIIDs.{h,cpp}. r=jfrancis@netscape.com, sr=rpotts@netscape.com 2002-05-23 00:00:34 +00:00
dbaron@fas.harvard.edu
49ccb8e11d Convert users of nsAReadable[C]String and nsAWritable[C]String typedefs to [const] nsA[C]String. b=131899 r=scc sr=jag a=asa 2002-03-23 22:26:36 +00:00
dbaron@fas.harvard.edu
46f35ee536 Backing out Bernd's checkin for bug 110596 to fix crashes / weird display. b=118991 r=bernd 2002-01-09 19:17:46 +00:00
bernd.mielke@snafu.de
127612eaa5 add form frames to debug reflow bug 115096 r=karnaze sr=attinasi 2002-01-07 19:55:56 +00:00
bzbarsky@mit.edu
aa00eb2f47 Use NS_LITERAL_STRING instead of NS_ConvertASCIItoUCS2 where possible
(i.e. where the string is a literal).  Bug 104159, r=jag, sr=alecf
2001-11-14 01:33:42 +00:00