Commit Graph

485 Commits

Author SHA1 Message Date
Daisuke Akatsuka
95533899a1 Bug 1936455: Remove the Suggest online opt-in onboarding dialog r=firefox-desktop-core-reviewers ,urlbar-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D238893
2025-02-21 05:01:33 +00:00
Alexandru Marc
a822e8842c Backed out changeset 2c10082390b2 (bug 1936455) for causing xpcshell failures @ test_quicksuggest_migrate_v1.js CLOSED TREE 2025-02-21 03:51:58 +02:00
Daisuke Akatsuka
9c1c8fcf29 Bug 1936455: Remove the Suggest online opt-in onboarding dialog r=firefox-desktop-core-reviewers ,urlbar-reviewers,adw
Differential Revision: https://phabricator.services.mozilla.com/D238893
2025-02-21 01:05:42 +00:00
Florian Quèze
b412ac1d8d Bug 1944631 - Migrate histograms to use Glean APIs for BROWSER_*, r=mconley.
Differential Revision: https://phabricator.services.mozilla.com/D238788
2025-02-20 19:34:10 +00:00
Gijs Kruitbosch
ecac1cfa05 Bug 1916424 - use category manager for quit-application-granted consumers from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D220898
2025-02-20 13:51:02 +00:00
Gijs Kruitbosch
baa24c276e Bug 1916424 - use category manager for idle startup tasks from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D220897
2025-02-20 13:51:02 +00:00
Alexandru Marc
31459715b9 Backed out 4 changesets (bug 1916424, bug 1946400) for causing leaks @ Alloc, JSString::OwnedChars
Backed out changeset df8e24e9be67 (bug 1946400)
Backed out changeset 88961496629c (bug 1946400)
Backed out changeset 8e0862096be2 (bug 1916424)
Backed out changeset b4b2ef6e086b (bug 1916424)
2025-02-18 19:57:43 +02:00
Gijs Kruitbosch
a7804bd1c3 Bug 1916424 - use category manager for quit-application-granted consumers from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D220898
2025-02-18 14:57:48 +00:00
Gijs Kruitbosch
698e1bfe4a Bug 1916424 - use category manager for idle startup tasks from BrowserGlue, r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D220897
2025-02-18 14:57:47 +00:00
Dave Townsend
16739ed121 Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-18 11:28:15 +00:00
Goloman Adrian
0e650176ac Backed out changeset 23237bed6270 (bug 1927808) for causing xpc failures @test_sync_warning_dialogs.js. CLOSED TREE 2025-02-17 13:45:43 +02:00
Dave Townsend
9ae2b19dba Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-17 10:52:15 +00:00
Goloman Adrian
260e6fa6bb Backed out changeset cc9c1dbec866 (bug 1927808) for causing multiple failures. CLOSED TREE 2025-02-17 12:20:26 +02:00
Dave Townsend
b4ae0c1ece Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-17 09:07:43 +00:00
Ed Lee
694a588ca5 Bug 1945904 - GenAIChild spams the parent process with HideShortcuts messages and should manage event listeners more efficiently r=ngrato,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop
Register actor on mousedown and conditionally register hide related events after showing shortcuts.

Differential Revision: https://phabricator.services.mozilla.com/D237975
2025-02-13 17:02:19 +00:00
Drew Willcoxon
1175b84265 Bug 1945999 - Make Suggest initialization happen in one place. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D236825
2025-02-07 21:35:22 +00:00
Goloman Adrian
bc8a66a1e1 Backed out changeset 39e6a7e77cfb (bug 1927808) for causing multiple failures. CLOSED TREE 2025-02-06 14:50:21 +02:00
Dave Townsend
89b6c18f30 Bug 1927808: Profiles should remain disabled if BlockAboutProfiles enterprise policy is active. r=mkaply,profiles-reviewers,firefox-desktop-core-reviewers ,Gijs,jhirsch
This also ensures we are more consistent about using the state of `SelectableProfileService.isEnabled` to check if the feature is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D236848
2025-02-06 10:23:36 +00:00
Nick Alexander
4773306fc7 Bug 1945672 - Part 3: Block Glean startup and default browser prompt on notifying user. r=chutten,TravisLong,mviar,firefox-desktop-core-reviewers ,Gijs
This blocks FOG initialization on notifying the user.  This **does**
change the existing functionality, even when the Messaging System is
not used to notify the user: in legacy situations, this will display a
background tab and the promise will resolve quickly (not immediately),
falling back to an infobar that might be delayed 10-60s before being
displayed and being resolved (again, not immediately).

(Legacy Telemetry was blocked already, because the existing user
notification blocks sending Legacy Telemetry.)

Finally, the default browser prompt is blocked so that there's no race
between the (potentially blocking) Messaging System notification and
other prompts.  This also changes the behaviour by allowing the
Messaging System notification to be resolved and a subsequent
prompt (such as the default browser prompt) to be displayed
immediately afterward.

Differential Revision: https://phabricator.services.mozilla.com/D236624
2025-02-06 05:15:32 +00:00
Alexandru Marc
68ea3f065b Backed out 5 changesets (bug 1945290, bug 1945672) for causing xpcshell failures @ test_TelemetryReportingPolicy.js
Backed out changeset c16bb7800e1f (bug 1945672)
Backed out changeset 1a5006cd4cff (bug 1945672)
Backed out changeset 7da7d972d2fb (bug 1945672)
Backed out changeset 7b360633f06b (bug 1945290)
Backed out changeset caf8581c6983 (bug 1945290)
2025-02-06 02:40:51 +02:00
Nick Alexander
437a0d2791 Bug 1945672 - Part 3: Block Glean startup and default browser prompt on notifying user. r=chutten,TravisLong,mviar,firefox-desktop-core-reviewers ,Gijs
This blocks FOG initialization on notifying the user.  This **does**
change the existing functionality, even when the Messaging System is
not used to notify the user: in legacy situations, this will display a
background tab and the promise will resolve quickly (not immediately),
falling back to an infobar that might be delayed 10-60s before being
displayed and being resolved (again, not immediately).

(Legacy Telemetry was blocked already, because the existing user
notification blocks sending Legacy Telemetry.)

Finally, the default browser prompt is blocked so that there's no race
between the (potentially blocking) Messaging System notification and
other prompts.  This also changes the behaviour by allowing the
Messaging System notification to be resolved and a subsequent
prompt (such as the default browser prompt) to be displayed
immediately afterward.

Differential Revision: https://phabricator.services.mozilla.com/D236624
2025-02-05 21:55:30 +00:00
Mike Conley
829da877ed Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy
Differential Revision: https://phabricator.services.mozilla.com/D233866
2025-02-03 16:45:30 +00:00
Alexandru Marc
88e7c19d5c Backed out 10 changesets (bug 1938452) for causing node failures CLOSED TREE
Backed out changeset f6a771e83261 (bug 1938452)
Backed out changeset 69f385bc90ce (bug 1938452)
Backed out changeset 9c8837fc4805 (bug 1938452)
Backed out changeset c9737e213e42 (bug 1938452)
Backed out changeset ac0a50aaf347 (bug 1938452)
Backed out changeset f1f41e902e36 (bug 1938452)
Backed out changeset aef74a3d077d (bug 1938452)
Backed out changeset 8ca1a633192a (bug 1938452)
Backed out changeset 88df910fa038 (bug 1938452)
Backed out changeset cd4fdafb2594 (bug 1938452)
2025-02-03 18:28:59 +02:00
Mike Conley
b75d1059ab Bug 1938452 - Move newtab documentation to browser/extensions/newtab. r=omc-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,pdahiya,mossop,amy
Differential Revision: https://phabricator.services.mozilla.com/D233866
2025-02-03 15:07:08 +00:00
Ed Lee
8b77709dbf Bug 1933524 - Flip chatbot default and remove from Labs in Nightly and Release r=ngrato,settings-reviewers,sidebar-reviewers,nsharpley,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,jsudiaman,Gijs,sclements,desktop-theme-reviewers,hjones
Flip default pref to true and remove featuregate entry/strings/styles. Switch actor enabled to actual opt-in / provider. Update sidebar tests for chatbot as default tool.

Differential Revision: https://phabricator.services.mozilla.com/D233204
2025-01-31 16:58:55 +00:00
Sarah Clements
6431a09f9c Bug 1944101 - remove aichat as a default tool for specific users r=Mardak,mossop,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235819
2025-01-30 12:46:46 +00:00
Florian Quèze
b4b0d27e43 Bug 1935420 - Migrate histograms to use Glean APIs in toolkit/components/antitracking, r=chutten,anti-tracking-reviewers,firefox-desktop-core-reviewers ,emz,mossop.
Differential Revision: https://phabricator.services.mozilla.com/D234069
2025-01-27 13:42:15 +00:00
Mike Conley
33e00ac976 Bug 1942144 - Move AboutNewTab JSWindowActor registration to AboutNewTabService. r=firefox-desktop-core-reviewers ,home-newtab-reviewers,Gijs,thecount
This makes the AboutNewTabChild DOMContentLoaded event handler capturing in
order to ensure that it injects the contentTheme.js script before the
LightweightThemeChild fires its LightweightTheme:Set event. This worked
before by virtue of actor registration order (which this patch changes).

Differential Revision: https://phabricator.services.mozilla.com/D234590
2025-01-24 21:33:56 +00:00
Mathieu Leplatre
2fb5433cde Bug 1786310 - Offboard the main/public-suffix-list Remote Settings collection r=valentin,Gijs,necko-reviewers,firefox-desktop-core-reviewers
Reverts the work done in:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1563226
- https://bugzilla.mozilla.org/show_bug.cgi?id=1582647
- https://bugzilla.mozilla.org/show_bug.cgi?id=1563246

Differential Revision: https://phabricator.services.mozilla.com/D234356
2025-01-22 15:55:42 +00:00
Meg Viar
de889acc9a Bug 1941896 - Add ability to show preonboarding modal persistently until interacted with r=jprickett,hanna_a
Add ability to show the preonboarding modal on every startup until a configured "interactionPref" is set to true, typically via interaction with the primary CTA.

Differential Revision: https://phabricator.services.mozilla.com/D234406
2025-01-17 21:13:03 +00:00
Meg Viar
3bd09d7884 Bug 1941350 - Add preonboarding modal Nimbus feature r=firefox-desktop-core-reviewers ,omc-reviewers,negin
- Add `preonboarding` Nimbus feature for showing a window modal over about:welcome that cannot be dismissed via ESC
- Include the ability to suppress showing the privacy notice tab on first run using a variable under the new `preonboarding` feature
- Remove legacy `showModal` related `aboutwelcome` Nimbus feature variables (these are not in use and were for [[ https://experimenter.services.mozilla.com/nimbus/window-modal-vs-tab-modal/summary | an old experiment ]])

Differential Revision: https://phabricator.services.mozilla.com/D234039
2025-01-17 15:18:15 +00:00
Butkovits Atila
6827b521ec Backed out changeset d43df6d45f03 (bug 1786310) for causing failures at nsEffectiveTLDService.cpp. CLOSED TREE 2025-01-17 15:02:28 +02:00
Mathieu Leplatre
24dad11c20 Bug 1786310 - Offboard the main/public-suffix-list Remote Settings collection r=valentin,Gijs,necko-reviewers,firefox-desktop-core-reviewers
Reverts the work done in:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1563226
- https://bugzilla.mozilla.org/show_bug.cgi?id=1582647
- https://bugzilla.mozilla.org/show_bug.cgi?id=1563246

Differential Revision: https://phabricator.services.mozilla.com/D234356
2025-01-17 11:47:30 +00:00
Stanca Serban
b272d96a83 Backed out changeset 7ebf2aee0c7b (bug 1941350) for causing xpcshell failures in test_TelemetryReportingPolicy.js. CLOSED TREE 2025-01-16 19:51:43 +02:00
Meg Viar
9317d6a34e Bug 1941350 - Add TOU preonboarding modal Nimbus feature r=firefox-desktop-core-reviewers ,omc-reviewers,negin
- Add `preonboarding` Nimbus feature for showing a window modal over about:welcome that cannot be dismissed via ESC
- Include the ability to suppress showing the privacy notice tab on first run using a variable under the new `preonboarding` feature
- Remove legacy `showModal` related `aboutwelcome` Nimbus feature variables (these are not in use and were for [[ https://experimenter.services.mozilla.com/nimbus/window-modal-vs-tab-modal/summary | an old experiment ]])

Differential Revision: https://phabricator.services.mozilla.com/D234039
2025-01-16 16:00:13 +00:00
Fatih
347fe5d450 Bug 1448423: Skip earlyBlankFirstPaint if RoundWindowSize RFP target is enabled. r=tjr,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D224240
2025-01-16 13:35:46 +00:00
Nick Alexander
5d2870189e Bug 1921218 - Part 3: Usage reporting preference inherits general preference. r=chutten,TravisLong,firefox-desktop-core-reviewers ,mak
This commit makes the usage reporting preference inherit the general
data reporting preference for existing Firefox users.  New Firefox
users will use the default usage reporting preference value, which is
enabled by default.  Future onboarding changes will likely impact the
default usage reporting preference value.

Differential Revision: https://phabricator.services.mozilla.com/D232569
2025-01-15 23:13:25 +00:00
Nick Alexander
9ed45850dd Bug 1921218 - Part 2: Connect usage reporting Gecko preference to Glean. r=chutten,TravisLong,firefox-desktop-core-reviewers
This commit "splits the difference", putting as much behaviour as
convenient into a new `UsageReporting` module while still connecting to
`TelemetryControllerParent`.  The latter connection keeps testing
consistent; tests can assume that preference listeners, etc, are
registered.

The usage ID is preserved sibling to other client IDs in the "data
reporting state" bundle.  In the future, it might make sense to keep
the usage ID only as a Glean metric, but that might require a
migration and some code restructuring.  For expedience, I will keep
the existing implementation.

Differential Revision: https://phabricator.services.mozilla.com/D231995
2025-01-15 23:13:24 +00:00
Helena
651b2cfe37 Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 21:55:20 +00:00
Alexandru Marc
5a4a4de260 Backed out 2 changesets (bug 1448423) for causing bc failures @ browser_startup.js
Backed out changeset 93e49e407bc1 (bug 1448423)
Backed out changeset ac0d0fe55391 (bug 1448423)
2025-01-15 23:14:01 +02:00
Fatih
525b98402b Bug 1448423: Skip earlyBlankFirstPaint if RoundWindowSize RFP target is enabled. r=tjr,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D224240
2025-01-15 18:17:54 +00:00
Butkovits Atila
7d5fe6b5ca Backed out changeset 9e414abada40 (bug 1915672) for causing failures at browser_glean_metrics_exist.js. 2025-01-15 16:03:47 +02:00
Helena
48a5fff8dd Bug 1915672 - Add Telemetry for OSAuth for Formautofill and about:logins. r=dimi,mtigley,settings-reviewers,firefox-desktop-core-reviewers ,joschmidt
Differential Revision: https://phabricator.services.mozilla.com/D232339
2025-01-15 12:27:33 +00:00
Sammy Khamis
b095b5ae27 Bug 1901666: Move Account-related code into its own BrowserGlue r=markh,Gijs,sync-reviewers,firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D233316
2025-01-14 18:56:55 +00:00
Fred Chasen
0f35a787ae Bug 1921576 - Fix close button for Review Checker sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,kpatenio
* Sends a `CloseShoppingSidebar` message on clicking the shopping header close button to allow the `ReviewCheckerParent` to close the sidebar.

Differential Revision: https://phabricator.services.mozilla.com/D228281
2024-12-18 21:49:02 +00:00
Meg Viar
5567720814 Bug 1933293 - Rework aboutWelcome modal behavior to still show about:welcome page and make requiring action to proceed configurable r=firefox-desktop-core-reviewers ,mossop,pdahiya
This patch updates the logic that prevents about:welcome from showing when the Nimbus `aboutWelcome` `showModal` variable is set to true. If separate screens for the modal are provided, it can now be shown on top of the default onboarding flow in about:welcome.

A `requireAction` variable that sets the modal to be a window modal requiring action (other than pressing ESC) to dismiss is also added to the `aboutWelcome` Nimbus feature

Differential Revision: https://phabricator.services.mozilla.com/D230185
2024-12-18 19:04:43 +00:00
Fatih
1c7d8d2aa1 Bug 1913421: Submit ping with at least 24 hour delay since last submission or on pref changes. r=mossop,geckoview-reviewers,tjr,tthibaud
We submit the ping with at least 24 hours delay in between to not spam with pings. When we receive a new captcha event,
we'll check the last submission time and submit the ping if it's been more than 24 hours since the last submission.

Differential Revision: https://phabricator.services.mozilla.com/D226023
2024-12-18 16:17:05 +00:00
Fred Chasen
b173af01b4 Bug 1921570 - Part 2: Render AboutWelcome in the new sidebar. r=shopping-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,kpatenio,pdahiya
- Update `AboutWelcomeShopping` actors to include the sidebar review checker message manager group.
- Update `AWSetProductURL` to handle when a URL is not passed, which will happen on non-product pages.

Differential Revision: https://phabricator.services.mozilla.com/D223431
2024-12-17 20:51:47 +00:00
Stanca Serban
48bbabbc35 Backed out 17 changesets (bug 1913421) for causing mochitests-plain failures in test_arkose_labs.html. CLOSED TREE
Backed out changeset 7eda60115372 (bug 1913421)
Backed out changeset 5f1bb8cea1d5 (bug 1913421)
Backed out changeset 22084dc8fbb0 (bug 1913421)
Backed out changeset d5f36da0c01f (bug 1913421)
Backed out changeset 2fbc4c09d4f0 (bug 1913421)
Backed out changeset 8ca6f7399e31 (bug 1913421)
Backed out changeset cc2acc1bd560 (bug 1913421)
Backed out changeset 335767ea0138 (bug 1913421)
Backed out changeset ba58924faee8 (bug 1913421)
Backed out changeset b36e090e8715 (bug 1913421)
Backed out changeset f6850c74997a (bug 1913421)
Backed out changeset 7f54b1a2c565 (bug 1913421)
Backed out changeset 2459730a7e10 (bug 1913421)
Backed out changeset afd89f58cab0 (bug 1913421)
Backed out changeset cd2258c3f8e3 (bug 1913421)
Backed out changeset 51f94cd7e9e5 (bug 1913421)
Backed out changeset 849674119c65 (bug 1913421)
2024-12-17 17:50:34 +02:00
Fatih
c2c06356a7 Bug 1913421: Submit ping with at least 24 hour delay since last submission or on pref changes. r=mossop,geckoview-reviewers,tjr,tthibaud
We submit the ping with at least 24 hours delay in between to not spam with pings. When we receive a new captcha event,
we'll check the last submission time and submit the ping if it's been more than 24 hours since the last submission.

Differential Revision: https://phabricator.services.mozilla.com/D226023
2024-12-17 13:09:09 +00:00