Commit Graph

123 Commits

Author SHA1 Message Date
MozLando
22d5df2f1d [components] Merge https://github.com/mozilla-mobile/android-components/pull/7355
7355: Fixes https://github.com/mozilla-mobile/android-components/issues/7354: Changes the add-ons icon from toolbar menu r=Amejia481 a=ValentinTimisica



Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
2020-06-22 08:13:53 +00:00
Mugurell
b78ae6372a [components] For https://github.com/mozilla-mobile/android-components/issues/7392 - Material design sanity checks for BrowserMenu min/max width
DynamicWidthRecyclerView will still be able to have a dynamic width between xml
set minWidth and maxWidth attributes but we'll now enforce the following:
- minimum width 112 dp
- maximum width - screen width minus a 48dp tappable “exit area”
2020-06-15 17:54:05 +03:00
ValentinTimisica
c949e6397a [components] Fixes https://github.com/mozilla-mobile/android-components/issues/7354: Changes the add-ons icon from toolbar menu 2020-06-12 12:16:56 +03:00
Simon Chae
c1301adcf3 [components] Set overflow item only visible for ParentBrowserMenuItem 2020-05-29 10:38:37 -04:00
MozLando
844104e5bc [components] Merge https://github.com/mozilla-mobile/android-components/pull/7111
7111: For https://github.com/mozilla-mobile/android-components/issues/7110: Dismiss menu popup window when anchor is detached from window. r=Amejia481,psymoon a=mcarare



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2020-05-29 05:37:18 +00:00
Simon Chae
13f0da91a6 [components] Closes https://github.com/mozilla-mobile/android-components/issues/7158: Add right chevron arrow in ParentBrowserMenuItem 2020-05-28 11:04:39 -04:00
mcarare
4c3485d644 [components] For https://github.com/mozilla-mobile/android-components/issues/7110: Add attached state listener for menu anchor.
Dismiss popup window when anchor is detached from window.
2020-05-28 08:26:48 +03:00
mcarare
448e7d09d7 [components] For https://github.com/mozilla-mobile/android-components/issues/7107: Set buttons height to match parent in browser item toolbar. 2020-05-26 13:42:16 +03:00
Simon Chae
93a613ff5f [components] Closes https://github.com/mozilla-mobile/android-components/issues/7062: Add nested menu UI for web extensions actions 2020-05-25 16:47:06 -04:00
Tiger Oakes
223af0811e [components] For https://github.com/mozilla-mobile/android-components/issues/6261 - Move browser.menu2 to concept-menu2
Move the current dumb data classes into a concept component

Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2020-05-12 10:29:09 -07:00
Mugurell
e9fe72b5c5 [components] For https://github.com/mozilla-mobile/android-components/issues/6499 - Add min/max width support for BrowserMenu
BrowserMenu will now use a RecyclerView with dynamic width, automatically set
between
- `mozac_browser_menu_width_min`
- `mozac_browser_menu_width_max`
allowing for a better fit for all menu items.

By default `mozac_browser_menu_width_min` and `mozac_browser_menu_width_max`
have the same value ensuring the same previous behavior for all clients -
fixed width, the value of mozac_browser_menu_width.
`mozac_browser_menu_width_min` and `mozac_browser_menu_width_max` must have
different values for BrowserMenu to have dynamic width.
2020-05-07 10:43:20 +03:00
MozLando
dc21f352d2 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6863 https://github.com/mozilla-mobile/android-components/pull/6869 https://github.com/mozilla-mobile/android-components/pull/6874 (part 1)
6863: For https://github.com/mozilla-mobile/android-components/issues/6825: Implement a custom tooltip for SDK 26. r=Amejia481 a=mcarare



6869: Closes https://github.com/mozilla-mobile/android-components/issues/6832: Ignore initial loads of about:blank for extension pages r=pocmo a=csadilek

We already have a workaround to ignore initial loads of about:blank. When switching to an extension page, there's a process switch involved, which triggers the same problem. This is pretty annoying, as we always see about:blank loads before loading the actual extension page e.g. the uBlock dashboard, or a reader view page.

GV can't fix this and advised to ignore all about:blank loads (https://bugzilla.mozilla.org/show_bug.cgi?id=1634428), which also doesn't seem right to me. So, here I am only ignoring the initial loads of about:blank when switching between regular and extension pages (after a process switch).

Not pretty, but does the trick and it's in line with our existing workaround at least. @pocmo can you take a look at this one?

6874:  Docs update (20200505-120948) [ci skip] r=pocmo a=MickeyMoz



Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
2020-05-05 12:29:43 +00:00
mcarare
e10c7414c1 [components] For https://github.com/mozilla-mobile/android-components/issues/6825: Implement a custom tooltip for SDK 26. 2020-05-05 09:32:38 +03:00
ValentinTimisica
f77db70001 [components] For https://github.com/mozilla-mobile/android-components/issues/6558: Adds tests for the menu with simple highlightable items 2020-05-04 12:17:30 +03:00
ValentinTimisica
b1c23e94c2 [components] For https://github.com/mozilla-mobile/android-components/issues/6558: Adds a menu with simple highlightable items 2020-05-04 12:17:20 +03:00
Jonathan Almeida
b86fa6dfb5 [components] Close https://github.com/mozilla-mobile/android-components/issues/6601: Update targetSdkVersion to 29 2020-04-28 03:16:54 -04:00
Simon Chae
b28f7f286e [components] Closes https://github.com/mozilla-mobile/android-components/issues/6228: Expose allowedInPrivateBrowsing control 2020-04-20 15:55:40 -04:00
mcarare
dc9d3756e0 [components] For https://github.com/mozilla-mobile/android-components/issues/6593: Update content description when item has dot notification 2020-04-09 17:11:34 +03:00
Mihai Branescu
6bdc149aeb [components] For https://github.com/mozilla-mobile/android-components/issues/6308 - Added unit tests for all BrowserMenuItem.getHighlight scenarios 2020-03-20 14:05:26 +02:00
Mihai Branescu
c3f0515cc5 [components] For https://github.com/mozilla-mobile/android-components/issues/6308 - Added canPropagate param so that other components may opt out
of displaying it (ex: three-dot menu can now hide the notification dot
for some items)
2020-03-20 14:05:26 +02:00
mcarare
5fd60fd902 [components] For https://github.com/mozilla-mobile/android-components/issues/6137: Set BrowserMenuCategory padding same as other items in menu 2020-03-02 13:11:19 +02:00
MozLando
252c56a7a8 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6103
6103: For https://github.com/mozilla-mobile/android-components/issues/6102 - Use app:srcCompat instead of android:src r=gabrielluong a=ekager



Co-authored-by: ekager <ekager@mozilla.com>
2020-02-27 23:32:41 +00:00
ekager
572b102758 [components] For https://github.com/mozilla-mobile/android-components/issues/6102 - Use app:srcCompat instead of android:src 2020-02-27 10:44:39 -08:00
Gabriel Luong
5ca4ae1b85 [components] Closes https://github.com/mozilla-mobile/android-components/issues/6033: Emit Facts for Web Extension Browser Menu 2020-02-26 13:54:38 -05:00
MozLando
3123137d99 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6071
6071: Closes https://github.com/mozilla-mobile/android-components/issues/6070: Mark badgeView invisible if it's null r=Amejia481 a=psymoon



Co-authored-by: Simon Chae <chaesmn@gmail.com>
2020-02-26 02:34:50 +00:00
MozLando
2d2baccee3 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6074
6074: Closes https://github.com/mozilla-mobile/android-components/issues/6073: Adds animation to showPopupWhereBestFits menu r=Amejia481 a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
2020-02-25 22:16:39 +00:00
Sawyer Blatz
ab062468fb [components] Closes https://github.com/mozilla-mobile/android-components/issues/6073: Adds animation to showPopupWhereBestFits menu 2020-02-25 13:51:42 -08:00
Simon Chae
7c4ab1b7ee [components] Closes https://github.com/mozilla-mobile/android-components/issues/6070: Mark badgeView invisible if it's null 2020-02-25 11:28:34 -05:00
MozLando
e432f6f333 [components] Merge https://github.com/mozilla-mobile/android-components/pull/6055
6055: For https://github.com/mozilla-mobile/fenix/issues/8706: Add padding to web-ext menu item badge text r=Amejia481 a=psymoon

https://github.com/mozilla-mobile/fenix/issues/8706

Co-authored-by: Simon Chae <chaesmn@gmail.com>
2020-02-25 00:58:16 +00:00
MozLando
5c6fea154b [components] Merge https://github.com/mozilla-mobile/android-components/pull/6051
6051: For https://github.com/mozilla-mobile/fenix/issues/8524 - Use SwitchCompat for BrowserMenuImageSwitch r=psymoon a=ekager



Co-authored-by: ekager <ekager@mozilla.com>
2020-02-24 23:55:19 +00:00
Simon Chae
9f0cb6db89 [components] For https://github.com/mozilla-mobile/fenix/issues/8706: Add padding to web-ext menu item badge text 2020-02-24 18:53:16 -05:00
ekager
823b00f884 [components] For https://github.com/mozilla-mobile/fenix/issues/8524 - Use SwitchCompat for BrowserMenuImageSwitch 2020-02-24 13:33:32 -08:00
Arturo Mejia
808b7aa150 [components] Remove double background from mozac_browser_menu_web_extension 2020-02-24 15:57:15 -05:00
Simon Chae
e024da5bee [components] Closes https://github.com/mozilla-mobile/android-components/issues/6004: Show web ext badge in browser menu item 2020-02-20 11:17:24 -05:00
Christian Sadilek
cc1bbaaa99 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5708: Browser/Page actions don't have stable ordering 2020-01-24 11:01:47 -05:00
Simon Chae
cd41fe6124 [components] Set web extension menu label clickable to false 2020-01-23 19:37:00 -05:00
Simon Chae
d4d7831a78 [components] For https://github.com/mozilla-mobile/android-components/issues/5572: Refactor web extension popup initialization 2020-01-23 19:36:58 -05:00
Tiger Oakes
4452fe5af8 [components] For https://github.com/mozilla-mobile/android-components/issues/5373 - Add menu candidate class 2020-01-22 19:50:04 -08:00
MozLando
66b907c26e [components] Merge https://github.com/mozilla-mobile/android-components/pull/5679 https://github.com/mozilla-mobile/android-components/pull/5683 https://github.com/mozilla-mobile/android-components/pull/5688 (part 3)
5679: Closes https://github.com/mozilla-mobile/android-components/issues/5677: Catch all known non-fatal push errors r=grigoryk a=jonalmeida

Previously, we wanted to throw on all unknown push errors so that we
were notified on them. Since this seems to be more common than
originally expected, we should just catch them and in a future version,
we should log them without crashing.

All of these push errors can be considered recoverable except
for InternalPanic.




5683: Closes https://github.com/mozilla-mobile/android-components/issues/5682: Remove failedToLaunch property from AppLinksUseCases r=NotWoods a=rocketsroger



5688: Closes https://github.com/mozilla-mobile/android-components/issues/5684: Intermittent failures in WebExtensionBrowserMenuItemTest r=Amejia481,psymoon a=csadilek



Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
Co-authored-by: Roger Yang <royang@mozilla.com>
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2020-01-23 02:15:20 +00:00
Christian Sadilek
905f4f2641 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5684: Intermittent failures in WebExtensionBrowserMenuItemTest 2020-01-22 17:26:06 -05:00
Arturo Mejia
f035568ade [components] Closes https://github.com/mozilla-mobile/android-components/issues/4470 Wire up UI for page action support. 2020-01-22 11:44:19 -05:00
MozLando
daa11d1481 [components] Merge https://github.com/mozilla-mobile/android-components/pull/5651
5651: Issue https://github.com/mozilla-mobile/android-components/issues/4470: Wire up API for page action support r=Amejia481 a=csadilek

Part 1: Bring in the engine and store API and wire it up.

Part 2 will be to add the action to our UIs (toolbar and browser menu) which we'll do separately.

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2020-01-20 22:53:46 +00:00
Christian Sadilek
70570d5ac2 [components] Issue https://github.com/mozilla-mobile/android-components/issues/4470: Wire up API for page action support
- This is basically just a copy of our browser action API, with some
refactoring to make some types and methods generic
2020-01-20 17:41:21 -05:00
Tiger Oakes
ee5372f81b [components] For https://github.com/mozilla-mobile/fenix/issues/7506 - Expose MenuButton 2020-01-16 17:44:49 -08:00
Simon Chae
215f44237e [components] For https://github.com/mozilla-mobile/fenix/pull/7517: Update menu container style to use 16dp padding
Also allow mozac_browser_menu_web_extension to use "@style/Mozac.Browser.Menu.Item.Container"
2020-01-16 14:37:51 -05:00
Simon Chae
d057441342 [components] Closes https://github.com/mozilla-mobile/android-components/issues/5355: Add web extension action browser-menu support 2020-01-16 10:50:50 -05:00
Eitan Isaacson
2f6b9f0331 [components] Provide full menu item count to accessibility services.
We need to count buttons inside of toolbar items, and ignore dividers.

This fixes https://github.com/mozilla-mobile/fenix/issues/2143
2020-01-09 16:02:38 -08:00
salvatorep
95b7cfdf88 [components] Added tooltips to browser toolbar images when long pressed 2019-12-31 10:05:18 +00:00
Tiger Oakes
fe50c6d630 [components] Add BrowserMenuHighlightableSwitch 2019-12-20 19:12:01 -08:00
Tiger Oakes
0fb42f90e2 [components] Add low priority menu highlight 2019-11-26 14:49:07 -08:00