Commit Graph

34644 Commits

Author SHA1 Message Date
Neil Deakin
21426e24f4 Bug 1776879, replace text/unicode for clipboard and drag and drop and use text/plain directly, r=edgar,mak,stransky,geckoview-reviewers,extension-reviewers,zombie,m_kato
Most usage is a straight replacement but gtk needs extra changes as it transfers plain text in UTF8 natively and needs to be converted into UTF16, and Windows uses single-byte characters for RTF and CF_HTML formats so we preserve this.

Differential Revision: https://phabricator.services.mozilla.com/D158587
2023-02-01 23:30:55 +00:00
scottdowne
6dedfa0f20 Bug 1814247 - Pocket newtab fixing Spain locale code for supported newtab Pocket stories. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D168573
2023-02-01 18:28:44 +00:00
Shane Hughes
7f19e919fb Bug 1805177 - Make Escape key dismiss Feature Callouts. r=mviar
Set up event handlers so that pressing Escape dismisses Feature
Callouts. If an interactive element outside of the Callout is focused,
then the Escape key will not be consumed. Also consolidate all the event
handlers into a single switch statement so we won't need to continue
adding more callback bindings (they were only necessary before
encapsulation was implemented). Also change the names of a couple
formerly pseudo-private methods that we're now referencing externally.

Differential Revision: https://phabricator.services.mozilla.com/D168307
2023-02-01 17:52:12 +00:00
Russell Chan
95fb6191c6 Bug 1809334 - [Cleanup] Remove pre-MR onboarding default message r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D166699
2023-02-01 17:47:42 +00:00
prathikshaprasadsuman
f6b948db44 Bug 1749866 - Top site add/edit dialog should get focus when it is opened. r=thecount
This patch does two things:
1. Brings focus into the add/edit top site dialogs when they are opened.
2. Sets the `aria-haspopup=dialog` attribute on the buttons that open the dialogs. This helps assistive technologies announce that a dialog is being opened before it opens.

Differential Revision: https://phabricator.services.mozilla.com/D168564
2023-02-01 17:21:00 +00:00
Drew Willcoxon
50d6926ab7 Bug 1814318 - Make L10nCache.ensure() re-cache strings when excludeArgsFromCacheKey is set. r=dao
This is an error in how I implemented the `excludeArgsFromCacheKey` mechanism in
D167318. It can be fixed by always re-caching strings when
`excludeArgsFromCacheKey` is passed to `ensure()`. We could instead store the
argument values of currently cached strings and then re-cache only when
different argument values are passed to `ensure()`, but that would require a
deeper change and I don't think it's worth it.

Differential Revision: https://phabricator.services.mozilla.com/D168509
2023-02-01 17:20:00 +00:00
Butkovits Atila
b95413c1ad Backed out changeset f878cff45427 (bug 1800670) for causing failures at browser_protectionsUI_cookie_banner.js. CLOSED TREE 2023-02-01 20:40:46 +02:00
James Teow
60e5cb7dba Bug 1807039 - Update telemetry.rst with urlbar-persisted specific info - r=Standard8 DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165405
2023-02-01 14:56:50 +00:00
Jared Hirsch
42e2eda79e Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-01 14:51:39 +00:00
DJ
46796f9251 Bug 1813555 - corrections for CBH doorhanger. r=omc-reviewers,fluent-reviewers,aminomancer,flod
Differential Revision: https://phabricator.services.mozilla.com/D168443
2023-02-01 14:18:40 +00:00
mcheang
f26d2a59ce Bug 1811556 - Fix text fading in weather suggestion result and hide middot when high and low temperatures are wrapped. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D167416
2023-02-01 13:52:57 +00:00
Emilio Cobos Álvarez
1c01d8e159 Bug 1812698 - Migrate old linux profiles to preserve titlebar default. r=mak,stransky
Differential Revision: https://phabricator.services.mozilla.com/D168262
2023-02-01 13:14:50 +00:00
reynaa
24a74cd52a Bug 1742697 - Change title-case strings to sentence-case on buttons. r=pbz
Changed the text of buttons to sentence case according to new design styling.
(revised)

Differential Revision: https://phabricator.services.mozilla.com/D168290
2023-02-01 10:56:10 +00:00
Daisuke Akatsuka
196f875251 Bug 1812197: Show page title by alternate same origin if matched origin has no title. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D168041
2023-01-31 21:32:07 +00:00
Gregory Pappas
7d1502f86d Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw
Differential Revision: https://phabricator.services.mozilla.com/D168191
2023-01-31 18:50:23 +00:00
Hannah Peuckmann
9f66067efd Bug 791594 - Set URL bar state while prompt is open. r=pbz,Gijs,adw
Differential Revision: https://phabricator.services.mozilla.com/D164441
2023-01-31 18:16:54 +00:00
Marco Bonardo
febc0037be Bug 1813484 - Use new URI <-> URL conversion in Places. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D168253
2023-01-31 17:36:22 +00:00
Niklas Baumgardner
b7a9cc4439 Bug 1799215 - Screenshots overlay buttons should have focus states. r=cmkm
Differential Revision: https://phabricator.services.mozilla.com/D167583
2023-01-31 16:20:48 +00:00
Otto Länd
c333f002e7 Bug 1811281, 1812704: apply code formatting via Lando
# ignore-this-changeset
2023-01-31 16:24:28 +00:00
Mike Conley
58108e2c7e Bug 1812704 - Wire up the new MigrationWizard to MigrationUtils to let it perform migrations. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D167998
2023-01-31 15:30:58 +00:00
Mike Conley
9c17617fb0 Bug 1811281 - Open new MigrationWizard dialog as a SubDialog in about:preferences rather than a TabDialog. r=Gijs,settings-reviewers
This does a few things to support this new behaviour:

1. Adds the ability for about:preferences category modules to indicate that
   they want to specially handle subcategories. In this particular case, it
   causes the "migrate" subcategory of the "general" category to open up the
   migration dialog.
2. Updates MigrationUtils to open about:preferences#general-migrate if the opener
   is a tabbrowser window.
3. Adds some utility functions to make writing tests easier.
4. Updates existing tests to expect the wizard to be opened in the about:preferences
   subdialog.
5. Makes pressing "Escape" close the migration wizard when it's loaded in the
   migration-dialog.html document.

Differential Revision: https://phabricator.services.mozilla.com/D167873
2023-01-31 15:30:57 +00:00
Gijs Kruitbosch
ccf0d0d117 Bug 1795255 - bustage fix: fix up some more imports that shouldn't have been removed because of confused environment conflicts. CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D168379
2023-01-31 13:07:58 +00:00
Gijs Kruitbosch
b965c4660a Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D166179
2023-01-31 11:48:41 +00:00
Gijs Kruitbosch
8bd11b391d Bug 1795255 - manual fixes for tests that break after applying this lint rule, r=Standard8,necko-reviewers,extension-reviewers,credential-management-reviewers,sgalich,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D167802
2023-01-31 11:48:41 +00:00
Dão Gottwald
e53679d678 Bug 1813505 - Make browser_view_selectionByMouse.js work with the result menu button. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D168242
2023-01-31 09:52:44 +00:00
Jonathan Sudiaman
8d20bcc639 Bug 1801871 - Update Bookmark Star panel to use editBookmark.js r=mak,Standard8
Enable delayed apply logic for the star panel. Refactor some existing code using async/await rather than `catch()` everywhere.

https://treeherder.mozilla.org/jobs?revision=fb6ba9ef08f132c72b6c2918067fc3db54a94650&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D166237
2023-01-30 20:10:46 +00:00
Mark Banner
9f5558b211 Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D168070
2023-01-30 19:33:37 +00:00
Russell Chan
49b66cb543 Bug 1796238 - Hide lone progress bar step in aboutwelcome in HCM r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D166833
2023-01-30 19:07:05 +00:00
Noemi Erli
879d74bdb0 Backed out changeset 68de023d3c5c (bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE 2023-01-30 21:16:42 +02:00
Jared Hirsch
e1c9146780 Bug 1812819 - Update cookie banner preferences checkbox to toggle reject-only mode. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D168285
2023-01-30 18:51:58 +00:00
Drew Willcoxon
b2d3b1dc40 Bug 1813155 - Quick suggest provider should not be active for search strings that contain only spaces. r=mak
I broke this in D167218. We didn't have a test for it.

Differential Revision: https://phabricator.services.mozilla.com/D168139
2023-01-30 16:45:32 +00:00
Jared Hirsch
992086fbed Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 16:30:28 +00:00
Rob Wu
79598d955e Bug 1811459 - Avoid _moveOutKids on disconnected panelmultiview r=Gijs,rpl
`this.forNode` (with `this` being a `PanelMultiView` instance) may
return a node that was already disconnected before, in which case its
`node` member will be void. To avoid unexpected promise rejections, add
a null check before `_moveOutKids()`.

Differential Revision: https://phabricator.services.mozilla.com/D167369
2023-01-30 14:43:24 +00:00
Butkovits Atila
2d7b95f5e7 Backed out changeset 0bd6e56348ff (bug 1813302) for causing xpc shell failures at test_providerOmnibox.js. CLOSED TREE 2023-01-30 17:36:11 +02:00
Butkovits Atila
af64ca6493 Backed out changeset ab00cf793f29 (bug 1800417) for causing failures at browser_unified_extensions_overflowable_toolbar.js. 2023-01-30 17:34:14 +02:00
William Durand
fd0ded3d7b Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-01-30 13:36:07 +00:00
Gregory Pappas
a5190d90d9 Bug 1813302 - Add missing blockL10n property to UrlbarProviderOmnibox payload r=dao,adw
Differential Revision: https://phabricator.services.mozilla.com/D168191
2023-01-30 12:55:37 +00:00
Butkovits Atila
8a37a83f45 Backed out changeset 0072aa5cd31d (bug 1800670) for causing multiple mochitest failures. CLOSED TREE 2023-01-30 15:26:29 +02:00
Jared Hirsch
64cb4ee8e6 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 12:24:28 +00:00
William Durand
d42c7aaa29 Bug 1811128 - Use 16/32px extension icons in toolbars. r=rpl,dao
Differential Revision: https://phabricator.services.mozilla.com/D167573
2023-01-30 10:46:12 +00:00
Dale Harvey
0438990a06 Bug 1812152 - Add pref to control minimum chars needed to match quickaction. r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D167713
2023-01-28 23:12:43 +00:00
Sergey Galich
6f8ed336b3 Bug 1748065 - Do not leak password length when password is concealed. r=credential-management-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D134912
2023-01-28 19:16:03 +00:00
Dão Gottwald
c549adc38a Bug 1811870 - Enable urlbar result menu in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D167693
2023-01-28 14:22:46 +00:00
Mike Conley
4d0fd85440 Bug 1813141 - Use a relative path for the progress mask image in the MigrationWizard Storybook story. r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D168136
2023-01-27 20:35:34 +00:00
DJ
6995a87679 Bug 1811053 - update text for CBH in about:prefs. r=settings-reviewers,fluent-reviewers,flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167631
2023-01-27 19:54:02 +00:00
Dão Gottwald
d7994183f4 Bug 1811507 - Fix highlighting of dynamic type rows. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D167795
2023-01-27 19:21:10 +00:00
Dan Mosedale
8089ad99f2 Bug 1809331 - add generic fxms-message-* feature-ids, r=omc-reviewers,emcminn,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D166397
2023-01-27 18:17:21 +00:00
Drew Willcoxon
24aa99e25f Bug 1813117 - Add comment to BrowserGlue about the removed migration 134. r=mak DONTBUILD
This is a follow up to D167889. See https://phabricator.services.mozilla.com/D167889#5529599

Differential Revision: https://phabricator.services.mozilla.com/D168124
2023-01-27 17:23:47 +00:00
Narcis Beleuzu
47cb05bbf5 Backed out 3 changesets (bug 1812275, bug 1812035, bug 1806501) for bc failures on browser_aboutprocesses_default_options.js .
Backed out changeset 4f13d8470d97 (bug 1806501)
Backed out changeset a276a2939cee (bug 1812275)
Backed out changeset 67775732c1a8 (bug 1812035)
2023-01-27 17:14:57 +02:00
ogiorgis
1826f0e73d Bug 1749473 - fix all pygments warnings r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D167915
2023-01-27 13:41:10 +00:00