corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
791,130 Commits 1 Branch 0 Tags
1c50fdedbaf7f3bee5bdfcd0c2c9bcf1ad30a5a7
Commit Graph

94 Commits

Author SHA1 Message Date
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180713
 2023-06-23 19:23:51 +00:00
Mike Conley
669193a9a3 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles 
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
 2023-06-22 13:48:51 +00:00
Norisz Fay
de0f4e32f7 Backed out 2 changesets (bug 1839462) as requested by dev CLOSED TREE 
Backed out changeset a61155e9121f (bug 1839462)
Backed out changeset 99d02fe665aa (bug 1839462)
 2023-06-21 23:42:10 +03:00
Mike Conley
b02bff5657 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles 
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
 2023-06-21 20:24:57 +00:00
Tim Giles
6d7971b059 Bug 1836773 - Support the new MigrationResource in the migration wizard. r=mconley,willdurand,fluent-reviewers,desktop-theme-reviewers,flod 
Enables support for migrating extensions from Chrome once we have the
API to match and install extensions from the add-ons store.

Adds a new ProgressState object to delineate between various progress
states. This new object has four properties: value, message, linkURL,
and linkText. See migration-wizard-constants for more information.

MigrationWizard.#onShowingProgress uses the new ProgressState object
to handle the new LOADING, SUCCESS, ERROR and INFO values for progress.
This has the added benefit of updating the UI on error cases for the
existing resource groups.

Adds a new details object parameter to MigratorBase.migrate which is
currently used in the Chrome extensions import case.
See ChromeProfileMigrator.GetExtensionsResource for an example of
creating this details object.
See MigrationWizardParent.#doBrowserMigration for example usage of this
details object.

Adds support-text links under each resource type group in the markup.
This is currently used only by extensions in the partial matching and
no matching extensions cases.

Refactor MigrationUtils.installExtensionsWrapper to return an array
with the progress state (LOADING, SUCCESS, ERROR, INFO) and any
imported extensions.

Depends on D180005

Differential Revision: https://phabricator.services.mozilla.com/D180876
 2023-06-21 20:24:56 +00:00
Mike Conley
99e87d9a44 Bug 1837367 - Allow file migrators to show an error message if migration failed for some reason. r=kpatenio,desktop-theme-reviewers 
The spec calls for a special-case in the event that file migration
ever fails - the wizard should be sent back to the selection page,
have the associated file migrator still set in the dropdown, and
show an error message.

A later patch in this series will add such an error message for
the bookmarks file migrator.

Depends on D180458

Differential Revision: https://phabricator.services.mozilla.com/D180490
 2023-06-13 14:53:00 +00:00
Mike Conley
1ddda0a319 Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D180458
 2023-06-12 19:45:51 +00:00
Mike Conley
e27d937911 Bug 1823537 - Add tests for the ported telemetry probes. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D180232
 2023-06-09 17:39:51 +00:00
Mike Conley
bb66c4f000 Bug 1823537 - Port some older telemetry probes from the old migration wizard to the new one. r=Gijs 
Those probes are:
* migration.uninstaller_profile_refresh (scalar)
* migration.discovered_migrators (keyed scalar)
* FX_MIGRATION_SOURCE_BROWSER (histogram)
* FX_MIGRATION_USAGE (histogram)
* FX_MIGRATION_ERRORS (histogram)

Not being ported are the following histograms:
* FX_STARTUP_MIGRATION_BROWSER_COUNT
* FX_STARTUP_MIGRATION_EXISTING_DEFAULT_BROWSER
* FX_STARTUP_MIGRATION_DATA_RECENCY
* FX_STARTUP_MIGRATION_USED_RECENT_BROWSER

as these are all expired.

Differential Revision: https://phabricator.services.mozilla.com/D180231
 2023-06-09 17:39:51 +00:00
Mike Conley
9dcf68ac4d Bug 1823537 - Use new migration wizard for startup and profile reset migrations. r=kpatenio,Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D180230
 2023-06-09 17:39:51 +00:00
Mike Conley
4972dd2d5f Bug 1833427 - Add bookmark import from HTML file in new migration wizard. r=fluent-reviewers,kpatenio,flod 
Original patch by Tim Giles <tgiles@mozilla.com>, completed by Mike Conley <mconley@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D179273
 2023-05-30 13:37:54 +00:00
Mike Conley
e62aa51bdc Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio 
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
 2023-05-29 16:12:41 +00:00
Butkovits Atila
9664e002bb Backed out changeset 863fae78db03 (bug 1825874) for causing failures at browser_disabled_migrator.js. CLOSED TREE 2023-05-29 18:34:53 +03:00
Mike Conley
e359cbe532 Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio 
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
 2023-05-29 14:39:59 +00:00
Mike Conley
dc1b375397 Bug 1826149 - Add payment method migration experience in new migration wizard. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D178364
 2023-05-25 20:16:04 +00:00
Mike Conley
12aaa8d45f Bug 1830891 - Clear new migration wizard progress strings when going back to in-progress. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D178856
 2023-05-23 23:13:26 +00:00
Mike Conley
ad6b556e37 Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r=flod,niklas 
Differential Revision: https://phabricator.services.mozilla.com/D177806
 2023-05-15 14:50:59 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 16:41:53 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-09 13:46:13 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley 
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
 2023-05-03 13:46:47 +00:00
Mike Conley
76072f1bb0 Bug 1830726 - Only show the scrollbar in the migration wizard browser profile selector when there is something to scroll to. r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D176810
 2023-05-01 18:22:22 +00:00
Mike Conley
819a3c15f1 Bug 1829733 - Remove extraneous block margin around migration wizard checkboxes. r=niklas 
This also updates the iterator that was - unchecking and hiding all of
the resource checkboxes during the start of the routine that runs
when the browser / profile selector changes. This original iterator
was accidentally including the "Select All" checkbox from Variant 2,
and setting the "hidden" attribute on it. That attribute has no effect,
but it _does_ cause the label:not([hidden]) selector in the migration
wizard to not select it, which cause the label to not have the right
vertical alignment.

This patch updates the iterator to just select and hide the checkboxes
that have resources associated with them.

Differential Revision: https://phabricator.services.mozilla.com/D176342
 2023-04-26 20:27:13 +00:00
elephanteatsapple
9a04884ec9 Bug 1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D175447
 2023-04-21 13:18:42 +00:00
Mike Conley
efc612f60b Bug 1829196 - Use the term 'Continue' rather than 'Done' in the success state of the new migration wizard when embedding. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D176072
 2023-04-21 03:18:13 +00:00
Mike Conley
ca528a2ed9 Bug 1820640 - Enforce left-alignment and expose the button containers for the new Migration Wizard. r=kpatenio 
This is so that the contents of the Migration Wizard don't get automatically
centered if its embedding context is centering things.

This change also makes it so that embedders can customize some of the rules of how
buttons are laid out.

Differential Revision: https://phabricator.services.mozilla.com/D171771
 2023-04-21 03:18:12 +00:00
Mike Conley
a98705b9fd Bug 1828758 - Make Password file migrator only available if importing logins from CSV is enabled. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175804
 2023-04-18 22:36:26 +00:00
Mike Conley
73c69aafb8 Bug 1828463 - Make file migrator icon the same size as browser icons in the browser-profile-selector dropdown. r=niklas,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D175677
 2023-04-18 19:22:25 +00:00
Mike Conley
4922e2e5c2 Bug 1827204 - Set the right aria roles and attributes for the browser profile selector in the new migration wizard. r=Jamie 
Differential Revision: https://phabricator.services.mozilla.com/D175052
 2023-04-18 14:31:50 +00:00
Mike Conley
3b8c2d4517 Bug 1827274 - Allow users to use file importers after showing NO_BROWSERS_FOUND page in the new migration wizard. r=kpatenio,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D175069
 2023-04-14 17:37:57 +00:00
Mike Conley
8cf40900bd Bug 1828003 - Remove aria-live attribute from new Migration Wizard deck to reduce chattiness. r=nlapre 
Differential Revision: https://phabricator.services.mozilla.com/D175410
 2023-04-13 21:31:39 +00:00
Mike Conley
a6b4bb2db1 Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Depends on D174537

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 20:15:03 +00:00
Butkovits Atila
08ba617ed0 Backed out 2 changesets (bug 1821187) for causing failures at browser_file_migration.js. CLOSED TREE 
Backed out changeset 8402100dfc12 (bug 1821187)
Backed out changeset 2a7196e34b3d (bug 1821187)
 2023-04-13 05:28:27 +03:00
Mike Conley
cd18f710fc Bug 1821187 - Add infrastructure for file migrators in the new Migration Wizard. r=fluent-reviewers,kpatenio,flod 
This also includes our first file migrator, which imports passwords from CSV/TSV files.

Differential Revision: https://phabricator.services.mozilla.com/D173033
 2023-04-13 01:28:38 +00:00
Mike Conley
a1a329e69b Bug 1827206 - Focus the Done button after migration completes in the new wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175050
 2023-04-11 20:53:23 +00:00
Mike Conley
02d9100424 Bug 1827205 - Make sure browser / profile selector is focused when showing the selection page in the new migration wizard. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D175049
 2023-04-11 20:53:22 +00:00
elephanteatsapple
9674321f7e Bug 1825070 - Make the Migration Wizard panel / panel-list closer to the width of the selector button. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D174801
 2023-04-05 21:42:35 +00:00
Mike Conley
3dcc43bd41 Bug 1824786 - Add event telemetry for the migration wizards. data-review=jhirsch, r=niklas 
Differential Revision: https://phabricator.services.mozilla.com/D174184
 2023-04-03 20:47:13 +00:00
Mike Conley
d2ac8a1acd Bug 1821779 - Move migrationWizard.ftl out from locales-preview into the locales folder. r=flod,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D174482
 2023-04-03 17:25:18 +00:00
steven wang
f6145d6708 Bug 1819334 - Display an error message when no importable resources can be found for a browser / profile pair. r=mconley,fluent-reviewers. 
Differential Revision: https://phabricator.services.mozilla.com/D173544
 2023-03-31 15:17:19 +00:00
Mike Conley
77137ac6ce Bug 1801981 - Use the word "favorites" instead of "bookmarks" when importing from IE / Edge. r=niklas,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D173567
 2023-03-29 17:58:22 +00:00