Commit Graph

259 Commits

Author SHA1 Message Date
Niklas Baumgardner
c300e0b0c4 Bug 1884936 - Make sure there are no gaps in screenshots canvas. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D204367
2024-03-12 19:34:25 +00:00
Niklas Baumgardner
7515009d91 Bug 1884172 - Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D204256
2024-03-12 19:03:33 +00:00
Stanca Serban
fe83932e94 Backed out changeset 1e8ffb360c27 (bug 1884172) for causing OSX mochitests failures in browser_screenshots_test_visible.js. CLOSED TREE 2024-03-12 19:10:04 +02:00
Niklas Baumgardner
1993607fe7 Bug 1884172 - Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D204256
2024-03-12 14:22:34 +00:00
Anna Yeddi
3b0b6ca299 Bug 1884180 - Add an exception from a11y_checks for a dragging event in Screenshots. r=niklas
We intentionally turn off this a11y check, because the mouse event that was flagged by the a11y_checks test suite is emitted at the end of the dragging event. Its keyboard accessible alternative is provided and tested elsewhere, therefore this rule check can be ignored by a11y_checks suite.

Differential Revision: https://phabricator.services.mozilla.com/D204296
2024-03-11 23:44:01 +00:00
Sandor Molnar
6b82cd2685 Backed out changeset a24a00e9a529 (bug 1884172) for causing bc failures @ browser/components/screenshots/tests/browser/browser_screenshots_test_full_page.js CLOSED TREE 2024-03-12 01:03:08 +02:00
Niklas Baumgardner
5b22671ddc Bug 1884172 - Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D204256
2024-03-11 16:18:31 +00:00
Niklas Baumgardner
04d3f814c0 Bug 1882925 - Floor coordinates before drawing to canvas in screenshots. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D203769
2024-03-07 22:55:58 +00:00
Niklas Baumgardner
d918992b35 Bug 1873947 - Fix dragging screenshots tab to new window. r=sfoster,mconley
Differential Revision: https://phabricator.services.mozilla.com/D198470
2024-03-07 13:32:00 +00:00
Cosmin Sabou
21b4dfeb0d Bug 1803618 - Disable browser_screenshots_focus_test.js on linux for frequent failures. r=#intermittent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203864
2024-03-07 00:15:22 +00:00
Niklas Baumgardner
33c3a923a1 Bug 1883678 - Dispatch screenshots events to chrome only. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D203631
2024-03-05 18:52:34 +00:00
Sam Foster
e10d714796 Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-03-04 21:13:17 +00:00
Sandor Molnar
7ec5066cee Backed out changeset 5b88e57227bc (bug 1789727) for causing bc failures @ browser_feature_callout_in_chrome.js & browser_asrouter_toolbarbadge CLOSED TREE 2024-03-01 20:33:14 +02:00
Sam Foster
27c17caceb Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-03-01 15:02:51 +00:00
Noemi Erli
6b84db45b8 Backed out changeset 9b4da905ce36 (bug 1789727) for causing failures in browser_asrouter_toolbarbadge.js CLOSED TREE 2024-02-29 22:43:51 +02:00
Sam Foster
998fa1d9fe Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-29 18:27:46 +00:00
Gregory Pappas
9bd4fc9c87 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Gregory Pappas
c1ec40f95a Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Sandor Molnar
0941fe84f2 Backed out changeset c8f7d19d58bb (bug 1789727) for causing telemetry/marionette/tests/client/test_subsession_management.py CLOSED TREE 2024-02-28 18:42:48 +02:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Sam Foster
0b69b3a243 Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-28 15:40:08 +00:00
Gregory Pappas
55e30a8b92 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
0428704119 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Cosmin Sabou
98cdab1a15 Bug 1804441 - Disable browser_screenshots_drag_scroll_test on mac for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D202273
2024-02-20 21:57:01 +00:00
Sebastian Hengst
92d9ce0dbc Bug 1879673 - disable screenshot test browser_iframe_test.js on Linux for frequent failures
This is a regression from the changes in bug 1791086.

Differential Revision: https://phabricator.services.mozilla.com/D202159
2024-02-19 16:06:12 +00:00
Sam Foster
923aed9c7c Bug 1874154 - Anchor the 'Screenshot copied' notification on the hamburger menu button if the screenshot button isn't available. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D201143
2024-02-14 20:12:30 +00:00
Niklas Baumgardner
4a088b2a9e Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-02-14 15:16:12 +00:00
Greg Stoll
b2839267e7 Bug 1871135 - Add content analysis support to clipboard operations r=edgar,nika,masayuki,devtools-reviewers
When content analysis is on, pastes will be checked by the CA
agent while tab input is blocked. The synchronous nsIClipboard.getData()
method must block until the analysis result is received, so this
requires doing a SpinEventLoopUntil.

Differential Revision: https://phabricator.services.mozilla.com/D196997
2024-02-13 11:26:48 +00:00
Niklas Baumgardner
bb40d6b5a8 Bug 1791086 - Select elements within iframes in screenshots. r=sfoster,mconley
Differential Revision: https://phabricator.services.mozilla.com/D195165
2024-02-09 22:02:51 +00:00
Niklas Baumgardner
d4bf26d83f Bug 1878141 - Move focus by key in screenshots. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D200381
2024-02-06 14:37:21 +00:00
Iulian Moraru
0f47785cac Backed out changeset 4726abbc0c2c (bug 1874026) for causing multiple frequent bc failures. CLOSED TREE 2024-02-02 21:23:59 +02:00
Niklas Baumgardner
6b3e9794e8 Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-02-02 14:16:53 +00:00
Niklas Baumgardner
1b14ee1867 Bug 1874380 - Fix HCM for screenshots initial state. r=sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D198868
2024-02-01 22:10:12 +00:00
Niklas Baumgardner
bbdd7059c2 Bug 1874671 - Change screenshot mover color in HCM. r=sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D199354
2024-02-01 22:09:38 +00:00
Sam Foster
5485b87147 Bug 1874663 - Ensure panel buttons have a text color defined. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D200374
2024-02-01 20:36:37 +00:00
Cristian Tuns
e2d969d64e Backed out changeset e1b248076131 (bug 1874026) for causing bc failures in browser_test_resize.js CLOSED TREE 2024-01-30 17:16:32 -05:00
Niklas Baumgardner
3f4770864a Bug 1874026 - Be careful not to draw screenshots overlay outside document. r=sfoster,desktop-theme-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D198467
2024-01-30 21:30:04 +00:00
Niklas Baumgardner
f37dadc23b Bug 1876779 - Fix issue with last screenshot method. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D199747
2024-01-30 20:05:53 +00:00
Niklas Baumgardner
a145338e1e Bug 1875034 - Round screenshots region before drawSnapshot. r=sfoster
Both the extension and the component were both passing in numbers like 286.6499938964844 but they were behind rounded differently or something?
It seems to me that the extension was flooring the numbers somewhere and the component wasn't flooring or rounding the numbers anywhere.
The two images would start off being the same but then would progressively become more different. See image diff below
{F5955989}

If we round the region before drawing the snapshot the resulting images will match.
Sometimes there is some offset difference (only 1 px difference) because the component now `round`s and I think the extensions `floor`s. `286.6499938964844` would be `286` for the extension and `287` for the component.

Differential Revision: https://phabricator.services.mozilla.com/D199059
2024-01-25 15:27:08 +00:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Niklas Baumgardner
5e4a8da9e6 Bug 1875109 - Add screenshots button to start of toolbar for tests. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D199100
2024-01-22 17:53:07 +00:00
Niklas Baumgardner
9b5daf0abd Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Stanca Serban
458c9f5419 Backed out changeset 9df2731a0530 (bug 1867644) for causing mochitests failures in browser_contentAltClick.js on OSX. CLOSED TREE 2024-01-20 03:59:49 +02:00
Niklas Baumgardner
dd6b11b910 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 22:08:30 +00:00
Erik Nordin
87592ba425 Bug 1875090 - Rename ContentTaskUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,sgalich
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198831
2024-01-19 02:15:34 +00:00
Erik Nordin
5bb63471e3 Bug 1875090 - Rename BrowserTestUtils.is_visible() to isVisible() r=Gijs,settings-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,bytesized,sfoster
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198826
2024-01-19 02:15:33 +00:00
Erik Nordin
857bffe429 Bug 1875090 - Rename BrowserTestUtils.is_hidden() to isHidden() r=Gijs,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,translations-reviewers,sgalich,mhowell
Renames all instances of the snake_case identifier to
camelCase to match more closely to idiomatic JavaScript
and to existing conventions throughout the code base.

Differential Revision: https://phabricator.services.mozilla.com/D198825
2024-01-19 02:15:33 +00:00
Natalia Csoregi
eb2e3cf8cb Backed out changeset c6a30d94edf2 (bug 1867644) for causing failures on browser_screenshots_drag_test.js. CLOSED TREE 2024-01-19 03:46:03 +02:00
Niklas Baumgardner
729c5b4066 Bug 1867644 - Focus last used button for screenshots UI. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D197348
2024-01-19 00:07:46 +00:00
Iulian Moraru
e1d66150c9 Backed out changeset 2b70f662a797 (bug 1867644) for causing bc failures on browser_overlay_keyboard_test.js. CLOSED TREE 2024-01-18 22:14:11 +02:00